bullet_train-super_scaffolding 1.0.26 → 1.0.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa96794f926b4ce6a9d479ba9cdb68d4b470d7b8f070891f598810b06d9fbb3c
-  data.tar.gz: 7f2a27b23a561c500c2ffd83e1021bbfca826cc1b320e0799a5d5177fda5559b
+  metadata.gz: 05b68451045068aa2ec97bb4198826333c702d2af995005b9cf0090e58254ed4
+  data.tar.gz: 1ea761bfa6ec36306bedae27ecbb51176fb03ff35581b0c5f66dbcf722f4f69e
 SHA512:
-  metadata.gz: a3fe8058ddf576b53a9b2838bcd5ac03c23f5592bcf2477eb89ca9e224b96f0312f4b693a5ad828166769791b4b567e0f44dea0b889242646d31372b7a01fb55
-  data.tar.gz: 328e7145a2a5913608caaab2358373269ddd249acce9f9f9d795d5b681781d3e810efeee3d3f8d86a90e08cd18168db443d72131f3115f2f842f570e939a893c
+  metadata.gz: '09dbb3f20dcb25d5f1abab3d5a009686f415799b43575e31738695809a882e3a26e8aa5cdb29951b882c66bd75af3f26abddf8006b053404eb8fafe3038ff5db'
+  data.tar.gz: f3b55698e2feb4425bf56d855b82570ec59c7ce51a867b7c447e7386a4c88245534bb54513f638b5b3fd60e2a390d374fd53c6199d0bf761ce5c91ff6186e600

data/lib/bullet_train/super_scaffolding/version.rb

@@ -1,5 +1,5 @@
 module BulletTrain
   module SuperScaffolding
-    VERSION = "1.0.26"
+    VERSION = "1.0.29"
   end
 end

data/lib/scaffolding/block_manipulator.rb

@@ -137,4 +137,8 @@ class Scaffolding::BlockManipulator
     end
     current_line
   end
+
+  def block_indentation_size(line_number)
+    lines[line_number].scan(/^\s+/).first.size
+  end
 end

data/lib/scaffolding/routes_file_manipulator.rb

@@ -1,5 +1,5 @@
 class Scaffolding::RoutesFileManipulator
-  attr_accessor :child, :parent, :lines, :transformer_options
+  attr_accessor :child, :parent, :lines, :transformer_options, :block_manipulator
 
   def initialize(filename, child, parent, transformer_options = {})
     self.child = child
@@ -7,6 +7,7 @@ class Scaffolding::RoutesFileManipulator
     @filename = filename
     self.lines = File.readlines(@filename)
     self.transformer_options = transformer_options
+    self.block_manipulator = Scaffolding::BlockManipulator.new(@filename)
   end
 
   def child_parts
@@ -141,7 +142,12 @@ class Scaffolding::RoutesFileManipulator
     current_namespace = nil
     while namespaces.any?
       current_namespace = namespaces.shift
-      namespace_lines = find_namespaces(created_namespaces + [current_namespace], within)
+      namespace_lines = if within.nil?
+        find_namespaces(created_namespaces + [current_namespace], within)
+      else
+        scope_namespace_to_parent(current_namespace, within)
+      end
+
       unless namespace_lines[current_namespace]
         lines_to_add = ["namespace :#{current_namespace} do", "end"]
         if created_namespaces.any?
@@ -156,6 +162,35 @@ class Scaffolding::RoutesFileManipulator
     namespace_lines ? namespace_lines[current_namespace] : nil
   end
 
+  # Since it's possible for multiple namespaces to exist on different levels,
+  # We scope the namespace we're trying to scaffold to its proper parent before processing it.
+  #
+  # i.e:
+  # Parent: Insight => Child: Personality::CharacterTrait
+  # Parent: Team    => Child: Personality::Disposition
+  # In this case, the :personality namespace under :insights should be
+  # ignored when Super Scaffolding Personality::Dispositon.
+  #
+  # resources do :insights do
+  #   namespace :personality do
+  #     resources :character_traits
+  #   end
+  # end
+  #
+  # namespace :personality do
+  #   resources :dispositions
+  # end
+  #
+  # In this case, Personality::CharacterTrait is under Team just like Personality::Disposition,
+  # but Personality::CharacterTrait's DIRECT parent is Insight so we shouldn't scaffold its routes there.
+  def scope_namespace_to_parent(namespace, within)
+    namespace_block_start = namespace_blocks_directly_under_parent(within).map do |namespace_block|
+      namespace_line_number = namespace_block.begin
+      namespace_line_number if lines[namespace_line_number].match?(/ +namespace :#{namespace}/)
+    end.compact
+    namespace_block_start.present? ? {namespace => namespace_block_start} : {}
+  end
+
   def find(needle, within = nil)
     lines_within(within).each_with_index do |line, line_number|
       return (within + (within ? 1 : 0) + line_number) if line.match?(needle)
@@ -220,6 +255,8 @@ class Scaffolding::RoutesFileManipulator
     result
   end
 
+  # Finds namespace blocks no matter how many levels deep they are nested in resource blocks, etc.
+  # However, will not find namespace blocks inside namespace blocks.
   def top_level_namespace_block_lines(within)
     local_namespace_blocks = []
     lines_within(within).each do |line|
@@ -253,6 +290,24 @@ class Scaffolding::RoutesFileManipulator
     local_namespace_blocks
   end
 
+  # Whereas top_level_namespace_block_lines grabs all namespace blocks that
+  # appear first no matter how many resource blocks they're nested in,
+  # this method grabs namespace blocks that are only indented one level deep.
+  def namespace_blocks_directly_under_parent(within)
+    blocks = []
+    if lines[within].match?(/do$/)
+      parent_indentation_size = block_manipulator.block_indentation_size(within)
+      within_block_end = find_block_end(within)
+      within.upto(within_block_end) do |line_number|
+        if lines[line_number].match?(/^#{" " * (parent_indentation_size + 2)}namespace/)
+          namespace_block_lines = line_number..find_block_end(line_number)
+          blocks << namespace_block_lines
+        end
+      end
+    end
+    blocks
+  end
+
   def find_or_create_resource_block(parts, options = {})
     find_or_create_resource(parts, options)
     find_or_convert_resource_block(parts.last, options)
@@ -300,7 +355,6 @@ class Scaffolding::RoutesFileManipulator
     child_namespaces, child_resource, parent_namespaces, parent_resource = divergent_parts
 
     within = find_or_create_namespaces(base_namespaces)
-    within = find_or_create_namespaces(common_namespaces, within) if common_namespaces.any?
 
     # e.g. Project and Projects::Deliverable
     if parent_namespaces.empty? && child_namespaces.one? && parent_resource == child_namespaces.first
@@ -326,33 +380,31 @@ class Scaffolding::RoutesFileManipulator
       #   resources :deliverables, except: collection_actions
       # end
 
+      # We want to see if there are any namespaces one level above the parent itself,
+      # because namespaces with the same name as the resource can exist on the same level.
+      parent_block_start = find_block_parent(parent_within)
+      namespace_line_within = find_or_create_namespaces(child_namespaces, parent_block_start)
+      find_or_create_resource([child_resource], options: "except: collection_actions", within: namespace_line_within)
       unless find_namespaces(child_namespaces, within)[child_namespaces.last]
-        insert_after(["", "namespace :#{child_namespaces.last} do", "end"], find_block_end(scope_within))
-        unless find_namespaces(child_namespaces, within)[child_namespaces.last]
-          raise "tried to insert `namespace :#{child_namespaces.last}` but it seems we failed"
-        end
+        raise "tried to insert `namespace :#{child_namespaces.last}` but it seems we failed"
       end
 
-      find_or_create_resource(child_namespaces + [child_resource], options: "except: collection_actions", within: within)
-
     # e.g. Projects::Deliverable and Objective Under It, Abstract::Concept and Concrete::Thing
     elsif parent_namespaces.any?
 
       # namespace :projects do
       #   resources :deliverables
       # end
-      #
+      top_parent_namespace = find_namespaces(parent_namespaces, within)[parent_namespaces.first]
+      find_or_create_resource(child_namespaces + [child_resource], within: top_parent_namespace)
+
       # resources :projects_deliverables, path: 'projects/deliverables' do
       #   resources :objectives
       # end
-
-      find_resource(parent_namespaces + [parent_resource], within: within)
-      top_parent_namespace = find_namespaces(parent_namespaces, within)[parent_namespaces.first]
       block_parent_within = find_block_parent(top_parent_namespace)
       parent_namespaces_and_resource = (parent_namespaces + [parent_resource]).join("_")
       parent_within = find_or_create_resource_block([parent_namespaces_and_resource], options: "path: '#{parent_namespaces_and_resource.tr("_", "/")}'", within: block_parent_within)
       find_or_create_resource(child_namespaces + [child_resource], within: parent_within)
-
     else
 
       begin

data/lib/scaffolding/script.rb

@@ -37,6 +37,12 @@ def check_required_options_for_attributes(scaffolding_type, attributes, child, p
     name = parts.shift
     type = parts.join(":")
 
+    unless Scaffolding.valid_attribute_type?(type)
+      raise "You have entered an invalid attribute type: #{type}. General data types are used when creating new models, but Bullet Train " +
+            "uses field partials when Super Scaffolding, i.e. - `name:text_field` as opposed to `name:string`. " +
+            "Please refer to the Field Partial documentation to view which attribute types are available."
+    end
+
     # extract any options they passed in with the field.
     type, attribute_options = type.scan(/^(.*){(.*)}/).first || type
 

data/lib/scaffolding/transformer.rb

@@ -655,8 +655,14 @@ class Scaffolding::Transformer
         "email"
       when "color_picker"
         "code"
-      else
+      when "text_field"
+        "text"
+      when "text_area"
+        "text"
+      when "file_field"
         "text"
+      else
+        raise "Invalid attribute type: #{type}."
       end
 
       cell_attributes = if boolean_buttons
@@ -1030,10 +1036,14 @@ class Scaffolding::Transformer
           scaffold_add_line_to_file("./app/views/account/scaffolding/completely_concrete/tangible_things/_tangible_thing.json.jbuilder", ":#{name},", RUBY_NEW_FIELDS_HOOK, prepend: true, suppress_could_not_find: true)
           scaffold_add_line_to_file("./app/serializers/api/v1/scaffolding/completely_concrete/tangible_thing_serializer.rb", ":#{name},", RUBY_NEW_FIELDS_HOOK, prepend: true)
 
-          assertion = if type == "date_field"
+          assertion = case type
+          when "date_field"
             "assert_equal Date.parse(tangible_thing_data['#{name}']), tangible_thing.#{name}"
-          elsif type == "date_and_time_field"
+          when "date_and_time_field"
             "assert_equal DateTime.parse(tangible_thing_data['#{name}']), tangible_thing.#{name}"
+          when "file_field"
+            # TODO: If we want to use Cloudinary to handle our files, we should make sure we're getting a URL.
+            "assert_equal tangible_thing_data['#{name}']['record']['id'], tangible_thing.#{name}.record.id"
           else
             "assert_equal tangible_thing_data['#{name}'], tangible_thing.#{name}"
           end
@@ -1276,10 +1286,20 @@ class Scaffolding::Transformer
       else
         transform_string("association :absolutely_abstract_creative_concept, factory: :scaffolding_absolutely_abstract_creative_concept")
       end
+
       scaffold_replace_line_in_file("./test/factories/scaffolding/completely_concrete/tangible_things.rb", content, "absolutely_abstract_creative_concept { nil }")
 
       add_has_many_association
 
+      # Adds file attachment to factory
+      attributes.each do |attribute|
+        attribute_name, partial_type = attribute.split(":")
+        if partial_type == "file_field"
+          content = "#{attribute_name} { Rack::Test::UploadedFile.new(\"test/support/foo.txt\") }"
+          scaffold_replace_line_in_file("./test/factories/scaffolding/completely_concrete/tangible_things.rb", content, "#{attribute_name} { nil }")
+        end
+      end
+
       if class_names_transformer.belongs_to_needs_class_definition?
         scaffold_replace_line_in_file("./app/models/scaffolding/completely_concrete/tangible_thing.rb", transform_string("belongs_to :absolutely_abstract_creative_concept, class_name: \"Scaffolding::AbsolutelyAbstract::CreativeConcept\"\n"), transform_string("belongs_to :absolutely_abstract_creative_concept\n"))
       end
@@ -1430,6 +1450,6 @@ class Scaffolding::Transformer
 
     add_additional_step :yellow, transform_string("If you would like the table view you've just generated to reactively update when a Tangible Thing is updated on the server, please edit `app/models/scaffolding/absolutely_abstract/creative_concept.rb`, locate the `has_many :completely_concrete_tangible_things`, and add `enable_updates: true` to it.")
 
-    restart_server
+    restart_server unless ENV["CI"].present?
   end
 end

data/lib/scaffolding.rb

@@ -1,2 +1,21 @@
 module Scaffolding
+  def self.valid_attribute_type?(type)
+    [
+      "boolean",
+      "button",
+      "cloudinary_image",
+      "color_picker",
+      "date_and_time_field",
+      "date_field",
+      "email_field",
+      "file_field",
+      "options",
+      "password_field",
+      "phone_field",
+      "super_select",
+      "text_area",
+      "text_field",
+      "trix_editor"
+    ].include?(type.gsub(/{.*}/, "")) # Pop off curly brackets such as `super_select{class_name=Membership}`
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet_train-super_scaffolding
 version: !ruby/object:Gem::Version
-  version: 1.0.26
+  version: 1.0.29
 platform: ruby
 authors:
 - Andrew Culver
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-07 00:00:00.000000000 Z
+date: 2022-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: standard
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: spring
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: indefinite_article
   requirement: !ruby/object:Gem::Requirement
@@ -73,6 +87,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".bt-link"
 - MIT-LICENSE
 - README.md
 - Rakefile