bullet_train-sortable 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fff0856e0a46a10b09270bc22d59958017ef78bbb70b02e095cbf5d503480c68
-  data.tar.gz: 6cb89997aa69c266582a59e5aa91512045e919600a43befd6e931799d85c5347
+  metadata.gz: 9e84511987b36e406e093226b47388d30f93efcc481666a42718bd866ca5e13c
+  data.tar.gz: 5e92c6e7f2ec330a6c66caa683dcc2e9665da9047a39db7cc7619d969296d070
 SHA512:
-  metadata.gz: 8de58432c2ad9f78f670636bb8b370f40470124e929f993704fc0d17adb7ad934eebc65dd70ba80e438d7d257d4091fa67a02d7790c5776668ee66519b7cfc89
-  data.tar.gz: 7b31ae826cf01892d88dfb5d22cbcd941d164294e82401d2e5b22298fc801d0928583b85ecd7bec96bf6f73754e58012bcb3dfffb7e93d50640bfa0a35459e1a
+  metadata.gz: b37f7953f0229ee1bf9ff2349f01137b0a8ccfd1eb1f12efd9e3ffe1834579288368c6677346a8ce98f26a09245e446bf9256f392c8551e04076572a388a3215
+  data.tar.gz: a79e8e3f162bcbed90578dc349a0bd83598043f58bb519eaf64cc697a8031f52094f367c621da19a8b3e0a8f5015b266115d6a0ba865031c73b3fe8d1254f558

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2022 Andrew Culver
+Copyright 2022 Bullet Train, Inc.
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -22,7 +22,7 @@ $ gem install bullet_train-sortable
 ```
 
 ## Contributing
-Contribution directions go here.
+See [`RELEASE.md` in bullet_train-base](https://github.com/bullet-train-co/bullet_train-base/blob/main/RELEASE.md) for instructions on local development and for publishing both the gem and the npm package.
 
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/app/javascript/concerns/index.js

@@ -0,0 +1 @@
+import "./reassignable"

data/app/javascript/controllers/index.js

@@ -0,0 +1,18 @@
+import { identifierForContextKey } from "@hotwired/stimulus-webpack-helpers"
+
+import SortableController from './sortable_controller'
+
+export const controllerDefinitions = [
+  [SortableController, 'sortable_controller.js']
+].map(function(d) {
+  const key = d[1]
+  const controller = d[0]
+  return {
+    identifier: identifierForContextKey(key),
+    controllerConstructor: controller
+  }
+})
+
+export {
+  SortableController
+}

data/app/javascript/controllers/sortable_controller.js

@@ -0,0 +1,80 @@
+import { Controller } from "@hotwired/stimulus"
+require("dragula/dist/dragula.min.css")
+
+import dragula from 'dragula';
+
+export default class extends Controller {
+  static values = {
+    reorderPath: String,
+    saveOnReorder: { type: Boolean, default: true }
+  }
+  
+  // will be reissued as native dom events name prepended with 'sortable:' e.g. 'sortable:drag', 'sortable:drop', etc
+  static pluginEventsToReissue = [ "drag", "dragend", "drop", "cancel", "remove", "shadow", "over", "out", "cloned" ]
+
+  connect() {
+    if (!this.hasReorderPathValue) { return }
+    this.initPluginInstance()
+  }
+
+  disconnect() {
+    this.teardownPluginInstance()
+  }
+
+  initPluginInstance() {
+    const self = this
+    this.plugin = dragula([this.element], {
+      moves: function(el, container, handle) {
+        var $handles = $(el).find('.reorder-handle')
+        if ($handles.length) {
+          return !!$(handle).closest('.reorder-handle').length
+        } else {
+          if (!$(handle).closest('.undraggable').length) {
+            return self.element === container
+          } else {
+            return false
+          }
+        }
+      },
+      accepts: function (el, target, source, sibling) {
+        if ($(sibling).hasClass('undraggable') && $(sibling).prev().hasClass('undraggable')) {
+          return false
+        } else {
+          return true
+        }
+      },
+    }).on('drop', function (el) {
+      // save order here.
+      if (self.saveOnReorderValue) {
+        self.saveSortOrder()
+      }
+    }).on('over', function (el, container) {
+      // deselect any text fields, or else things go slow!
+      $(document.activeElement).blur()
+    })
+    
+    this.initReissuePluginEventsAsNativeEvents()
+  }
+  
+  initReissuePluginEventsAsNativeEvents() {
+    this.constructor.pluginEventsToReissue.forEach((eventName) => {
+      this.plugin.on(eventName, (...args) => {
+        this.dispatch(eventName, { detail: { plugin: 'dragula', type: eventName, args: args }})
+      })
+    })
+  }
+
+  teardownPluginInstance() {
+    if (this.plugin === undefined) { return }
+
+    // revert to original markup, remove any event listeners
+    this.plugin.destroy()
+  }
+  
+  saveSortOrder() {
+    var idsInOrder = Array.from(this.element.childNodes).map((el) => { return parseInt(el.dataset?.id) });
+    
+    $.post(this.reorderPathValue, {ids_in_order: idsInOrder})
+  }
+
+}

data/app/javascript/index.js

@@ -0,0 +1,2 @@
+import "./concerns"
+export * from './controllers'

data/lib/bullet_train/sortable/version.rb

@@ -1,5 +1,5 @@
 module BulletTrain
   module Sortable
-    VERSION = "1.0.2"
+    VERSION = "1.0.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet_train-sortable
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Andrew Culver
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-12 00:00:00.000000000 Z
+date: 2022-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -36,8 +36,11 @@ files:
 - Rakefile
 - app/assets/config/bullet_train_sortable_manifest.js
 - app/controllers/concerns/sortable_actions.rb
+- app/javascript/concerns/index.js
 - app/javascript/concerns/reassignable.js
-- app/javascript/concerns/sortable.js
+- app/javascript/controllers/index.js
+- app/javascript/controllers/sortable_controller.js
+- app/javascript/index.js
 - app/models/concerns/sortable.rb
 - config/routes.rb
 - lib/bullet_train/sortable.rb
@@ -65,7 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Bullet Train Sortable

data/app/javascript/concerns/sortable.js

@@ -1,70 +0,0 @@
-require("dragula/dist/dragula.min.css")
-
-import dragula from 'dragula';
-
-function saveSortOrder($container) {
-  var idsInOrder = $container.find('> *').map(function(index,element) { return parseInt($(element).attr('data-id')); }).toArray();
-  $.post($container.attr('data-reorder'), {ids_in_order: idsInOrder}, function() {
-    if ($container.closest('.opened-modally').length) {
-      refreshModalBase();
-    }
-  });
-}
-
-function enableSortable($scope) {
-  setTimeout(function() {
-    var selector = '[data-reorder]';
-    var $reorderable = $scope.find(selector).addBack(selector);
-    console.log("enabling sort on array of " + $reorderable.length);
-
-    $reorderable.each(function (index, container) {
-
-      var $container = $(container);
-
-      // enable drag-and-drop reordering.
-      var dragulaObj = dragula([container], {
-        moves: function(el, container, handle) {
-          var $handles = $(el).find('.reorder-handle')
-          if ($handles.length) {
-            return !!$(handle).closest('.reorder-handle').length
-          } else {
-            if (!$(handle).closest('.undraggable').length) {
-              return $(handle).closest('[data-reorder]')[0] == container;
-            } else {
-              return false;
-            }
-          }
-        },
-        accepts: function (el, target, source, sibling) {
-          if ($(sibling).hasClass('undraggable') && $(sibling).prev().hasClass('undraggable')) {
-            return false;
-          } else {
-            return true;
-          }
-        },
-      }).on('drop', function (el) {
-
-        // save order here.
-        saveSortOrder($container);
-
-      }).on('over', function (el, container) {
-
-        // deselect any text fields, or else things go slow!
-        $(document.activeElement).blur();
-
-      });
-
-    });
-  }, 500);
-}
-
-$(document).on('turbo:load', function() {
-  console.log("🍩 Sortable: Enabling on <body> after a Turbo load.")
-  enableSortable($('body'));
-})
-
-$(document).on('sprinkles:update', function(event) {
-  console.log("🍩 Sortable: Enabling on the following element after a Sprinkles content update:")
-  console.log(event.target);
-  enableSortable($(event.target));
-})