bullet 5.9.0 → 7.0.4

data/spec/integration/mongoid/association_spec.rb

@@ -7,9 +7,7 @@ if mongoid?
     context 'embeds_many' do
       context 'posts => users' do
         it 'should detect nothing' do
-          Mongoid::Post.all.each do |post|
-            post.users.map(&:name)
-          end
+          Mongoid::Post.all.each { |post| post.users.map(&:name) }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
@@ -21,9 +19,7 @@ if mongoid?
     context 'has_many' do
       context 'posts => comments' do
         it 'should detect non preload posts => comments' do
-          Mongoid::Post.all.each do |post|
-            post.comments.map(&:name)
-          end
+          Mongoid::Post.all.each { |post| post.comments.map(&:name) }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
@@ -31,9 +27,7 @@ if mongoid?
         end
 
         it 'should detect preload post => comments' do
-          Mongoid::Post.includes(:comments).each do |post|
-            post.comments.map(&:name)
-          end
+          Mongoid::Post.includes(:comments).each { |post| post.comments.map(&:name) }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
@@ -78,7 +72,10 @@ if mongoid?
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
-          expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Mongoid::Category, :posts)
+          expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(
+            Mongoid::Category,
+            :posts
+          )
           expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Mongoid::Category, :entries)
         end
 
@@ -103,9 +100,7 @@ if mongoid?
         end
 
         it 'should detect unused preload with category => entries, but not with category => posts' do
-          Mongoid::Category.includes(:posts, :entries).each do |category|
-            category.posts.map(&:name)
-          end
+          Mongoid::Category.includes(:posts, :entries).each { |category| category.posts.map(&:name) }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Mongoid::Category, :posts)
           expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Mongoid::Category, :entries)
@@ -116,16 +111,14 @@ if mongoid?
 
       context 'post => comment' do
         it 'should detect unused preload with post => comments' do
-          Mongoid::Post.includes(:comments).each do |post|
-            post.comments.first.name
-          end
+          Mongoid::Post.includes(:comments).each { |post| post.comments.first.name }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Mongoid::Post, :comments)
 
           expect(Bullet::Detector::Association).to be_completely_preloading_associations
         end
 
-        it 'should detect preload with post => commnets' do
+        it 'should detect preload with post => comments' do
           Mongoid::Post.first.comments.map(&:name)
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -136,9 +129,7 @@ if mongoid?
 
       context 'scope preload_comments' do
         it 'should detect preload post => comments with scope' do
-          Mongoid::Post.preload_comments.each do |post|
-            post.comments.map(&:name)
-          end
+          Mongoid::Post.preload_comments.each { |post| post.comments.map(&:name) }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
@@ -158,9 +149,7 @@ if mongoid?
     context 'belongs_to' do
       context 'comment => post' do
         it 'should detect non preload with comment => post' do
-          Mongoid::Comment.all.each do |comment|
-            comment.post.name
-          end
+          Mongoid::Comment.all.each { |comment| comment.post.name }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
@@ -176,9 +165,7 @@ if mongoid?
         end
 
         it 'should detect preload with comment => post' do
-          Mongoid::Comment.includes(:post).each do |comment|
-            comment.post.name
-          end
+          Mongoid::Comment.includes(:post).each { |comment| comment.post.name }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
@@ -207,20 +194,19 @@ if mongoid?
       context 'company => address' do
         if Mongoid::VERSION !~ /\A3.0/
           it 'should detect non preload association' do
-            Mongoid::Company.all.each do |company|
-              company.address.name
-            end
+            Mongoid::Company.all.each { |company| company.address.name }
             Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
             expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
-            expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Mongoid::Company, :address)
+            expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(
+              Mongoid::Company,
+              :address
+            )
           end
         end
 
         it 'should detect preload association' do
-          Mongoid::Company.includes(:address).each do |company|
-            company.address.name
-          end
+          Mongoid::Company.includes(:address).each { |company| company.address.name }
           Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
           expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 

data/spec/models/attachment.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class Attachment < ActiveRecord::Base
+  belongs_to :submission
+end

data/spec/models/deal.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+class Deal < ActiveRecord::Base
+  has_and_belongs_to_many :posts
+end

data/spec/models/post.rb

@@ -4,6 +4,7 @@ class Post < ActiveRecord::Base
   belongs_to :category, inverse_of: :posts
   belongs_to :writer
   has_many :comments, inverse_of: :post
+  has_and_belongs_to_many :deals
 
   validates :category, presence: true
 
@@ -21,6 +22,7 @@ class Post < ActiveRecord::Base
     next unless trigger_after_save
 
     temp_comment = Comment.new(post: self)
+
     # this triggers self to be "possible", even though it's
     # not saved yet
     temp_comment.post

data/spec/models/role.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class Role < ActiveRecord::Base
+  has_and_belongs_to_many :users
+
+  belongs_to :resource, polymorphic: true
+end

data/spec/models/submission.rb

@@ -3,4 +3,5 @@
 class Submission < ActiveRecord::Base
   belongs_to :user
   has_many :replies
+  has_one :attachment
 end

data/spec/models/user.rb

@@ -2,5 +2,7 @@
 
 class User < ActiveRecord::Base
   has_one :submission
+  has_one :submission_attachment, through: :submission, source: :attachment, class_name: 'Attachment'
   belongs_to :category
+  has_and_belongs_to_many :roles
 end

data/spec/spec_helper.rb

@@ -11,7 +11,7 @@ rescue LoadError
 end
 
 module Rails
-  class <<self
+  class << self
     def root
       File.expand_path(__FILE__).split('/')[0..-3].join('/')
     end
@@ -60,9 +60,7 @@ if active_record?
       Bullet.enable = true
     end
 
-    config.after(:example) do
-      Bullet.end_request
-    end
+    config.after(:example) { Bullet.end_request }
   end
 
   if ENV['BULLET_LOG']
@@ -87,13 +85,9 @@ if mongoid?
       Support::MongoSeed.teardown_db
     end
 
-    config.before(:each) do
-      Bullet.start_request
-    end
+    config.before(:each) { Bullet.start_request }
 
-    config.after(:each) do
-      Bullet.end_request
-    end
+    config.after(:each) { Bullet.end_request }
   end
 
   if ENV['BULLET_LOG']

data/spec/support/bullet_ext.rb

@@ -2,9 +2,7 @@
 
 module Bullet
   def self.collected_notifications_of_class(notification_class)
-    Bullet.notification_collector.collection.select do |notification|
-      notification.is_a? notification_class
-    end
+    Bullet.notification_collector.collection.select { |notification| notification.is_a? notification_class }
   end
 
   def self.collected_counter_cache_notifications
@@ -23,7 +21,7 @@ end
 module Bullet
   module Detector
     class Association
-      class <<self
+      class << self
         # returns true if all associations are preloaded
         def completely_preloading_associations?
           Bullet.collected_n_plus_one_query_notifications.empty?
@@ -35,21 +33,22 @@ module Bullet
 
         # returns true if a given object has a specific association
         def creating_object_association_for?(object, association)
-          object_associations[object.bullet_key].present? && object_associations[object.bullet_key].include?(association)
+          object_associations[object.bullet_key].present? &&
+            object_associations[object.bullet_key].include?(association)
         end
 
         # returns true if a given class includes the specific unpreloaded association
         def detecting_unpreloaded_association_for?(klass, association)
-          Bullet.collected_n_plus_one_query_notifications.select { |notification|
+          Bullet.collected_n_plus_one_query_notifications.select do |notification|
             notification.base_class == klass.to_s && notification.associations.include?(association)
-          }.present?
+          end.present?
         end
 
         # returns true if the given class includes the specific unused preloaded association
         def unused_preload_associations_for?(klass, association)
-          Bullet.collected_unused_eager_association_notifications.select { |notification|
+          Bullet.collected_unused_eager_association_notifications.select do |notification|
             notification.base_class == klass.to_s && notification.associations.include?(association)
-          }.present?
+          end.present?
         end
       end
     end

data/spec/support/mongo_seed.rb

@@ -39,26 +39,13 @@ module Support
     def setup_db
       if Mongoid::VERSION =~ /\A4/
         Mongoid.configure do |config|
-          config.load_configuration(
-            sessions: {
-              default: {
-                database: 'bullet',
-                hosts: ['localhost:27017']
-              }
-            }
-          )
+          config.load_configuration(sessions: { default: { database: 'bullet', hosts: %w[localhost:27017] } })
         end
       else
         Mongoid.configure do |config|
-          config.load_configuration(
-            clients: {
-              default: {
-                database: 'bullet',
-                hosts: ['localhost:27017']
-              }
-            }
-          )
+          config.load_configuration(clients: { default: { database: 'bullet', hosts: %w[localhost:27017] } })
         end
+
         # Increase the level from DEBUG in order to avoid excessive logging to the screen
         Mongo::Logger.logger.level = Logger::WARN
       end

data/spec/support/sqlite_seed.rb

@@ -21,6 +21,13 @@ module Support
       post2 = category2.posts.create(name: 'second', writer: writer2)
       post3 = category2.posts.create(name: 'third', writer: writer2)
 
+      deal1 = Deal.new(name: 'Deal 1')
+      deal1.posts << post1
+      deal1.posts << post2
+      deal2 = Deal.new(name: 'Deal 2')
+      post1.deals << deal1
+      post1.deals << deal2
+
       comment1 = post1.comments.create(name: 'first', author: writer1)
       comment2 = post1.comments.create(name: 'first2', author: writer1)
       comment3 = post1.comments.create(name: 'first3', author: writer1)
@@ -85,9 +92,16 @@ module Support
       page3 = Page.create(name: 'page3', parent_id: folder2.id, author_id: author2.id)
       page4 = Page.create(name: 'page4', parent_id: folder2.id, author_id: author2.id)
 
+      role1 = Role.create(name: 'Admin')
+      role2 = Role.create(name: 'User')
+
       user1 = User.create(name: 'user1', category: category1)
       user2 = User.create(name: 'user2', category: category1)
 
+      user1.roles << role1
+      user1.roles << role2
+      user2.roles << role2
+
       submission1 = user1.create_submission(name: 'submission1')
       submission2 = user2.create_submission(name: 'submission2')
 
@@ -95,6 +109,9 @@ module Support
       submission1.replies.create(name: 'reply2')
       submission2.replies.create(name: 'reply3')
       submission2.replies.create(name: 'reply4')
+
+      submission1.create_attachment(file_name: 'submission1 file')
+      submission2.create_attachment(file_name: 'submission2 file')
     end
 
     def setup_db
@@ -153,6 +170,11 @@ module Support
           t.column :hotel_id, :integer
         end
 
+        create_table :deals_posts do |t|
+          t.column :deal_id, :integer
+          t.column :post_id, :integer
+        end
+
         create_table :documents do |t|
           t.string :name
           t.string :type
@@ -231,6 +253,17 @@ module Support
           t.column :submission_id, :integer
         end
 
+        create_table :roles do |t|
+          t.column :name, :string
+          t.column :resource_id, :integer
+          t.column :resource_type, :string
+        end
+
+        create_table :roles_users do |t|
+          t.column :role_id, :integer
+          t.column :user_id, :integer
+        end
+
         create_table :submissions do |t|
           t.column :name, :string
           t.column :user_id, :integer
@@ -240,6 +273,11 @@ module Support
           t.column :name, :string
           t.column :category_id, :integer
         end
+
+        create_table :attachments do |t|
+          t.column :file_name, :string
+          t.column :submission_id, :integer
+        end
       end
     end
   end

data/test.sh

@@ -1,5 +1,8 @@
 #bundle update rails && bundle exec rspec spec
 #BUNDLE_GEMFILE=Gemfile.mongoid bundle update mongoid && BUNDLE_GEMFILE=Gemfile.mongoid bundle exec rspec spec
+BUNDLE_GEMFILE=Gemfile.rails-7.0 bundle && BUNDLE_GEMFILE=Gemfile.rails-7.0 bundle exec rspec spec
+BUNDLE_GEMFILE=Gemfile.rails-6.1 bundle && BUNDLE_GEMFILE=Gemfile.rails-6.1 bundle exec rspec spec
+BUNDLE_GEMFILE=Gemfile.rails-6.0 bundle && BUNDLE_GEMFILE=Gemfile.rails-6.0 bundle exec rspec spec
 BUNDLE_GEMFILE=Gemfile.rails-5.2 bundle && BUNDLE_GEMFILE=Gemfile.rails-5.2 bundle exec rspec spec
 BUNDLE_GEMFILE=Gemfile.rails-5.1 bundle && BUNDLE_GEMFILE=Gemfile.rails-5.1 bundle exec rspec spec
 BUNDLE_GEMFILE=Gemfile.rails-5.0 bundle && BUNDLE_GEMFILE=Gemfile.rails-5.0 bundle exec rspec spec

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet
 version: !ruby/object:Gem::Version
-  version: 5.9.0
+  version: 7.0.4
 platform: ruby
 authors:
 - Richard Huang
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-11-11 00:00:00.000000000 Z
+date: 2022-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -45,9 +45,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.mongoid
@@ -61,6 +61,9 @@ files:
 - Gemfile.rails-5.0
 - Gemfile.rails-5.1
 - Gemfile.rails-5.2
+- Gemfile.rails-6.0
+- Gemfile.rails-6.1
+- Gemfile.rails-7.0
 - Guardfile
 - Hacking.md
 - MIT-LICENSE
@@ -68,11 +71,16 @@ files:
 - Rakefile
 - bullet.gemspec
 - lib/bullet.rb
+- lib/bullet/active_job.rb
 - lib/bullet/active_record4.rb
 - lib/bullet/active_record41.rb
 - lib/bullet/active_record42.rb
 - lib/bullet/active_record5.rb
 - lib/bullet/active_record52.rb
+- lib/bullet/active_record60.rb
+- lib/bullet/active_record61.rb
+- lib/bullet/active_record70.rb
+- lib/bullet/bullet_xhr.js
 - lib/bullet/dependency.rb
 - lib/bullet/detector.rb
 - lib/bullet/detector/association.rb
@@ -123,6 +131,7 @@ files:
 - spec/integration/counter_cache_spec.rb
 - spec/integration/mongoid/association_spec.rb
 - spec/models/address.rb
+- spec/models/attachment.rb
 - spec/models/author.rb
 - spec/models/base_user.rb
 - spec/models/category.rb
@@ -131,6 +140,7 @@ files:
 - spec/models/comment.rb
 - spec/models/company.rb
 - spec/models/country.rb
+- spec/models/deal.rb
 - spec/models/document.rb
 - spec/models/entry.rb
 - spec/models/firm.rb
@@ -150,6 +160,7 @@ files:
 - spec/models/post.rb
 - spec/models/relationship.rb
 - spec/models/reply.rb
+- spec/models/role.rb
 - spec/models/student.rb
 - spec/models/submission.rb
 - spec/models/teacher.rb
@@ -169,7 +180,7 @@ licenses:
 metadata:
   changelog_uri: https://github.com/flyerhzm/bullet/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/flyerhzm/bullet
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -184,9 +195,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
-signing_key: 
+rubygems_version: 3.3.22
+signing_key:
 specification_version: 4
 summary: help to kill N+1 queries and unused eager loading.
 test_files:
@@ -211,6 +221,7 @@ test_files:
 - spec/integration/counter_cache_spec.rb
 - spec/integration/mongoid/association_spec.rb
 - spec/models/address.rb
+- spec/models/attachment.rb
 - spec/models/author.rb
 - spec/models/base_user.rb
 - spec/models/category.rb
@@ -219,6 +230,7 @@ test_files:
 - spec/models/comment.rb
 - spec/models/company.rb
 - spec/models/country.rb
+- spec/models/deal.rb
 - spec/models/document.rb
 - spec/models/entry.rb
 - spec/models/firm.rb
@@ -238,6 +250,7 @@ test_files:
 - spec/models/post.rb
 - spec/models/relationship.rb
 - spec/models/reply.rb
+- spec/models/role.rb
 - spec/models/student.rb
 - spec/models/submission.rb
 - spec/models/teacher.rb

data/.travis.yml

@@ -1,12 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.3.0
-gemfile:
-  - Gemfile.rails-5.1
-  - Gemfile.rails-5.0
-  - Gemfile.rails-4.2
-  - Gemfile.rails-4.1
-  - Gemfile.rails-4.0
-env:
-  - DB=sqlite