bullet 5.7.4 → 5.8.0

data/spec/models/comment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Comment < ActiveRecord::Base
   belongs_to :post, inverse_of: :comments
   belongs_to :author, class_name: 'BaseUser'

data/spec/models/company.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Company < ActiveRecord::Base
   has_one :address
 end

data/spec/models/country.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Country < ActiveRecord::Base
   has_many :cities
 end

data/spec/models/document.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Document < ActiveRecord::Base
   has_many :children, class_name: 'Document', foreign_key: 'parent_id'
   belongs_to :parent, class_name: 'Document', foreign_key: 'parent_id'

data/spec/models/entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Entry < ActiveRecord::Base
   belongs_to :category
 end

data/spec/models/firm.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 class Firm < ActiveRecord::Base
   has_many :relationships
   has_many :clients, through: :relationships
+  has_many :groups, through: :clients
 end

data/spec/models/folder.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class Folder < Document
 end

data/spec/models/group.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class Group < ActiveRecord::Base
+end

data/spec/models/mongoid/address.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Mongoid::Address
   include Mongoid::Document
 

data/spec/models/mongoid/category.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Mongoid::Category
   include Mongoid::Document
 

data/spec/models/mongoid/comment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Mongoid::Comment
   include Mongoid::Document
 

data/spec/models/mongoid/company.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Mongoid::Company
   include Mongoid::Document
 

data/spec/models/mongoid/entry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Mongoid::Entry
   include Mongoid::Document
 

data/spec/models/mongoid/post.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Mongoid::Post
   include Mongoid::Document
 

data/spec/models/mongoid/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Mongoid::User
   include Mongoid::Document
 

data/spec/models/newspaper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Newspaper < ActiveRecord::Base
   has_many :writers, class_name: 'BaseUser'
 end

data/spec/models/page.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class Page < Document
 end

data/spec/models/person.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Person < ActiveRecord::Base
   has_many :pets
 end

data/spec/models/pet.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Pet < ActiveRecord::Base
   belongs_to :person, counter_cache: true
 end

data/spec/models/post.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Post < ActiveRecord::Base
   belongs_to :category, inverse_of: :posts
   belongs_to :writer
@@ -12,4 +14,19 @@ class Post < ActiveRecord::Base
   def link=(*)
     comments.new
   end
+
+  # see association_spec.rb 'should not detect newly assigned object in an after_save'
+  attr_accessor :trigger_after_save
+  after_save do
+    next unless trigger_after_save
+
+    temp_comment = Comment.new(post: self)
+    # this triggers self to be "possible", even though it's
+    # not saved yet
+    temp_comment.post
+
+    # category should NOT whine about not being pre-loaded, because
+    # it's obviously attached to a new object
+    category
+  end
 end

data/spec/models/relationship.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Relationship < ActiveRecord::Base
   belongs_to :firm
   belongs_to :client

data/spec/models/reply.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Reply < ActiveRecord::Base
   belongs_to :submission
 end

data/spec/models/student.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Student < ActiveRecord::Base
   has_and_belongs_to_many :teachers
 end

data/spec/models/submission.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Submission < ActiveRecord::Base
   belongs_to :user
   has_many :replies

data/spec/models/teacher.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Teacher < ActiveRecord::Base
   has_and_belongs_to_many :students
 end

data/spec/models/user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class User < ActiveRecord::Base
   has_one :submission
   belongs_to :category

data/spec/models/writer.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class Writer < BaseUser
 end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec'
 begin
   require 'active_record'

data/spec/support/bullet_ext.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Bullet
   def self.collected_notifications_of_class(notification_class)
     Bullet.notification_collector.collection.select do |notification|

data/spec/support/mongo_seed.rb

@@ -1,5 +1,9 @@
+# frozen_string_literal: true
+
 module Support
   module MongoSeed
+    module_function
+
     def seed_db
       category1 = Mongoid::Category.create(name: 'first')
       category2 = Mongoid::Category.create(name: 'second')
@@ -64,7 +68,5 @@ module Support
       Mongoid.purge!
       Mongoid::IdentityMap.clear if Mongoid.const_defined?(:IdentityMap)
     end
-
-    module_function
   end
 end

data/spec/support/rack_double.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Support
   class AppDouble
     def call(_env)

data/spec/support/sqlite_seed.rb

@@ -1,5 +1,9 @@
+# frozen_string_literal: true
+
 module Support
   module SqliteSeed
+    module_function
+
     def seed_db
       newspaper1 = Newspaper.create(name: 'First Newspaper')
       newspaper2 = Newspaper.create(name: 'Second Newspaper')
@@ -41,8 +45,10 @@ module Support
 
       firm1 = Firm.create(name: 'first')
       firm2 = Firm.create(name: 'second')
-      client1 = Client.create(name: 'first')
-      client2 = Client.create(name: 'second')
+      group1 = Group.create(name: 'first')
+      group2 = Group.create(name: 'second')
+      client1 = Client.create(name: 'first', group: group1)
+      client2 = Client.create(name: 'second', group: group2)
       firm1.clients = [client1, client2]
       firm2.clients = [client1, client2]
       client1.firms << firm1
@@ -121,6 +127,7 @@ module Support
 
         create_table :clients do |t|
           t.column :name, :string
+          t.column :group_id, :integer
         end
 
         create_table :comments do |t|
@@ -167,6 +174,10 @@ module Support
           t.column :name, :string
         end
 
+        create_table :groups do |t|
+          t.column :name, :string
+        end
+
         create_table :hotels do |t|
           t.column :name, :string
           t.column :location_id, :integer
@@ -231,7 +242,5 @@ module Support
         end
       end
     end
-
-    module_function
   end
 end

data/tasks/bullet_tasks.rake

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 namespace :bullet do
   namespace :log do
     desc 'Truncates the bullet log file to zero bytes'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet
 version: !ruby/object:Gem::Version
-  version: 5.7.4
+  version: 5.8.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-10 00:00:00.000000000 Z
+date: 2018-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.0
+        version: '1.11'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.0
+        version: '1.11'
 description: help to kill N+1 queries and unused eager loading.
 email:
 - flyerhzm@gmail.com
@@ -133,6 +133,7 @@ files:
 - spec/models/entry.rb
 - spec/models/firm.rb
 - spec/models/folder.rb
+- spec/models/group.rb
 - spec/models/mongoid/address.rb
 - spec/models/mongoid/category.rb
 - spec/models/mongoid/comment.rb
@@ -163,7 +164,9 @@ files:
 homepage: https://github.com/flyerhzm/bullet
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/flyerhzm/bullet/blob/master/CHANGELOG.md
+  source_code_uri: https://github.com/flyerhzm/bullet
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -218,6 +221,7 @@ test_files:
 - spec/models/entry.rb
 - spec/models/firm.rb
 - spec/models/folder.rb
+- spec/models/group.rb
 - spec/models/mongoid/address.rb
 - spec/models/mongoid/category.rb
 - spec/models/mongoid/comment.rb