bullet 5.5.0 → 5.8.0

data/spec/integration/{active_record4 → active_record}/association_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
-if !mongoid? && active_record4?
+if active_record?
   describe Bullet::Detector::Association, 'has_many' do
-    context "post => comments" do
-      it "should detect non preload post => comments" do
+    context 'post => comments' do
+      it 'should detect non preload post => comments' do
         Post.all.each do |post|
           post.comments.map(&:name)
         end
@@ -13,8 +15,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
 
-      it "should detect non preload post => comments for find_by_sql" do
-        Post.find_by_sql("SELECT * FROM posts").each do |post|
+      it 'should detect non preload post => comments for find_by_sql' do
+        Post.find_by_sql('SELECT * FROM posts').each do |post|
           post.comments.map(&:name)
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -23,7 +25,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
 
-      it "should detect preload with post => comments" do
+      it 'should detect preload with post => comments' do
         Post.includes(:comments).each do |post|
           post.comments.map(&:name)
         end
@@ -33,7 +35,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload post => comments" do
+      it 'should detect unused preload post => comments' do
         Post.includes(:comments).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
@@ -41,7 +43,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not detect unused preload post => comments" do
+      it 'should not detect unused preload post => comments' do
         Post.all.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -49,7 +51,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect non preload comment => post with inverse_of" do
+      it 'should detect non preload comment => post with inverse_of' do
         Post.includes(:comments).each do |post|
           post.comments.each do |comment|
             comment.name
@@ -62,7 +64,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect non preload post => comments with empty?" do
+      it 'should detect non preload post => comments with empty?' do
         Post.all.each do |post|
           post.comments.empty?
         end
@@ -72,7 +74,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
 
-      it "should detect non preload post => comments with include?" do
+      it 'should detect non preload post => comments with include?' do
         comment = Comment.last
         Post.all.each do |post|
           post.comments.include?(comment)
@@ -83,7 +85,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
 
-      it "should not detect unused preload person => pets with empty?" do
+      it 'should not detect unused preload person => pets with empty?' do
         Person.all.each do |person|
           person.pets.empty?
         end
@@ -94,8 +96,8 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "category => posts => comments" do
-      it "should detect non preload category => posts => comments" do
+    context 'category => posts => comments' do
+      it 'should detect non preload category => posts => comments' do
         Category.all.each do |category|
           category.posts.each do |post|
             post.comments.map(&:name)
@@ -108,7 +110,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
 
-      it "should detect preload category => posts, but no post => comments" do
+      it 'should detect preload category => posts, but no post => comments' do
         Category.includes(:posts).each do |category|
           category.posts.each do |post|
             post.comments.map(&:name)
@@ -121,8 +123,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
 
-      it "should detect preload with category => posts => comments" do
-        Category.includes({:posts => :comments}).each do |category|
+      it 'should detect preload with category => posts => comments' do
+        Category.includes(posts: :comments).each do |category|
           category.posts.each do |post|
             post.comments.map(&:name)
           end
@@ -133,8 +135,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect preload with category => posts => comments with posts.id > 0" do
-        Category.includes({:posts => :comments}).where('posts.id > 0').references(:posts).each do |category|
+      it 'should detect preload with category => posts => comments with posts.id > 0' do
+        Category.includes(posts: :comments).where('posts.id > 0').references(:posts).each do |category|
           category.posts.each do |post|
             post.comments.map(&:name)
           end
@@ -145,16 +147,16 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload with category => posts => comments" do
-        Category.includes({:posts => :comments}).map(&:name)
+      it 'should detect unused preload with category => posts => comments' do
+        Category.includes(posts: :comments).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
 
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload with post => commnets, no category => posts" do
-        Category.includes({:posts => :comments}).each do |category|
+      it 'should detect unused preload with post => commnets, no category => posts' do
+        Category.includes(posts: :comments).each do |category|
           category.posts.map(&:name)
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -164,8 +166,8 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "category => posts, category => entries" do
-      it "should detect non preload with category => [posts, entries]" do
+    context 'category => posts, category => entries' do
+      it 'should detect non preload with category => [posts, entries]' do
         Category.all.each do |category|
           category.posts.map(&:name)
           category.entries.map(&:name)
@@ -177,7 +179,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :entries)
       end
 
-      it "should detect preload with category => posts, but not with category => entries" do
+      it 'should detect preload with category => posts, but not with category => entries' do
         Category.includes(:posts).each do |category|
           category.posts.map(&:name)
           category.entries.map(&:name)
@@ -189,8 +191,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :entries)
       end
 
-      it "should detect preload with category => [posts, entries]" do
-        Category.includes([:posts, :entries]).each do |category|
+      it 'should detect preload with category => [posts, entries]' do
+        Category.includes(%i[posts entries]).each do |category|
           category.posts.map(&:name)
           category.entries.map(&:name)
         end
@@ -200,8 +202,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload with category => [posts, entries]" do
-        Category.includes([:posts, :entries]).map(&:name)
+      it 'should detect unused preload with category => [posts, entries]' do
+        Category.includes(%i[posts entries]).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :posts)
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :entries)
@@ -209,8 +211,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload with category => entries, but not with category => posts" do
-        Category.includes([:posts, :entries]).each do |category|
+      it 'should detect unused preload with category => entries, but not with category => posts' do
+        Category.includes(%i[posts entries]).each do |category|
           category.posts.map(&:name)
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -221,10 +223,10 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "post => comment" do
-      it "should detect unused preload with post => comments" do
+    context 'post => comment' do
+      it 'should detect unused preload with post => comments' do
         Post.includes(:comments).each do |post|
-          post.comments.first.name if post.comments.first
+          post.comments.first&.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Post, :comments)
@@ -232,7 +234,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect preload with post => commnets" do
+      it 'should detect preload with post => commnets' do
         Post.first.comments.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -240,7 +242,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not detect unused preload with category => posts" do
+      it 'should not detect unused preload with category => posts' do
         category = Category.first
         category.draft_post.destroy!
         post = category.draft_post
@@ -255,9 +257,9 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "category => posts => writer" do
-      it "should not detect unused preload associations" do
-        category = Category.includes({:posts => :writer}).order("id DESC").find_by_name('first')
+    context 'category => posts => writer' do
+      it 'should not detect unused preload associations' do
+        category = Category.includes(posts: :writer).order('id DESC').find_by_name('first')
         category.posts.map do |post|
           post.name
           post.writer.name
@@ -268,8 +270,8 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "scope for_category_name" do
-      it "should detect preload with post => category" do
+    context 'scope for_category_name' do
+      it 'should detect preload with post => category' do
         Post.in_category_name('first').references(:categories).each do |post|
           post.category.name
         end
@@ -279,7 +281,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not be unused preload post => category" do
+      it 'should not be unused preload post => category' do
         Post.in_category_name('first').references(:categories).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -288,8 +290,8 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "scope preload_comments" do
-      it "should detect preload post => comments with scope" do
+    context 'scope preload_comments' do
+      it 'should detect preload post => comments with scope' do
         Post.preload_comments.each do |post|
           post.comments.map(&:name)
         end
@@ -299,7 +301,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload with scope" do
+      it 'should detect unused preload with scope' do
         Post.preload_comments.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
@@ -310,8 +312,8 @@ if !mongoid? && active_record4?
   end
 
   describe Bullet::Detector::Association, 'belongs_to' do
-    context "comment => post" do
-      it "should detect non preload with comment => post" do
+    context 'comment => post' do
+      it 'should detect non preload with comment => post' do
         Comment.all.each do |comment|
           comment.post.name
         end
@@ -321,7 +323,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Comment, :post)
       end
 
-      it "should detect preload with one comment => post" do
+      it 'should detect preload with one comment => post' do
         Comment.first.post.name
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -329,7 +331,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should dtect preload with comment => post" do
+      it 'should dtect preload with comment => post' do
         Comment.includes(:post).each do |comment|
           comment.post.name
         end
@@ -339,7 +341,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not detect preload with comment => post" do
+      it 'should not detect preload with comment => post' do
         Comment.all.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -347,17 +349,39 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload with comment => post" do
+      it 'should detect unused preload with comment => post' do
         Comment.includes(:post).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Comment, :post)
 
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
+
+      it 'should not detect newly assigned object in an after_save' do
+        new_post = Post.new(category: Category.first)
+
+        new_post.trigger_after_save = true
+        new_post.save!
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+      end
+
+      it 'should not detect "manual" preload' do
+        comment = Comment.all.to_a.first
+        post = Post.find(comment.post_id)
+        # "manually" preload with out-of-band data
+        comment.post = post
+        # loading it should not trigger anything
+        comment.post
+
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+      end
     end
 
-    context "comment => post => category" do
-      it "should detect non preload association with comment => post" do
+    context 'comment => post => category' do
+      it 'should detect non preload association with comment => post' do
         Comment.all.each do |comment|
           comment.post.category.name
         end
@@ -367,7 +391,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Comment, :post)
       end
 
-      it "should not detect non preload association with only one comment" do
+      it 'should not detect non preload association with only one comment' do
         Comment.first.post.category.name
 
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -376,7 +400,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect non preload association with post => category" do
+      it 'should detect non preload association with post => category' do
         Comment.includes(:post).each do |comment|
           comment.post.category.name
         end
@@ -386,8 +410,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :category)
       end
 
-      it "should not detect unpreload association" do
-        Comment.includes(:post => :category).each do |comment|
+      it 'should not detect unpreload association' do
+        Comment.includes(post: :category).each do |comment|
           comment.post.category.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -397,9 +421,9 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "comment => author, post => writer" do
-      it "should detect non preloaded writer" do
-        Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
+    context 'comment => author, post => writer' do
+      it 'should detect non preloaded writer' do
+        Comment.includes(%i[author post]).where(['base_users.id = ?', BaseUser.first]).references(:base_users).each do |comment|
           comment.post.writer.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -408,8 +432,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :writer)
       end
 
-      it "should detect unused preload with comment => author" do
-        Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
+      it 'should detect unused preload with comment => author' do
+        Comment.includes([:author, { post: :writer }]).where(['base_users.id = ?', BaseUser.first]).references(:base_users).each do |comment|
           comment.post.writer.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -418,8 +442,8 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect non preloading with writer => newspaper" do
-        Comment.includes(:post => :writer).where("posts.name like '%first%'").references(:posts).each do |comment|
+      it 'should detect non preloading with writer => newspaper' do
+        Comment.includes(post: :writer).where("posts.name like '%first%'").references(:posts).each do |comment|
           comment.post.writer.newspaper.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -428,19 +452,19 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Writer, :newspaper)
       end
 
-      it "should not raise a stack error from posts to category" do
+      it 'should not raise a stack error from posts to category' do
         expect {
-          Comment.includes({:post => :category}).each do |com|
+          Comment.includes(post: :category).each do |com|
             com.post.category
           end
-        }.not_to raise_error()
+        }.not_to raise_error
       end
     end
   end
 
   describe Bullet::Detector::Association, 'has_and_belongs_to_many' do
-    context "students <=> teachers" do
-      it "should detect non preload associations" do
+    context 'students <=> teachers' do
+      it 'should detect non preload associations' do
         Student.all.each do |student|
           student.teachers.map(&:name)
         end
@@ -450,7 +474,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Student, :teachers)
       end
 
-      it "should detect preload associations" do
+      it 'should detect preload associations' do
         Student.includes(:teachers).each do |student|
           student.teachers.map(&:name)
         end
@@ -460,7 +484,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload associations" do
+      it 'should detect unused preload associations' do
         Student.includes(:teachers).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Student, :teachers)
@@ -468,7 +492,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect no unused preload associations" do
+      it 'should detect no unused preload associations' do
         Student.all.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -476,7 +500,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect non preload student => teachers with empty?" do
+      it 'should detect non preload student => teachers with empty?' do
         Student.all.each do |student|
           student.teachers.empty?
         end
@@ -489,8 +513,8 @@ if !mongoid? && active_record4?
   end
 
   describe Bullet::Detector::Association, 'has_many :through' do
-    context "firm => clients" do
-      it "should detect non preload associations" do
+    context 'firm => clients' do
+      it 'should detect non preload associations' do
         Firm.all.each do |firm|
           firm.clients.map(&:name)
         end
@@ -500,7 +524,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Firm, :clients)
       end
 
-      it "should detect preload associations" do
+      it 'should detect preload associations' do
         Firm.includes(:clients).each do |firm|
           firm.clients.map(&:name)
         end
@@ -510,7 +534,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not detect preload associations" do
+      it 'should not detect preload associations' do
         Firm.all.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -518,7 +542,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload associations" do
+      it 'should detect unused preload associations' do
         Firm.includes(:clients).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Firm, :clients)
@@ -526,11 +550,49 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
     end
+
+    context 'firm => clients => groups' do
+      it 'should detect non preload associations' do
+        Firm.all.each do |firm|
+          firm.groups.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Firm, :groups)
+      end
+
+      it 'should detect preload associations' do
+        Firm.includes(:groups).each do |firm|
+          firm.groups.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+      end
+
+      it 'should not detect preload associations' do
+        Firm.all.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+      end
+
+      it 'should detect unused preload associations' do
+        Firm.includes(:groups).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Firm, :groups)
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+      end
+    end
   end
 
-  describe Bullet::Detector::Association, "has_one" do
-    context "company => address" do
-      it "should detect non preload association" do
+  describe Bullet::Detector::Association, 'has_one' do
+    context 'company => address' do
+      it 'should detect non preload association' do
         Company.all.each do |company|
           company.address.name
         end
@@ -540,7 +602,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Company, :address)
       end
 
-      it "should detect preload association" do
+      it 'should detect preload association' do
         Company.includes(:address).each do |company|
           company.address.name
         end
@@ -550,7 +612,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not detect preload association" do
+      it 'should not detect preload association' do
         Company.all.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -558,7 +620,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload association" do
+      it 'should detect unused preload association' do
         Company.includes(:address).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Company, :address)
@@ -568,8 +630,8 @@ if !mongoid? && active_record4?
     end
   end
 
-  describe Bullet::Detector::Association, "has_one => has_many" do
-    it "should not detect preload association" do
+  describe Bullet::Detector::Association, 'has_one => has_many' do
+    it 'should not detect preload association' do
       user = User.first
       user.submission.replies.map(&:name)
       Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -579,8 +641,8 @@ if !mongoid? && active_record4?
     end
   end
 
-  describe Bullet::Detector::Association, "call one association that in possible objects" do
-    it "should not detect preload association" do
+  describe Bullet::Detector::Association, 'call one association that in possible objects' do
+    it 'should not detect preload association' do
       Post.all
       Post.first.comments.map(&:name)
       Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -590,9 +652,9 @@ if !mongoid? && active_record4?
     end
   end
 
-  describe Bullet::Detector::Association, "query immediately after creation" do
-    context "with save" do
-      context "document => children" do
+  describe Bullet::Detector::Association, 'query immediately after creation' do
+    context 'with save' do
+      context 'document => children' do
         it 'should not detect non preload associations' do
           document1 = Document.new
           document1.children.build
@@ -612,8 +674,8 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "with save!" do
-      context "document => children" do
+    context 'with save!' do
+      context 'document => children' do
         it 'should not detect non preload associations' do
           document1 = Document.new
           document1.children.build
@@ -634,9 +696,9 @@ if !mongoid? && active_record4?
     end
   end
 
-  describe Bullet::Detector::Association, "STI" do
-    context "page => author" do
-      it "should detect non preload associations" do
+  describe Bullet::Detector::Association, 'STI' do
+    context 'page => author' do
+      it 'should detect non preload associations' do
         Page.all.each do |page|
           page.author.name
         end
@@ -646,7 +708,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Page, :author)
       end
 
-      it "should detect preload associations" do
+      it 'should detect preload associations' do
         Page.includes(:author).each do |page|
           page.author.name
         end
@@ -656,7 +718,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload associations" do
+      it 'should detect unused preload associations' do
         Page.includes(:author).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Page, :author)
@@ -664,7 +726,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not detect preload associations" do
+      it 'should not detect preload associations' do
         Page.all.map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
@@ -673,11 +735,11 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "disable n plus one query" do
+    context 'disable n plus one query' do
       before { Bullet.n_plus_one_query_enable = false }
       after { Bullet.n_plus_one_query_enable = true }
 
-      it "should not detect n plus one query" do
+      it 'should not detect n plus one query' do
         Post.all.each do |post|
           post.comments.map(&:name)
         end
@@ -687,7 +749,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
       end
 
-      it "should still detect unused eager loading" do
+      it 'should still detect unused eager loading' do
         Post.includes(:comments).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
 
@@ -696,11 +758,11 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "disable unused eager loading" do
+    context 'disable unused eager loading' do
       before { Bullet.unused_eager_loading_enable = false }
       after { Bullet.unused_eager_loading_enable = true }
 
-      it "should not detect unused eager loading" do
+      it 'should not detect unused eager loading' do
         Post.includes(:comments).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
 
@@ -708,7 +770,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
       end
 
-      it "should still detect n plus one query" do
+      it 'should still detect n plus one query' do
         Post.all.each do |post|
           post.comments.map(&:name)
         end
@@ -719,11 +781,11 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "whitelist n plus one query" do
-      before { Bullet.add_whitelist :type => :n_plus_one_query, :class_name => "Post", :association => :comments }
+    context 'whitelist n plus one query' do
+      before { Bullet.add_whitelist type: :n_plus_one_query, class_name: 'Post', association: :comments }
       after { Bullet.clear_whitelist }
 
-      it "should not detect n plus one query" do
+      it 'should not detect n plus one query' do
         Post.all.each do |post|
           post.comments.map(&:name)
         end
@@ -733,7 +795,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
       end
 
-      it "should still detect unused eager loading" do
+      it 'should still detect unused eager loading' do
         Post.includes(:comments).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
 
@@ -742,11 +804,11 @@ if !mongoid? && active_record4?
       end
     end
 
-    context "whitelist unused eager loading" do
-      before { Bullet.add_whitelist :type => :unused_eager_loading, :class_name => "Post", :association => :comments }
+    context 'whitelist unused eager loading' do
+      before { Bullet.add_whitelist type: :unused_eager_loading, class_name: 'Post', association: :comments }
       after { Bullet.clear_whitelist }
 
-      it "should not detect unused eager loading" do
+      it 'should not detect unused eager loading' do
         Post.includes(:comments).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
 
@@ -754,7 +816,7 @@ if !mongoid? && active_record4?
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
       end
 
-      it "should still detect n plus one query" do
+      it 'should still detect n plus one query' do
         Post.all.each do |post|
           post.comments.map(&:name)
         end