bullet 5.5.0 → 5.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f8cac0418ea4a1bb9f8abc6c12e84022f2f118d
-  data.tar.gz: ebdf99115037dec22a5480a63d3bed5f15956dda
+  metadata.gz: '06945d7fd724e3e1f6355de32b078fac99e6366a'
+  data.tar.gz: ab28a1e628416d945ec40ad21b0ff3e8e4dd50ac
 SHA512:
-  metadata.gz: 0904f996964a403a495af310bab8a0612e614eb72a71d08646948508c25d4bf36d2b939da65156a5fc81595477820e0f123aa2a88d618fe97e28e81a6b6f8ada
-  data.tar.gz: d491e12ccce38a26a5e3d27d3f6b84acafe34bb7b6aff56b78a8e22a73a5a3abf88443110587de0080e50b32ef70d8ca387eab5faac0b1bec16efed04bf3acc1
+  metadata.gz: 33e0206bd7d7624e3ca311f48274708fcc8030a23ec77954007faaa6b2b14b1d4fd3a7f75c18a8150399565770dd19e252856c2cc94907c6abd3147488280bbf
+  data.tar.gz: cac678c258a0d278c92cbff1bb5e820d9ec71d628a55573588d3fb100a2ded60d28e496c7906632d438f367835d41b923aa98828028693183610840a22c5d114

data/.travis.yml

@@ -3,6 +3,7 @@ language: ruby
 rvm:
   - 2.3.0
 gemfile:
+  - Gemfile.rails-5.1
   - Gemfile.rails-5.0
   - Gemfile.rails-4.2
   - Gemfile.rails-4.1

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Next Release
 
+## 5.5.1 (03/01/2016)
+
+* Fix inverse_of for rails 5
+* Fix detect file attachment for rack #319
+* Fix `ActiveRecord::Associations::SingularAssociation#reader` usage for Rails 5.1
+
 ## 5.5.0 (12/30/2016)
 
 * Display http request method #311

data/Gemfile.rails-5.1

@@ -0,0 +1,15 @@
+source "https://rubygems.org"
+
+gemspec
+
+gem 'rails', '5.1.0.beta.1'
+gem 'sqlite3'
+gem 'activerecord-jdbcsqlite3-adapter', platforms: [:jruby]
+gem 'activerecord-import'
+
+gem "rspec"
+
+platforms :rbx do
+  gem 'rubysl', '~> 2.0'
+  gem 'rubinius-developer_tools'
+end

data/Hacking.md

@@ -28,7 +28,7 @@ So the flow of a request goes like this:
    the notification collector
 2. The request is handled by Rails, and the installed ActiveRecord extensions
    trigger Detector callbacks
-3. Detectors once called, will determine whether something noteworthy happend.
+3. Detectors once called, will determine whether something noteworthy happened.
    If yes, then a Notification is created and stored in the notification collector.
 4. Rails finishes handling the request
 5. For each notification in the collector, Bullet will iterate over each

data/README.md

@@ -13,7 +13,7 @@ Bullet gem now supports **activerecord** >= 4.0 and **mongoid** >= 4.0.
 
 If you use activerecord 2.x, please use bullet <= 4.5.0
 
-If you use activerecord 3.x, plesae use bullet < 5.5.0
+If you use activerecord 3.x, please use bullet < 5.5.0
 
 ## External Introduction
 
@@ -34,7 +34,7 @@ or add it into a Gemfile (Bundler):
 
 
 ```ruby
-gem "bullet", :group => "development"
+gem 'bullet', group: 'development'
 ```
 
 **Note**: make sure `bullet` gem is added after activerecord (rails) and
@@ -70,23 +70,24 @@ end
 
 The notifier of Bullet is a wrap of [uniform_notifier](https://github.com/flyerhzm/uniform_notifier)
 
-The code above will enable all seven of the Bullet notification systems:
+The code above will enable all of the Bullet notification systems:
 * `Bullet.enable`: enable Bullet gem, otherwise do nothing
 * `Bullet.alert`: pop up a JavaScript alert in the browser
 * `Bullet.bullet_logger`: log to the Bullet log file (Rails.root/log/bullet.log)
+* `Bullet.console`: log warnings to your browser's console.log (Safari/Webkit browsers or Firefox w/Firebug installed)
+* `Bullet.growl`: pop up Growl warnings if your system has Growl installed. Requires a little bit of configuration
+* `Bullet.xmpp`: send XMPP/Jabber notifications to the receiver indicated. Note that the code will currently not handle the adding of contacts, so you will need to make both accounts indicated know each other manually before you will receive any notifications. If you restart the development server frequently, the 'coming online' sound for the Bullet account may start to annoy - in this case set :show_online_status to false; you will still get notifications, but the Bullet account won't announce it's online status anymore.
 * `Bullet.rails_logger`: add warnings directly to the Rails log
 * `Bullet.honeybadger`: add notifications to Honeybadger
 * `Bullet.bugsnag`: add notifications to bugsnag
 * `Bullet.airbrake`: add notifications to airbrake
 * `Bullet.rollbar`: add notifications to rollbar
-* `Bullet.console`: log warnings to your browser's console.log (Safari/Webkit browsers or Firefox w/Firebug installed)
-* `Bullet.growl`: pop up Growl warnings if your system has Growl installed. Requires a little bit of configuration
-* `Bullet.xmpp`: send XMPP/Jabber notifications to the receiver indicated. Note that the code will currently not handle the adding of contacts, so you will need to make both accounts indicated know each other manually before you will receive any notifications. If you restart the development server frequently, the 'coming online' sound for the Bullet account may start to annoy - in this case set :show_online_status to false; you will still get notifications, but the Bullet account won't announce it's online status anymore.
-* `Bullet.raise`: raise errors, useful for making your specs fail unless they have optimized queries
 * `Bullet.add_footer`: adds the details in the bottom left corner of the page. Double click the footer or use close button to hide footer.
 * `Bullet.stacktrace_includes`: include paths with any of these substrings in the stack trace, even if they are not in your main app
 * `Bullet.stacktrace_excludes`: ignore paths with any of these substrings in the stack trace, even if they are not in your main app.
 * `Bullet.slack`: add notifications to slack
+* `Bullet.raise`: raise errors, useful for making your specs fail unless they have optimized queries
+
 
 Bullet also allows you to disable any of its detectors.
 

data/lib/bullet/active_record5.rb

@@ -21,8 +21,8 @@ module Bullet
       ::ActiveRecord::Base.class_eval do
         class <<self
           alias_method :origin_find_by_sql, :find_by_sql
-          def find_by_sql(sql, binds = [], preparable: nil)
-            result = origin_find_by_sql(sql, binds, preparable: nil)
+          def find_by_sql(sql, binds = [], preparable: nil, &block)
+            result = origin_find_by_sql(sql, binds, preparable: nil, &block)
             if Bullet.start?
               if result.is_a? Array
                 if result.size > 1
@@ -204,7 +204,7 @@ module Bullet
         # call has_one and belongs_to associations
         alias_method :origin_reader, :reader
         def reader(force_reload = false)
-          result = origin_reader(force_reload)
+          result = force_reload ? force_reload_reader : origin_reader
           if Bullet.start?
             if owner.class.name !~ /^HABTM_/ && !@inversed
               Bullet::Detector::NPlusOneQuery.call_association(owner, reflection.name)

data/lib/bullet/detector/n_plus_one_query.rb

@@ -11,6 +11,7 @@ module Bullet
         #   if it is, keeps this unpreload associations and caller.
         def call_association(object, associations)
           return unless Bullet.start?
+          return unless Bullet.n_plus_one_query_enable?
           return unless object.primary_key_value
           return if inversed_objects.include?(object.bullet_key, associations)
           add_call_object_associations(object, associations)
@@ -68,7 +69,7 @@ module Bullet
           value = object_associations[object.bullet_key]
           if value
             value.each do |v|
-              # associations == v comparision order is important here because
+              # associations == v comparison order is important here because
               # v variable might be a squeel node where :== method is redefined,
               # so it does not compare values at all and return unexpected results
               result = v.is_a?(Hash) ? v.key?(associations) : associations == v

data/lib/bullet/rack.rb

@@ -55,7 +55,7 @@ module Bullet
     end
 
     def file?(headers)
-      headers["Content-Transfer-Encoding"] == "binary"
+      headers["Content-Transfer-Encoding"] == "binary" || headers["Content-Disposition"]
     end
 
     def sse?(headers)

data/lib/bullet/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Bullet
-  VERSION = "5.5.0"
+  VERSION = "5.5.1"
 end

data/spec/integration/{active_record4 → active_record}/association_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-if !mongoid? && active_record4?
+if active_record?
   describe Bullet::Detector::Association, 'has_many' do
     context "post => comments" do
       it "should detect non preload post => comments" do

data/spec/support/mongo_seed.rb

@@ -33,15 +33,7 @@ module Support
     end
 
     def setup_db
-      if Mongoid::VERSION =~ /\A2\.[4-8]/
-        Mongoid.configure do |config|
-          config.master = Mongo::Connection.new.db("bullet")
-        end
-      elsif Mongoid::VERSION =~ /\A3/
-        Mongoid.configure do |config|
-          config.connect_to("bullet")
-        end
-      elsif Mongoid::VERSION =~ /\A4/
+      if Mongoid::VERSION =~ /\A4/
         Mongoid.configure do |config|
           config.load_configuration(
             sessions: {
@@ -52,7 +44,7 @@ module Support
             }
           )
         end
-      elsif Mongoid::VERSION =~ /\A5/
+      else
         Mongoid.configure do |config|
           config.load_configuration(
               clients: {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet
 version: !ruby/object:Gem::Version
-  version: 5.5.0
+  version: 5.5.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-30 00:00:00.000000000 Z
+date: 2017-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -58,6 +58,7 @@ files:
 - Gemfile.rails-4.1
 - Gemfile.rails-4.2
 - Gemfile.rails-5.0
+- Gemfile.rails-5.1
 - Guardfile
 - Hacking.md
 - MIT-LICENSE
@@ -113,8 +114,7 @@ files:
 - spec/bullet/registry/base_spec.rb
 - spec/bullet/registry/object_spec.rb
 - spec/bullet_spec.rb
-- spec/integration/active_record4/association_spec.rb
-- spec/integration/active_record5/association_spec.rb
+- spec/integration/active_record/association_spec.rb
 - spec/integration/counter_cache_spec.rb
 - spec/integration/mongoid/association_spec.rb
 - spec/models/address.rb
@@ -177,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: help to kill N+1 queries and unused eager loading.
@@ -199,8 +199,7 @@ test_files:
 - spec/bullet/registry/base_spec.rb
 - spec/bullet/registry/object_spec.rb
 - spec/bullet_spec.rb
-- spec/integration/active_record4/association_spec.rb
-- spec/integration/active_record5/association_spec.rb
+- spec/integration/active_record/association_spec.rb
 - spec/integration/counter_cache_spec.rb
 - spec/integration/mongoid/association_spec.rb
 - spec/models/address.rb

data/spec/integration/active_record5/association_spec.rb

@@ -1,768 +0,0 @@
-require 'spec_helper'
-
-if !mongoid? && active_record5?
-  describe Bullet::Detector::Association, 'has_many' do
-    context "post => comments" do
-      it "should detect non preload post => comments" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect non preload post => comments for find_by_sql" do
-        Post.find_by_sql("SELECT * FROM posts").each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect preload with post => comments" do
-        Post.includes(:comments).each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload post => comments" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect unused preload post => comments" do
-        Post.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preload comment => post with inverse_of" do
-        Post.includes(:comments).each do |post|
-          post.comments.each do |comment|
-            comment.name
-            comment.post.name
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preload post => comments with empty?" do
-        Post.all.each do |post|
-          post.comments.empty?
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect non preload post => comments with include?" do
-        comment = Comment.last
-        Post.all.each do |post|
-          post.comments.include?(comment)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should not detect unused preload person => pets with empty?" do
-        Person.all.each do |person|
-          person.pets.empty?
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "category => posts => comments" do
-      it "should detect non preload category => posts => comments" do
-        Category.all.each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect preload category => posts, but no post => comments" do
-        Category.includes(:posts).each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect preload with category => posts => comments" do
-        Category.includes({:posts => :comments}).each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect preload with category => posts => comments with posts.id > 0" do
-        Category.includes({:posts => :comments}).where('posts.id > 0').references(:posts).each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with category => posts => comments" do
-        Category.includes({:posts => :comments}).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with post => commnets, no category => posts" do
-        Category.includes({:posts => :comments}).each do |category|
-          category.posts.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "category => posts, category => entries" do
-      it "should detect non preload with category => [posts, entries]" do
-        Category.all.each do |category|
-          category.posts.map(&:name)
-          category.entries.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :entries)
-      end
-
-      it "should detect preload with category => posts, but not with category => entries" do
-        Category.includes(:posts).each do |category|
-          category.posts.map(&:name)
-          category.entries.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :entries)
-      end
-
-      it "should detect preload with category => [posts, entries]" do
-        Category.includes([:posts, :entries]).each do |category|
-          category.posts.map(&:name)
-          category.entries.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with category => [posts, entries]" do
-        Category.includes([:posts, :entries]).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :entries)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with category => entries, but not with category => posts" do
-        Category.includes([:posts, :entries]).each do |category|
-          category.posts.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :entries)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "post => comment" do
-      it "should detect unused preload with post => comments" do
-        Post.includes(:comments).each do |post|
-          post.comments.first.name if post.comments.first
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect preload with post => commnets" do
-        Post.first.comments.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect unused preload with category => posts" do
-        category = Category.first
-        category.draft_post.destroy!
-        post = category.draft_post
-        post.update_attributes!(link: true)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-
-        Support::SqliteSeed.setup_db
-        Support::SqliteSeed.seed_db
-      end
-    end
-
-    context "category => posts => writer" do
-      it "should not detect unused preload associations" do
-        category = Category.includes({:posts => :writer}).order("id DESC").find_by_name('first')
-        category.posts.map do |post|
-          post.name
-          post.writer.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Category, :posts)
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Post, :writer)
-      end
-    end
-
-    context "scope for_category_name" do
-      it "should detect preload with post => category" do
-        Post.in_category_name('first').references(:categories).each do |post|
-          post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not be unused preload post => category" do
-        Post.in_category_name('first').references(:categories).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "scope preload_comments" do
-      it "should detect preload post => comments with scope" do
-        Post.preload_comments.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with scope" do
-        Post.preload_comments.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, 'belongs_to' do
-    context "comment => post" do
-      it "should detect non preload with comment => post" do
-        Comment.all.each do |comment|
-          comment.post.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Comment, :post)
-      end
-
-      it "should detect preload with one comment => post" do
-        Comment.first.post.name
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should dtect preload with comment => post" do
-        Comment.includes(:post).each do |comment|
-          comment.post.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload with comment => post" do
-        Comment.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with comment => post" do
-        Comment.includes(:post).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Comment, :post)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "comment => post => category" do
-      it "should detect non preload association with comment => post" do
-        Comment.all.each do |comment|
-          comment.post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Comment, :post)
-      end
-
-      it "should not detect non preload association with only one comment" do
-        Comment.first.post.category.name
-
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preload association with post => category" do
-        Comment.includes(:post).each do |comment|
-          comment.post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :category)
-      end
-
-      it "should not detect unpreload association" do
-        Comment.includes(:post => :category).each do |comment|
-          comment.post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "comment => author, post => writer" do
-      it "should detect non preloaded writer" do
-        Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
-          comment.post.writer.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :writer)
-      end
-
-      it "should detect unused preload with comment => author" do
-        Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
-          comment.post.writer.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preloading with writer => newspaper" do
-        Comment.includes(:post => :writer).where("posts.name like '%first%'").references(:posts).each do |comment|
-          comment.post.writer.newspaper.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Writer, :newspaper)
-      end
-
-      it "should not raise a stack error from posts to category" do
-        expect {
-          Comment.includes({:post => :category}).each do |com|
-            com.post.category
-          end
-        }.not_to raise_error()
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, 'has_and_belongs_to_many' do
-    context "students <=> teachers" do
-      it "should detect non preload associations" do
-        Student.all.each do |student|
-          student.teachers.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Student, :teachers)
-      end
-
-      it "should detect preload associations" do
-        Student.includes(:teachers).each do |student|
-          student.teachers.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload associations" do
-        Student.includes(:teachers).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Student, :teachers)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect no unused preload associations" do
-        Student.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preload student => teachers with empty?" do
-        Student.all.each do |student|
-          student.teachers.empty?
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Student, :teachers)
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, 'has_many :through' do
-    context "firm => clients" do
-      it "should detect non preload associations" do
-        Firm.all.each do |firm|
-          firm.clients.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Firm, :clients)
-      end
-
-      it "should detect preload associations" do
-        Firm.includes(:clients).each do |firm|
-          firm.clients.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload associations" do
-        Firm.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload associations" do
-        Firm.includes(:clients).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Firm, :clients)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, "has_one" do
-    context "company => address" do
-      it "should detect non preload association" do
-        Company.all.each do |company|
-          company.address.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Company, :address)
-      end
-
-      it "should detect preload association" do
-        Company.includes(:address).each do |company|
-          company.address.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload association" do
-        Company.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload association" do
-        Company.includes(:address).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Company, :address)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, "has_one => has_many" do
-    it "should not detect preload association" do
-      user = User.first
-      user.submission.replies.map(&:name)
-      Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-      expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-      expect(Bullet::Detector::Association).to be_completely_preloading_associations
-    end
-  end
-
-  describe Bullet::Detector::Association, "call one association that in possible objects" do
-    it "should not detect preload association" do
-      Post.all
-      Post.first.comments.map(&:name)
-      Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-      expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-      expect(Bullet::Detector::Association).to be_completely_preloading_associations
-    end
-  end
-
-  describe Bullet::Detector::Association, "query immediately after creation" do
-    context "with save" do
-      context "document => children" do
-        it 'should not detect non preload associations' do
-          document1 = Document.new
-          document1.children.build
-          document1.save
-
-          document2 = Document.new(parent: document1)
-          document2.save
-          document2.parent
-
-          document1.children.each.first
-
-          Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-          expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-          expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        end
-      end
-    end
-
-    context "with save!" do
-      context "document => children" do
-        it 'should not detect non preload associations' do
-          document1 = Document.new
-          document1.children.build
-          document1.save!
-
-          document2 = Document.new(parent: document1)
-          document2.save!
-          document2.parent
-
-          document1.children.each.first
-
-          Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-          expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-          expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        end
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, "STI" do
-    context "page => author" do
-      it "should detect non preload associations" do
-        Page.all.each do |page|
-          page.author.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Page, :author)
-      end
-
-      it "should detect preload associations" do
-        Page.includes(:author).each do |page|
-          page.author.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload associations" do
-        Page.includes(:author).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Page, :author)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload associations" do
-        Page.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "disable n plus one query" do
-      before { Bullet.n_plus_one_query_enable = false }
-      after { Bullet.n_plus_one_query_enable = true }
-
-      it "should not detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-      end
-    end
-
-    context "disable unused eager loading" do
-      before { Bullet.unused_eager_loading_enable = false }
-      after { Bullet.unused_eager_loading_enable = true }
-
-      it "should not detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-    end
-
-    context "whitelist n plus one query" do
-      before { Bullet.add_whitelist :type => :n_plus_one_query, :class_name => "Post", :association => :comments }
-      after { Bullet.clear_whitelist }
-
-      it "should not detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-      end
-    end
-
-    context "whitelist unused eager loading" do
-      before { Bullet.add_whitelist :type => :unused_eager_loading, :class_name => "Post", :association => :comments }
-      after { Bullet.clear_whitelist }
-
-      it "should not detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-    end
-  end
-end