bullet 5.4.3 → 5.5.0

data/lib/bullet/active_record3x.rb

@@ -1,210 +0,0 @@
-module Bullet
-  module ActiveRecord
-    def self.enable
-      require 'active_record'
-      ::ActiveRecord::Base.class_eval do
-        class <<self
-          alias_method :origin_find_by_sql, :find_by_sql
-          def find_by_sql(sql, binds = [])
-            result = origin_find_by_sql(sql, binds)
-            if Bullet.start?
-              if result.is_a? Array
-                if result.size > 1
-                  Bullet::Detector::NPlusOneQuery.add_possible_objects(result)
-                  Bullet::Detector::CounterCache.add_possible_objects(result)
-                elsif result.size == 1
-                  Bullet::Detector::NPlusOneQuery.add_impossible_object(result.first)
-                  Bullet::Detector::CounterCache.add_impossible_object(result.first)
-                end
-              elsif result.is_a? ::ActiveRecord::Base
-                Bullet::Detector::NPlusOneQuery.add_impossible_object(result)
-                Bullet::Detector::CounterCache.add_impossible_object(result)
-              end
-            end
-            result
-          end
-        end
-      end
-
-      ::ActiveRecord::Relation.class_eval do
-        alias_method :origin_to_a, :to_a
-        # if select a collection of objects, then these objects have possible to cause N+1 query.
-        # if select only one object, then the only one object has impossible to cause N+1 query.
-        def to_a
-          records = origin_to_a
-          if Bullet.start?
-            if records.size > 1
-              Bullet::Detector::NPlusOneQuery.add_possible_objects(records)
-              Bullet::Detector::CounterCache.add_possible_objects(records)
-            elsif records.size == 1
-              Bullet::Detector::NPlusOneQuery.add_impossible_object(records.first)
-              Bullet::Detector::CounterCache.add_impossible_object(records.first)
-            end
-          end
-          records
-        end
-      end
-
-      ::ActiveRecord::Persistence.class_eval do
-        alias_method :origin_save, :save
-        def save(*args, &proc)
-          was_new_record = new_record?
-          origin_save(*args, &proc).tap do |result|
-            Bullet::Detector::NPlusOneQuery.add_impossible_object(self) if result && was_new_record
-          end
-        end
-
-        alias_method :origin_save!, :save!
-        def save!(*args, &proc)
-          was_new_record = new_record?
-          origin_save!(*args, &proc).tap do |result|
-            Bullet::Detector::NPlusOneQuery.add_impossible_object(self) if result && was_new_record
-          end
-        end
-      end
-
-      ::ActiveRecord::Associations::Preloader.class_eval do
-        # include query for one to many associations.
-        # keep this eager loadings.
-        alias_method :origin_initialize, :initialize
-        def initialize(records, associations, preload_scope = nil)
-          origin_initialize(records, associations, preload_scope)
-          if Bullet.start?
-            records = [records].flatten.compact.uniq
-            return if records.empty?
-            records.each do |record|
-              Bullet::Detector::Association.add_object_associations(record, associations)
-            end
-            Bullet::Detector::UnusedEagerLoading.add_eager_loadings(records, associations)
-          end
-        end
-      end
-
-      ::ActiveRecord::FinderMethods.class_eval do
-        # add includes in scope
-        alias_method :origin_find_with_associations, :find_with_associations
-        def find_with_associations
-          records = origin_find_with_associations
-          if Bullet.start?
-            associations = (eager_load_values + includes_values).uniq
-            records.each do |record|
-              Bullet::Detector::Association.add_object_associations(record, associations)
-            end
-            Bullet::Detector::UnusedEagerLoading.add_eager_loadings(records, associations)
-          end
-          records
-        end
-      end
-
-      ::ActiveRecord::Associations::JoinDependency.class_eval do
-        alias_method :origin_instantiate, :instantiate
-        alias_method :origin_construct_association, :construct_association
-
-        def instantiate(rows)
-          @bullet_eager_loadings = {}
-          records = origin_instantiate(rows)
-
-          if Bullet.start?
-            @bullet_eager_loadings.each do |klazz, eager_loadings_hash|
-              objects = eager_loadings_hash.keys
-              Bullet::Detector::UnusedEagerLoading.add_eager_loadings(objects, eager_loadings_hash[objects.first].to_a)
-            end
-          end
-          records
-        end
-
-        # call join associations
-        def construct_association(record, join, row)
-          result = origin_construct_association(record, join, row)
-
-          if Bullet.start?
-            associations = join.reflection.name
-            Bullet::Detector::Association.add_object_associations(record, associations)
-            Bullet::Detector::NPlusOneQuery.call_association(record, associations)
-            @bullet_eager_loadings[record.class] ||= {}
-            @bullet_eager_loadings[record.class][record] ||= Set.new
-            @bullet_eager_loadings[record.class][record] << associations
-          end
-
-          result
-        end
-      end
-
-      ::ActiveRecord::Associations::CollectionAssociation.class_eval do
-        # call one to many associations
-        alias_method :origin_load_target, :load_target
-        def load_target
-          if Bullet.start?
-            Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
-          end
-          origin_load_target
-        end
-
-        alias_method :origin_include?, :include?
-        def include?(object)
-          if Bullet.start?
-            Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
-          end
-          origin_include?(object)
-        end
-      end
-
-      ::ActiveRecord::Associations::HasManyAssociation.class_eval do
-        alias_method :origin_empty?, :empty?
-        def empty?
-          if Bullet.start? && !has_cached_counter?(@reflection)
-            Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
-          end
-          origin_empty?
-        end
-      end
-
-      ::ActiveRecord::Associations::HasAndBelongsToManyAssociation.class_eval do
-        alias_method :origin_empty?, :empty?
-        def empty?
-          if Bullet.start?
-            Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
-          end
-          origin_empty?
-        end
-      end
-
-      ::ActiveRecord::Associations::SingularAssociation.class_eval do
-        # call has_one and belongs_to associations
-        alias_method :origin_reader, :reader
-        def reader(force_reload = false)
-          result = origin_reader(force_reload)
-          if Bullet.start?
-            Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
-            Bullet::Detector::NPlusOneQuery.add_possible_objects(result)
-          end
-          result
-        end
-      end
-
-      ::ActiveRecord::Associations::Association.class_eval do
-        alias_method :origin_set_inverse_instance, :set_inverse_instance
-        def set_inverse_instance(record)
-          if Bullet.start?
-            if record && invertible_for?(record)
-              Bullet::Detector::NPlusOneQuery.add_inversed_object(record, inverse_reflection_for(record).name)
-            end
-          end
-          origin_set_inverse_instance(record)
-        end
-      end
-
-      ::ActiveRecord::Associations::HasManyAssociation.class_eval do
-        alias_method :origin_has_cached_counter?, :has_cached_counter?
-
-        def has_cached_counter?(reflection = reflection())
-          result = origin_has_cached_counter?(reflection)
-          if Bullet.start? && !result
-            Bullet::Detector::CounterCache.add_counter_cache(owner, reflection.name)
-          end
-          result
-        end
-      end
-    end
-  end
-end

data/lib/bullet/mongoid2x.rb

@@ -1,56 +0,0 @@
-module Bullet
-  module Mongoid
-    def self.enable
-      require 'mongoid'
-
-      ::Mongoid::Contexts::Mongo.class_eval do
-        alias_method :origin_first, :first
-        alias_method :origin_last, :last
-        alias_method :origin_iterate, :iterate
-        alias_method :origin_eager_load, :eager_load
-
-        def first
-          result = origin_first
-          Bullet::Detector::NPlusOneQuery.add_impossible_object(result) if result
-          result
-        end
-
-        def last
-          result = origin_last
-          Bullet::Detector::NPlusOneQuery.add_impossible_object(result) if result
-          result
-        end
-
-        def iterate(&block)
-          records = execute.to_a
-          if records.size > 1
-            Bullet::Detector::NPlusOneQuery.add_possible_objects(records)
-          elsif records.size == 1
-            Bullet::Detector::NPlusOneQuery.add_impossible_object(records.first)
-          end
-          origin_iterate(&block)
-        end
-
-        def eager_load(docs)
-          associations = criteria.inclusions.map(&:name)
-          docs.each do |doc|
-            Bullet::Detector::Association.add_object_associations(doc, associations)
-          end
-          Bullet::Detector::UnusedEagerLoading.add_eager_loadings(docs, associations)
-          origin_eager_load(docs)
-        end
-      end
-
-      ::Mongoid::Relations::Accessors.class_eval do
-        alias_method :origin_set_relation, :set_relation
-
-        def set_relation(name, relation)
-          if relation && relation.metadata.macro !~ /embed/
-            Bullet::Detector::NPlusOneQuery.call_association(self, name)
-          end
-          origin_set_relation(name, relation)
-        end
-      end
-    end
-  end
-end

data/spec/integration/active_record3/association_spec.rb

@@ -1,745 +0,0 @@
-require 'spec_helper'
-
-if !mongoid? && active_record3?
-  describe Bullet::Detector::Association, 'has_many' do
-    context "post => comments" do
-      it "should detect non preload post => comments" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect non preload post => comments for find_by_sql" do
-        Post.find_by_sql("SELECT * FROM posts").each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect preload with post => comments" do
-        Post.includes(:comments).each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload post => comments" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect unused preload post => comments" do
-        Post.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect non preload comment => post with inverse_of" do
-        Post.includes(:comments).each do |post|
-          post.comments.each do |comment|
-            comment.name
-            comment.post.name
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preload post => comments with empty?" do
-        Post.all.each do |post|
-          post.comments.empty?
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect non preload post => comments with include?" do
-        comment = Comment.last
-        Post.all.each do |post|
-          post.comments.include?(comment)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should not detect unused preload person => pets with empty?" do
-        Person.all.each do |person|
-          person.pets.empty?
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "category => posts => comments" do
-      it "should detect non preload category => posts => comments" do
-        Category.all.each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect preload category => posts, but no post => comments" do
-        Category.includes(:posts).each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-      end
-
-      it "should detect preload with category => posts => comments" do
-        Category.includes({:posts => :comments}).each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect preload with category => posts => comments with posts.id > 0" do
-        Category.includes({:posts => :comments}).where('posts.id > 0').each do |category|
-          category.posts.each do |post|
-            post.comments.map(&:name)
-          end
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with category => posts => comments" do
-        Category.includes({:posts => :comments}).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with post => commnets, no category => posts" do
-        Category.includes({:posts => :comments}).each do |category|
-          category.posts.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "category => posts, category => entries" do
-      it "should detect non preload with category => [posts, entries]" do
-        Category.all.each do |category|
-          category.posts.map(&:name)
-          category.entries.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :entries)
-      end
-
-      it "should detect preload with category => posts, but not with category => entries" do
-        Category.includes(:posts).each do |category|
-          category.posts.map(&:name)
-          category.entries.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Category, :entries)
-      end
-
-      it "should detect preload with category => [posts, entries]" do
-        Category.includes([:posts, :entries]).each do |category|
-          category.posts.map(&:name)
-          category.entries.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with category => [posts, entries]" do
-        Category.includes([:posts, :entries]).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :entries)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with category => entries, but not with category => posts" do
-        Category.includes([:posts, :entries]).each do |category|
-          category.posts.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Category, :posts)
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Category, :entries)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "post => comment" do
-      it "should detect unused preload with post => comments" do
-        Post.includes(:comments).each do |post|
-          post.comments.first.name if post.comments.first
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect preload with post => commnets" do
-        Post.first.comments.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "category => posts => writer" do
-      it "should not detect unused preload associations" do
-        category = Category.includes({:posts => :writer}).order("id DESC").find_by_name('first')
-        category.posts.map do |post|
-          post.name
-          post.writer.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Category, :posts)
-        expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Post, :writer)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "scope for_category_name" do
-      it "should detect preload with post => category" do
-        Post.in_category_name('first').each do |post|
-          post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not be unused preload post => category" do
-        Post.in_category_name('first').all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "scope preload_comments" do
-      it "should detect preload post => comments with scope" do
-        Post.preload_comments.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with scope" do
-        Post.preload_comments.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, 'belongs_to' do
-    context "comment => post" do
-      it "should detect non preload with comment => post" do
-        Comment.all.each do |comment|
-          comment.post.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Comment, :post)
-      end
-
-      it "should detect preload with one comment => post" do
-        Comment.first.post.name
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should dtect preload with comment => post" do
-        Comment.includes(:post).each do |comment|
-          comment.post.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload with comment => post" do
-        Comment.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload with comments => post" do
-        Comment.includes(:post).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Comment, :post)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "comment => post => category" do
-      it "should detect non preload association with comment => post" do
-        Comment.all.each do |comment|
-          comment.post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Comment, :post)
-      end
-
-      it "should not detect non preload association with only one comment" do
-        Comment.first.post.category.name
-
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preload association with post => category" do
-        Comment.includes(:post).each do |comment|
-          comment.post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :category)
-      end
-
-      it "should not detect unpreload association" do
-        Comment.includes(:post => :category).each do |comment|
-          comment.post.category.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "comment => author, post => writer" do
-      it "should detect non preloaded writer" do
-        Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).each do |comment|
-          comment.post.writer.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :writer)
-      end
-
-      it "should detect unused preload with comment => author" do
-        Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).each do |comment|
-          comment.post.writer.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preloading with writer => newspaper" do
-        Comment.all(:include => {:post => :writer}, :conditions => "posts.name like '%first%'").each do |comment|
-          comment.post.writer.newspaper.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Writer, :newspaper)
-      end
-
-      it "should not raise a stack error from posts to category" do
-        expect {
-          Comment.includes({:post => :category}).each do |com|
-            com.post.category
-          end
-        }.not_to raise_error
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, 'has_and_belongs_to_many' do
-    context "students <=> teachers" do
-      it "should detect non preload associations" do
-        Student.all.each do |student|
-          student.teachers.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Student, :teachers)
-      end
-
-      it "should detect preload associations" do
-        Student.includes(:teachers).each do |student|
-          student.teachers.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload associations" do
-        Student.includes(:teachers).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Student, :teachers)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect no unused preload associations" do
-        Student.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect non preload student => teachers with empty?" do
-        Student.all.each do |student|
-          student.teachers.empty?
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Student, :teachers)
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, 'has_many :through' do
-    context "firm => clients" do
-      it "should detect non preload associations" do
-        Firm.all.each do |firm|
-          firm.clients.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Firm, :clients)
-      end
-
-      it "should detect preload associations" do
-        Firm.includes(:clients).each do |firm|
-          firm.clients.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload associations" do
-        Firm.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload associations" do
-        Firm.includes(:clients).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Firm, :clients)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, "has_one" do
-    context "company => address" do
-      it "should detect non preload association" do
-        Company.all.each do |company|
-          company.address.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Company, :address)
-      end
-
-      it "should detect preload association" do
-        Company.includes(:address).each do |company|
-          company.address.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload association" do
-        Company.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload association" do
-        Company.includes(:address).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Company, :address)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, "call one association that in possible objects" do
-    it "should not detect preload association" do
-      Post.all
-      Post.first.comments.map(&:name)
-      Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-      expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-      expect(Bullet::Detector::Association).to be_completely_preloading_associations
-    end
-  end
-
-  describe Bullet::Detector::Association, "query immediately after creation" do
-    context "with save" do
-      context "document => children" do
-        it 'should not detect non preload associations' do
-          document1 = Document.new
-          document1.children.build
-          document1.save
-
-          document2 = Document.new(parent: document1)
-          document2.save
-          document2.parent
-
-          document1.children.each.first
-
-          Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-          expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-          expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        end
-      end
-    end
-
-    context "with save!" do
-      context "document => children" do
-        it 'should not detect non preload associations' do
-          document1 = Document.new
-          document1.children.build
-          document1.save!
-
-          document2 = Document.new(parent: document1)
-          document2.save!
-          document2.parent
-
-          document1.children.each.first
-
-          Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-          expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-          expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        end
-      end
-    end
-  end
-
-  describe Bullet::Detector::Association, "STI" do
-    context "page => author" do
-      it "should detect non preload associations" do
-        Page.all.each do |page|
-          page.author.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Page, :author)
-      end
-
-      it "should detect preload associations" do
-        Page.includes(:author).each do |page|
-          page.author.name
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should detect unused preload associations" do
-        Page.includes(:author).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Page, :author)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-
-      it "should not detect preload associations" do
-        Page.all.map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-      end
-    end
-
-    context "disable n plus one query" do
-      before { Bullet.n_plus_one_query_enable = false }
-      after { Bullet.n_plus_one_query_enable = true }
-
-      it "should not detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-      end
-    end
-
-    context "disable unused eager loading" do
-      before { Bullet.unused_eager_loading_enable = false }
-      after { Bullet.unused_eager_loading_enable = true }
-
-      it "should not detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-    end
-
-    context "whitelist n plus one query" do
-      before { Bullet.add_whitelist :type => :n_plus_one_query, :class_name => "Post", :association => :comments }
-      after { Bullet.clear_whitelist }
-
-      it "should not detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
-      end
-    end
-
-    context "whitelist unused eager loading" do
-      before { Bullet.add_whitelist :type => :unused_eager_loading, :class_name => "Post", :association => :comments }
-      after { Bullet.clear_whitelist }
-
-      it "should not detect unused eager loading" do
-        Post.includes(:comments).map(&:name)
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-
-      it "should still detect n plus one query" do
-        Post.all.each do |post|
-          post.comments.map(&:name)
-        end
-        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
-
-        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
-        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
-      end
-    end
-  end
-end