bullet 4.6.0 → 4.7.0

data/lib/bullet/notification.rb

@@ -4,5 +4,7 @@ module Bullet
     autoload :UnusedEagerLoading, 'bullet/notification/unused_eager_loading'
     autoload :NPlusOneQuery, 'bullet/notification/n_plus_one_query'
     autoload :CounterCache, 'bullet/notification/counter_cache'
+
+    class UnoptimizedQueryError < StandardError; end
   end
 end

data/lib/bullet/notification/base.rb

@@ -47,6 +47,10 @@ module Bullet
         self.notifier.out_of_channel_notify(self.full_notice)
       end
 
+      def short_notice
+        [whoami, url, title, body].compact.join("\n")
+      end
+
       def eql?(other)
         klazz_associations_str == other.klazz_associations_str
       end

data/lib/bullet/rack.rb

@@ -8,7 +8,6 @@ module Bullet
 
     def call(env)
       return @app.call(env) unless Bullet.enable?
-
       Bullet.start_request
       status, headers, response = @app.call(env)
       return [status, headers, response] if file?(headers) || empty?(response)
@@ -17,6 +16,7 @@ module Bullet
       if Bullet.notification?
         if status == 200 && !response_body(response).frozen? && html_request?(headers, response)
           response_body = response_body(response) << Bullet.gather_inline_notifications
+          add_footer_note(response_body) if Bullet.add_footer
           headers['Content-Length'] = response_body.bytesize.to_s
         end
         Bullet.perform_out_of_channel_notifications(env)
@@ -34,10 +34,15 @@ module Bullet
           !response_body(response).respond_to?(:empty?) ||
           response_body(response).empty?
       else
-        response_body(response).empty?
+        body = response_body(response)
+        body.nil? || body.empty?
       end
     end
 
+    def add_footer_note(response_body)
+      response_body << "<div #{footer_div_style}>" + Bullet.footer_info.uniq.join("<br>") + "</div>"
+    end
+
     # if send file?
     def file?(headers)
       headers["Content-Transfer-Encoding"] == "binary"
@@ -48,7 +53,23 @@ module Bullet
     end
 
     def response_body(response)
-      rails? ? response.body : response.first
+      if rails?
+        Array === response.body ? response.body.first : response.body
+      else
+        response.first
+      end
+    end
+
+    private
+    def footer_div_style
+<<EOF
+style="position: fixed; bottom: 0pt; left: 0pt; cursor: pointer; border-style: solid; border-color: rgb(153, 153, 153);
+ -moz-border-top-colors: none; -moz-border-right-colors: none; -moz-border-bottom-colors: none;
+ -moz-border-left-colors: none; -moz-border-image: none; border-width: 2pt 2pt 0px 0px;
+ padding: 5px; border-radius: 0pt 10pt 0pt 0px; background: none repeat scroll 0% 0% rgba(200, 200, 200, 0.8);
+ color: rgb(119, 119, 119); font-size: 18px;"
+EOF
     end
   end
 end
+

data/lib/bullet/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Bullet
-  VERSION = "4.6.0"
+  VERSION = "4.7.0"
 end

data/spec/bullet/detector/unused_eager_loading_spec.rb

@@ -10,7 +10,7 @@ module Bullet
       before(:each) { UnusedEagerLoading.clear }
 
       context ".call_associations" do
-        it "should get empty array if eager_loadgins" do
+        it "should get empty array if eager_loadings" do
           UnusedEagerLoading.send(:call_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
         end
 

data/spec/bullet/notification/base_spec.rb

@@ -47,7 +47,7 @@ module Bullet
 
       context "#notify_inline" do
         it "should send full_notice to notifier" do
-          notifier = stub
+          notifier = double
           subject.stub(:notifier => notifier, :full_notice => "full_notice")
           notifier.should_receive(:inline_notify).with("full_notice")
           subject.notify_inline
@@ -56,7 +56,7 @@ module Bullet
 
       context "#notify_out_of_channel" do
         it "should send full_out_of_channel to notifier" do
-          notifier = stub
+          notifier = double
           subject.stub(:notifier => notifier, :full_notice => "full_notice")
           notifier.should_receive(:out_of_channel_notify).with("full_notice")
           subject.notify_out_of_channel

data/spec/bullet/rack_spec.rb

@@ -9,48 +9,48 @@ module Bullet
     context "#html_request?" do
       it "should be true if Content-Type is text/html and http body contains html tag" do
         headers = {"Content-Type" => "text/html"}
-        response = stub(:body => "<html><head></head><body></body></html>")
+        response = double(:body => "<html><head></head><body></body></html>")
         middleware.should be_html_request(headers, response)
       end
 
       it "should be true if Content-Type is text/html and http body contains html tag with attributes" do
         headers = {"Content-Type" => "text/html"}
-        response = stub(:body => "<html attr='hello'><head></head><body></body></html>")
+        response = double(:body => "<html attr='hello'><head></head><body></body></html>")
         middleware.should be_html_request(headers, response)
       end
 
       it "should be false if there is no Content-Type header" do
         headers = {}
-        response = stub(:body => "<html><head></head><body></body></html>")
+        response = double(:body => "<html><head></head><body></body></html>")
         middleware.should_not be_html_request(headers, response)
       end
 
       it "should be false if Content-Type is javascript" do
         headers = {"Content-Type" => "text/javascript"}
-        response = stub(:body => "<html><head></head><body></body></html>")
+        response = double(:body => "<html><head></head><body></body></html>")
         middleware.should_not be_html_request(headers, response)
       end
 
       it "should be false if response body doesn't contain html tag" do
         headers = {"Content-Type" => "text/html"}
-        response = stub(:body => "<div>Partial</div>")
+        response = double(:body => "<div>Partial</div>")
         middleware.should_not be_html_request(headers, response)
       end
     end
 
     context "empty?" do
       it "should be false if response is a string and not empty" do
-        response = stub(:body => "<html><head></head><body></body></html>")
+        response = double(:body => "<html><head></head><body></body></html>")
         middleware.should_not be_empty(response)
       end
 
-      it "should be tru if response is not found" do
+      it "should be true if response is not found" do
         response = ["Not Found"]
         middleware.should be_empty(response)
       end
 
       it "should be true if response body is empty" do
-        response = stub(:body => "")
+        response = double(:body => "")
         middleware.should be_empty(response)
       end
     end
@@ -91,7 +91,7 @@ module Bullet
       end
 
       context "when Bullet is disabled" do
-        before(:each) { Bullet.stub(:enable?, false) }
+        before(:each) { Bullet.stub(:enable? => false) }
 
         it "should not call Bullet.start_request" do
           Bullet.should_not_receive(:start_request)

data/spec/integration/{association_spec.rb → active_record3/association_spec.rb}

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-if active_record3? || active_record4?
+if active_record3?
   describe Bullet::Detector::Association, 'has_many' do
     before(:each) do
       Bullet.clear

data/spec/integration/active_record4/association_spec.rb

@@ -0,0 +1,698 @@
+require 'spec_helper'
+
+if active_record4?
+  describe Bullet::Detector::Association, 'has_many' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "post => comments" do
+      it "should detect non preload post => comments" do
+        Post.all.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :comments)
+      end
+
+      it "should detect preload with post => comments" do
+        Post.includes(:comments).each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload post => comments" do
+        Post.includes(:comments).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect unused preload post => comments" do
+        Post.all.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect non preload comment => post with inverse_of" do
+        Post.includes(:comments).each do |post|
+          post.comments.each do |comment|
+            comment.name
+            comment.post.name
+          end
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "category => posts => comments" do
+      it "should detect non preload category => posts => comments" do
+        Category.all.each do |category|
+          category.posts.each do |post|
+            post.comments.map(&:name)
+          end
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :comments)
+      end
+
+      it "should detect preload category => posts, but no post => comments" do
+        Category.includes(:posts).each do |category|
+          category.posts.each do |post|
+            post.comments.map(&:name)
+          end
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should_not be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :comments)
+      end
+
+      it "should detect preload with category => posts => comments" do
+        Category.includes({:posts => :comments}).each do |category|
+          category.posts.each do |post|
+            post.comments.map(&:name)
+          end
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with category => posts => comments" do
+        Category.includes({:posts => :comments}).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with post => commnets, no category => posts" do
+        Category.includes({:posts => :comments}).each do |category|
+          category.posts.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "category => posts, category => entries" do
+      it "should detect non preload with category => [posts, entries]" do
+        Category.all.each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :entries)
+      end
+
+      it "should detect preload with category => posts, but not with category => entries" do
+        Category.includes(:posts).each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should_not be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :entries)
+      end
+
+      it "should detect preload with category => [posts, entries]" do
+        Category.includes([:posts, :entries]).each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with category => [posts, entries]" do
+        Category.includes([:posts, :entries]).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Category, :posts)
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Category, :entries)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with category => entries, but not with category => posts" do
+        Category.includes([:posts, :entries]).each do |category|
+          category.posts.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Category, :posts)
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Category, :entries)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "post => comment" do
+      it "should detect unused preload with post => comments" do
+        Post.includes(:comments).each do |post|
+          post.comments.first.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect preload with post => commnets" do
+        Post.first.comments.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "category => posts => writer" do
+      it "should not detect unused preload associations" do
+        category = Category.includes({:posts => :writer}).order("id DESC").find_by_name('first')
+        category.posts.map do |post|
+          post.name
+          post.writer.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Category, :posts)
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Post, :writer)
+      end
+    end
+
+    context "scope for_category_name" do
+      it "should detect preload with post => category" do
+        Post.in_category_name('first').references(:categories).each do |post|
+          post.category.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not be unused preload post => category" do
+        Post.in_category_name('first').references(:categories).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "scope preload_comments" do
+      it "should detect preload post => comments with scope" do
+        Post.preload_comments.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with scope" do
+        Post.preload_comments.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, 'belongs_to' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "comment => post" do
+      it "should detect non preload with comment => post" do
+        Comment.all.each do |comment|
+          comment.post.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Comment, :post)
+      end
+
+      it "should detect preload with one comment => post" do
+        Comment.first.post.name
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should dtect preload with comment => post" do
+        Comment.includes(:post).each do |comment|
+          comment.post.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect preload with comment => post" do
+        Comment.all.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with comments => post" do
+        Comment.includes(:post).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Comment, :post)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "comment => post => category" do
+      it "should detect non preload association with comment => post" do
+        Comment.all.each do |comment|
+          comment.post.category.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Comment, :post)
+      end
+
+      it "should detect non preload association with post => category" do
+        Comment.includes(:post).each do |comment|
+          comment.post.category.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :category)
+      end
+
+      it "should not detect unpreload association" do
+        Comment.includes(:post => :category).each do |comment|
+          comment.post.category.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "comment => author, post => writer" do
+      # this happens because the post isn't a possible object even though the writer is access through the post
+      # which leads to an 1+N queries
+      it "should detect non preloaded writer" do
+        Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
+          comment.post.writer.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :writer)
+      end
+
+      # this happens because the comment doesn't break down the hash into keys
+      # properly creating an association from comment to post
+      it "should detect unused preload with comment => author" do
+        Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
+          comment.post.writer.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Comment, :author)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      # To flyerhzm: This does not detect that newspaper is unpreloaded. The association is
+      # not within possible objects, and thus cannot be detected as unpreloaded
+      it "should detect non preloading with writer => newspaper" do
+        Comment.includes(:post => :writer).where("posts.name like '%first%'").references(:posts).each do |comment|
+          comment.post.writer.newspaper.name
+        end
+        #Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        #Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Writer, :newspaper)
+      end
+
+      # when we attempt to access category, there is an infinite overflow because load_target is hijacked leading to
+      # a repeating loop of calls in this test
+      it "should not raise a stack error from posts to category" do
+        expect {
+          Comment.includes({:post => :category}).each do |com|
+            com.post.category
+          end
+        }.not_to raise_error()
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, 'has_and_belongs_to_many' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "students <=> teachers" do
+      it "should detect non preload associations" do
+        Student.all.each do |student|
+          student.teachers.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Student, :teachers)
+      end
+
+      it "should detect preload associations" do
+        Student.includes(:teachers).each do |student|
+          student.teachers.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload associations" do
+        Student.includes(:teachers).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Student, :teachers)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect no unused preload associations" do
+        Student.all.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, 'has_many :through' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "firm => clients" do
+      it "should detect non preload associations" do
+        Firm.all.each do |firm|
+          firm.clients.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Firm, :clients)
+      end
+
+      it "should detect preload associations" do
+        Firm.includes(:clients).each do |firm|
+          firm.clients.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect preload associations" do
+        Firm.all.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload associations" do
+        Firm.includes(:clients).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Firm, :clients)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, "has_one" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "company => address" do
+      it "should detect non preload association" do
+        Company.all.each do |company|
+          company.address.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Company, :address)
+      end
+
+      it "should detect preload association" do
+        Company.includes(:address).each do |company|
+          company.address.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect preload association" do
+        Company.all.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload association" do
+        Company.includes(:address).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Company, :address)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, "call one association that in possible objects" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    it "should not detect preload association" do
+      Post.all
+      Post.first.comments.map(&:name)
+      Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+      Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+      Bullet::Detector::Association.should be_completely_preloading_associations
+    end
+  end
+
+  describe Bullet::Detector::Association, "STI" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "page => author" do
+      it "should detect non preload associations" do
+        Page.all.each do |page|
+          page.author.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Page, :author)
+      end
+
+      it "should detect preload associations" do
+        Page.includes(:author).each do |page|
+          page.author.name
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload associations" do
+        Page.includes(:author).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Page, :author)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect preload associations" do
+        Page.all.map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "disable n plus one query" do
+      before { Bullet.n_plus_one_query_enable = false }
+      after { Bullet.n_plus_one_query_enable = true }
+
+      it "should not detect n plus one query" do
+        Post.all.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Post, :comments)
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+      end
+
+      it "should still detect unused eager loading" do
+        Post.includes(:comments).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
+      end
+    end
+
+    context "disable unused eager loading" do
+      before { Bullet.unused_eager_loading_enable = false }
+      after { Bullet.unused_eager_loading_enable = true }
+
+      it "should not detect unused eager loading" do
+        Post.includes(:comments).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+      end
+
+      it "should still detect n plus one query" do
+        Post.all.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+      end
+    end
+
+    context "whitelist n plus one query" do
+      before { Bullet.add_whitelist :type => :n_plus_one_query, :class_name => "Post", :association => :comments }
+      after { Bullet.reset_whitelist }
+
+      it "should not detect n plus one query" do
+        Post.all.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).not_to be_detecting_unpreloaded_association_for(Post, :comments)
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+      end
+
+      it "should still detect unused eager loading" do
+        Post.includes(:comments).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+        expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Post, :comments)
+      end
+    end
+
+    context "whitelist unused eager loading" do
+      before { Bullet.add_whitelist :type => :unused_eager_loading, :class_name => "Post", :association => :comments }
+      after { Bullet.reset_whitelist }
+
+      it "should not detect unused eager loading" do
+        Post.includes(:comments).map(&:name)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+      end
+
+      it "should still detect n plus one query" do
+        Post.all.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+      end
+    end
+  end
+end