bullet 4.3.1 → 4.5.0

data/spec/bullet/detector/association_spec.rb

@@ -40,55 +40,6 @@ module Bullet
           Association.send(:call_object_associations).should be_include(@post1.bullet_ar_key, :associations)
         end
       end
-
-      context ".add_possible_objects" do
-        it "should add possible objects" do
-          Association.add_possible_objects([@post1, @post2])
-          Association.send(:possible_objects).should be_include(@post1.bullet_ar_key)
-          Association.send(:possible_objects).should be_include(@post2.bullet_ar_key)
-        end
-
-        it "should not raise error if object is nil" do
-          lambda { Association.add_possible_objects(nil) }.should_not raise_error
-        end
-      end
-
-      context ".add_impossible_object" do
-        it "should add impossible object" do
-          Association.add_impossible_object(@post1)
-          Association.send(:impossible_objects).should be_include(@post1.bullet_ar_key)
-        end
-      end
-
-      context ".add_eager_loadings" do
-        it "should add objects, associations pair when eager_loadings are empty" do
-          Association.add_eager_loadings([@post1, @post2], :associations)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key, @post2.bullet_ar_key], :associations)
-        end
-
-        it "should add objects, associations pair for existing eager_loadings" do
-          Association.add_eager_loadings([@post1, @post2], :association1)
-          Association.add_eager_loadings([@post1, @post2], :association2)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key, @post2.bullet_ar_key], :association1)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key, @post2.bullet_ar_key], :association2)
-        end
-
-        it "should merge objects, associations pair for existing eager_loadings" do
-          Association.add_eager_loadings([@post1], :association1)
-          Association.add_eager_loadings([@post1, @post2], :association2)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key], :association1)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key], :association2)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key, @post2.bullet_ar_key], :association2)
-        end
-
-        it "should delete objects, associations pair for existing eager_loadings" do
-          Association.add_eager_loadings([@post1, @post2], :association1)
-          Association.add_eager_loadings([@post1], :association2)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key], :association1)
-          Association.send(:eager_loadings).should be_include([@post1.bullet_ar_key], :association2)
-          Association.send(:eager_loadings).should be_include([@post2.bullet_ar_key], :association1)
-        end
-      end
     end
   end
 end

data/spec/bullet/detector/counter_cache_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+module Bullet
+  module Detector
+    describe CounterCache do
+      before :all do
+        @post1 = Post.first
+        @post2 = Post.last
+      end
+      before(:each) { CounterCache.clear }
+
+      context ".clear" do
+        it "should clear all class variables" do
+          CounterCache.class_variable_get(:@@possible_objects).should be_nil
+          CounterCache.class_variable_get(:@@impossible_objects).should be_nil
+        end
+      end
+
+      context ".add_counter_cache" do
+        it "should create notification if conditions met" do
+          CounterCache.should_receive(:conditions_met?).with(@post1.bullet_ar_key, [:comments]).and_return(true)
+          CounterCache.should_receive(:create_notification).with("Post", [:comments])
+          CounterCache.add_counter_cache(@post1, [:comments])
+        end
+
+        it "should not create notification if conditions not met" do
+          CounterCache.should_receive(:conditions_met?).with(@post1.bullet_ar_key, [:comments]).and_return(false)
+          CounterCache.should_receive(:create_notification).never
+          CounterCache.add_counter_cache(@post1, [:comments])
+        end
+      end
+
+      context ".add_possible_objects" do
+        it "should add possible objects" do
+          CounterCache.add_possible_objects([@post1, @post2])
+          CounterCache.send(:possible_objects).should be_include(@post1.bullet_ar_key)
+          CounterCache.send(:possible_objects).should be_include(@post2.bullet_ar_key)
+        end
+
+        it "should add impossible object" do
+          CounterCache.add_impossible_object(@post1)
+          CounterCache.send(:impossible_objects).should be_include(@post1.bullet_ar_key)
+        end
+      end
+
+      context ".conditions_met?" do
+        it "should be true when object is possible, not impossible" do
+          CounterCache.add_possible_objects(@post1)
+          CounterCache.send(:conditions_met?, @post1.bullet_ar_key, :associations).should be_true
+        end
+
+        it "should be false when object is not possible" do
+          CounterCache.send(:conditions_met?, @post1.bullet_ar_key, :associations).should be_false
+        end
+
+        it "should be true when object is possible, and impossible" do
+          CounterCache.add_possible_objects(@post1)
+          CounterCache.add_impossible_object(@post1)
+          CounterCache.send(:conditions_met?, @post1.bullet_ar_key, :associations).should be_false
+        end
+      end
+    end
+  end
+end

data/spec/bullet/detector/n_plus_one_query_spec.rb

@@ -3,7 +3,10 @@ require 'spec_helper'
 module Bullet
   module Detector
     describe NPlusOneQuery do
-      before(:all) { @post = Post.first }
+      before(:all) do
+        @post = Post.first
+        @post2 = Post.last
+      end
       before(:each) { NPlusOneQuery.clear }
 
       context ".call_association" do
@@ -89,6 +92,25 @@ module Bullet
           NPlusOneQuery.call_association(@post, :association)
         end
       end
+
+      context ".add_possible_objects" do
+        it "should add possible objects" do
+          NPlusOneQuery.add_possible_objects([@post, @post2])
+          NPlusOneQuery.send(:possible_objects).should be_include(@post.bullet_ar_key)
+          NPlusOneQuery.send(:possible_objects).should be_include(@post2.bullet_ar_key)
+        end
+
+        it "should not raise error if object is nil" do
+          lambda { NPlusOneQuery.add_possible_objects(nil) }.should_not raise_error
+        end
+      end
+
+      context ".add_impossible_object" do
+        it "should add impossible object" do
+          NPlusOneQuery.add_impossible_object(@post)
+          NPlusOneQuery.send(:impossible_objects).should be_include(@post.bullet_ar_key)
+        end
+      end
     end
   end
 end

data/spec/bullet/detector/unused_eager_loading_spec.rb

@@ -0,0 +1,95 @@
+require 'spec_helper'
+
+module Bullet
+  module Detector
+    describe UnusedEagerLoading do
+      before(:all) do
+        @post = Post.first
+        @post2 = Post.last
+      end
+      before(:each) { UnusedEagerLoading.clear }
+
+      context ".call_associations" do
+        it "should get empty array if eager_loadgins" do
+          UnusedEagerLoading.send(:call_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
+        end
+
+        it "should get call associations if object and association are both in eager_loadings and call_object_associations" do
+          UnusedEagerLoading.add_eager_loadings([@post], :association)
+          UnusedEagerLoading.add_call_object_associations(@post, :association)
+          UnusedEagerLoading.send(:call_associations, @post.bullet_ar_key, Set.new([:association])).should == [:association]
+        end
+
+        it "should not get call associations if not exist in call_object_associations" do
+          UnusedEagerLoading.add_eager_loadings([@post], :association)
+          UnusedEagerLoading.send(:call_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
+        end
+      end
+
+      context ".diff_object_associations" do
+        it "should return associations not exist in call_association" do
+          UnusedEagerLoading.send(:diff_object_associations, @post.bullet_ar_key, Set.new([:association])).should == [:association]
+        end
+
+        it "should return empty if associations exist in call_association" do
+          UnusedEagerLoading.add_eager_loadings([@post], :association)
+          UnusedEagerLoading.add_call_object_associations(@post, :association)
+          UnusedEagerLoading.send(:diff_object_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
+        end
+      end
+
+      context ".check_unused_preload_associations" do
+        it "should set @@checked to true" do
+          UnusedEagerLoading.check_unused_preload_associations
+          UnusedEagerLoading.class_variable_get(:@@checked).should be_true
+        end
+
+        it "should create notification if object_association_diff is not empty" do
+          UnusedEagerLoading.add_object_associations(@post, :association)
+          UnusedEagerLoading.should_receive(:create_notification).with("Post", [:association])
+          UnusedEagerLoading.check_unused_preload_associations
+        end
+
+        it "should not create notification if object_association_diff is empty" do
+          UnusedEagerLoading.clear
+          UnusedEagerLoading.add_object_associations(@post, :association)
+          UnusedEagerLoading.add_eager_loadings([@post], :association)
+          UnusedEagerLoading.add_call_object_associations(@post, :association)
+          UnusedEagerLoading.send(:diff_object_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
+          UnusedEagerLoading.should_not_receive(:create_notification).with("Post", [:association])
+          UnusedEagerLoading.check_unused_preload_associations
+        end
+      end
+
+      context ".add_eager_loadings" do
+        it "should add objects, associations pair when eager_loadings are empty" do
+          UnusedEagerLoading.add_eager_loadings([@post, @post2], :associations)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key, @post2.bullet_ar_key], :associations)
+        end
+
+        it "should add objects, associations pair for existing eager_loadings" do
+          UnusedEagerLoading.add_eager_loadings([@post, @post2], :association1)
+          UnusedEagerLoading.add_eager_loadings([@post, @post2], :association2)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key, @post2.bullet_ar_key], :association1)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key, @post2.bullet_ar_key], :association2)
+        end
+
+        it "should merge objects, associations pair for existing eager_loadings" do
+          UnusedEagerLoading.add_eager_loadings([@post], :association1)
+          UnusedEagerLoading.add_eager_loadings([@post, @post2], :association2)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key], :association1)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key], :association2)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key, @post2.bullet_ar_key], :association2)
+        end
+
+        it "should delete objects, associations pair for existing eager_loadings" do
+          UnusedEagerLoading.add_eager_loadings([@post, @post2], :association1)
+          UnusedEagerLoading.add_eager_loadings([@post], :association2)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key], :association1)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post.bullet_ar_key], :association2)
+          UnusedEagerLoading.send(:eager_loadings).should be_include([@post2.bullet_ar_key], :association1)
+        end
+      end
+    end
+  end
+end