bullet 4.13.1 → 5.5.0

data/spec/integration/{active_record3 → active_record5}/association_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-if !mongoid? && active_record3?
+if !mongoid? && active_record5?
   describe Bullet::Detector::Association, 'has_many' do
     context "post => comments" do
       it "should detect non preload post => comments" do
@@ -13,6 +13,16 @@ if !mongoid? && active_record3?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
 
+      it "should detect non preload post => comments for find_by_sql" do
+        Post.find_by_sql("SELECT * FROM posts").each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
+      end
+
       it "should detect preload with post => comments" do
         Post.includes(:comments).each do |post|
           post.comments.map(&:name)
@@ -39,7 +49,7 @@ if !mongoid? && active_record3?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should not detect non preload comment => post with inverse_of" do
+      it "should detect non preload comment => post with inverse_of" do
         Post.includes(:comments).each do |post|
           post.comments.each do |comment|
             comment.name
@@ -72,6 +82,16 @@ if !mongoid? && active_record3?
 
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
+
+      it "should not detect unused preload person => pets with empty?" do
+        Person.all.each do |person|
+          person.pets.empty?
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+      end
     end
 
     context "category => posts => comments" do
@@ -114,7 +134,7 @@ if !mongoid? && active_record3?
       end
 
       it "should detect preload with category => posts => comments with posts.id > 0" do
-        Category.includes({:posts => :comments}).where('posts.id > 0').each do |category|
+        Category.includes({:posts => :comments}).where('posts.id > 0').references(:posts).each do |category|
           category.posts.each do |post|
             post.comments.map(&:name)
           end
@@ -204,7 +224,7 @@ if !mongoid? && active_record3?
     context "post => comment" do
       it "should detect unused preload with post => comments" do
         Post.includes(:comments).each do |post|
-          post.comments.first.name
+          post.comments.first.name if post.comments.first
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Post, :comments)
@@ -219,6 +239,20 @@ if !mongoid? && active_record3?
 
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
+
+      it "should not detect unused preload with category => posts" do
+        category = Category.first
+        category.draft_post.destroy!
+        post = category.draft_post
+        post.update_attributes!(link: true)
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+
+        Support::SqliteSeed.setup_db
+        Support::SqliteSeed.seed_db
+      end
     end
 
     context "category => posts => writer" do
@@ -231,14 +265,12 @@ if !mongoid? && active_record3?
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Category, :posts)
         expect(Bullet::Detector::Association).not_to be_unused_preload_associations_for(Post, :writer)
-
-        expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
     end
 
     context "scope for_category_name" do
       it "should detect preload with post => category" do
-        Post.in_category_name('first').each do |post|
+        Post.in_category_name('first').references(:categories).each do |post|
           post.category.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -248,7 +280,7 @@ if !mongoid? && active_record3?
       end
 
       it "should not be unused preload post => category" do
-        Post.in_category_name('first').all.map(&:name)
+        Post.in_category_name('first').references(:categories).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
 
@@ -315,7 +347,7 @@ if !mongoid? && active_record3?
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
 
-      it "should detect unused preload with comments => post" do
+      it "should detect unused preload with comment => post" do
         Comment.includes(:post).map(&:name)
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
         expect(Bullet::Detector::Association).to be_unused_preload_associations_for(Comment, :post)
@@ -335,6 +367,15 @@ if !mongoid? && active_record3?
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Comment, :post)
       end
 
+      it "should not detect non preload association with only one comment" do
+        Comment.first.post.category.name
+
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_completely_preloading_associations
+      end
+
       it "should detect non preload association with post => category" do
         Comment.includes(:post).each do |comment|
           comment.post.category.name
@@ -358,7 +399,7 @@ if !mongoid? && active_record3?
 
     context "comment => author, post => writer" do
       it "should detect non preloaded writer" do
-        Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).each do |comment|
+        Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
           comment.post.writer.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -368,7 +409,7 @@ if !mongoid? && active_record3?
       end
 
       it "should detect unused preload with comment => author" do
-        Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).each do |comment|
+        Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).references(:base_users).each do |comment|
           comment.post.writer.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -378,7 +419,7 @@ if !mongoid? && active_record3?
       end
 
       it "should detect non preloading with writer => newspaper" do
-        Comment.all(:include => {:post => :writer}, :conditions => "posts.name like '%first%'").each do |comment|
+        Comment.includes(:post => :writer).where("posts.name like '%first%'").references(:posts).each do |comment|
           comment.post.writer.newspaper.name
         end
         Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
@@ -392,7 +433,7 @@ if !mongoid? && active_record3?
           Comment.includes({:post => :category}).each do |com|
             com.post.category
           end
-        }.not_to raise_error
+        }.not_to raise_error()
       end
     end
   end
@@ -434,6 +475,16 @@ if !mongoid? && active_record3?
 
         expect(Bullet::Detector::Association).to be_completely_preloading_associations
       end
+
+      it "should detect non preload student => teachers with empty?" do
+        Student.all.each do |student|
+          student.teachers.empty?
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Student, :teachers)
+      end
     end
   end
 
@@ -517,6 +568,17 @@ if !mongoid? && active_record3?
     end
   end
 
+  describe Bullet::Detector::Association, "has_one => has_many" do
+    it "should not detect preload association" do
+      user = User.first
+      user.submission.replies.map(&:name)
+      Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+      expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+      expect(Bullet::Detector::Association).to be_completely_preloading_associations
+    end
+  end
+
   describe Bullet::Detector::Association, "call one association that in possible objects" do
     it "should not detect preload association" do
       Post.all
@@ -528,6 +590,50 @@ if !mongoid? && active_record3?
     end
   end
 
+  describe Bullet::Detector::Association, "query immediately after creation" do
+    context "with save" do
+      context "document => children" do
+        it 'should not detect non preload associations' do
+          document1 = Document.new
+          document1.children.build
+          document1.save
+
+          document2 = Document.new(parent: document1)
+          document2.save
+          document2.parent
+
+          document1.children.each.first
+
+          Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+          expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+          expect(Bullet::Detector::Association).to be_completely_preloading_associations
+        end
+      end
+    end
+
+    context "with save!" do
+      context "document => children" do
+        it 'should not detect non preload associations' do
+          document1 = Document.new
+          document1.children.build
+          document1.save!
+
+          document2 = Document.new(parent: document1)
+          document2.save!
+          document2.parent
+
+          document1.children.each.first
+
+          Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+          expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+          expect(Bullet::Detector::Association).to be_completely_preloading_associations
+        end
+      end
+    end
+  end
+
   describe Bullet::Detector::Association, "STI" do
     context "page => author" do
       it "should detect non preload associations" do
@@ -615,7 +721,7 @@ if !mongoid? && active_record3?
 
     context "whitelist n plus one query" do
       before { Bullet.add_whitelist :type => :n_plus_one_query, :class_name => "Post", :association => :comments }
-      after { Bullet.reset_whitelist }
+      after { Bullet.clear_whitelist }
 
       it "should not detect n plus one query" do
         Post.all.each do |post|
@@ -638,7 +744,7 @@ if !mongoid? && active_record3?
 
     context "whitelist unused eager loading" do
       before { Bullet.add_whitelist :type => :unused_eager_loading, :class_name => "Post", :association => :comments }
-      after { Bullet.reset_whitelist }
+      after { Bullet.clear_whitelist }
 
       it "should not detect unused eager loading" do
         Post.includes(:comments).map(&:name)

data/spec/integration/counter_cache_spec.rb

@@ -29,6 +29,29 @@ if !mongoid? && active_record?
       expect(Bullet.collected_counter_cache_notifications).to be_empty
     end
 
+    it "should not need counter cache without size" do
+      Country.includes(:cities).each do |country|
+        country.cities.empty?
+      end
+      expect(Bullet.collected_counter_cache_notifications).to be_empty
+    end
+
+    if active_record5?
+      it "should not need counter cache for has_many through" do
+        Client.all.each do |client|
+          client.firms.size
+        end
+        expect(Bullet.collected_counter_cache_notifications).to be_empty
+      end
+    else
+      it "should need counter cache for has_many through" do
+        Client.all.each do |client|
+          client.firms.size
+        end
+        expect(Bullet.collected_counter_cache_notifications).not_to be_empty
+      end
+    end
+
     it "should not need counter cache with part of cities" do
       Country.all.each do |country|
         country.cities.where(:name => 'first').size
@@ -50,7 +73,7 @@ if !mongoid? && active_record?
 
     context "whitelist" do
       before { Bullet.add_whitelist :type => :counter_cache, :class_name => "Country", :association => :cities }
-      after { Bullet.reset_whitelist }
+      after { Bullet.clear_whitelist }
 
       it "should not detect counter cache" do
         Country.all.each do |country|

data/spec/models/category.rb

@@ -2,6 +2,9 @@ class Category < ActiveRecord::Base
   has_many :posts, inverse_of: :category
   has_many :entries
 
-  has_many :submissions
   has_many :users
+
+  def draft_post
+    posts.draft.first_or_create
+  end
 end

data/spec/models/comment.rb

@@ -1,4 +1,6 @@
 class Comment < ActiveRecord::Base
   belongs_to :post, inverse_of: :comments
   belongs_to :author, class_name: "BaseUser"
+
+  validates :post, presence: true
 end

data/spec/models/post.rb

@@ -1,10 +1,15 @@
 class Post < ActiveRecord::Base
-  extend Bullet::Dependency
-
   belongs_to :category, inverse_of: :posts
   belongs_to :writer
   has_many :comments, inverse_of: :post
 
+  validates :category, presence: true
+
   scope :preload_comments, -> { includes(:comments) }
   scope :in_category_name, ->(name) { where(['categories.name = ?', name]).includes(:category) }
+  scope :draft, -> { where(active: false) }
+
+  def link=(*)
+    comments.new
+  end
 end

data/spec/models/reply.rb

@@ -0,0 +1,3 @@
+class Reply < ActiveRecord::Base
+  belongs_to :submission
+end

data/spec/models/submission.rb

@@ -1,4 +1,4 @@
 class Submission < ActiveRecord::Base
-  belongs_to :category
   belongs_to :user
+  has_many :replies
 end

data/spec/spec_helper.rb

@@ -30,9 +30,6 @@ $LOAD_PATH.unshift(MODELS)
 SUPPORT = File.join(File.dirname(__FILE__), "support")
 Dir[ File.join(SUPPORT, "*.rb") ].reject { |filename| filename =~ /_seed.rb$/ }.sort.each { |file| require file }
 
-require 'coveralls'
-Coveralls.wear!
-
 RSpec.configure do |config|
   config.extend Bullet::Dependency
 
@@ -56,11 +53,12 @@ if active_record?
       Support::SqliteSeed.seed_db
     end
 
-    config.before(:each) do
+    config.before(:example) do
       Bullet.start_request
+      Bullet.enable = true
     end
 
-    config.after(:each) do
+    config.after(:example) do
       Bullet.end_request
     end
   end

data/spec/support/mongo_seed.rb

@@ -52,6 +52,19 @@ module Support
             }
           )
         end
+      elsif Mongoid::VERSION =~ /\A5/
+        Mongoid.configure do |config|
+          config.load_configuration(
+              clients: {
+                  default: {
+                      database: "bullet",
+                      hosts: [ "localhost:27017" ]
+                  }
+              }
+          )
+        end
+        # Increase the level from DEBUG in order to avoid excessive logging to the screen
+        Mongo::Logger.logger.level = Logger::WARN
       end
     end
 

data/spec/support/sqlite_seed.rb

@@ -14,8 +14,9 @@ module Support
       category2 = Category.create(:name => 'second')
 
       post1 = category1.posts.create(:name => 'first', :writer => writer1)
-      post1a = category1.posts.create(:name => 'like first', :writer => writer2)
+      post1a = category1.posts.create(:name => 'like first', :writer => writer2, active: false)
       post2 = category2.posts.create(:name => 'second', :writer => writer2)
+      post3 = category2.posts.create(:name => 'third', :writer => writer2)
 
       comment1 = post1.comments.create(:name => 'first', :author => writer1)
       comment2 = post1.comments.create(:name => 'first2', :author => writer1)
@@ -82,10 +83,13 @@ module Support
       user1 = User.create(:name => 'user1', :category => category1)
       user2 = User.create(:name => 'user2', :category => category1)
 
-      submission1 = category1.submissions.create(:name => "submission1", :user => user1)
-      submission2 = category1.submissions.create(:name => "submission2", :user => user2)
-      submission3 = category2.submissions.create(:name => "submission3", :user => user1)
-      submission4 = category2.submissions.create(:name => "submission4", :user => user2)
+      submission1 = user1.create_submission(:name => "submission1")
+      submission2 = user2.create_submission(:name => "submission2")
+
+      submission1.replies.create(:name => 'reply1')
+      submission1.replies.create(:name => 'reply2')
+      submission2.replies.create(:name => 'reply3')
+      submission2.replies.create(:name => 'reply4')
     end
 
     def setup_db
@@ -191,6 +195,7 @@ module Support
           t.column :name, :string
           t.column :category_id, :integer
           t.column :writer_id, :integer
+          t.column :active, :boolean, :default => true
         end
 
         create_table :relationships do |t|
@@ -211,9 +216,13 @@ module Support
           t.column :name, :string
         end
 
+        create_table :replies do |t|
+          t.column :name, :string
+          t.column :submission_id, :integer
+        end
+
         create_table :submissions do |t|
           t.column :name, :string
-          t.column :category_id, :integer
           t.column :user_id, :integer
         end
 

data/test.sh

@@ -1,15 +1,9 @@
 #bundle update rails && bundle exec rspec spec
 #BUNDLE_GEMFILE=Gemfile.mongoid bundle update mongoid && BUNDLE_GEMFILE=Gemfile.mongoid bundle exec rspec spec
+BUNDLE_GEMFILE=Gemfile.rails-5.0 bundle && BUNDLE_GEMFILE=Gemfile.rails-5.0 bundle exec rspec spec
+BUNDLE_GEMFILE=Gemfile.rails-4.2 bundle && BUNDLE_GEMFILE=Gemfile.rails-4.2 bundle exec rspec spec
 BUNDLE_GEMFILE=Gemfile.rails-4.1 bundle && BUNDLE_GEMFILE=Gemfile.rails-4.1 bundle exec rspec spec
 BUNDLE_GEMFILE=Gemfile.rails-4.0 bundle && BUNDLE_GEMFILE=Gemfile.rails-4.0 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.rails-3.2 bundle && BUNDLE_GEMFILE=Gemfile.rails-3.2 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.rails-3.1 bundle && BUNDLE_GEMFILE=Gemfile.rails-3.1 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.rails-3.0 bundle && BUNDLE_GEMFILE=Gemfile.rails-3.0 bundle exec rspec spec
+BUNDLE_GEMFILE=Gemfile.mongoid-6.0 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-6.0 bundle exec rspec spec
+BUNDLE_GEMFILE=Gemfile.mongoid-5.0 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-5.0 bundle exec rspec spec
 BUNDLE_GEMFILE=Gemfile.mongoid-4.0 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-4.0 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.mongoid-3.1 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-3.1 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.mongoid-3.0 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-3.0 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.mongoid-2.8 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-2.8 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.mongoid-2.7 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-2.7 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.mongoid-2.6 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-2.6 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.mongoid-2.5 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-2.5 bundle exec rspec spec
-BUNDLE_GEMFILE=Gemfile.mongoid-2.4 bundle && BUNDLE_GEMFILE=Gemfile.mongoid-2.4 bundle exec rspec spec

data/update.sh

@@ -0,0 +1,7 @@
+BUNDLE_GEMFILE=Gemfile.rails-5.0 bundle update
+BUNDLE_GEMFILE=Gemfile.rails-4.2 bundle update
+BUNDLE_GEMFILE=Gemfile.rails-4.1 bundle update
+BUNDLE_GEMFILE=Gemfile.rails-4.0 bundle update
+BUNDLE_GEMFILE=Gemfile.mongoid-6.0 bundle update
+BUNDLE_GEMFILE=Gemfile.mongoid-5.0 bundle update
+BUNDLE_GEMFILE=Gemfile.mongoid-4.0 bundle update

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet
 version: !ruby/object:Gem::Version
-  version: 4.13.1
+  version: 5.5.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-03 00:00:00.000000000 Z
+date: 2016-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -28,16 +28,16 @@ dependencies:
   name: uniform_notifier
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 1.10.0
 description: help to kill N+1 queries and unused eager loading.
 email:
 - flyerhzm@gmail.com
@@ -51,19 +51,13 @@ files:
 - CHANGELOG.md
 - Gemfile
 - Gemfile.mongoid
-- Gemfile.mongoid-2.4
-- Gemfile.mongoid-2.5
-- Gemfile.mongoid-2.6
-- Gemfile.mongoid-2.7
-- Gemfile.mongoid-2.8
-- Gemfile.mongoid-3.0
-- Gemfile.mongoid-3.1
 - Gemfile.mongoid-4.0
-- Gemfile.rails-3.0
-- Gemfile.rails-3.1
-- Gemfile.rails-3.2
+- Gemfile.mongoid-5.0
+- Gemfile.mongoid-6.0
 - Gemfile.rails-4.0
 - Gemfile.rails-4.1
+- Gemfile.rails-4.2
+- Gemfile.rails-5.0
 - Guardfile
 - Hacking.md
 - MIT-LICENSE
@@ -71,10 +65,10 @@ files:
 - Rakefile
 - bullet.gemspec
 - lib/bullet.rb
-- lib/bullet/active_record3.rb
-- lib/bullet/active_record3x.rb
 - lib/bullet/active_record4.rb
 - lib/bullet/active_record41.rb
+- lib/bullet/active_record42.rb
+- lib/bullet/active_record5.rb
 - lib/bullet/dependency.rb
 - lib/bullet/detector.rb
 - lib/bullet/detector/association.rb
@@ -84,9 +78,9 @@ files:
 - lib/bullet/detector/unused_eager_loading.rb
 - lib/bullet/ext/object.rb
 - lib/bullet/ext/string.rb
-- lib/bullet/mongoid2x.rb
-- lib/bullet/mongoid3x.rb
 - lib/bullet/mongoid4x.rb
+- lib/bullet/mongoid5x.rb
+- lib/bullet/mongoid6x.rb
 - lib/bullet/notification.rb
 - lib/bullet/notification/base.rb
 - lib/bullet/notification/counter_cache.rb
@@ -98,6 +92,7 @@ files:
 - lib/bullet/registry/association.rb
 - lib/bullet/registry/base.rb
 - lib/bullet/registry/object.rb
+- lib/bullet/stack_trace_filter.rb
 - lib/bullet/version.rb
 - perf/benchmark.rb
 - rails/init.rb
@@ -118,8 +113,8 @@ files:
 - spec/bullet/registry/base_spec.rb
 - spec/bullet/registry/object_spec.rb
 - spec/bullet_spec.rb
-- spec/integration/active_record3/association_spec.rb
 - spec/integration/active_record4/association_spec.rb
+- spec/integration/active_record5/association_spec.rb
 - spec/integration/counter_cache_spec.rb
 - spec/integration/mongoid/association_spec.rb
 - spec/models/address.rb
@@ -148,6 +143,7 @@ files:
 - spec/models/pet.rb
 - spec/models/post.rb
 - spec/models/relationship.rb
+- spec/models/reply.rb
 - spec/models/student.rb
 - spec/models/submission.rb
 - spec/models/teacher.rb
@@ -160,6 +156,7 @@ files:
 - spec/support/sqlite_seed.rb
 - tasks/bullet_tasks.rake
 - test.sh
+- update.sh
 homepage: http://github.com/flyerhzm/bullet
 licenses:
 - MIT
@@ -180,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: help to kill N+1 queries and unused eager loading.
@@ -202,8 +199,8 @@ test_files:
 - spec/bullet/registry/base_spec.rb
 - spec/bullet/registry/object_spec.rb
 - spec/bullet_spec.rb
-- spec/integration/active_record3/association_spec.rb
 - spec/integration/active_record4/association_spec.rb
+- spec/integration/active_record5/association_spec.rb
 - spec/integration/counter_cache_spec.rb
 - spec/integration/mongoid/association_spec.rb
 - spec/models/address.rb
@@ -232,6 +229,7 @@ test_files:
 - spec/models/pet.rb
 - spec/models/post.rb
 - spec/models/relationship.rb
+- spec/models/reply.rb
 - spec/models/student.rb
 - spec/models/submission.rb
 - spec/models/teacher.rb

data/Gemfile.mongoid-2.4

@@ -1,19 +0,0 @@
-source "https://rubygems.org"
-
-gemspec
-
-gem 'rails', '~> 3.2.16'
-gem 'sqlite3', platforms: [:ruby]
-gem 'activerecord-jdbcsqlite3-adapter', platforms: [:jruby]
-gem 'mongoid', '~> 2.4.12'
-
-gem "rspec"
-gem "guard"
-gem "guard-rspec"
-
-gem 'coveralls', require: false
-
-platforms :rbx do
-  gem 'rubysl', '~> 2.0'
-  gem 'rubinius-developer_tools'
-end

data/Gemfile.mongoid-2.6

@@ -1,19 +0,0 @@
-source "https://rubygems.org"
-
-gemspec
-
-gem 'rails', '~> 3.2.16'
-gem 'sqlite3', platforms: [:ruby]
-gem 'activerecord-jdbcsqlite3-adapter', platforms: [:jruby]
-gem 'mongoid', '~> 2.6.0'
-
-gem "rspec"
-gem "guard"
-gem "guard-rspec"
-
-gem 'coveralls', require: false
-
-platforms :rbx do
-  gem 'rubysl', '~> 2.0'
-  gem 'rubinius-developer_tools'
-end