bullet 4.12.0 → 4.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b201e99b1db5ea0ae016eb415b8bdcb2141a0321
-  data.tar.gz: 072c423687b8482273549f30c2538edec5c3c03f
+  metadata.gz: e90d569b3150f0988aeb2f614513e4603f231a92
+  data.tar.gz: 8106c975d3aa193772e6146757c2f55144f8205e
 SHA512:
-  metadata.gz: 624bfcc8a8f2044699d19e598729cba0bf858e054002b435a31cce643d1bc3834139dad14ea510ef573a31059ce13f4b5c1dd892404645cca8d77e47264db794
-  data.tar.gz: ffaf8125f6797fd85b42be44f645e835796d623bc8b656662b8bd7387ac3b92882d4f2daaf2c50c04aced38113d7c96fbd8b3bdf631bd532c0a02663e221e1d1
+  metadata.gz: d7fdb81048632cf1c99bf42680ce5c78ef8f605be770088d2d7f623f25663fb1a00e8f860775175791b54245f1a610430372d7402b35e29b4a636148052ef0e6
+  data.tar.gz: 12518c2cafae4fa1db72215e3d6430c1781f82601176db91edf5b7246f52305a9991f37f522517e71af3d4435b5159589efbc25379694e38c76726cedd85ffc0

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Next Release
 
-## 4.12.0
+## 4.13.0 (07/19/2014)
+
+* Support include? call on ar associations
+
+## 4.12.0 (07/13/2014)
 
 * Fix false n+1 queries caused by inversed objects.
 * Replace .id with .primary_key_value

data/lib/bullet/active_record3.rb

@@ -103,6 +103,12 @@ module Bullet
           Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
           origin_empty?
         end
+
+        alias_method :origin_include?, :include?
+        def include?(object)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
+          origin_include?(object)
+        end
       end
 
       ::ActiveRecord::Associations::AssociationProxy.class_eval do

data/lib/bullet/active_record3x.rb

@@ -91,6 +91,12 @@ module Bullet
           Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
           origin_empty?
         end
+
+        alias_method :origin_include?, :include?
+        def include?(object)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
+          origin_include?(object)
+        end
       end
 
       ::ActiveRecord::Associations::SingularAssociation.class_eval do

data/lib/bullet/active_record4.rb

@@ -91,6 +91,12 @@ module Bullet
           Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
           origin_empty?
         end
+
+        alias_method :origin_include?, :include?
+        def include?(object)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
+          origin_include?(object)
+        end
       end
 
       ::ActiveRecord::Associations::SingularAssociation.class_eval do

data/lib/bullet/active_record41.rb

@@ -93,6 +93,12 @@ module Bullet
           Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
           origin_empty?
         end
+
+        alias_method :origin_include?, :include?
+        def include?(object)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
+          origin_include?(object)
+        end
       end
 
       ::ActiveRecord::Associations::SingularAssociation.class_eval do

data/lib/bullet/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module Bullet
-  VERSION = "4.12.0"
+  VERSION = "4.13.0"
 end

data/spec/integration/active_record3/association_spec.rb

@@ -61,6 +61,17 @@ if !mongoid? && active_record3?
 
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
+
+      it "should detect non preload post => comments with include?" do
+        comment = Comment.last
+        Post.all.each do |post|
+          post.comments.include?(comment)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
+      end
     end
 
     context "category => posts => comments" do

data/spec/integration/active_record4/association_spec.rb

@@ -61,6 +61,17 @@ if !mongoid? && active_record4?
 
         expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
       end
+
+      it "should detect non preload post => comments with include?" do
+        comment = Comment.last
+        Post.all.each do |post|
+          post.comments.include?(comment)
+        end
+        Bullet::Detector::UnusedEagerLoading.check_unused_preload_associations
+        expect(Bullet::Detector::Association).not_to be_has_unused_preload_associations
+
+        expect(Bullet::Detector::Association).to be_detecting_unpreloaded_association_for(Post, :comments)
+      end
     end
 
     context "category => posts => comments" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet
 version: !ruby/object:Gem::Version
-  version: 4.12.0
+  version: 4.13.0
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-13 00:00:00.000000000 Z
+date: 2014-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport