bullet 2.3.1 → 4.0.0

data/spec/bullet/detector/counter_spec.rb

@@ -11,7 +11,6 @@ module Bullet
 
       context ".clear" do
         it "should clear all class variables" do
-          Counter.clear
           Counter.class_variable_get(:@@possible_objects).should be_nil
           Counter.class_variable_get(:@@impossible_objects).should be_nil
         end
@@ -19,13 +18,13 @@ module Bullet
 
       context ".add_counter_cache" do
         it "should create notification if conditions met" do
-          Counter.should_receive(:conditions_met?).with(@post1.ar_key, [:comments]).and_return(true)
+          Counter.should_receive(:conditions_met?).with(@post1.bullet_ar_key, [:comments]).and_return(true)
           Counter.should_receive(:create_notification).with("Post", [:comments])
           Counter.add_counter_cache(@post1, [:comments])
         end
 
         it "should not create notification if conditions not met" do
-          Counter.should_receive(:conditions_met?).with(@post1.ar_key, [:comments]).and_return(false)
+          Counter.should_receive(:conditions_met?).with(@post1.bullet_ar_key, [:comments]).and_return(false)
           Counter.should_receive(:create_notification).never
           Counter.add_counter_cache(@post1, [:comments])
         end
@@ -34,30 +33,30 @@ module Bullet
       context ".add_possible_objects" do
         it "should add possible objects" do
           Counter.add_possible_objects([@post1, @post2])
-          Counter.send(:possible_objects).should be_include(@post1.ar_key)
-          Counter.send(:possible_objects).should be_include(@post2.ar_key)
+          Counter.send(:possible_objects).should be_include(@post1.bullet_ar_key)
+          Counter.send(:possible_objects).should be_include(@post2.bullet_ar_key)
         end
 
         it "should add impossible object" do
           Counter.add_impossible_object(@post1)
-          Counter.send(:impossible_objects).should be_include(@post1.ar_key)
+          Counter.send(:impossible_objects).should be_include(@post1.bullet_ar_key)
         end
       end
 
       context ".conditions_met?" do
         it "should be true when object is possible, not impossible" do
           Counter.add_possible_objects(@post1)
-          Counter.send(:conditions_met?, @post1.ar_key, :associations).should be_true
+          Counter.send(:conditions_met?, @post1.bullet_ar_key, :associations).should be_true
         end
 
         it "should be false when object is not possible" do
-          Counter.send(:conditions_met?, @post1.ar_key, :associations).should be_false
+          Counter.send(:conditions_met?, @post1.bullet_ar_key, :associations).should be_false
         end
 
         it "should be true when object is possible, and impossible" do
           Counter.add_possible_objects(@post1)
           Counter.add_impossible_object(@post1)
-          Counter.send(:conditions_met?, @post1.ar_key, :associations).should be_false
+          Counter.send(:conditions_met?, @post1.bullet_ar_key, :associations).should be_false
         end
       end
     end

data/spec/bullet/detector/n_plus_one_query_spec.rb

@@ -21,69 +21,69 @@ module Bullet
       context ".possible?" do
         it "should be true if possible_objects contain" do
           NPlusOneQuery.add_possible_objects(@post)
-          NPlusOneQuery.send(:possible?, @post.ar_key).should be_true
+          NPlusOneQuery.send(:possible?, @post.bullet_ar_key).should be_true
         end
       end
 
       context ".impossible?" do
         it "should be true if impossible_objects contain" do
           NPlusOneQuery.add_impossible_object(@post)
-          NPlusOneQuery.send(:impossible?, @post.ar_key).should be_true
+          NPlusOneQuery.send(:impossible?, @post.bullet_ar_key).should be_true
         end
       end
 
       context ".association?" do
         it "should be true if object, associations pair is already existed" do
           NPlusOneQuery.add_object_associations(@post, :association)
-          NPlusOneQuery.send(:association?, @post.ar_key, :association).should be_true
+          NPlusOneQuery.send(:association?, @post.bullet_ar_key, :association).should be_true
         end
 
         it "should be false if object, association pair is not existed" do
           NPlusOneQuery.add_object_associations(@post, :association1)
-          NPlusOneQuery.send(:association?, @post.ar_key, :associatio2).should be_false
+          NPlusOneQuery.send(:association?, @post.bullet_ar_key, :associatio2).should be_false
         end
       end
 
       context ".conditions_met?" do
         it "should be true if object is possible, not impossible and object, associations pair is not already existed" do
-          NPlusOneQuery.stub(:possible?).with(@post.ar_key).and_return(true)
-          NPlusOneQuery.stub(:impossible?).with(@post.ar_key).and_return(false)
-          NPlusOneQuery.stub(:association?).with(@post.ar_key, :associations).and_return(false)
-          NPlusOneQuery.send(:conditions_met?, @post.ar_key, :associations).should be_true
+          NPlusOneQuery.stub(:possible?).with(@post.bullet_ar_key).and_return(true)
+          NPlusOneQuery.stub(:impossible?).with(@post.bullet_ar_key).and_return(false)
+          NPlusOneQuery.stub(:association?).with(@post.bullet_ar_key, :associations).and_return(false)
+          NPlusOneQuery.send(:conditions_met?, @post.bullet_ar_key, :associations).should be_true
         end
 
         it "should be false if object is not possible, not impossible and object, associations pair is not already existed" do
-          NPlusOneQuery.stub(:possible?).with(@post.ar_key).and_return(false)
-          NPlusOneQuery.stub(:impossible?).with(@post.ar_key).and_return(false)
-          NPlusOneQuery.stub(:association?).with(@post.ar_key, :associations).and_return(false)
-          NPlusOneQuery.send(:conditions_met?, @post.ar_key, :associations).should be_false
+          NPlusOneQuery.stub(:possible?).with(@post.bullet_ar_key).and_return(false)
+          NPlusOneQuery.stub(:impossible?).with(@post.bullet_ar_key).and_return(false)
+          NPlusOneQuery.stub(:association?).with(@post.bullet_ar_key, :associations).and_return(false)
+          NPlusOneQuery.send(:conditions_met?, @post.bullet_ar_key, :associations).should be_false
         end
 
         it "should be false if object is possible, but impossible and object, associations pair is not already existed" do
-          NPlusOneQuery.stub(:possible?).with(@post.ar_key).and_return(true)
-          NPlusOneQuery.stub(:impossible?).with(@post.ar_key).and_return(true)
-          NPlusOneQuery.stub(:association?).with(@post.ar_key, :associations).and_return(false)
-          NPlusOneQuery.send(:conditions_met?, @post.ar_key, :associations).should be_false
+          NPlusOneQuery.stub(:possible?).with(@post.bullet_ar_key).and_return(true)
+          NPlusOneQuery.stub(:impossible?).with(@post.bullet_ar_key).and_return(true)
+          NPlusOneQuery.stub(:association?).with(@post.bullet_ar_key, :associations).and_return(false)
+          NPlusOneQuery.send(:conditions_met?, @post.bullet_ar_key, :associations).should be_false
         end
 
         it "should be false if object is possible, not impossible and object, associations pair is already existed" do
-          NPlusOneQuery.stub(:possible?).with(@post.ar_key).and_return(true)
-          NPlusOneQuery.stub(:impossible?).with(@post.ar_key).and_return(false)
-          NPlusOneQuery.stub(:association?).with(@post.ar_key, :associations).and_return(true)
-          NPlusOneQuery.send(:conditions_met?, @post.ar_key, :associations).should be_false
+          NPlusOneQuery.stub(:possible?).with(@post.bullet_ar_key).and_return(true)
+          NPlusOneQuery.stub(:impossible?).with(@post.bullet_ar_key).and_return(false)
+          NPlusOneQuery.stub(:association?).with(@post.bullet_ar_key, :associations).and_return(true)
+          NPlusOneQuery.send(:conditions_met?, @post.bullet_ar_key, :associations).should be_false
         end
       end
 
       context ".call_association" do
         it "should create notification if conditions met" do
-          NPlusOneQuery.should_receive(:conditions_met?).with(@post.ar_key, :association).and_return(true)
+          NPlusOneQuery.should_receive(:conditions_met?).with(@post.bullet_ar_key, :association).and_return(true)
           NPlusOneQuery.should_receive(:caller_in_project).and_return(["caller"])
           NPlusOneQuery.should_receive(:create_notification).with(["caller"], "Post", :association)
           NPlusOneQuery.call_association(@post, :association)
         end
 
         it "should not create notification if conditions not met" do
-          NPlusOneQuery.should_receive(:conditions_met?).with(@post.ar_key, :association).and_return(false)
+          NPlusOneQuery.should_receive(:conditions_met?).with(@post.bullet_ar_key, :association).and_return(false)
           NPlusOneQuery.should_not_receive(:caller_in_project!)
           NPlusOneQuery.should_not_receive(:create_notification).with("Post", :association)
           NPlusOneQuery.call_association(@post, :association)

data/spec/bullet/detector/unused_eager_association_spec.rb

@@ -8,30 +8,30 @@ module Bullet
 
       context ".call_associations" do
         it "should get empty array if eager_loadgins" do
-          UnusedEagerAssociation.send(:call_associations, @post.ar_key, Set.new([:association])).should be_empty
+          UnusedEagerAssociation.send(:call_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
         end
 
         it "should get call associations if object and association are both in eager_loadings and call_object_associations" do
           UnusedEagerAssociation.add_eager_loadings([@post], :association)
           UnusedEagerAssociation.add_call_object_associations(@post, :association)
-          UnusedEagerAssociation.send(:call_associations, @post.ar_key, Set.new([:association])).should == [:association]
+          UnusedEagerAssociation.send(:call_associations, @post.bullet_ar_key, Set.new([:association])).should == [:association]
         end
 
         it "should not get call associations if not exist in call_object_associations" do
           UnusedEagerAssociation.add_eager_loadings([@post], :association)
-          UnusedEagerAssociation.send(:call_associations, @post.ar_key, Set.new([:association])).should be_empty
+          UnusedEagerAssociation.send(:call_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
         end
       end
 
-      context ".diff_object_association" do
+      context ".diff_object_associations" do
         it "should return associations not exist in call_association" do
-          UnusedEagerAssociation.send(:diff_object_association, @post.ar_key, Set.new([:association])).should == [:association]
+          UnusedEagerAssociation.send(:diff_object_associations, @post.bullet_ar_key, Set.new([:association])).should == [:association]
         end
 
         it "should return empty if associations exist in call_association" do
           UnusedEagerAssociation.add_eager_loadings([@post], :association)
           UnusedEagerAssociation.add_call_object_associations(@post, :association)
-          UnusedEagerAssociation.send(:diff_object_association, @post.ar_key, Set.new([:association])).should be_empty
+          UnusedEagerAssociation.send(:diff_object_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
         end
       end
 
@@ -52,7 +52,7 @@ module Bullet
           UnusedEagerAssociation.add_object_associations(@post, :association)
           UnusedEagerAssociation.add_eager_loadings([@post], :association)
           UnusedEagerAssociation.add_call_object_associations(@post, :association)
-          UnusedEagerAssociation.send(:diff_object_association, @post.ar_key, Set.new([:association])).should be_empty
+          UnusedEagerAssociation.send(:diff_object_associations, @post.bullet_ar_key, Set.new([:association])).should be_empty
           UnusedEagerAssociation.should_not_receive(:create_notification).with("Post", [:association])
           UnusedEagerAssociation.check_unused_preload_associations
         end

data/spec/bullet/ext/object_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Object do
+  context "bullet_ar_key" do
+    it "should return class and id composition" do
+      post = Post.first
+      post.bullet_ar_key.should == "Post:#{post.id}"
+    end
+
+    begin
+      require 'mongoid'
+
+      it "should return class with namesapce and id composition" do
+        post = Mongoid::Post.first
+        post.bullet_ar_key.should == "Mongoid::Post:#{post.id}"
+      end
+    rescue LoadError
+    end
+  end
+end

data/spec/bullet/ext/string_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe String do
+  context "bullet_class_name" do
+    it "should only return class name" do
+      "Post:1".bullet_class_name.should == "Post"
+    end
+
+    it "should return class name with namespace" do
+      "Mongoid::Post:1234567890".bullet_class_name.should == "Mongoid::Post"
+    end
+  end
+end

data/spec/bullet/registry/object_spec.rb

@@ -6,18 +6,18 @@ module Bullet
     describe Object do
       let(:post) { Post.first }
       let(:another_post) { Post.last }
-      subject { Object.new.tap { |object| object.add(post.ar_key) } }
+      subject { Object.new.tap { |object| object.add(post.bullet_ar_key) } }
 
       context "#include?" do
         it "should include the object" do
-          subject.should be_include(post.ar_key)
+          subject.should be_include(post.bullet_ar_key)
         end
       end
 
       context "#add" do
         it "should add an object" do
-          subject.add(another_post.ar_key)
-          subject.should be_include(another_post.ar_key)
+          subject.add(another_post.bullet_ar_key)
+          subject.should be_include(another_post.bullet_ar_key)
         end
       end
     end

data/spec/integration/association_spec.rb

@@ -1,531 +1,593 @@
 require 'spec_helper'
 
-describe Bullet::Detector::Association, 'has_many' do
-  before(:each) do
-    Bullet.start_request
-  end
-
-  after(:each) do
-    Bullet.end_request
-  end
-
-  context "for unused cases" do
-    #If you have the same record created twice with different includes
-    #  the hash value get's accumulated includes, which leads to false Unused eager loading
-    #it "should not incorrectly mark associations as unused when multiple object instances" do
-      #comments_with_author = Comment.includes(:author)
-      #comments_with_post = Comment.includes(:post)
-      #comments_with_author.each { |c| c.author.name }
-      #comments_with_author.each { |c| c.post.name }
-      #Bullet::Association.check_unused_preload_associations
-      #Bullet::Association.should be_unused_preload_associations_for(Comment, :post)
-      #Bullet::Association.should be_detecting_unpreloaded_association_for(Comment, :post)
-    #end
-
-    # same as above with different Models being queried
-    #it "should not incorrectly mark associations as unused when multiple object instances different Model" do
-      #post_with_comments = Post.includes(:comments)
-      #comments_with_author = Comment.includes(:author)
-      #post_with_comments.each { |p| p.comments.first.author.name }
-      #comments_with_author.each { |c| c.name }
-      #Bullet::Association.check_unused_preload_associations
-      #Bullet::Association.should be_unused_preload_associations_for(Comment, :author)
-      #Bullet::Association.should be_detecting_unpreloaded_association_for(Comment, :author)
-    #end
-
-    # this test passes right now. But is a regression test to ensure that if only a small set of returned records
-    # is not used that a unused preload association error is not generated
-    it  "should not have unused when small set of returned records are discarded" do
-      comments_with_author = Comment.includes(:author)
-      comment_collection = comments_with_author.limit(2)
-      comment_collection.collect { |com| com.author.name }
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_unused_preload_associations_for(Comment, :author)
+if Rails.version.to_i > 2
+  describe Bullet::Detector::Association, 'has_many' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
     end
-  end
 
+    after(:each) do
+      Bullet.end_request
+    end
 
-  context "comments => posts => category" do
+    context "post => comments" do
+      it "should detect non preload post => comments" do
+        Post.all.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-    # this happens because the post isn't a possible object even though the writer is access through the post
-    # which leads to an 1+N queries
-    it "should detect unpreloaded writer" do
-      Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).each do |com|
-        com.post.writer.name
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :comments)
       end
-      Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :writer)
-    end
 
-    # this happens because the comment doesn't break down the hash into keys
-    # properly creating an association from comment to post
-    it "should detect preload of comment => post" do
-      comments = Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).each do |com|
-        com.post.writer.name
+      it "should detect preload with post => comments" do
+        Post.includes(:comments).each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should_not be_detecting_unpreloaded_association_for(Comment, :post)
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
 
-    it "should detect preload of post => writer" do
-      comments = Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).each do |com|
-        com.post.writer.name
+      it "should detect unused preload post => comments" do
+        Post.includes(:comments).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should be_creating_object_association_for(comments.first, :author)
-      Bullet::Detector::Association.should_not be_detecting_unpreloaded_association_for(Post, :writer)
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
 
-    # To flyerhzm: This does not detect that newspaper is unpreloaded. The association is
-    # not within possible objects, and thus cannot be detected as unpreloaded
-    it "should detect unpreloading of writer => newspaper" do
-      comments = Comment.all(:include => {:post => :writer}, :conditions => "posts.name like '%first%'").each do |com|
-        com.post.writer.newspaper.name
+      it "should not detect unused preload post => comments" do
+        Post.all.map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Writer, :newspaper)
     end
 
-    # when we attempt to access category, there is an infinite overflow because load_target is hijacked leading to
-    # a repeating loop of calls in this test
-    it "should not raise a stack error from posts to category" do
-      lambda {
-        Comment.includes({:post => :category}).each do |com|
-          com.post.category
+    context "category => posts => comments" do
+      it "should detect non preload category => posts => comments" do
+        Category.all.each do |category|
+          category.posts.each do |post|
+            post.comments.map(&:name)
+          end
         end
-      }.should_not raise_error(SystemStackError)
-    end
-  end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-  context "post => comments" do
-  #
-  ### FIXME: Please double check semantic equivalence with original
-    it "should detect preload with post => comments" do
-      Post.includes(:comments).each do |post|
-        post.comments.collect(&:name)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :comments)
       end
-      # Bullet::Detector::Association.should_not be_has_unpreload_associations
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
 
-    it "should detect no preload post => comments" do
-      Post.all.each do |post|
-        post.comments.collect(&:name)
+      it "should detect preload category => posts, but no post => comments" do
+        Category.includes(:posts).each do |category|
+          category.posts.each do |post|
+            post.comments.collect(&:name)
+          end
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should_not be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :comments)
       end
-      # Bullet::Detector::Association.should be_has_unpreload_associations
-      Bullet::Detector::Association.should_not be_completely_preloading_associations
-    end
 
-    it "should detect unused preload post => comments for post" do
-      Post.includes(:comments).collect(&:name)
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should be_has_unused_preload_associations
-    end
+      it "should detect preload with category => posts => comments" do
+        Category.includes({:posts => :comments}).each do |category|
+          category.posts.each do |post|
+            post.comments.map(&:name)
+          end
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-    it "should detect no unused preload post => comments for post" do
-      Post.all.collect(&:name)
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
-    end
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with category => posts => comments" do
+        Category.includes({:posts => :comments}).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
 
-    it "should detect no unused preload post => comments for comment" do
-      Post.all.each do |post|
-        post.comments.collect(&:name)
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-      Bullet.end_request
-      Bullet.start_request
+      it "should detect unused preload with post => commnets, no category => posts" do
+        Category.includes({:posts => :comments}).each do |category|
+          category.posts.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
 
-      Post.all.each do |post|
-        post.comments.collect(&:name)
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
     end
-  end
 
-  context "category => posts => comments" do
-    it "should detect preload with category => posts => comments" do
-      Category.includes({:posts => :comments}).each do |category|
-        category.posts.each do |post|
-          post.comments.collect(&:name)
+    context "category => posts, category => entries" do
+      it "should detect non preload with category => [posts, entries]" do
+        Category.all.each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
         end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :entries)
       end
-      # Bullet::Detector::Association.should_not be_has_unpreload_associations
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
 
-    it "should detect preload category => posts, but no post => comments" do
-      Category.includes(:posts).each do |category|
-        category.posts.each do |post|
-          post.comments.collect(&:name)
+      it "should detect preload with category => posts, but not with category => entries" do
+        Category.includes(:posts).each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
         end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should_not be_detecting_unpreloaded_association_for(Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Category, :entries)
       end
-      # Bullet::Detector::Association.should be_has_unpreload_associations
-      Bullet::Detector::Association.should_not be_completely_preloading_associations
-    end
 
-    it "should detect no preload category => posts => comments" do
-      Category.all.each do |category|
-        category.posts.each do |post|
-          post.comments.collect(&:name)
+      it "should detect preload with category => [posts, entries]" do
+        Category.includes([:posts, :entries]).each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
         end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      # Bullet::Detector::Association.should be_has_unpreload_associations
-      Bullet::Detector::Association.should_not be_completely_preloading_associations
-    end
 
-    it "should detect unused preload with category => posts => comments" do
-      Category.includes({:posts => :comments}).collect(&:name)
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should be_has_unused_preload_associations
-    end
+      it "should detect unused preload with category => [posts, entries]" do
+        Category.includes([:posts, :entries]).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Category, :posts)
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Category, :entries)
 
-    it "should detect unused preload with post => commnets, no category => posts" do
-      Category.includes({:posts => :comments}).each do |category|
-        category.posts.collect(&:name)
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should be_has_unused_preload_associations
-    end
 
-    it "should no detect preload with category => posts => comments" do
-      Category.all.each do |category|
-        category.posts.each do |post|
-          post.comments.collect(&:name)
+      it "should detect unused preload with category => entries, but not with category => posts" do
+        Category.includes([:posts, :entries]).each do |category|
+          category.posts.map(&:name)
         end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Category, :posts)
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Category, :entries)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
     end
-  end
 
-  context "category => posts, category => entries" do
-    it "should detect preload with category => [posts, entries]" do
-      Category.includes([:posts, :entries]).each do |category|
-        category.posts.collect(&:name)
-        category.entries.collect(&:name)
+    context "post => comment" do
+      it "should detect unused preload with post => comments" do
+        Post.includes(:comments).each do |post|
+          post.comments.first.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
 
-    it "should detect preload with category => posts, but no category => entries" do
-      Category.includes(:posts).each do |category|
-        category.posts.collect(&:name)
-        category.entries.collect(&:name)
+      it "should detect preload with post => commnets" do
+        Post.first.comments.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should_not be_completely_preloading_associations
     end
 
-    it "should detect no preload with category => [posts, entries]" do
-      Category.all.each do |category|
-        category.posts.collect(&:name)
-        category.entries.collect(&:name)
+    context "category => posts => writer" do
+      it "should not detect unused preload associations" do
+        category = Category.includes({:posts => :writer}).order("id DESC").find_by_name('first')
+        category.posts.map do |post|
+          post.name
+          post.writer.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Category, :posts)
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Post, :writer)
       end
-      Bullet::Detector::Association.should_not be_completely_preloading_associations
     end
 
-    it "should detect unused with category => [posts, entries]" do
-      Category.includes([:posts, :entries]).collect(&:name)
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should be_has_unused_preload_associations
-    end
+    context "scope for_category_name" do
+      it "should detect preload with post => category" do
+        Post.in_category_name('first').all.each do |post|
+          post.category.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-    it "should detect unused preload with category => entries, but no category => posts" do
-      Category.includes([:posts, :entries]).each do |category|
-        category.posts.collect(&:name)
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should be_has_unused_preload_associations
-    end
 
-    it "should detect no unused preload" do
-      Category.all.each do |category|
-        category.posts.collect(&:name)
-        category.entries.collect(&:name)
+      it "should not be unused preload post => category" do
+        Post.in_category_name('first').all.map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
     end
-  end
 
-  context "no preload" do
-    it "should no preload only display only one post => comment" do
-      Post.includes(:comments).each do |post|
-        post.comments.first.name
+    context "scope preload_comments" do
+      it "should detect preload post => comments with scope" do
+        Post.preload_comments.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
 
-    it "should no preload only one post => commnets" do
-      Post.first.comments.collect(&:name)
-      Bullet::Detector::Association.should be_completely_preloading_associations
+      it "should detect unused preload with scope" do
+        Post.preload_comments.map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
     end
   end
 
-  context "scope for_category_name" do
-    it "should detect preload with post => category" do
-      Post.in_category_name('first').all.each do |post|
-        post.category.name
-      end
-      Bullet::Detector::Association.should be_completely_preloading_associations
+  describe Bullet::Detector::Association, 'belongs_to' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
     end
 
-    it "should not be unused preload post => category" do
-      Post.in_category_name('first').all.collect(&:name)
-      Bullet::Detector::Association.should be_completely_preloading_associations
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
+    after(:each) do
+      Bullet.end_request
     end
-  end
 
-  context "scope preload_posts" do
-    it "should no preload post => comments with scope" do
-      Post.preload_posts.each do |post|
-        post.comments.collect(&:name)
+    context "comment => post" do
+      it "should detect non preload with comment => post" do
+        Comment.all.each do |comment|
+          comment.post.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Comment, :post)
       end
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
 
-    it "should unused preload with scope" do
-      Post.preload_posts.collect(&:name)
-      Bullet::Detector::Association.should be_completely_preloading_associations
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should be_has_unused_preload_associations
-    end
-  end
+      it "should detect preload with one comment => post" do
+        Comment.first.post.name
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-  context "no unused" do
-    it "should no unused only display only one post => comment" do
-      Post.includes(:comments).each do |post|
-        i = 0
-        post.comments.each do |comment|
-          if i == 0
-            comment.name
-          else
-            i += 1
-          end
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should dtect preload with comment => post" do
+        Comment.includes(:post).each do |comment|
+          comment.post.name
         end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
-    end
-  end
 
-  context "belongs_to" do
-    it "should preload comments => post" do
-      Comment.all.each do |comment|
-        comment.post.name
+      it "should not detect preload with comment => post" do
+        Comment.all.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should_not be_completely_preloading_associations
-    end
 
-    it "should no preload comment => post" do
-      Comment.first.post.name
-      Bullet::Detector::Association.should be_completely_preloading_associations
-    end
+      it "should detect unused preload with comments => post" do
+        Comment.includes(:post).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Comment, :post)
 
-    it "should no preload comments => post" do
-      Comment.includes(:post).each do |comment|
-        comment.post.name
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::Association.should be_completely_preloading_associations
     end
 
-    it "should detect no unused preload comments => post" do
-      Comment.all.collect(&:name)
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
-    end
+    context "comment => post => category" do
+      it "should detect non preload association with comment => post" do
+        Comment.all.each do |comment|
+          comment.post.category.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-    it "should detect unused preload comments => post" do
-      Comment.includes(:post).collect(&:name)
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should be_has_unused_preload_associations
-    end
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Comment, :post)
+      end
+
+      it "should detect non preload association with post => category" do
+        Comment.includes(:post).each do |comment|
+          comment.post.category.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-    it "should dectect no unused preload comments => post" do
-      Comment.all.each do |comment|
-        comment.post.name
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :category)
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
-    end
 
-    it "should dectect no unused preload comments => post" do
-      Comment.includes(:post).each do |comment|
-        comment.post.name
+      it "should not detect unpreload association" do
+        Comment.includes(:post => :category).each do |comment|
+          comment.post.category.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
       end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
     end
-  end
-end
 
-describe Bullet::Detector::Association, 'has_and_belongs_to_many' do
-  before(:each) do
-    Bullet.start_request
-  end
+    context "comment => author, post => writer" do
+      # this happens because the post isn't a possible object even though the writer is access through the post
+      # which leads to an 1+N queries
+      it "should detect non preloaded writer" do
+        Comment.includes([:author, :post]).where(["base_users.id = ?", BaseUser.first]).each do |comment|
+          comment.post.writer.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-  after(:each) do
-    Bullet.end_request
-  end
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Post, :writer)
+      end
+
+      # this happens because the comment doesn't break down the hash into keys
+      # properly creating an association from comment to post
+      it "should detect unused preload with comment => author" do
+        Comment.includes([:author, {:post => :writer}]).where(["base_users.id = ?", BaseUser.first]).each do |comment|
+          comment.post.writer.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Comment, :author)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
 
-  it "should detect unpreload associations" do
-    Student.all.each do |student|
-      student.teachers.collect(&:name)
+      # To flyerhzm: This does not detect that newspaper is unpreloaded. The association is
+      # not within possible objects, and thus cannot be detected as unpreloaded
+      it "should detect non preloading with writer => newspaper" do
+        Comment.all(:include => {:post => :writer}, :conditions => "posts.name like '%first%'").each do |comment|
+          comment.post.writer.newspaper.name
+        end
+        #Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        #Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Writer, :newspaper)
+      end
+
+      # when we attempt to access category, there is an infinite overflow because load_target is hijacked leading to
+      # a repeating loop of calls in this test
+      it "should not raise a stack error from posts to category" do
+        lambda {
+          Comment.includes({:post => :category}).each do |com|
+            com.post.category
+          end
+        }.should_not raise_error(SystemStackError)
+      end
     end
-    Bullet::Detector::Association.should_not be_completely_preloading_associations
   end
 
-  it "should detect no unpreload associations" do
-    Student.includes(:teachers).each do |student|
-      student.teachers.collect(&:name)
+  describe Bullet::Detector::Association, 'has_and_belongs_to_many' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
     end
-    Bullet::Detector::Association.should be_completely_preloading_associations
-  end
 
-  it "should detect unused preload associations" do
-    Student.includes(:teachers).collect(&:name)
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should be_has_unused_preload_associations
-  end
+    after(:each) do
+      Bullet.end_request
+    end
 
-  it "should detect no unused preload associations" do
-    Student.all.collect(&:name)
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should_not be_has_unused_preload_associations
-  end
-end
+    context "students <=> teachers" do
+      it "should detect non preload associations" do
+        Student.all.each do |student|
+          student.teachers.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-describe Bullet::Detector::Association, 'has_many :through' do
-  before(:each) do
-    Bullet.start_request
-  end
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Student, :teachers)
+      end
 
-  after(:each) do
-    Bullet.end_request
-  end
+      it "should detect preload associations" do
+        Student.includes(:teachers).each do |student|
+          student.teachers.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload associations" do
+        Student.includes(:teachers).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Student, :teachers)
 
-  it "should detect unpreload associations" do
-    Firm.all.each do |firm|
-      firm.clients.collect(&:name)
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect no unused preload associations" do
+        Student.all.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
     end
-    Bullet::Detector::Association.should_not be_completely_preloading_associations
   end
 
-  it "should detect no unpreload associations" do
-    Firm.includes(:clients).each do |firm|
-      firm.clients.collect(&:name)
+  describe Bullet::Detector::Association, 'has_many :through' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
     end
-    Bullet::Detector::Association.should be_completely_preloading_associations
-  end
 
-  it "should detect no unused preload associations" do
-    Firm.all.collect(&:name)
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should_not be_has_unused_preload_associations
-  end
+    after(:each) do
+      Bullet.end_request
+    end
 
-  it "should detect unused preload associations" do
-    Firm.includes(:clients).collect(&:name)
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should be_has_unused_preload_associations
-  end
-end
+    context "firm => clients" do
+      it "should detect non preload associations" do
+        Firm.all.each do |firm|
+          firm.clients.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Firm, :clients)
+      end
 
+      it "should detect preload associations" do
+        Firm.includes(:clients).each do |firm|
+          firm.clients.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
 
-describe Bullet::Detector::Association, "has_one" do
-  before(:each) do
-    Bullet.start_request
-  end
+      it "should not detect preload associations" do
+        Firm.all.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-  after(:each) do
-    Bullet.end_request
-  end
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload associations" do
+        Firm.includes(:clients).collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Firm, :clients)
 
-  it "should detect unpreload association" do
-    Company.all.each do |company|
-      company.address.name
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
     end
-    Bullet::Detector::Association.should_not be_completely_preloading_associations
   end
 
-  it "should detect no unpreload association" do
-    Company.find(:all, :include => :address).each do |company|
-      company.address.name
+  describe Bullet::Detector::Association, "has_one" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
     end
-    Bullet::Detector::Association.should be_completely_preloading_associations
-  end
 
-  it "should detect no unused preload association" do
-    Company.all.collect(&:name)
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should_not be_has_unused_preload_associations
-  end
+    after(:each) do
+      Bullet.end_request
+    end
 
-  it "should detect unused preload association" do
-    Company.find(:all, :include => :address).collect(&:name)
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should be_has_unused_preload_associations
-  end
-end
+    context "company => address" do
+      it "should detect non preload association" do
+        Company.all.each do |company|
+          company.address.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-describe Bullet::Detector::Association, "call one association that in possible objects" do
-  before(:each) do
-    Bullet.start_request
-  end
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Company, :address)
+      end
 
-  after(:each) do
-    Bullet.end_request
-  end
+      it "should detect preload association" do
+        Company.find(:all, :include => :address).each do |company|
+          company.address.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-  it "should detect no unpreload association" do
-    Contact.all
-    Contact.first.emails.collect(&:name)
-    Bullet::Detector::Association.should be_completely_preloading_associations
-  end
-end
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
 
-describe Bullet::Detector::Association, "STI" do
-  before(:each) do
-    Bullet.start_request
-  end
+      it "should not detect preload association" do
+        Company.all.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
 
-  after(:each) do
-    Bullet.end_request
-  end
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload association" do
+        Company.find(:all, :include => :address).collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Company, :address)
 
-  it "should detect unpreload associations" do
-    Page.all.each do |page|
-      page.author.name
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
     end
-    Bullet::Detector::Association.should_not be_completely_preloading_associations
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should_not be_has_unused_preload_associations
   end
 
-  it "should not detect unpreload associations" do
-    Page.find(:all, :include => :author).each do |page|
-      page.author.name
+  describe Bullet::Detector::Association, "call one association that in possible objects" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
     end
-    Bullet::Detector::Association.should be_completely_preloading_associations
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should_not be_has_unused_preload_associations
-  end
 
-  it "should detect unused preload associations" do
-    Page.find(:all, :include => :author).collect(&:name)
-    Bullet::Detector::Association.should be_completely_preloading_associations
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should be_has_unused_preload_associations
+    after(:each) do
+      Bullet.end_request
+    end
+
+    it "should not detect preload association" do
+      Post.all
+      Post.first.comments.map(&:name)
+      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+      Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+      Bullet::Detector::Association.should be_completely_preloading_associations
+    end
   end
 
-  it "should not detect unused preload associations" do
-    Page.all.collect(&:name)
-    Bullet::Detector::Association.should be_completely_preloading_associations
-    Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-    Bullet::Detector::Association.should_not be_has_unused_preload_associations
+  describe Bullet::Detector::Association, "STI" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "page => author" do
+      it "should detect non preload associations" do
+        Page.all.each do |page|
+          page.author.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Page, :author)
+      end
+
+      it "should detect preload associations" do
+        Page.find(:all, :include => :author).each do |page|
+          page.author.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload associations" do
+        Page.find(:all, :include => :author).collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Page, :author)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect preload associations" do
+        Page.all.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
   end
 end