bullet 2.3.0 → 4.0.0

data/spec/integration/counter_spec.rb

@@ -1,37 +1,39 @@
 require 'spec_helper'
 
-describe Bullet::Detector::Counter do
-  before(:each) do
-    Bullet.start_request
-  end
+if Rails.version.to_i > 2
+  describe Bullet::Detector::Counter do
+    before(:each) do
+      Bullet.start_request
+    end
 
-  after(:each) do
-    Bullet.end_request
-  end
+    after(:each) do
+      Bullet.end_request
+    end
 
-  it "should need counter cache with all cities" do
-    Country.all.each do |country|
-      country.cities.size
+    it "should need counter cache with all cities" do
+      Country.all.each do |country|
+        country.cities.size
+      end
+      Bullet.collected_counter_cache_notifications.should_not be_empty
     end
-    Bullet.collected_counter_cache_notifications.should_not be_empty
-  end
 
-  it "should not need counter cache if already define counter_cache" do
-    Person.all.each do |person|
-      person.pets.size
+    it "should not need counter cache if already define counter_cache" do
+      Person.all.each do |person|
+        person.pets.size
+      end
+      Bullet.collected_counter_cache_notifications.should be_empty
     end
-    Bullet.collected_counter_cache_notifications.should be_empty
-  end
 
-  it "should not need counter cache with only one object" do
-    Country.first.cities.size
-    Bullet.collected_counter_cache_notifications.should be_empty
-  end
+    it "should not need counter cache with only one object" do
+      Country.first.cities.size
+      Bullet.collected_counter_cache_notifications.should be_empty
+    end
 
-  it "should not need counter cache with part of cities" do
-    Country.all.each do |country|
-      country.cities.where(:name => 'first').size
+    it "should not need counter cache with part of cities" do
+      Country.all.each do |country|
+        country.cities.where(:name => 'first').size
+      end
+      Bullet.collected_counter_cache_notifications.should be_empty
     end
-    Bullet.collected_counter_cache_notifications.should be_empty
   end
 end

data/spec/integration/mongoid/association_spec.rb

@@ -0,0 +1,276 @@
+require 'spec_helper'
+
+begin
+  require 'mongoid'
+  describe Bullet::Detector::Association, 'has_many' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "posts => comments" do
+      it "should detect non preload posts => comments" do
+        Mongoid::Post.all.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Mongoid::Post, :comments)
+      end
+
+      it "should detect preload post => comments" do
+        Mongoid::Post.includes(:comments).each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload post => comments" do
+        Mongoid::Post.includes(:comments).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Mongoid::Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect unused preload post => comments" do
+        Mongoid::Post.all.map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "category => posts, category => entries" do
+      it "should detect non preload with category => [posts, entries]" do
+        Mongoid::Category.all.each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Mongoid::Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Mongoid::Category, :entries)
+      end
+
+      it "should detect preload with category => posts, but not with category => entries" do
+        Mongoid::Category.includes(:posts).each do |category|
+          category.posts.collect(&:name)
+          category.entries.collect(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should_not be_detecting_unpreloaded_association_for(Mongoid::Category, :posts)
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Mongoid::Category, :entries)
+      end
+
+      it "should detect preload with category => [posts, entries]" do
+        Mongoid::Category.includes([:posts, :entries]).each do |category|
+          category.posts.map(&:name)
+          category.entries.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with category => [posts, entries]" do
+        Mongoid::Category.includes([:posts, :entries]).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Mongoid::Category, :posts)
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Mongoid::Category, :entries)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with category => entries, but not with category => posts" do
+        Mongoid::Category.includes([:posts, :entries]).each do |category|
+          category.posts.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Mongoid::Category, :posts)
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Mongoid::Category, :entries)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "post => comment" do
+      it "should detect unused preload with post => comments" do
+        Mongoid::Post.includes(:comments).each do |post|
+          post.comments.first.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_unused_preload_associations_for(Mongoid::Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect preload with post => commnets" do
+        Mongoid::Post.first.comments.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+
+    context "scope preload_comments" do
+      it "should detect preload post => comments with scope" do
+        Mongoid::Post.preload_comments.each do |post|
+          post.comments.map(&:name)
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with scope" do
+        Mongoid::Post.preload_comments.map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Mongoid::Post, :comments)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, 'belongs_to' do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "comment => post" do
+      it "should detect non preload with comment => post" do
+        Mongoid::Comment.all.each do |comment|
+          comment.post.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Mongoid::Comment, :post)
+      end
+
+      it "should detect preload with one comment => post" do
+        Mongoid::Comment.first.post.name
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect preload with comment => post" do
+        Mongoid::Comment.includes(:post).each do |comment|
+          comment.post.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect preload with comment => post" do
+        Mongoid::Comment.all.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload with comments => post" do
+        Mongoid::Comment.includes(:post).map(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Mongoid::Comment, :post)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, "has_one" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    context "company => address" do
+      it "should detect non preload association" do
+        Mongoid::Company.all.each do |company|
+          company.address.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Mongoid::Company, :address)
+      end
+
+      it "should detect preload association" do
+        Mongoid::Company.includes(:address).each do |company|
+          company.address.name
+        end
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should not detect preload association" do
+        Mongoid::Company.all.collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+
+      it "should detect unused preload association" do
+        Mongoid::Company.includes(:address).collect(&:name)
+        Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+        Bullet::Detector::Association.should be_unused_preload_associations_for(Mongoid::Company, :address)
+
+        Bullet::Detector::Association.should be_completely_preloading_associations
+      end
+    end
+  end
+
+  describe Bullet::Detector::Association, "call one association that in possible objects" do
+    before(:each) do
+      Bullet.clear
+      Bullet.start_request
+    end
+
+    after(:each) do
+      Bullet.end_request
+    end
+
+    it "should not detect preload association" do
+      Mongoid::Post.all
+      Mongoid::Post.first.comments.map(&:name)
+      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
+      Bullet::Detector::Association.should_not be_has_unused_preload_associations
+
+      Bullet::Detector::Association.should be_completely_preloading_associations
+    end
+  end
+rescue LoadError
+end