bullet 2.2.1 → 2.3.0

data/spec/bullet/association_for_chris_spec.rb

@@ -1,96 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper'
-
-ActiveRecord::Base.establish_connection(:adapter => 'sqlite3', :database => ':memory:')
-# This test is just used for http://github.com/flyerhzm/bullet/issues/#issue/14
-describe Bullet::Detector::Association do
-
-  describe "for chris" do
-    def setup_db
-      ActiveRecord::Schema.define(:version => 1) do
-        create_table :locations do |t|
-          t.column :name, :string
-        end
-
-        create_table :hotels do |t|
-          t.column :name, :string
-          t.column :location_id, :integer
-        end
-
-        create_table :deals do |t|
-          t.column :name, :string
-          t.column :hotel_id, :integer
-        end
-      end
-    end
-
-    def teardown_db
-      ActiveRecord::Base.connection.tables.each do |table|
-        ActiveRecord::Base.connection.drop_table(table)
-      end
-    end
-
-    class Location < ActiveRecord::Base
-      has_many :hotels
-    end
-  
-    class Hotel < ActiveRecord::Base
-      belongs_to :location
-      has_many :deals
-    end
-  
-    class Deal < ActiveRecord::Base
-      belongs_to :hotel
-      has_one :location, :through => :hotel
-    end
-
-    before(:all) do
-      setup_db
-    
-      location1 = Location.create(:name => "location1")
-      location2 = Location.create(:name => "location2")
-    
-      hotel1 = location1.hotels.create(:name => "hotel1")
-      hotel2 = location1.hotels.create(:name => "hotel2")
-      hotel3 = location2.hotels.create(:name => "hotel3")
-      hotel4 = location2.hotels.create(:name => "hotel4")
-    
-      deal1 = hotel1.deals.create(:name => "deal1")
-      deal2 = hotel2.deals.create(:name => "deal2")
-      deal3 = hotel3.deals.create(:name => "deal3")
-      deal4 = hotel4.deals.create(:name => "deal4")
-    end
-
-    after(:all) do
-      teardown_db
-    end
-
-    before(:each) do
-      Bullet.start_request
-    end
-
-    after(:each) do
-      Bullet.end_request
-    end
-  
-    it "should detect unpreload association from deal to hotel" do
-      Deal.all.each do |deal|
-        deal.hotel.location.name
-      end
-      Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Deal, :hotel)
-    end
-  
-    it "should detect unpreload association from hotel to location" do
-      Deal.includes(:hotel).each do |deal|
-        deal.hotel.location.name
-      end
-      Bullet::Detector::Association.should be_detecting_unpreloaded_association_for(Hotel, :location)
-    end
-  
-    it "should not detect unpreload association" do
-      Deal.includes({:hotel => :location}).each do |deal|
-        deal.hotel.location.name
-      end
-      Bullet::Detector::Association.should_not be_has_unused_preload_associations
-    end
-  end
-end

data/spec/bullet/association_for_peschkaj_spec.rb

@@ -1,86 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper'
-
-ActiveRecord::Base.establish_connection(:adapter => 'sqlite3', :database => ':memory:')
-# This test is just used for http://github.com/flyerhzm/bullet/issues#issue/20
-describe Bullet::Detector::Association do
-  
-  describe "for peschkaj" do
-    def setup_db
-      ActiveRecord::Schema.define(:version => 1) do
-        create_table :categories do |t|
-          t.column :name, :string
-        end
-
-        create_table :submissions do |t|
-          t.column :name, :string
-          t.column :category_id, :integer
-          t.column :user_id, :integer
-        end
-
-        create_table :users do |t|
-          t.column :name, :string
-          t.column :category_id, :integer
-        end
-      end
-    end
-
-    def teardown_db
-      ActiveRecord::Base.connection.tables.each do |table|
-        ActiveRecord::Base.connection.drop_table(table)
-      end
-    end
-
-    class Category < ActiveRecord::Base
-      has_many :submissions
-      has_many :users
-    end
-  
-    class Submission < ActiveRecord::Base
-      belongs_to :category
-      belongs_to :user
-    end
-  
-    class User < ActiveRecord::Base
-      has_one :submission
-      belongs_to :category
-    end
-
-    before(:all) do
-      setup_db
-    
-      category1 = Category.create(:name => "category1")
-      category2 = Category.create(:name => "category2")
-    
-      user1 = User.create(:name => 'user1', :category => category1)
-      user2 = User.create(:name => 'user2', :category => category1)
-    
-      submission1 = category1.submissions.create(:name => "submission1", :user => user1)
-      submission2 = category1.submissions.create(:name => "submission2", :user => user2)
-      submission3 = category2.submissions.create(:name => "submission3", :user => user1)
-      submission4 = category2.submissions.create(:name => "submission4", :user => user2)
-    end
-
-    after(:all) do
-      teardown_db
-    end
-
-    before(:each) do
-      Bullet.start_request
-    end
-
-    after(:each) do
-      Bullet.end_request
-    end
-  
-    it "should not detect unused preload associations" do
-      category = Category.includes({:submissions => :user}).order("id DESC").find_by_name('category1')
-      category.submissions.map do |submission|
-        submission.name
-        submission.user.name
-      end
-      Bullet::Detector::UnusedEagerAssociation.check_unused_preload_associations
-      Bullet::Detector::Association.should_not be_unused_preload_associations_for(Category, :submissions)
-      Bullet::Detector::Association.should_not be_unused_preload_associations_for(Submission, :user)
-    end
-  end
-end

data/spec/bullet/counter_spec.rb

@@ -1,136 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper'
-
-ActiveRecord::Base.establish_connection(:adapter => 'sqlite3', :database => ':memory:')
-
-describe Bullet::Detector::Counter do
-  def setup_db
-    ActiveRecord::Schema.define(:version => 1) do
-      create_table :countries do |t|
-        t.string :name
-      end
-
-      create_table :cities do |t|
-        t.string :name
-        t.integer :country_id
-      end
-    end
-  end
-
-  def teardown_db
-    ActiveRecord::Base.connection.tables.each do |table|
-      ActiveRecord::Base.connection.drop_table(table)
-    end
-  end
-
-  class Country < ActiveRecord::Base
-    has_many :cities
-  end
-
-  class City < ActiveRecord::Base
-    belongs_to :country
-  end
-
-  before(:all) do
-    setup_db
-
-    country1 = Country.create(:name => 'first')
-    country2 = Country.create(:name => 'second')
-    
-    country1.cities.create(:name => 'first')
-    country1.cities.create(:name => 'second')
-    country2.cities.create(:name => 'third')
-    country2.cities.create(:name => 'fourth')
-  end
-
-  after(:all) do
-    teardown_db
-  end
-
-  before(:each) do
-    Bullet.start_request
-  end
-  
-  after(:each) do
-    Bullet.end_request
-  end
-
-  it "should need counter cache with all cities" do
-    Country.all.each do |country|
-      country.cities.size
-    end
-    Bullet.collected_counter_cache_notifications.should_not be_empty
-  end
-  
-  it "should not need coounter cache with only one object" do
-    Country.first.cities.size
-    Bullet.collected_counter_cache_notifications.should be_empty
-  end
-
-  it "should not need counter cache with part of cities" do
-    Country.all.each do |country|
-      country.cities.where(:name => 'first').size
-    end
-    Bullet.collected_counter_cache_notifications.should be_empty
-  end
-end
-
-describe Bullet::Detector::Counter do
-  def setup_db
-    ActiveRecord::Schema.define(:version => 1) do
-      create_table :people do |t|
-        t.string :name
-        t.integer :pets_count
-      end
-
-      create_table :pets do |t|
-        t.string :name
-        t.integer :person_id
-      end
-    end
-  end
-
-  def teardown_db
-    ActiveRecord::Base.connection.tables.each do |table|
-      ActiveRecord::Base.connection.drop_table(table)
-    end
-  end
-
-  class Person < ActiveRecord::Base
-    has_many :pets
-  end
-
-  class Pet < ActiveRecord::Base
-    belongs_to :person, :counter_cache => true
-  end
-
-  before(:all) do
-    setup_db
-
-    person1 = Person.create(:name => 'first')
-    person2 = Person.create(:name => 'second')
-    
-    person1.pets.create(:name => 'first')
-    person1.pets.create(:name => 'second')
-    person2.pets.create(:name => 'third')
-    person2.pets.create(:name => 'fourth')
-  end
-
-  after(:all) do
-    teardown_db
-  end
-
-  before(:each) do
-    Bullet.start_request
-  end
-  
-  after(:each) do
-    Bullet.end_request
-  end
-
-  it "should not need counter cache" do
-    Person.all.each do |person|
-      person.pets.size
-    end
-    Bullet.collected_counter_cache_notifications.should be_empty
-  end
-end