bullet 2.0.0.beta.2 → 2.1.0

data/README_for_rails2.textile

@@ -6,8 +6,6 @@ Best practice is to use Bullet in development mode or custom mode (staging, prof
 
 The Bullet plugin/gem now supports rails 2.1, 2.2 and 2.3, tested in rails 2.1.2, 2.2.2 and 2.3.2.
 
-*Important: bullet gem has been moved to gemcutter.org*
-
 ****************************************************************************
 
 h2. Change
@@ -18,6 +16,7 @@ There is a large refactor from gem 1.4 to 1.5, so if you upgrade to 1.5 gem, ple
 
 h2. Contributors
 
+sriedel did a lot of awesome refactors, added xmpp notification support, and added Hacking.textile about how to extend to bullet plugin.
 flipsasser added Growl, console.log and Rails.log support, very awesome. And he also improved README.
 rainux added group style console.log.
 2collegebums added some great specs to generate red bar.
@@ -26,18 +25,11 @@ rainux added group style console.log.
 
 h2. Install
 
-You can add Bullet to your Rails gem requirements:
-<pre><code>config.gem 'bullet', :source => 'http://gemcutter.org'</code></pre>
-
 You can install it as a gem:
 <pre><code>
-sudo gem sources -a http://gemcutter.org
 sudo gem install bullet
 </code></pre>
 
-Or you can install it as a rails plugin:
-<pre><code>script/plugin install git://github.com/flyerhzm/bullet.git</code></pre>
-
 ****************************************************************************
 
 h2. Configuration
@@ -45,24 +37,21 @@ h2. Configuration
 Bullet won't do ANYTHING unless you tell it to explicitly. Append to <code>config/environments/development.rb</code> initializer with the following code:
 <pre><code>
 config.after_initialize do
-  Bullet.enable = true 
+  Bullet.enable = true
   Bullet.alert = true
-  Bullet.bullet_logger = true  
+  Bullet.bullet_logger = true
   Bullet.console = true
   Bullet.growl = true
   Bullet.rails_logger = true
   Bullet.disable_browser_cache = true
+  Bullet.xmpp = { :account => 'bullets_account@jabber.org',
+                  :password => 'bullets_password_for_jabber',
+                  :receiver => 'your_account@jabber.org',
+                  :show_online_status => true }
 end
 </code></pre>
 
-It is recommended to config growl notification as follows if your collaborators are not using MacOS
-<pre><code>
-  begin
-    require 'ruby-growl'
-    Bullet.growl = true
-  rescue MissingSourceFile
-  end
-</code></pre>
+The notifier of bullet is a wrap of "uniform_notifier":https://github.com/flyerhzm/uniform_notifier
 
 The code above will enable all five of the Bullet notification systems:
 * <code>Bullet.enable</code>: enable Bullet plugin/gem, otherwise do nothing
@@ -111,10 +100,10 @@ These two lines are notifications that unused eager loadings have been encounter
 h2. Growl Support
 
 To get Growl support up-and-running for Bullet, follow the steps below:
-* Install the ruby-growl gem: <code>sudo gem install ruby-growl</code>
+* Install the ruby-growl gem: <code>gem install ruby-growl</code>
 * Open the Growl preference pane in Systems Preferences
 * Click the "Network" tab
-* Make sure both "Listen for incoming notifications" and "Allow remote application registration" are checked. *Note*: If you set a password, you will need to set <code>Bullet.growl_password = 'your_growl_password</code>' in the config file.
+* Make sure both "Listen for incoming notifications" and "Allow remote application registration" are checked. *Note*: If you set a password, you will need to set <code>Bullet.growl = { :password => 'growl password' }</code> in the config file.
 * Restart Growl ("General" tab -> Stop Growl -> Start Growl)
 * Boot up your application. Bullet will automatically send a Growl notification when Growl is turned on. If you do not see it when your application loads, make sure it is enabled in your initializer and double-check the steps above.
 
@@ -126,6 +115,17 @@ ruby-growl gem has an issue about md5 in ruby 1.9, if you use growl and ruby 1.9
 
 ****************************************************************************
 
+h2. XMPP/Jabber Support
+
+To get XMPP support up-and-running for Bullet, follow the steps below:
+* Install the xmpp4r gem: <code>sudo gem install xmpp4r</code>
+* Make both the bullet and the receipient account add each other as contacts.
+  This will require you to manually log into both accounts, add each other
+  as contact and confirm each others contact request.
+* Boot up your application. Bullet will automatically send an XMPP notification when XMPP is turned on.
+
+****************************************************************************
+
 h2. Important
 
 If you encounter the following errors in development environment:
@@ -167,8 +167,7 @@ end
 
 after(:each)
   if Bullet.enable?
-    Bullet.growl_notification
-    Bullet.log_notification('Test: ')
+    Bullet.perform_out_of_channel_notifications
     Bullet.end_request
   end
 end
@@ -193,9 +192,9 @@ Bullet is designed to function as you browse through your application in develop
 1. setup test environment
 
 <pre><code>
-$ rails test
-$ cd test
-$ script/generate scaffold post name:string 
+$ rails test_bullet
+$ cd test_bullet
+$ script/generate scaffold post name:string
 $ script/generate scaffold comment name:string post_id:integer
 $ rake db:migrate
 </code></pre>
@@ -280,18 +279,18 @@ In the meanwhile, there's a log appended into <code>log/bullet.log</code> file
 2009-08-20 09:12:19[INFO] N+1 Query: PATH_INFO: /posts;    model: Post => assocations: [comments]
 Add your finder: :include => [:comments]
 2009-08-20 09:12:19[INFO] N+1 Query: method call stack:
-/Users/richard/Downloads/test/app/views/posts/index.html.erb:11:in `_run_erb_app47views47posts47index46html46erb'
-/Users/richard/Downloads/test/app/views/posts/index.html.erb:8:in `each'
-/Users/richard/Downloads/test/app/views/posts/index.html.erb:8:in `_run_erb_app47views47posts47index46html46erb'
-/Users/richard/Downloads/test/app/controllers/posts_controller.rb:7:in `index'
+/Users/flyerhzm/Downloads/test_bullet/app/views/posts/index.html.erb:11:in `_run_erb_app47views47posts47index46html46erb'
+/Users/flyerhzm/Downloads/test_bullet/app/views/posts/index.html.erb:8:in `each'
+/Users/flyerhzm/Downloads/test_bullet/app/views/posts/index.html.erb:8:in `_run_erb_app47views47posts47index46html46erb'
+/Users/flyerhzm/Downloads/test_bullet/app/controllers/posts_controller.rb:7:in `index'
 </code></pre>
 
 The generated SQLs are
 
 <pre><code>
-  Post Load (1.0ms)   SELECT * FROM "posts" 
-  Comment Load (0.4ms)   SELECT * FROM "comments" WHERE ("comments".post_id = 1) 
-  Comment Load (0.3ms)   SELECT * FROM "comments" WHERE ("comments".post_id = 2) 
+  Post Load (1.0ms)   SELECT * FROM "posts"
+  Comment Load (0.4ms)   SELECT * FROM "comments" WHERE ("comments".post_id = 1)
+  Comment Load (0.3ms)   SELECT * FROM "comments" WHERE ("comments".post_id = 2)
 </code></pre>
 
 
@@ -304,8 +303,8 @@ The generated SQLs are
     respond_to do |format|
       format.html # index.html.erb
       format.xml  { render :xml => @posts }
-    end 
-  end 
+    end
+  end
 </code></pre>
 
 10. refresh http://localhost:3000/posts page, no alert box and no log appended.
@@ -313,8 +312,8 @@ The generated SQLs are
 The generated SQLs are
 
 <pre><code>
-  Post Load (0.5ms)   SELECT * FROM "posts" 
-  Comment Load (0.5ms)   SELECT "comments".* FROM "comments" WHERE ("comments".post_id IN (1,2)) 
+  Post Load (0.5ms)   SELECT * FROM "posts"
+  Comment Load (0.5ms)   SELECT "comments".* FROM "comments" WHERE ("comments".post_id IN (1,2))
 </code></pre>
 
 a N+1 query fixed. Cool!
@@ -328,8 +327,8 @@ a N+1 query fixed. Cool!
     respond_to do |format|
       format.html # index.html.erb
       format.xml  { render :xml => @posts }
-    end 
-  end 
+    end
+  end
 </code></pre>
 
 <pre><code>
@@ -368,8 +367,8 @@ Remove from your finder: :include => [:comments]
     respond_to do |format|
       format.html # index.html.erb
       format.xml  { render :xml => @posts }
-    end 
-  end 
+    end
+  end
 </code></pre>
 
 <pre><code>
@@ -401,4 +400,4 @@ In the meanwhile, there's a log appended into <code>log/bullet.log</code> file.
 ****************************************************************************
 
 
-Copyright (c) 2009 Richard Huang (flyerhzm@gmail.com), released under the MIT license
+Copyright (c) 2009 - 2011 Richard Huang (flyerhzm@gmail.com), released under the MIT license

data/Rakefile

@@ -1,34 +1,45 @@
-require 'rake'
-require 'rspec/core/rake_task'
-require 'rake/rdoctask'
-require 'jeweler'
+$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
+require "bundler"
+Bundler.setup
 
-desc 'Default: run unit tests.'
-task :default => :spec
+require "rake"
+require "rdoc/task"
+require "rspec"
+require "rspec/core/rake_task"
+
+require "bullet/version"
+
+task :build do
+  system "gem build bullet.gemspec"
+end
+
+task :install => :build do
+  system "sudo gem install bullet-#{Bullet::VERSION}.gem"
+end
 
-desc 'Generate documentation for the sitemap plugin.'
-Rake::RDocTask.new(:rdoc) do |rdoc|
-  rdoc.rdoc_dir = 'rdoc'
-  rdoc.title    = 'Bullet'
-  rdoc.options << '--line-numbers' << '--inline-source'
-  rdoc.rdoc_files.include('README')
-  rdoc.rdoc_files.include('lib/**/*.rb')
+task :release => :build do
+  puts "Tagging #{Bullet::VERSION}..."
+  system "git tag -a #{Bullet::VERSION} -m 'Tagging #{Bullet::VERSION}'"
+  puts "Pushing to Github..."
+  system "git push --tags"
+  puts "Pushing to rubygems.org..."
+  system "gem push bullet-#{Bullet::VERSION}.gem"
 end
 
-# FIXME: 'rake spec' will break the test, just run 'ruby spec/association_spec.rb'
-#desc "Run all specs in spec directory"
-#Rspec::Core::RakeTask.new(:spec) do |t|
-  #t.pattern = FileList['spec/**/*_spec.rb']
-#end
-
-Jeweler::Tasks.new do |gemspec|
-  gemspec.name = "bullet"
-  gemspec.summary = "A plugin to kill N+1 queries and unused eager loading"
-  gemspec.description = "The Bullet plugin is designed to help you increase your application's performance by reducing the number of queries it makes. It will watch your queries while you develop your application and notify you when you should add eager loading (N+1 queries) or when you're using eager loading that isn't necessary."
-  gemspec.email = "flyerhzm@gmail.com"
-  gemspec.homepage = "http://github.com/flyerhzm/bullet"
-  gemspec.authors = ["Richard Huang"]
-  gemspec.files.exclude '.gitignore'
-  gemspec.files.exclude 'log/*'
+RSpec::Core::RakeTask.new(:spec) do |spec|
+  spec.pattern = "spec/**/*_spec.rb"
 end
-Jeweler::GemcutterTasks.new
+
+RSpec::Core::RakeTask.new('spec:progress') do |spec|
+  spec.rspec_opts = %w(--format progress)
+  spec.pattern = "spec/**/*_spec.rb"
+end
+
+Rake::RDocTask.new do |rdoc|
+  rdoc.rdoc_dir = "rdoc"
+  rdoc.title = "bullet #{Bullet::VERSION}"
+  rdoc.rdoc_files.include("README*")
+  rdoc.rdoc_files.include("lib/**/*.rb")
+end
+
+task :default => :spec

data/bullet.gemspec

@@ -1,67 +1,24 @@
-# Generated by jeweler
-# DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
-# -*- encoding: utf-8 -*-
+lib = File.expand_path('../lib/', __FILE__)
+$:.unshift lib unless $:.include?(lib)
+
+require "bullet/version"
 
 Gem::Specification.new do |s|
-  s.name = %q{bullet}
-  s.version = "2.0.0.beta.2"
+  s.name        = "bullet"
+  s.version     = Bullet::VERSION
+  s.platform    = Gem::Platform::RUBY
+  s.authors     = ["Richard Huang"]
+  s.email       = ["flyerhzm@gmail.com"]
+  s.homepage    = "http://github.com/flyerhzm/bullet"
+  s.summary     = "A rails plugin to kill N+1 queries and unused eager loading."
+  s.description = "A rails plugin to kill N+1 queries and unused eager loading."
 
-  s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Richard Huang"]
-  s.date = %q{2010-03-07}
-  s.description = %q{The Bullet plugin is designed to help you increase your application's performance by reducing the number of queries it makes. It will watch your queries while you develop your application and notify you when you should add eager loading (N+1 queries) or when you're using eager loading that isn't necessary.}
-  s.email = %q{flyerhzm@gmail.com}
-  s.extra_rdoc_files = [
-    "README.textile",
-     "README_for_rails2.textile"
-  ]
-  s.files = [
-    "MIT-LICENSE",
-     "README.textile",
-     "README_for_rails2.textile",
-     "Rakefile",
-     "VERSION",
-     "bullet.gemspec",
-     "lib/bullet.rb",
-     "lib/bullet/action_controller2.rb",
-     "lib/bullet/active_record2.rb",
-     "lib/bullet/active_record3.rb",
-     "lib/bullet/association.rb",
-     "lib/bullet/counter.rb",
-     "lib/bullet/logger.rb",
-     "lib/bullet/notification.rb",
-     "lib/bulletware.rb",
-     "rails/init.rb",
-     "spec/bullet/association_for_chris_spec.rb",
-     "spec/bullet/association_for_peschkaj_spec.rb",
-     "spec/bullet/association_spec.rb",
-     "spec/bullet/counter_spec.rb",
-     "spec/spec.opts",
-     "spec/spec_helper.rb",
-     "tasks/bullet_tasks.rake"
-  ]
-  s.homepage = %q{http://github.com/flyerhzm/bullet}
-  s.rdoc_options = ["--charset=UTF-8"]
-  s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.3.6}
-  s.summary = %q{A plugin to kill N+1 queries and unused eager loading}
-  s.test_files = [
-    "spec/spec_helper.rb",
-     "spec/bullet/counter_spec.rb",
-     "spec/bullet/association_spec.rb",
-     "spec/bullet/association_for_chris_spec.rb",
-     "spec/bullet/association_for_peschkaj_spec.rb"
-  ]
+  s.required_rubygems_version = ">= 1.3.6"
 
-  if s.respond_to? :specification_version then
-    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
-    s.specification_version = 3
+  s.add_dependency "uniform_notifier", "~> 1.0.0"
 
-    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
-    else
-    end
-  else
-  end
+  s.files         = `git ls-files`.split("\n")
+  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
+  s.require_paths = ["lib"]
 end
 

data/lib/bullet/action_controller2.rb

@@ -4,6 +4,7 @@ module Bullet
       require 'action_controller'
       case Rails.version
       when /^2.3/
+        ::ActionController::Dispatcher.middleware.use Bullet::Rack
         ::ActionController::Dispatcher.class_eval do
           class <<self
             alias_method :origin_reload_application, :reload_application
@@ -21,21 +22,20 @@ module Bullet
             Bullet.clear
           end
         end
-        
+
         ::ActionController::Base.class_eval do
           alias_method :origin_process, :process
           def process(request, response, method = :perform_action, *arguments)
             Bullet.start_request
             response = origin_process(request, response, method = :perform_action, *arguments)
-            
+
             if Bullet.notification?
               if response.headers["type"] and response.headers["type"].include? 'text/html' and response.body =~ %r{<html.*</html>}m
-                response.body <<= Bullet.javascript_notification
+                response.body <<= Bullet.gather_inline_notifications
                 response.headers["Content-Length"] = response.body.length.to_s
               end
-            
-              Bullet.growl_notification
-              Bullet.log_notification(request.params['PATH_INFO'])
+
+              Bullet.perform_out_of_channel_notifications
             end
             Bullet.end_request
             response

data/lib/bullet/active_record2.rb

@@ -1,4 +1,5 @@
 module Bullet
+  LOAD_TARGET_RGX = /load_target/
   module ActiveRecord
     def self.enable
       require 'active_record'
@@ -12,11 +13,11 @@ module Bullet
 
             if records 
               if records.size > 1
-                Bullet::Association.add_possible_objects(records)
-                Bullet::Counter.add_possible_objects(records)
+                Bullet::Detector::Association.add_possible_objects(records)
+                Bullet::Detector::Counter.add_possible_objects(records)
               elsif records.size == 1
-                Bullet::Association.add_impossible_object(records.first)
-                Bullet::Counter.add_impossible_object(records.first)
+                Bullet::Detector::Association.add_impossible_object(records.first)
+                Bullet::Detector::Counter.add_impossible_object(records.first)
               end
             end
 
@@ -33,9 +34,9 @@ module Bullet
           records = [records].flatten.compact.uniq
           return if records.empty?
           records.each do |record|
-            Bullet::Association.add_object_associations(record, associations)
+            Bullet::Detector::Association.add_object_associations(record, associations)
           end
-          Bullet::Association.add_eager_loadings(records, associations)
+          Bullet::Detector::Association.add_eager_loadings(records, associations)
           origin_preload_associations(records, associations, preload_options={})
         end
       end
@@ -47,10 +48,10 @@ module Bullet
           records = origin_find_with_associations(options)
           associations = merge_includes(scope(:find, :include), options[:include])
           records.each do |record|
-            Bullet::Association.add_object_associations(record, associations)
-            Bullet::Association.call_association(record, associations)
+            Bullet::Detector::Association.add_object_associations(record, associations)
+            Bullet::Detector::NPlusOneQuery.call_association(record, associations)
           end
-          Bullet::Association.add_eager_loadings(records, associations)
+          Bullet::Detector::Association.add_eager_loadings(records, associations)
           records
         end
       end
@@ -60,8 +61,8 @@ module Bullet
         alias_method :origin_construct_association, :construct_association
         def construct_association(record, join, row)
           associations = join.reflection.name
-          Bullet::Association.add_object_associations(record, associations)
-          Bullet::Association.call_association(record, associations)
+          Bullet::Detector::Association.add_object_associations(record, associations)
+          Bullet::Detector::NPlusOneQuery.call_association(record, associations)
           origin_construct_association(record, join, row)
         end
       end
@@ -70,7 +71,7 @@ module Bullet
         # call one to many associations
         alias_method :origin_load_target, :load_target
         def load_target
-          Bullet::Association.call_association(@owner, @reflection.name)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
           origin_load_target
         end
       end
@@ -81,8 +82,8 @@ module Bullet
         def load_target
           # avoid stack level too deep
           result = origin_load_target
-          Bullet::Association.call_association(@owner, @reflection.name) unless caller.to_s.include? 'load_target'
-          Bullet::Association.add_possible_objects(result)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name) unless caller.find {|c| c =~ LOAD_TARGET_RGX }
+          Bullet::Detector::Association.add_possible_objects(result)
           result
         end
       end
@@ -91,7 +92,7 @@ module Bullet
         alias_method :origin_has_cached_counter?, :has_cached_counter?
         def has_cached_counter?
           result = origin_has_cached_counter?
-          Bullet::Counter.add_counter_cache(@owner, @reflection.name) unless result
+          Bullet::Detector::Counter.add_counter_cache(@owner, @reflection.name) unless result
           result
         end
       end
@@ -100,7 +101,7 @@ module Bullet
         alias_method :origin_has_cached_counter?, :has_cached_counter?
         def has_cached_counter?
           result = origin_has_cached_counter?
-          Bullet::Counter.add_counter_cache(@owner, @reflection.name) unless result
+          Bullet::Detector::Counter.add_counter_cache(@owner, @reflection.name) unless result
           result
         end
       end

data/lib/bullet/active_record3.rb

@@ -1,4 +1,5 @@
 module Bullet
+  LOAD_TARGET_RGX = /load_target/
   module ActiveRecord
     def self.enable
       require 'active_record'
@@ -9,11 +10,11 @@ module Bullet
         def to_a
           records = origin_to_a
           if records.size > 1
-            Bullet::Association.add_possible_objects(records)
-            Bullet::Counter.add_possible_objects(records)
+            Bullet::Detector::Association.add_possible_objects(records)
+            Bullet::Detector::Counter.add_possible_objects(records)
           elsif records.size == 1
-            Bullet::Association.add_impossible_object(records.first)
-            Bullet::Counter.add_impossible_object(records.first)
+            Bullet::Detector::Association.add_impossible_object(records.first)
+            Bullet::Detector::Counter.add_impossible_object(records.first)
           end
           records
         end
@@ -27,9 +28,9 @@ module Bullet
           records = [records].flatten.compact.uniq
           return if records.empty?
           records.each do |record|
-            Bullet::Association.add_object_associations(record, associations)
+            Bullet::Detector::Association.add_object_associations(record, associations)
           end
-          Bullet::Association.add_eager_loadings(records, associations)
+          Bullet::Detector::Association.add_eager_loadings(records, associations)
           origin_preload_associations(records, associations, preload_options={})
         end
       end
@@ -41,10 +42,10 @@ module Bullet
           records = origin_find_with_associations
           associations = (@eager_load_values + @includes_values).uniq
           records.each do |record|
-            Bullet::Association.add_object_associations(record, associations)
-            Bullet::Association.call_association(record, associations)
+            Bullet::Detector::Association.add_object_associations(record, associations)
+            Bullet::Detector::NPlusOneQuery.call_association(record, associations)
           end
-          Bullet::Association.add_eager_loadings(records, associations)
+          Bullet::Detector::Association.add_eager_loadings(records, associations)
           records
         end
       end
@@ -54,8 +55,8 @@ module Bullet
         # call join associations
         def construct_association(record, join, row)
           associations = join.reflection.name
-          Bullet::Association.add_object_associations(record, associations)
-          Bullet::Association.call_association(record, associations)
+          Bullet::Detector::Association.add_object_associations(record, associations)
+          Bullet::Detector::NPlusOneQuery.call_association(record, associations)
           origin_construct_association(record, join, row)
         end
       end
@@ -64,7 +65,7 @@ module Bullet
         # call one to many associations
         alias_method :origin_load_target, :load_target
         def load_target
-          Bullet::Association.call_association(@owner, @reflection.name)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name)
           origin_load_target
         end
       end
@@ -75,8 +76,8 @@ module Bullet
         def load_target
           # avoid stack level too deep
           result = origin_load_target
-          Bullet::Association.call_association(@owner, @reflection.name) unless caller.to_s.include? 'load_target'
-          Bullet::Association.add_possible_objects(result)
+          Bullet::Detector::NPlusOneQuery.call_association(@owner, @reflection.name) unless caller.find {|c| c =~ LOAD_TARGET_RGX }
+          Bullet::Detector::Association.add_possible_objects(result)
           result
         end
       end
@@ -86,7 +87,7 @@ module Bullet
 
         def has_cached_counter?
           result = origin_has_cached_counter?
-          Bullet::Counter.add_counter_cache(@owner, @reflection.name) unless result
+          Bullet::Detector::Counter.add_counter_cache(@owner, @reflection.name) unless result
           result
         end
       end
@@ -95,16 +96,7 @@ module Bullet
         alias_method :origin_has_cached_counter?, :has_cached_counter?
         def has_cached_counter?
           result = origin_has_cached_counter?
-          Bullet::Counter.add_counter_cache(@owner, @reflection.name) unless result
-          result
-        end
-      end
-      
-      ::ActiveRecord::Associations::HasManyThroughAssociation.class_eval do
-        alias_method :origin_has_cached_counter?, :has_cached_counter?
-        def has_cached_counter?
-          result = origin_has_cached_counter?
-          Bullet::Counter.add_counter_cache(@owner, @reflection.name) unless result
+          Bullet::Detector::Counter.add_counter_cache(@owner, @reflection.name) unless result
           result
         end
       end