bulkrax 8.2.1 → 8.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f2cc08d07d9dcc8bd23ffcbb4bffb003a29526e10eee216eafe38218cf210e4
-  data.tar.gz: ebb308781109821d73da4f26e1a836ff6ee7ae1052145808321b385380b57e17
+  metadata.gz: efd4c183d72156bd32a32eb0e160485f1dc46c67630f6835db761bb93ab3b16b
+  data.tar.gz: 05c58dccdae7e285db479602490dd3be7429405f931a18aede0accbd4eec3503
 SHA512:
-  metadata.gz: b1e760746c5afdf36af2621ca6a2b13d6c1c81f5a5a1e291ec290c53c0bbe2219d346aa0dc54db8b2bf17f11e5aea13594058d0bae55518bf5fa857e8190661f
-  data.tar.gz: d840b1bdcb3c20ca939f778e3e6e5bbb490e890224ec5c912dcf881489e34a58b6d957395387a358fa8930023a93f8f15077ac7f5146a7d87fa0e7a59b6d71e8
+  metadata.gz: e64eecf68566f81c2d105640b71b8b6834e4c32fc18a416f0c026883387a257f913ad82ad676826b6a744a352edbce4a21aa82a304b23f2583f2c15a97f72078
+  data.tar.gz: 9c4ce4f1b4d36c5dcb031ce0a8ecb6617c0114dbc891384d3de5fe6e5ee42b04761001d269d22d6b54c616aaf3cf793e461187d0e17fd20c3a025a907c20fb4e

data/app/controllers/concerns/bulkrax/datatables_behavior.rb

@@ -132,7 +132,7 @@ module Bulkrax
           status_message: status_message_for(e),
           type: e.type,
           updated_at: e.updated_at,
-          errors: e.latest_status&.error_class&.present? ? view_context.link_to(e.latest_status.error_class, view_context.item_entry_path(item, e), title: e.latest_status.error_message) : "",
+          errors: e.status_message == 'Failed' ? view_context.link_to(e.error_class, view_context.item_entry_path(item, e)) : "",
           actions: entry_util_links(e, item)
         }
       end

data/app/factories/bulkrax/object_factory.rb

@@ -165,7 +165,10 @@ module Bulkrax
     end
 
     def delete(_user)
-      find&.delete
+      obj = find
+      return false unless obj
+
+      obj.delete(eradicate: true)
     end
 
     private

data/app/jobs/bulkrax/delete_file_set_job.rb

@@ -10,11 +10,11 @@ module Bulkrax
           om = parent.ordered_members.to_a
           om.delete(file_set)
           parent.ordered_members = om
-        elsif parent.respond_to?(:member_ids)
+          parent.save
+        elsif parent&.respond_to?(:member_ids)
           parent.member_ids.delete(file_set.id)
           Hyrax.persister.save(resource: parent)
         end
-        parent.save
       end
 
       super

data/app/jobs/bulkrax/export_work_job.rb

@@ -26,7 +26,7 @@ module Bulkrax
         end
         # rubocop:enable Rails/SkipsModelValidations
       end
-      return entry if exporter_run.enqueued_records.positive?
+      return entry if exporter_run.reload.enqueued_records.positive?
 
       if exporter_run.failed_records.positive?
         exporter_run.exporter.set_status_info('Complete (with failures)')

data/app/models/bulkrax/status.rb

@@ -2,7 +2,7 @@
 
 module Bulkrax
   class Status < ApplicationRecord
-    belongs_to :statusable, polymorphic: true, denormalize: { fields: %i[status_message], if: :latest? }
+    belongs_to :statusable, polymorphic: true, denormalize: { fields: %i[status_message error_class], if: :latest? }
     belongs_to :runnable, polymorphic: true
     serialize :error_backtrace, Array
 

data/app/models/concerns/bulkrax/export_behavior.rb

@@ -26,11 +26,15 @@ module Bulkrax
 
     # Prepend the file_set id to ensure a unique filename and also one that is not longer than 255 characters
     def filename(file_set)
-      # NOTE: Will this work with Valkyrie?
       return if file_set.original_file.blank?
-      fn = file_set.original_file.file_name.first
-      mime = ::Marcel::MimeType.for(file_set.original_file.mime_type)
-      ext_mime = ::Marcel::MimeType.for(file_set.original_file.file_name)
+      if file_set.original_file.respond_to?(:original_filename) # valkyrie
+        fn = file_set.original_file.original_filename
+        mime = ::Marcel::MimeType.for(file_set.original_file.file.io)
+      else # original non valkyrie version
+        fn = file_set.original_file.file_name.first
+        mime = ::Marcel::MimeType.for(declared_type: file_set.original_file.mime_type)
+      end
+      ext_mime = ::Marcel::MimeType.for(name: fn)
       if fn.include?(file_set.id) || importerexporter.metadata_only?
         filename = "#{fn}.#{mime.to_sym}"
         filename = fn if mime.to_s == ext_mime.to_s

data/app/parsers/bulkrax/csv_parser.rb

@@ -244,7 +244,10 @@ module Bulkrax
       record = Bulkrax.object_factory.find(identifier)
       return unless record
 
-      file_sets = record.file_set? ? Array.wrap(record) : record.file_sets
+      file_sets = Array.wrap(record) if record.file_set?
+      if file_sets.nil? # for valkyrie
+        file_sets = record.respond_to?(:file_sets) ? record.file_sets : record.members&.select(&:file_set?)
+      end
       file_sets << record.thumbnail if exporter.include_thumbnails && record.thumbnail.present? && record.work?
       file_sets.each do |fs|
         path = File.join(exporter_export_path, folder_count, 'files')
@@ -252,7 +255,7 @@ module Bulkrax
         file = filename(fs)
         next if file.blank? || fs.original_file.blank?
 
-        io = open(fs.original_file.uri)
+        io = fs.original_file.respond_to?(:uri) ? open(fs.original_file.uri) : fs.original_file.file.io
         File.open(File.join(path, file), 'wb') do |f|
           f.write(io.read)
           f.close

data/app/parsers/bulkrax/parser_export_record_set.rb

@@ -173,7 +173,7 @@ module Bulkrax
       # @see https://github.com/samvera/hyrax/blob/64c0bbf0dc0d3e1b49f040b50ea70d177cc9d8f6/app/indexers/hyrax/work_indexer.rb#L15-L18
       def file_sets
         @file_sets ||= ParserExportRecordSet.in_batches(candidate_file_set_ids) do |batch_of_ids|
-          fsq = "has_model_ssim:#{Bulkrax.file_model_internal_resource} AND id:(\"" + batch_of_ids.join('" OR "') + "\")"
+          fsq = "has_model_ssim:\"#{Bulkrax.file_model_internal_resource.demodulize}\" AND id:(\"" + batch_of_ids.join('" OR "') + "\")"
           fsq += extra_filters if extra_filters.present?
           Bulkrax.object_factory.query(
             fsq,

data/db/migrate/20241203010707_entry_error_denormalization.rb

@@ -0,0 +1,7 @@
+class EntryErrorDenormalization < ActiveRecord::Migration[5.1]
+  def change
+    add_column :bulkrax_entries, :error_class, :string unless column_exists?(:bulkrax_entries, :error_class)
+    add_column :bulkrax_importers, :error_class, :string unless column_exists?(:bulkrax_importers, :error_class)
+    add_column :bulkrax_exporters, :error_class, :string unless column_exists?(:bulkrax_exporters, :error_class)
+  end
+end

data/db/migrate/20241205212513_faster_first_entry.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+class FasterFirstEntry < ActiveRecord::Migration[5.2]
+  def change
+    add_index :bulkrax_entries, [:importerexporter_id, :importerexporter_type, :id], name: 'index_bulkrax_entries_on_importerexporter_id_type_and_id' unless index_exists?(:bulkrax_entries, [:importerexporter_id, :importerexporter_type, :id],
+      name: 'index_bulkrax_entries_on_importerexporter_id_type_and_id')
+  end
+end

data/lib/bulkrax/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bulkrax
-  VERSION = '8.2.1'
+  VERSION = '8.2.3'
 end

data/lib/tasks/bulkrax_tasks.rake

@@ -9,7 +9,7 @@ namespace :bulkrax do
                                    progress_mark: ' ',
                                    remainder_mark: "\u{FF65}")
     Bulkrax::Status.latest_by_statusable.includes(:statusable).find_each do |status|
-      status.statusable.update(status_message: status.status_message)
+      status.statusable.update(status_message: status.status_message, error_class: status.error_class)
       @progress.increment
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bulkrax
 version: !ruby/object:Gem::Version
-  version: 8.2.1
+  version: 8.2.3
 platform: ruby
 authors:
 - Rob Kaufman
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-02 00:00:00.000000000 Z
+date: 2024-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.6
+        version: 0.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.6
+        version: 0.6.0
 - !ruby/object:Gem::Dependency
   name: coderay
   requirement: !ruby/object:Gem::Requirement
@@ -486,6 +486,8 @@ files:
 - db/migrate/20240823173525_add_error_tracking_to_pending_relationships.rb
 - db/migrate/20240916182737_add_last_imported_at_to_bulkrax_importers.rb
 - db/migrate/20240916182823_add_next_import_at_to_bulkrax_importers.rb
+- db/migrate/20241203010707_entry_error_denormalization.rb
+- db/migrate/20241205212513_faster_first_entry.rb
 - lib/bulkrax.rb
 - lib/bulkrax/engine.rb
 - lib/bulkrax/entry_spec_helper.rb
@@ -518,7 +520,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.20
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: Import and export tool for Hyrax and Hyku