bulkippt 0.0.3 → 0.0.4

data/README.md

@@ -1,5 +1,7 @@
 # Bulkippt
 
+[![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/jboursiquot/bulkippt)
+
 Allows you to upload your bookmarks to kippt.com in bulk. You'll need a kippt.com account (of course) from which you'll obtain your API token along with your username. From there, all you need is a CSV file with url, title and description headers and the loader will push those links to kippt.com on your behalf.
 
 ## Installation

data/lib/bulkippt.rb

@@ -30,7 +30,25 @@ module Bulkippt
     def extract_bookmarks(file_path)
       begin
         validate_file_path file_path
+      rescue => e
+        @logger.error e.message
+        return []
+      end
+
+      begin
         @csv = CSV.read(file_path, {headers: true})
+      rescue ArgumentError => e
+        @logger.warn e.message + " | Forcing UTF-8..."
+        begin
+          data = IO.read(file_path).force_encoding("ISO-8859-1").encode("utf-8", replace: nil)
+          @csv = CSV.parse(data, {headers: true})
+        rescue => e
+          @logger.error "Failed to force UTF-8 | " + e.message
+          return []
+        end
+      end
+
+      begin
         validate_headers(normalize_headers(@csv.headers))
         parse_csv(@csv)
       rescue => e
@@ -70,6 +88,10 @@ module Bulkippt
       result
     end
 
+    def parse_file(file_path)
+      IO.read(file_path).force_encoding("ISO-8859-1").encode("utf-8", replace: nil)
+    end
+
     def normalize_headers(headers)
       headers.map(&:downcase)
     end

data/lib/bulkippt/version.rb

@@ -1,3 +1,3 @@
 module Bulkippt
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/data/non-utf8.csv

@@ -0,0 +1 @@
+URL,Title,Description,Folder

data/spec/lib/bulkippt_spec.rb

@@ -44,6 +44,10 @@ describe "Bulkippt" do
       File.expand_path './spec/data/good.csv'
     end
 
+    let :non_utf8_csv do
+      File.expand_path './spec/data/non-utf8.csv'
+    end
+
     let :loader do
       Bulkippt::Loader.new(Bulkippt::FakeService.new('valid','valid'), Logger.new('/dev/null'))
     end
@@ -54,6 +58,12 @@ describe "Bulkippt" do
       clips.size.should >= 3
     end
 
+    it "should handle non-UTF-8 CSVs and still find all the bookmarks" do
+      clips = loader.extract_bookmarks non_utf8_csv
+      clips.class.should == Array
+      clips.size.should >= 2
+    end
+
     it "should use the service to submit the bookmarks" do
       bookmarks = loader.extract_bookmarks good_csv
       saved = loader.submit_bookmarks bookmarks

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bulkippt
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-14 00:00:00.000000000 Z
+date: 2012-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kippt
@@ -126,6 +126,7 @@ files:
 - lib/bulkippt/version.rb
 - spec/data/empty.csv
 - spec/data/good.csv
+- spec/data/non-utf8.csv
 - spec/lib/bulkippt_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/jboursiquot/bulkippt
@@ -155,5 +156,6 @@ summary: Imports bookmarks (url, title, etc) into your kippt.com account in bulk
 test_files:
 - spec/data/empty.csv
 - spec/data/good.csv
+- spec/data/non-utf8.csv
 - spec/lib/bulkippt_spec.rb
 - spec/spec_helper.rb