bulkippt 0.0.2 → 0.0.3

data/bulkippt.gemspec

@@ -22,4 +22,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rake','~> 0.9'
   gem.add_development_dependency 'rspec','~> 2.11'
   gem.add_development_dependency 'fivemat', '~> 1.1'
+  gem.add_development_dependency 'pry'
+  gem.add_development_dependency 'pry-debugger'
 end

data/lib/bulkippt/fake_service.rb

@@ -1,4 +1,5 @@
 require 'ostruct'
+require 'json'
 
 module Bulkippt
 

data/lib/bulkippt/version.rb

@@ -1,3 +1,3 @@
 module Bulkippt
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/bulkippt.rb

@@ -35,6 +35,7 @@ module Bulkippt
         parse_csv(@csv)
       rescue => e
         @logger.error e.message
+        []
       end
     end
 
@@ -53,6 +54,7 @@ module Bulkippt
         submitted
       rescue => e
         @logger.error e.message
+        []
       end
     end
 
@@ -73,13 +75,13 @@ module Bulkippt
     end
 
     def validate_file_path(file_path)
-      raise Exception, "CSV not found: #{file_path}" if !File.exists?(file_path)
+      raise "File not found: #{file_path}" if !File.exists?(file_path)
     end
 
     def validate_headers(headers)
       #url and title are required, description and folder are not
-      raise Exception, "Missing 'url' column" unless headers.include? 'url'
-      raise Exception, "Missing 'title' column" unless headers.include? 'title'
+      raise "Missing 'url' column" unless headers.include? 'url'
+      raise "Missing 'title' column" unless headers.include? 'title'
     end
 
     def bookmark_instance(url, title, desc, folder)

data/spec/lib/bulkippt_spec.rb

@@ -5,11 +5,11 @@ describe "Bulkippt" do
   context "when asked to verify credentials" do
 
     it "should detect that a given set of credentials is incorrect" do
-      Bulkippt::Loader.new(Bulkippt::FakeService.new('invalid', 'invalid')).credentials_valid?.should be_false
+      Bulkippt::Loader.new(Bulkippt::FakeService.new('invalid', 'invalid'), Logger.new('/dev/null')).credentials_valid?.should be_false
     end
 
     it "should detect that a given set of credentials is correct" do
-      Bulkippt::Loader.new(Bulkippt::FakeService.new('valid', 'valid')).credentials_valid?.should be_true
+      Bulkippt::Loader.new(Bulkippt::FakeService.new('valid', 'valid'), Logger.new('/dev/null')).credentials_valid?.should be_true
     end
 
   end
@@ -20,14 +20,20 @@ describe "Bulkippt" do
       File.expand_path './spec/data/empty.csv'
     end
 
-    it "should raise an error when it can't find the file specified" do
-      loader = Bulkippt::Loader.new(Bulkippt::FakeService.new('valid','valid'))
-      expect {loader.extract_bookmarks('/does/not/exist.csv')}.to raise_error
+    let :loader do
+      Bulkippt::Loader.new(Bulkippt::FakeService.new('valid','valid'), Logger.new('/dev/null'))
+    end
+
+    it "should fail to extract bookmarks when CSV's not found" do
+      result = loader.extract_bookmarks('/does/not/exist.csv')
+      result.should be_an_instance_of Array
+      result.size.should == 0
     end
 
     it "should raise an error when missing the require url and title columns" do
-      loader = Bulkippt::Loader.new(Bulkippt::FakeService.new('valid', 'valid'))
-      expect { loader.extract_bookmarks bad_csv }.to raise_error
+      result = loader.extract_bookmarks(bad_csv)
+      result.should be_an_instance_of Array
+      result.size.should == 0
     end
 
   end
@@ -38,15 +44,17 @@ describe "Bulkippt" do
       File.expand_path './spec/data/good.csv'
     end
 
+    let :loader do
+      Bulkippt::Loader.new(Bulkippt::FakeService.new('valid','valid'), Logger.new('/dev/null'))
+    end
+
     it "should find all the bookmarks" do
-      loader = Bulkippt::Loader.new(Bulkippt::FakeService.new('valid', 'valid'))
       clips = loader.extract_bookmarks good_csv
       clips.class.should == Array
       clips.size.should >= 3
     end
 
     it "should use the service to submit the bookmarks" do
-      loader = Bulkippt::Loader.new(Bulkippt::FakeService.new('valid', 'valid'))
       bookmarks = loader.extract_bookmarks good_csv
       saved = loader.submit_bookmarks bookmarks
       saved.class.should == Array

data/spec/spec_helper.rb

@@ -1,2 +1,2 @@
-%w{kippt json}.each{ |lib| require lib}
-%w{bulkippt}.each { |file| require File.join(File.dirname(__FILE__),"../lib", file)}
+%w{kippt json pry}.each{ |lib| require lib }
+%w{bulkippt}.each { |file| require File.join(File.dirname(__FILE__),"../lib", file) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bulkippt
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -75,6 +75,38 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-debugger
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Imports bookmarks (url, title, etc) into your kippt.com account in bulk
 email:
 - jboursiquot@gmail.com