bulkforce 1.0.0

data/spec/lib/bulkforce/connection_spec.rb

@@ -0,0 +1,99 @@
+#encoding: utf-8
+require "spec_helper"
+
+describe Bulkforce::Connection do
+  let(:subject) do
+    described_class.new(
+      session_id: session_id,
+      instance: instance,
+      api_version: api_version,
+    )
+  end
+
+  let(:session_id) { "org_id!session_id" }
+  let(:instance) { "eu2" }
+  let(:api_version) { "33.0" }
+
+  {
+    login: 0,
+    create_job: 4,
+    close_job: 1,
+    query_batch: 2,
+    query_batch_result_id: 2,
+    query_batch_result_data: 3,
+  }.each do |method_name, num_of_params|
+    describe "##{method_name}" do
+      it "delegates correctly to Http class" do
+        allow(Bulkforce::Helper).to receive(:parse_csv).and_return([])
+        expect(Bulkforce::Http)
+          .to receive(method_name)
+          .and_return({})
+        subject.send(method_name, *Array.new(num_of_params))
+      end
+    end
+  end
+
+  describe "#add_query" do
+    it "delegates correctly to Http class" do
+      expect(Bulkforce::Http).to receive(:add_batch)
+          .and_return({})
+      subject.add_query(nil, nil)
+    end
+  end
+
+  describe "#org_id" do
+    let(:org_id) { "00D50000000IehZ" }
+    let(:session_id) { "#{org_id}!AQcAQH0dMHZfz972Szmpkb58urFRkgeBGsxL_QJWwYMfAbUeeG7c1E6LYUfiDUkWe6H34r1AAwOR8B8fLEz6n04NPGRrq0FM" }
+
+    it "returns correct OrgId" do
+      expect(subject.org_id).to eq(org_id)
+    end
+  end
+
+  describe "#add_batch" do
+    it "delegates correctly to underlying classes" do
+      expect(Bulkforce::Http).to receive(:add_batch)
+          .and_return({})
+      expect(Bulkforce::Helper).to receive(:records_to_csv)
+        .and_return("My,Awesome,CSV")
+      subject.add_batch(nil, [{"non_emtpy" => "records"}])
+    end
+
+    it "returns -1 for nil input" do
+      return_code = subject.add_batch(nil, nil)
+      expect(return_code).to eq(-1)
+    end
+
+    it "returns -1 for empty input" do
+      return_code = subject.add_batch(nil, [])
+      expect(return_code).to eq(-1)
+    end
+  end
+
+  describe "#query_batch_result_id" do
+    let(:job_id) {"12345"}
+    let(:batch_id) {"67890"}
+
+    context "with a single page of results" do
+      let(:single_result) {{:result=>"M75200000001Vgt", :@xmlns=>"http://www.force.com/2009/06/asyncapi/dataload"}}
+      it "returns the result_id as a string" do
+        expect(Bulkforce::Http).to receive(:query_batch_result_id).
+          with(instance, session_id, job_id, batch_id, api_version).
+          and_return(single_result)
+
+        expect(subject.query_batch_result_id(job_id, batch_id)).to eq(single_result)
+      end
+    end
+
+    context "with an array of page of results" do
+      let(:multiple_result) {{:result=>["752M00000001Vgt", "752M00000001Vgy"], :@xmlns=>"http://www.force.com/2009/06/asyncapi/dataload"}}
+      it "returns the result_id as a string" do
+        expect(Bulkforce::Http).to receive(:query_batch_result_id).
+          with(instance, session_id, job_id, batch_id, api_version).
+          and_return(multiple_result)
+
+        expect(subject.query_batch_result_id(job_id, batch_id)).to eq(multiple_result)
+      end
+    end
+  end
+end

data/spec/lib/bulkforce/helper_spec.rb

@@ -0,0 +1,249 @@
+#encoding: utf-8
+require "spec_helper"
+
+describe Bulkforce::Helper do
+  describe ".records_to_csv" do
+    it "returns valid csv for single record" do
+      input = [
+        {"Title" => "Awesome Title", "Name" => "A name"},
+      ]
+
+      expected_csv = "\"Title\",\"Name\"\n" \
+      "\"Awesome Title\",\"A name\"\n"
+      expect(described_class.records_to_csv(input)).to eq(expected_csv)
+    end
+
+    it "returns valid csv for basic records" do
+      input = [
+        {"Title" => "Awesome Title", "Name" => "A name"},
+        {"Title" => "A second Title", "Name" => "A second name"},
+      ]
+
+      expected_csv = "\"Title\",\"Name\"\n" \
+      "\"Awesome Title\",\"A name\"\n" \
+      "\"A second Title\",\"A second name\"\n"
+      expect(described_class.records_to_csv(input)).to eq(expected_csv)
+    end
+
+    it "returns valid csv when first row misses a key" do
+      input = [
+        {"Title" => "Awesome Title", "Name" => "A name"},
+        {"Title" => "A second Title", "Name" => "A second name", "Something" => "Else"},
+      ]
+
+      expected_csv = "\"Title\",\"Name\",\"Something\"\n" \
+      "\"Awesome Title\",\"A name\",\"\"\n" \
+      "\"A second Title\",\"A second name\",\"Else\"\n"
+      expect(described_class.records_to_csv(input)).to eq(expected_csv)
+    end
+
+    it "correctly converts Array to Multi-Picklist" do
+      input = [
+        {"Title" => "Awesome Title", "Picklist" => ["Several", "Values"]},
+        {"Title" => "A second Title", "Picklist" => ["SingleValue"]},
+      ]
+
+      expected_csv = "\"Title\",\"Picklist\"\n" \
+        "\"Awesome Title\",\"Several;Values\"\n" \
+        "\"A second Title\",\"SingleValue\"\n"
+      expect(described_class.records_to_csv(input)).to eq(expected_csv)
+    end
+
+    it "returns valid csv when order of keys varies" do
+      input = [
+        {"Title" => "Awesome Title", "Name" => "A name"},
+        {"Name" => "A second name", "Title" => "A second Title"},
+      ]
+
+      expected_csv = "\"Title\",\"Name\"\n" \
+      "\"Awesome Title\",\"A name\"\n" \
+      "\"A second Title\",\"A second name\"\n"
+      expect(described_class.records_to_csv(input)).to eq(expected_csv)
+    end
+
+    it "correctly converts empty arrays, nil values and blank strings to #N/A" do
+      input = [
+        {"Title" => nil, "Picklist" => ["Several", "Values"]},
+        {"Title" => "", "Picklist" => []},
+      ]
+
+      expected_csv = "\"Title\",\"Picklist\"\n" \
+        "\"#N/A\",\"Several;Values\"\n" \
+        "\"#N/A\",\"#N/A\"\n"
+      expect(described_class.records_to_csv(input)).to eq(expected_csv)
+    end
+  end
+
+  describe ".fetch_instance_from_server_url" do
+    let(:basic_api_server_url) {
+      "https://cs7-api.salesforce.com/services/Soap/u/28.0/00CS00000095Y5b"
+    }
+
+    let(:basic_server_url) {
+      "https://eu1.salesforce.com/services/Soap/u/28.0/00EU00000096Y8c"
+    }
+
+    let(:named_server_url) {
+      "https://supercustomname.my.salesforce.com/services/Soap/u/28.0/00EH0000001jNQu"
+    }
+
+    it "returns correct instance for regular salesforce server url" do
+      expect(described_class.fetch_instance_from_server_url(basic_server_url))
+        .to eq("eu1")
+    end
+
+    it "returns correct instance for api salesforce server url" do
+      expect(described_class.fetch_instance_from_server_url(basic_api_server_url))
+        .to eq("cs7")
+    end
+
+    it "returns correct instance for named salesforce server url" do
+      expect(described_class.fetch_instance_from_server_url(named_server_url))
+        .to eq("supercustomname.my")
+    end
+  end
+
+  describe ".attachment_keys" do
+    let(:records_with_attachment) do
+      prefix = Dir.tmpdir
+      FileUtils.touch("#{prefix}/attachment.pdf")
+      [
+        {
+          "normal_key" => "normal_value1",
+          "attachment_key" => nil,
+        },
+        {
+          "normal_key" => "normal_value2",
+          "attachment_key" => File.new("#{prefix}/attachment.pdf"),
+        }
+      ]
+    end
+
+    let(:records_with_multiple_attachment) do
+      prefix = Dir.tmpdir
+      FileUtils.touch("#{prefix}/attachment1.pdf")
+      FileUtils.touch("#{prefix}/attachment2.pdf")
+      FileUtils.touch("#{prefix}/attachment3.pdf")
+      [
+        {
+          "normal_key" => "normal_value1",
+          "attachment_key" => File.new("#{prefix}/attachment1.pdf"),
+          "another_attachment_key" => File.new("#{prefix}/attachment2.pdf"),
+        },
+        {
+          "normal_key" => "normal_value2",
+          "attachment_key" => File.new("#{prefix}/attachment3.pdf"),
+        }
+      ]
+    end
+
+    let(:records_without_attachment) do
+      [
+        {
+          "normal_key" => "normal_value1",
+          "another_normal_key" => "another_normal_value1",
+        },
+        {
+          "normal_key" => "normal_value2",
+          "another_normal_key" => "another_normal_value2",
+        }
+      ]
+    end
+
+    it "returns correct keys for single attachment key" do
+      expect(described_class.attachment_keys(records_with_attachment))
+        .to eq(["attachment_key"])
+    end
+
+    it "returns correct keys for multiple attachment keys" do
+      expect(described_class.attachment_keys(records_with_multiple_attachment))
+        .to eq(["attachment_key", "another_attachment_key"])
+    end
+
+    it "returns false for no attachment" do
+      expect(described_class.attachment_keys(records_without_attachment))
+        .to eq([])
+    end
+  end
+
+  describe ".transform_values!" do
+    let(:records_with_attachment) do
+      prefix = Dir.tmpdir
+      FileUtils.touch("#{prefix}/attachment.pdf")
+      [
+        {
+          "normal_key" => "normal_value1",
+          "attachment_key" => nil,
+        },
+        {
+          "normal_key" => "normal_value2",
+          "attachment_key" => File.new("#{prefix}/attachment.pdf"),
+        }
+      ]
+    end
+
+    it "transforms values correctly" do
+      expect(File).to receive(:absolute_path).and_return("/an/absolute/path")
+      expected_output = [
+        {
+          "normal_key" => "normal_value1",
+          "attachment_key" => nil,
+        },
+        {
+          "normal_key" => "normal_value2",
+          "attachment_key" => "#an/absolute/path",
+        }
+      ]
+
+      input = records_with_attachment
+      described_class.transform_values!(input,["attachment_key"])
+      expect(input).to eq(expected_output)
+    end
+
+    it "yields absolute path" do
+      expect(File).to receive(:absolute_path).and_return("/an/absolute/path")
+      input = records_with_attachment
+      expect do |blk|
+        described_class.transform_values!(input,["attachment_key"], &blk)
+      end.to yield_with_args("/an/absolute/path")
+    end
+  end
+
+  describe ".absolute_to_relative_path" do
+    let(:unix_path) { "/a/unix/path" }
+    let(:windows_path_backslash) { "C:\\a\\backslash\\path" }
+    let(:windows_path_forwardslash) { "C:/a/forwardslash/path" }
+
+    it "strips unix path correctly" do
+      expect(described_class.absolute_to_relative_path(unix_path,"")).
+        to eq("a/unix/path")
+    end
+
+    it "strips windows path with backslash correctly" do
+      expect(described_class.absolute_to_relative_path(windows_path_backslash,"")).
+        to eq("a\\backslash\\path")
+    end
+
+    it "strips windows path with forwardslash correctly" do
+      expect(described_class.absolute_to_relative_path(windows_path_forwardslash,"")).
+        to eq("a/forwardslash/path")
+    end
+  end
+
+  describe ".parse_csv" do
+    let(:csv_string) {
+       "Id,my_external_id__c\n" \
+       "003M000057GH39aIAD,K-00J799\n" \
+       "003M001200KO82cIAD,K-015699"
+    }
+    let(:expected_result) {
+      [
+        { "Id" => "003M000057GH39aIAD", "my_external_id__c" => "K-00J799" },
+        { "Id" => "003M001200KO82cIAD", "my_external_id__c" => "K-015699" },
+      ]
+    }
+    it "correctly transforms csv string" do
+      expect(described_class.parse_csv(csv_string)).to eq(expected_result)
+    end
+  end
+end

data/spec/lib/bulkforce/http_spec.rb

@@ -0,0 +1,375 @@
+#encoding: utf-8
+require "spec_helper"
+
+describe Bulkforce::Http do
+  describe "#process_http_request" do
+    let(:post_request) do
+      Bulkforce::Http::Request.new(
+        :post,
+        "test.host",
+        "/",
+        "post body",
+        {"X-SFDC-Session" => "super_secret"})
+    end
+
+    let(:get_request) do
+      Bulkforce::Http::Request.new(:get, "test.host", "/", "", [])
+    end
+
+    it "returns a response object" do
+       expected_body = "correct result"
+        stub_request(:post, "https://test.host")
+          .with(
+            body: post_request.body,
+            headers: post_request.headers)
+          .to_return(:body => expected_body)
+       res = Bulkforce::Http.process_http_request(post_request)
+       expect(res).to eq(expected_body)
+    end
+  end
+
+  describe "#login" do
+    let(:login_error_message) do
+      "INVALID_LOGIN: Invalid username, password, security token;" \
+      "or user locked out."
+    end
+
+    let(:sf_instance) {"cs7"}
+
+    let(:login_success) do
+      %Q{<?xml version="1.0" encoding="UTF-8"?>
+          <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns="urn:partner.soap.sforce.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+            <soapenv:Body>
+              <loginResponse>
+                <result>
+                  <metadataServerUrl>https://#{sf_instance}-api.salesforce.com/services/Soap/m/27.0/00EU00000095Y5b</metadataServerUrl>
+                  <passwordExpired>false</passwordExpired>
+                  <sandbox>true</sandbox>
+                  <serverUrl>https://#{sf_instance}-api.salesforce.com/services/Soap/u/27.0/00EU00000095Y5b</serverUrl>
+                  <sessionId>00DM00000099X9a!AQ7AQJ9BjrYfF2h_G9_VERsCRVjTMAPaWjz2zuqqRBduYvKCmHexVbKdtxFMrgTnV9Xi.M80AhIkjnwuEVxI00ChG09._Q_X</sessionId>
+                  <userId>005K001100243YPIAY</userId>
+                  <userInfo>
+                    <accessibilityMode>false</accessibilityMode>
+                    <currencySymbol xsi:nil="true"/>
+                    <orgAttachmentFileSizeLimit>2621440</orgAttachmentFileSizeLimit>
+                    <orgDefaultCurrencyIsoCode xsi:nil="true"/>
+                    <orgDisallowHtmlAttachments>false</orgDisallowHtmlAttachments>
+                    <orgHasPersonAccounts>false</orgHasPersonAccounts>
+                    <organizationId>00ID0000OrgFoo</organizationId>
+                    <organizationMultiCurrency>true</organizationMultiCurrency>
+                    <organizationName>Hinz &amp; Kunz</organizationName>
+                    <profileId>00eA0000000nJEY</profileId>
+                    <roleId xsi:nil="true"/>
+                    <sessionSecondsValid>3600</sessionSecondsValid>
+                    <userDefaultCurrencyIsoCode>EUR</userDefaultCurrencyIsoCode>
+                    <userEmail>theadmin@example.com</userEmail>
+                    <userFullName>John Doe</userFullName>
+                    <userId>005D0000002b3SPIAY</userId>
+                    <userLanguage>de</userLanguage>
+                    <userLocale>de_DE_EURO</userLocale>
+                    <userName>theadmin@exammple.com.euvconfig</userName>
+                    <userTimeZone>Europe/Berlin</userTimeZone>
+                    <userType>Standard</userType>
+                    <userUiSkin>Theme42</userUiSkin>
+                  </userInfo>
+                </result>
+              </loginResponse>
+            </soapenv:Body>
+          </soapenv:Envelope>}
+    end
+
+    let(:login_success_new) do
+      %Q{<?xml version="1.0" encoding="UTF-8"?>
+          <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns="urn:partner.soap.sforce.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+            <soapenv:Body>
+              <loginResponse>
+                <result>
+                  <metadataServerUrl>https://#{sf_instance}.salesforce.com/services/Soap/m/27.0/00EU00000095Y5b</metadataServerUrl>
+                  <passwordExpired>false</passwordExpired>
+                  <sandbox>true</sandbox>
+                  <serverUrl>https://#{sf_instance}.salesforce.com/services/Soap/u/27.0/00EU00000095Y5b</serverUrl>
+                  <sessionId>00DM00000099X9a!AQ7AQJ9BjrYfF2h_G9_VERsCRVjTMAPaWjz2zuqqRBduYvKCmHexVbKdtxFMrgTnV9Xi.M80AhIkjnwuEVxI00ChG09._Q_X</sessionId>
+                  <userId>005K001100243YPIAY</userId>
+                  <userInfo>
+                    <accessibilityMode>false</accessibilityMode>
+                    <currencySymbol xsi:nil="true"/>
+                    <orgAttachmentFileSizeLimit>2621440</orgAttachmentFileSizeLimit>
+                    <orgDefaultCurrencyIsoCode xsi:nil="true"/>
+                    <orgDisallowHtmlAttachments>false</orgDisallowHtmlAttachments>
+                    <orgHasPersonAccounts>false</orgHasPersonAccounts>
+                    <organizationId>00ID0000OrgFoo</organizationId>
+                    <organizationMultiCurrency>true</organizationMultiCurrency>
+                    <organizationName>Hinz &amp; Kunz</organizationName>
+                    <profileId>00eA0000000nJEY</profileId>
+                    <roleId xsi:nil="true"/>
+                    <sessionSecondsValid>3600</sessionSecondsValid>
+                    <userDefaultCurrencyIsoCode>EUR</userDefaultCurrencyIsoCode>
+                    <userEmail>theadmin@example.com</userEmail>
+                    <userFullName>John Doe</userFullName>
+                    <userId>005D0000002b3SPIAY</userId>
+                    <userLanguage>de</userLanguage>
+                    <userLocale>de_DE_EURO</userLocale>
+                    <userName>theadmin@exammple.com.euvconfig</userName>
+                    <userTimeZone>Europe/Berlin</userTimeZone>
+                    <userType>Standard</userType>
+                    <userUiSkin>Theme42</userUiSkin>
+                  </userInfo>
+                </result>
+              </loginResponse>
+            </soapenv:Body>
+          </soapenv:Envelope>}
+    end
+
+    let(:login_error) do
+      %Q{<?xml version="1.0" encoding="UTF-8"?>
+        <soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/"
+        xmlns:sf="urn:fault.partner.soap.sforce.com" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+          <soapenv:Body>
+            <soapenv:Fault>
+              <faultcode>INVALID_LOGIN</faultcode>
+              <faultstring>#{login_error_message}</faultstring>
+              <detail>
+                <sf:LoginFault xsi:type="sf:LoginFault">
+                  <sf:exceptionCode>INVALID_LOGIN</sf:exceptionCode>
+                  <sf:exceptionMessage>Invalid username, password, │Your bundle is complete!security token; or user locked out.
+                  </sf:exceptionMessage>
+                </sf:LoginFault>
+              </detail>
+            </soapenv:Fault>
+          </soapenv:Body>
+        </soapenv:Envelope>}
+    end
+
+    it "raises an error for faulty login" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(login_error)
+      expect{ Bulkforce::Http.login("a","b","c", "d") }
+        .to raise_error(RuntimeError, login_error_message)
+    end
+
+    it "returns hash for correct login" do
+      [login_success, login_success_new].each do |login_response|
+        expect(Bulkforce::Http).to receive(:process_http_request)
+          .and_return(login_response)
+        result = Bulkforce::Http.login("a","b","c", "d")
+        expect(result).to be_a(Hash)
+        expect(result).to have_key(:session_id)
+        expect(result).to have_key(:server_url)
+        expect(result[:instance]).to eq(sf_instance)
+      end
+    end
+  end
+
+  describe "#oauth_login" do
+    let(:login_error) do
+      %Q{<OAuth>
+          <error_description>invalid client credentials</error_description>
+          <error>invalid_client</error>
+        </OAuth>}
+    end
+
+    let(:login_error_message) { "invalid_client: invalid client credentials" }
+
+    let(:sf_instance) {"eu2"}
+
+    let(:login_success) do
+      %Q{<OAuth>
+          <id>https://login.salesforce.com/id/00Db0000000bHH3EAM/005b0000000K44BAAS</id>
+          <issued_at>1435621555861</issued_at>
+          <scope>full</scope>
+          <instance_url>https://eu2.salesforce.com</instance_url>
+          <token_type>Bearer</token_type>
+          <signature>mbfZerj8DRVXVF9WD28kM/p8j6d74fE29RRGleTxELE=</signature>
+          <access_token>00Db0000000bHH3!AREAQFjvfelEv7D6TM3QqoqhWAJ52sUPSw.yMuIJ0x4NExqxey7xwvezoTG6DgUypEp8.FW_l6LdyK.viB4kxZY.Tn63oRP5</access_token>
+        </OAuth>}
+    end
+
+    it "raises an error for faulty login" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(login_error)
+      expect{ Bulkforce::Http.oauth_login("a","b","c", "d") }
+        .to raise_error(RuntimeError, login_error_message)
+    end
+
+    it "returns hash for correct login" do
+      expect(Bulkforce::Http).to receive(:process_http_request).and_return(login_success)
+      result = Bulkforce::Http.oauth_login("a","b","c", "d")
+      expect(result).to be_a(Hash)
+      expect(result).to have_key(:session_id)
+      expect(result).to have_key(:server_url)
+      expect(result[:instance]).to eq(sf_instance)
+    end
+  end
+
+  describe "#create_job" do
+    let(:create_job_success) do
+      %Q{<?xml version="1.0" encoding="UTF-8"?>
+          <jobInfo xmlns="http://www.force.com/2009/06/asyncapi/dataload">
+            <id>750D0000000002lIAA</id>
+            <operation>upsert</operation>
+            <object>Contact</object>
+            <createdById>005D0000001ALVFIA4</createdById>
+            <createdDate>2013-04-10T15:52:02.000Z</createdDate>
+            <systemModstamp>2013-04-10T15:52:02.000Z</systemModstamp>
+            <state>Open</state>
+            <externalIdFieldName>my_external_field__c</externalIdFieldName>
+            <concurrencyMode>Parallel</concurrencyMode>
+            <contentType>CSV</contentType>
+            <numberBatchesQueued>0</numberBatchesQueued>
+            <numberBatchesInProgress>0</numberBatchesInProgress>
+            <numberBatchesCompleted>0</numberBatchesCompleted>
+            <numberBatchesFailed>0</numberBatchesFailed>
+            <numberBatchesTotal>0</numberBatchesTotal>
+            <numberRecordsProcessed>0</numberRecordsProcessed>
+            <numberRetries>0</numberRetries>
+            <apiVersion>27.0</apiVersion>
+            <numberRecordsFailed>0</numberRecordsFailed>
+            <totalProcessingTime>0</totalProcessingTime>
+            <apiActiveProcessingTime>0</apiActiveProcessingTime>
+            <apexProcessingTime>0</apexProcessingTime>
+          </jobInfo>}
+    end
+
+    it "returns hash for creating job" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(create_job_success)
+      result = Bulkforce::Http.create_job("a","b","c","d", "e", "f")
+      expect(result).to be_a(Hash)
+      expect(result).to have_key(:id)
+      expect(result).to have_key(:operation)
+    end
+  end
+
+  describe "#add_batch" do
+    let(:add_batch_success) do
+      %Q{
+        <?xml version="1.0" encoding="UTF-8"?>
+          <batchInfo xmlns="http://www.force.com/2009/06/asyncapi/dataload">
+            <id>750M0000000B1Z6IAL</id>
+            <jobId>751K00000009x71IAA</jobId>
+            <state>Queued</state>
+            <createdDate>2013-04-10T15:53:46.000Z</createdDate>
+            <systemModstamp>2013-04-10T15:53:46.000Z</systemModstamp>
+            <numberRecordsProcessed>0</numberRecordsProcessed>
+            <numberRecordsFailed>0</numberRecordsFailed>
+            <totalProcessingTime>0</totalProcessingTime>
+            <apiActiveProcessingTime>0</apiActiveProcessingTime>
+            <apexProcessingTime>0</apexProcessingTime>
+          </batchInfo>
+      }
+    end
+
+    it "returns hash for adding batch" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(add_batch_success)
+      result = Bulkforce::Http.add_batch(:post,"a","b","c","d")
+      expect(result).to be_a(Hash)
+      expect(result).to have_key(:id)
+      expect(result).to have_key(:job_id)
+      expect(result).to have_key(:state)
+    end
+  end
+
+  describe "#close_job" do
+    let(:close_job_success) do
+      %Q{<?xml version="1.0" encoding="UTF-8"?>
+          <jobInfo xmlns="http://www.force.com/2009/06/asyncapi/dataload">
+            <id>750D0000000002jIAA</id>
+            <operation>upsert</operation>
+            <object>Contact</object>
+            <createdById>005D0000002b3SPIAY</createdById>
+            <createdDate>2013-04-10T16:27:56.000Z</createdDate>
+            <systemModstamp>2013-04-10T16:27:56.000Z</systemModstamp>
+            <state>Closed</state>
+            <externalIdFieldName>my_external_id__c</externalIdFieldName>
+            <concurrencyMode>Parallel</concurrencyMode>
+            <contentType>CSV</contentType>
+            <numberBatchesQueued>0</numberBatchesQueued>
+            <numberBatchesInProgress>0</numberBatchesInProgress>
+            <numberBatchesCompleted>1</numberBatchesCompleted>
+            <numberBatchesFailed>0</numberBatchesFailed>
+            <numberBatchesTotal>1</numberBatchesTotal>
+            <numberRecordsProcessed>4</numberRecordsProcessed>
+            <numberRetries>0</numberRetries>
+            <apiVersion>27.0</apiVersion>
+            <numberRecordsFailed>0</numberRecordsFailed>
+            <totalProcessingTime>838</totalProcessingTime>
+            <apiActiveProcessingTime>355</apiActiveProcessingTime>
+            <apexProcessingTime>253</apexProcessingTime>
+          </jobInfo>}
+    end
+
+    it "returns hash for closing job" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(close_job_success)
+      result = Bulkforce::Http.close_job("a","b","c","d")
+      expect(result).to be_a(Hash)
+      expect(result).to have_key(:id)
+      expect(result).to have_key(:object)
+      expect(result).to have_key(:operation)
+      expect(result).to have_key(:state)
+      expect(result).to have_key(:content_type)
+    end
+  end
+
+  describe "#add_batch" do
+    let(:invalid_session_id) do
+      %Q{<?xml version="1.0" encoding="UTF-8"?>
+        <error xmlns="http://www.force.com/2009/06/asyncapi/dataload">
+          <exceptionCode>InvalidSessionId</exceptionCode>
+          <exceptionMessage>Invalid session id</exceptionMessage>
+        </error>}
+    end
+
+    it "raises an exception on faulty authorization" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(invalid_session_id)
+      expect{Bulkforce::Http.query_batch("a","b","c","d","e")}
+        .to raise_error(RuntimeError, "InvalidSessionId: Invalid session id")
+    end
+  end
+
+  describe "#query_batch_result_id" do
+    let(:batch_result_success) do
+      %Q{<result-list xmlns="http://www.force.com/2009/06/asyncapi/dataload">
+          <result>750D0000002jIAA</result>
+        </result-list>}
+    end
+
+    it "returns hash including the result id" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(batch_result_success)
+      result = Bulkforce::Http.query_batch_result_id("a","b","c","d","e")
+      expect(result).to be_a(Hash)
+      expect(result).to have_key(:result)
+    end
+  end
+
+  describe "#query_batch_result_data" do
+    let(:batch_result_data_success) do
+      %Q{"Id","my_external_id__c"
+        "003M000057GH39aIAD","K-00J799"
+        "003M001200KO82cIAD","K-015699"}
+    end
+
+    let(:batch_result_data_with_spaces_success) do
+      %Q{"Id","Name"
+        "003K000057GH39aIAD","Master of Disaster"
+        "003K001200KO82cIAD","King of the  Hill"}
+    end
+
+    it "returns a correctly formatted CSV string" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(batch_result_data_success)
+      result = Bulkforce::Http.query_batch_result_data("a","b","c","d","e","f")
+      expect(result).to eq(batch_result_data_success.gsub(/^\s+/, ""))
+    end
+
+    it "returns a correctly formatted CSV string including spaces" do
+      expect(Bulkforce::Http).to receive(:process_http_request)
+        .and_return(batch_result_data_with_spaces_success)
+      result = Bulkforce::Http.query_batch_result_data("a","b","c","d","e","f")
+      expect(result).to eq(batch_result_data_with_spaces_success.gsub(/^\s+/, ""))
+    end
+  end
+end