bulk_loader 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f597dd144f901e0dfdd7118b2c4b3195f9de24a42344efebfd338bb79b2eb7f
-  data.tar.gz: '094b05be80e70f378067597d5197ec849828416513a7a5012b9932f741bca36d'
+  metadata.gz: b6dece1077abb8076b7b22b30d4db5565f175417fe29e17043e6e2e1f226684c
+  data.tar.gz: d6af0bf31f863df6a00bd90a057e74becbc3e67bc140f54a2dc07297914ef0e6
 SHA512:
-  metadata.gz: c934949c8af3328af455fd1c0964e594f422346f68efae6a4b5dd58eb0d9cb4ee85b5fb0f0e2d994567d6e2d6ea74760d9dd7186de6ce722bc7d539592ddde2b
-  data.tar.gz: 35971ca21b9685d44755697520373484b60bdb68f9f5edbdbca45bec77e30dc5d3a88504526c6beb14ebd1ef55c2d9319fb5ae13db314f09e353d2655162530e
+  metadata.gz: c49b93dbcd1cd1d09cf50085022bcb2198a6771cd4db44c42e607eb0eca42937c26c6727133d3b8556d5022871f48c6a16997ecd81eae2d9c6041b61c0990804
+  data.tar.gz: b899710ae8b53ab5fdeb399c122f35d50c0db73994fcffc3132d37c5794fc6ef97eb5d02522216daef2efc7fc84d0e069a985655b3423aeb89a7c43cf5ac403c

data/.rubocop.yml

@@ -1,6 +1,6 @@
 # See default settings https://github.com/bbatsov/rubocop/blob/master/config/enabled.yml
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
   DisplayCopNames: true
   Exclude:
     - '*.gemspec'
@@ -10,6 +10,12 @@ AllCops:
     - 'Rakefile'
     - 'example/**/*'
 
+Metrics/AbcSize:
+  Max: 17
+
+Metrics/MethodLength:
+  Max: 14
+
 Metrics/BlockLength:
   Exclude:
     - 'spec/**/*'

data/lib/bulk_loader/attribute.rb

@@ -16,6 +16,7 @@ module BulkLoader
 
     def method_missing(name, *args)
       return super unless @class_attribute.include?(name)
+
       names = [name].freeze
       define_singleton_method(name) do
         attr = lazy(name)
@@ -27,6 +28,7 @@ module BulkLoader
 
     def respond_to_missing?(name, include_private)
       return true if @class_attribute.include?(name)
+
       super
     end
   end

data/lib/bulk_loader/class_attribute.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 module BulkLoader
+  class LoaderNotFoundError < StandardError; end
+
   class ClassAttribute
     def initialize
       @loader_of = {}
@@ -19,6 +21,8 @@ module BulkLoader
 
       loader_names = [loader_names] unless loader_names.is_a?(Array)
       loader_names.each do |name|
+        raise LoaderNotFoundError, "bulk_loader :#{name} is not defined" unless @loader_of[name]
+
         @loader_of[name].load(attrs.map { |attr| attr.lazy(name) }, *args)
       end
     end
@@ -32,6 +36,14 @@ module BulkLoader
       "#<BulkLoader::ClassAttribute:#{object_id} #{loader_inspect}>"
     end
 
+    def dup
+      new_object = self.class.new
+      each do |key, loader|
+        new_object.define_loader(key, loader)
+      end
+      new_object
+    end
+
     private
 
     def loader_inspect

data/lib/bulk_loader/dsl.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'weakref'
-
 module BulkLoader
   module DSL
     module ClassMethods
@@ -9,7 +7,12 @@ module BulkLoader
       # If you pass name, mapping, options argument, you can define loader
       # if you does not want to export name to object, pass export: false to options.
       def bulk_loader(*args, &block)
-        @bulk_loader ||= BulkLoader::ClassAttribute.new
+        @bulk_loader ||= if superclass.respond_to?(:bulk_loader)
+                           superclass.bulk_loader.dup
+                         else
+                           BulkLoader::ClassAttribute.new
+                         end
+
         return @bulk_loader if args.empty?
 
         name, mapping, options = *args
@@ -34,7 +37,7 @@ module BulkLoader
       return @bulk_loader if @bulk_loader
 
       class_attribute = self.class.bulk_loader
-      @bulk_loader = BulkLoader::Attribute.new(class_attribute, WeakRef.new(self))
+      @bulk_loader = BulkLoader::Attribute.new(class_attribute, self)
     end
   end
 end

data/lib/bulk_loader/lazy.rb

@@ -13,6 +13,7 @@ module BulkLoader
 
     def get
       raise 'data is not loaded!!' unless @loaded
+
       @value
     end
 

data/lib/bulk_loader/loader.rb

@@ -35,6 +35,7 @@ module BulkLoader
       end
       result_of = @block.call(mapping_of.keys, *args)
       raise 'block shuold return Hash' unless result_of.is_a?(Hash)
+
       result_of
     end
 
@@ -52,6 +53,7 @@ module BulkLoader
     def set_result_to_lazy_objs(result_of, lazy_obj_of, mapping_of)
       result_of.each do |mapped_target, value|
         next unless mapping_of[mapped_target]
+
         mapping_of[mapped_target].each do |target|
           lazy_obj_of[target]&.set(value)
         end

data/lib/bulk_loader/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BulkLoader
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bulk_loader
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Keiji Yoshimi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-12-06 00:00:00.000000000 Z
+date: 2019-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -152,8 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: utility to avoid N+1 queries