bulk_insert 1.8.2 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d23ef2d75aeafbefae857d874eff4f18183717fbcd1a63128a83ce407a0dfba1
-  data.tar.gz: 9bb240020a5559bf12ff4d91be847590142302fce59927707509bfdd20820bfc
+  metadata.gz: 385a28475e8a07cdf1cad85aacf241734ce65ed922648417c7beda2b88a5b3c9
+  data.tar.gz: a14a05da23f256f3d30cf69fab032ec72c5953fe1ddb3ccc45a0673bef717266
 SHA512:
-  metadata.gz: cadb63453d7036005118e8009007deb1e194a0284edbc8580009314fd02348b408bdfb2f640b6bf9eba6352a9eef77b696662463f24dbddaeedaf9dfb60613dd
-  data.tar.gz: a93e786c4d29bf7a2678d32e657a7c7ae3e0c92a91121b52ce375eaa25eaab7cd73a884624f1315ae0e83fa93bdcb9f70c4160ea26dc07530baee2b28d8ef944
+  metadata.gz: cbe45a91a166d6faa3e2899a4fad7ac1af8a6e050249adbc810121ddc3000f0786c277b8c240809935bbb80178bbb1df43044dda32a02cea87c0d5d956e3cee1
+  data.tar.gz: 165de20f26c00dfcbe605866576f731199f692b7bccb07e671b8dcb9541552e39d0940a9f6fff73701286586f909e7be1254be6df157f41f76e83b105e88b9f2

data/README.md

@@ -191,6 +191,30 @@ end
 worker.result_sets
 ```
 
+## Ruby and Rails Versions Supported
+
+> :warning: The scope of this gem may be somehow covered natively by the `.insert_all` API
+> introduced by [Rails 6](https://apidock.com/rails/v6.0.0/ActiveRecord/Persistence/ClassMethods/insert_all).
+> This gem represents the state of art for rails version < 6 and it is still open to
+> further developments for more recent versions.
+
+The current CI prevents regressions on the following versions:
+
+ruby / rails | `~>3` | `~>4` | `~>5` | `~>6`
+:-----------:|-------|-------|-------|------
+2.2          |  yes  |  yes  |  no   |  no
+2.3          |  yes  |  yes  |  yes  |  no
+2.4          |  no   |  yes  |  yes  |  no
+2.5          |  no   |  no   |  yes  |  yes
+2.6          |  no   |  no   |  yes  |  yes
+2.7          |  no   |  no   |  yes  |  yes
+
+The adapters covered in the CI are:
+* sqlite
+* mysql
+* postgresql
+
+
 ## License
 
 BulkInsert is released under the MIT license (see MIT-LICENSE) by

data/lib/bulk_insert/version.rb

@@ -1,7 +1,7 @@
 module BulkInsert
   MAJOR = 1
-  MINOR = 8
-  TINY  = 2
+  MINOR = 9
+  TINY  = 0
 
   VERSION = [MAJOR, MINOR, TINY].join(".")
 end

data/lib/bulk_insert/worker.rb

@@ -93,8 +93,19 @@ module BulkInsert
 
     def execute_query
       if query = compose_insert_query
-        result_set = @connection.exec_query(query)
-        @result_sets.push(result_set) if @return_primary_keys
+
+        # Return primary key support broke mysql compatibility
+        # with rails < 5 mysql adapter. (see issue #41)
+        if ActiveRecord::VERSION::STRING < "5.0.0" && @statement_adapter.is_a?(StatementAdapters::MySQLAdapter)
+          # raise an exception for unsupported return_primary_keys
+          raise ArgumentError.new("BulkInsert does not support @return_primary_keys for mysql and rails < 5") if @return_primary_keys
+
+          # restore v1.6 query execution
+          @connection.execute(query)
+        else
+          result_set = @connection.exec_query(query)
+          @result_sets.push(result_set) if @return_primary_keys
+        end
       end
     end
 

data/test/bulk_insert/worker_test.rb

@@ -1,14 +1,17 @@
 require 'minitest/mock'
 require 'test_helper'
+require 'connection_mocks'
 
 class BulkInsertWorkerTest < ActiveSupport::TestCase
+  include ConnectionMocks
+
   setup do
     @insert = BulkInsert::Worker.new(
       Testing.connection,
       Testing.table_name,
       'id',
       %w(greeting age happy created_at updated_at color))
-    @now = Time.now
+    @now = Time.now.utc
   end
 
   test "empty insert is not pending" do
@@ -37,8 +40,8 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
     @insert.save!
 
     record = Testing.first
-    assert_operator record.created_at, :>=, now
-    assert_operator record.updated_at, :>=, now
+    assert_operator record.created_at.to_i, :>=, now.to_i
+    assert_operator record.updated_at.to_i, :>=, now.to_i
   end
 
   test "default timestamp columns should be equivalent for the entire batch" do
@@ -111,8 +114,8 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
     @insert.add ["Hello", 25, true, @now, @now]
     @insert.save!
 
-    yo = Testing.find_by(greeting: 'Yo')
-    hello = Testing.find_by(greeting: 'Hello')
+    yo = Testing.where(greeting: 'Yo').first
+    hello = Testing.where(greeting: 'Hello').first
 
     assert_not_nil yo
     assert_equal 15, yo.age
@@ -144,6 +147,10 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
       true
     )
 
+    # return_primary_keys is not supported for mysql and rails < 5
+    # skip is not supported in the minitest version used for testing rails 3
+    return if ActiveRecord::VERSION::STRING < "5.0.0" && worker.adapter_name =~ /^mysql/i
+
     assert_no_difference -> { worker.result_sets.count } do
       worker.save!
     end
@@ -239,8 +246,8 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
     @insert.add ["Hello", 25, true, @now, @now]
     @insert.save!
 
-    yo = Testing.find_by(greeting: 'Yo')
-    hello = Testing.find_by(greeting: 'Hello')
+    yo = Testing.where(greeting: 'Yo').first
+    hello = Testing.where(greeting: 'Hello').first
 
     assert_nil yo
     assert_not_nil hello
@@ -255,24 +262,35 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
     @insert.add ["Hello", 25, true, @now, @now]
     @insert.save!
 
-    yo = Testing.find_by(greeting: 'Yo')
-    hello = Testing.find_by(greeting: 'Hello')
+    yo = Testing.where(greeting: 'Yo').first
+    hello = Testing.where(greeting: 'Hello').first
 
     assert_nil yo
     assert_nil hello
   end
 
-  test "adapter dependent default methods" do
-    assert_equal @insert.adapter_name, 'SQLite'
-    assert_equal @insert.insert_sql_statement, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES "
+  test "adapter dependent SQLite methods" do
+    connection = Testing.connection
+    stub_connection_if_needed(connection, 'SQLite') do
+      sqlite_worker = BulkInsert::Worker.new(
+        connection,
+        Testing.table_name,
+        'id',
+        %w(greeting age happy created_at updated_at color),
+        500 # batch size
+      )
+
+      assert_equal sqlite_worker.adapter_name, 'SQLite'
+      assert_equal sqlite_worker.insert_sql_statement, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES "
 
-    @insert.add ["Yo", 15, false, nil, nil]
-    assert_equal @insert.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
+      sqlite_worker.add ["Yo", 15, false, nil, nil]
+      assert_equal sqlite_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
+    end
   end
 
-  test "adapter dependent mysql methods" do
+  test "adapter dependent MySQL methods" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'MySQL' do
+    stub_connection_if_needed(connection, 'mysql') do
       mysql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -282,20 +300,21 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
         true  # ignore
       )
 
-      assert_equal mysql_worker.adapter_name, 'MySQL'
-      assert_equal (mysql_worker.adapter_name == 'MySQL'), true
+      assert_equal mysql_worker.adapter_name, 'mysql'
+      assert_equal (mysql_worker.adapter_name == 'mysql'), true
       assert_equal mysql_worker.ignore, true
-      assert_equal ((mysql_worker.adapter_name == 'MySQL') & mysql_worker.ignore), true
+      assert_equal ((mysql_worker.adapter_name == 'mysql') & mysql_worker.ignore), true
 
       mysql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal mysql_worker.compose_insert_query, "INSERT IGNORE INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
+      assert_statement_adapter mysql_worker, 'BulkInsert::StatementAdapters::MySQLAdapter'
+      assert_equal mysql_worker.compose_insert_query, "INSERT IGNORE INTO `testings` (`greeting`,`age`,`happy`,`created_at`,`updated_at`,`color`) VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse')"
     end
   end
 
   test "adapter dependent mysql methods work for mysql2" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'Mysql2' do
+    stub_connection_if_needed(connection, 'mysql2') do
       mysql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -305,18 +324,19 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
         true, # ignore
         true) # update_duplicates
 
-      assert_equal mysql_worker.adapter_name, 'Mysql2'
+      assert_equal mysql_worker.adapter_name, 'mysql2'
       assert mysql_worker.ignore
 
       mysql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal mysql_worker.compose_insert_query, "INSERT IGNORE INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') ON DUPLICATE KEY UPDATE `greeting`=VALUES(`greeting`), `age`=VALUES(`age`), `happy`=VALUES(`happy`), `created_at`=VALUES(`created_at`), `updated_at`=VALUES(`updated_at`), `color`=VALUES(`color`)"
+      assert_statement_adapter mysql_worker, 'BulkInsert::StatementAdapters::MySQLAdapter'
+      assert_equal mysql_worker.compose_insert_query, "INSERT IGNORE INTO `testings` (`greeting`,`age`,`happy`,`created_at`,`updated_at`,`color`) VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse') ON DUPLICATE KEY UPDATE `greeting`=VALUES(`greeting`), `age`=VALUES(`age`), `happy`=VALUES(`happy`), `created_at`=VALUES(`created_at`), `updated_at`=VALUES(`updated_at`), `color`=VALUES(`color`)"
     end
   end
 
   test "adapter dependent Mysql2Spatial methods" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'Mysql2Spatial' do
+    stub_connection_if_needed(connection, 'mysql2spatial') do
       mysql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -325,17 +345,18 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
         500, # batch size
         true) # ignore
 
-      assert_equal mysql_worker.adapter_name, 'Mysql2Spatial'
+      assert_equal mysql_worker.adapter_name, 'mysql2spatial'
 
       mysql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal mysql_worker.compose_insert_query, "INSERT IGNORE INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
-      end
+      assert_statement_adapter mysql_worker, 'BulkInsert::StatementAdapters::MySQLAdapter'
+      assert_equal mysql_worker.compose_insert_query, "INSERT IGNORE INTO `testings` (`greeting`,`age`,`happy`,`created_at`,`updated_at`,`color`) VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse')"
+    end
   end
 
   test "adapter dependent postgresql methods" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'PostgreSQL' do
+    stub_connection_if_needed(connection, 'PostgreSQL') do
       pgsql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -349,13 +370,19 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
 
       pgsql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') ON CONFLICT DO NOTHING RETURNING id"
+      assert_statement_adapter pgsql_worker, 'BulkInsert::StatementAdapters::PostgreSQLAdapter'
+
+      if ActiveRecord::VERSION::STRING >= "5.0.0"
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse') ON CONFLICT DO NOTHING RETURNING id"
+      else
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,'f',NULL,NULL,'chartreuse') ON CONFLICT DO NOTHING RETURNING id"
+      end
     end
   end
 
   test "adapter dependent postgresql methods (no ignore, no update_duplicates)" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'PostgreSQL' do
+    stub_connection_if_needed(connection, 'PostgreSQL') do
       pgsql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -369,13 +396,19 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
 
       pgsql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') RETURNING id"
+      assert_statement_adapter pgsql_worker, 'BulkInsert::StatementAdapters::PostgreSQLAdapter'
+
+      if ActiveRecord::VERSION::STRING >= "5.0.0"
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse') RETURNING id"
+      else
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,'f',NULL,NULL,'chartreuse') RETURNING id"
+      end
     end
   end
 
   test "adapter dependent postgresql methods (with update_duplicates)" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'PostgreSQL' do
+    stub_connection_if_needed(connection, 'PostgreSQL') do
       pgsql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -388,13 +421,19 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
       )
       pgsql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') ON CONFLICT(greeting, age, happy) DO UPDATE SET greeting=EXCLUDED.greeting, age=EXCLUDED.age, happy=EXCLUDED.happy, created_at=EXCLUDED.created_at, updated_at=EXCLUDED.updated_at, color=EXCLUDED.color RETURNING id"
+      assert_statement_adapter pgsql_worker, 'BulkInsert::StatementAdapters::PostgreSQLAdapter'
+
+      if ActiveRecord::VERSION::STRING >= "5.0.0"
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse') ON CONFLICT(greeting, age, happy) DO UPDATE SET greeting=EXCLUDED.greeting, age=EXCLUDED.age, happy=EXCLUDED.happy, created_at=EXCLUDED.created_at, updated_at=EXCLUDED.updated_at, color=EXCLUDED.color RETURNING id"
+      else
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,'f',NULL,NULL,'chartreuse') ON CONFLICT(greeting, age, happy) DO UPDATE SET greeting=EXCLUDED.greeting, age=EXCLUDED.age, happy=EXCLUDED.happy, created_at=EXCLUDED.created_at, updated_at=EXCLUDED.updated_at, color=EXCLUDED.color RETURNING id"
+      end
     end
   end
 
   test "adapter dependent PostGIS methods" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'PostGIS' do
+    stub_connection_if_needed(connection, 'postgis') do
       pgsql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -407,41 +446,55 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
       )
       pgsql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') ON CONFLICT DO NOTHING RETURNING id"
+      assert_statement_adapter pgsql_worker, 'BulkInsert::StatementAdapters::PostgreSQLAdapter'
+
+      if ActiveRecord::VERSION::STRING >= "5.0.0"
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse') ON CONFLICT DO NOTHING RETURNING id"
+      else
+        assert_equal pgsql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,'f',NULL,NULL,'chartreuse') ON CONFLICT DO NOTHING RETURNING id"
+      end
     end
   end
 
   test "adapter dependent sqlite3 methods (with lowercase adapter name)" do
-    sqlite_worker = BulkInsert::Worker.new(
-      Testing.connection,
-      Testing.table_name,
-      'id',
-      %w(greeting age happy created_at updated_at color),
-      500, # batch size
-      true) # ignore
-    sqlite_worker.adapter_name = 'sqlite3'
-    sqlite_worker.add ["Yo", 15, false, nil, nil]
+    connection = Testing.connection
+    stub_connection_if_needed(connection, 'sqlite3') do
+      sqlite_worker = BulkInsert::Worker.new(
+        Testing.connection,
+        Testing.table_name,
+        'id',
+        %w(greeting age happy created_at updated_at color),
+        500, # batch size
+        true) # ignore
+      sqlite_worker.adapter_name = 'sqlite3'
+      sqlite_worker.add ["Yo", 15, false, nil, nil]
 
-    assert_equal sqlite_worker.compose_insert_query, "INSERT OR IGNORE INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
+      assert_statement_adapter sqlite_worker, 'BulkInsert::StatementAdapters::SQLiteAdapter'
+      assert_equal sqlite_worker.compose_insert_query, "INSERT OR IGNORE INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
+    end
   end
 
   test "adapter dependent sqlite3 methods (with stylecase adapter name)" do
-    sqlite_worker = BulkInsert::Worker.new(
-      Testing.connection,
-      Testing.table_name,
-      'id',
-      %w(greeting age happy created_at updated_at color),
-      500, # batch size
-      true) # ignore
-    sqlite_worker.adapter_name = 'SQLite'
-    sqlite_worker.add ["Yo", 15, false, nil, nil]
+    connection = Testing.connection
+    stub_connection_if_needed(connection, 'SQLite') do
+      sqlite_worker = BulkInsert::Worker.new(
+        connection,
+        Testing.table_name,
+        'id',
+        %w(greeting age happy created_at updated_at color),
+        500, # batch size
+        true) # ignore
+      sqlite_worker.adapter_name = 'SQLite'
+      sqlite_worker.add ["Yo", 15, false, nil, nil]
 
-    assert_equal sqlite_worker.compose_insert_query, "INSERT OR IGNORE INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
+      assert_statement_adapter sqlite_worker, 'BulkInsert::StatementAdapters::SQLiteAdapter'
+      assert_equal sqlite_worker.compose_insert_query, "INSERT OR IGNORE INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse')"
+    end
   end
 
   test "mysql adapter can update duplicates" do
     connection = Testing.connection
-    connection.stub :adapter_name, 'MySQL' do
+    stub_connection_if_needed(connection, 'mysql') do
       mysql_worker = BulkInsert::Worker.new(
         connection,
         Testing.table_name,
@@ -453,7 +506,12 @@ class BulkInsertWorkerTest < ActiveSupport::TestCase
       )
       mysql_worker.add ["Yo", 15, false, nil, nil]
 
-      assert_equal mysql_worker.compose_insert_query, "INSERT  INTO \"testings\" (\"greeting\",\"age\",\"happy\",\"created_at\",\"updated_at\",\"color\") VALUES ('Yo',15,0,NULL,NULL,'chartreuse') ON DUPLICATE KEY UPDATE `greeting`=VALUES(`greeting`), `age`=VALUES(`age`), `happy`=VALUES(`happy`), `created_at`=VALUES(`created_at`), `updated_at`=VALUES(`updated_at`), `color`=VALUES(`color`)"
+      assert_statement_adapter mysql_worker, 'BulkInsert::StatementAdapters::MySQLAdapter'
+      assert_equal mysql_worker.compose_insert_query, "INSERT  INTO `testings` (`greeting`,`age`,`happy`,`created_at`,`updated_at`,`color`) VALUES ('Yo',15,FALSE,NULL,NULL,'chartreuse') ON DUPLICATE KEY UPDATE `greeting`=VALUES(`greeting`), `age`=VALUES(`age`), `happy`=VALUES(`happy`), `created_at`=VALUES(`created_at`), `updated_at`=VALUES(`updated_at`), `color`=VALUES(`color`)"
     end
   end
+
+  def assert_statement_adapter(worker, adapter_name)
+    assert_equal worker.instance_variable_get(:@statement_adapter).class.to_s, adapter_name
+  end
 end

data/test/bulk_insert_test.rb

@@ -30,8 +30,16 @@ class BulkInsertTest < ActiveSupport::TestCase
   test "with option to return primary keys, worker should have result sets" do
     worker = Testing.bulk_insert(return_primary_keys: true)
     worker.add greeting: "yo"
-    worker.save!
-    assert_equal 1, worker.result_sets.count
+
+    # return_primary_keys is not supported for mysql and rails < 5
+    # this test ensures that the case is covered in the CI and handled as expected
+    if ActiveRecord::VERSION::STRING < "5.0.0" && worker.adapter_name =~ /^mysql/i
+      error = assert_raise(ArgumentError) { worker.save! }
+      assert_equal error.message, "BulkInsert does not support @return_primary_keys for mysql and rails < 5"
+    else
+      worker.save!
+      assert_equal 1, worker.result_sets.count
+    end
   end
 
   test "bulk_insert with array should save the array immediately" do

data/test/connection_mocks.rb

@@ -0,0 +1,140 @@
+module ConnectionMocks
+  DOUBLE_QUOTE_PROC = Proc.new do |value, *_column|
+    return value unless value.is_a? String
+    "\"#{value}\""
+  end
+
+  BACKTICK_QUOTE_PROC = Proc.new do |value, *_column|
+    return value unless value.is_a? String
+    '`' + value + '`'
+  end
+
+  BOOLEAN_VALUE_QUOTE_PROC = Proc.new do |value, *_column|
+    case value
+    when String
+      "'" + value + "'"
+    when TrueClass
+      'TRUE'
+    when FalseClass
+      'FALSE'
+    when NilClass
+      'NULL'
+    else
+      value
+    end
+  end
+
+  LITERAL_BOOLEAN_VALUE_QUOTE_PROC = Proc.new do |value, *_column|
+    case value
+    when String
+      "'" + value + "'"
+    when TrueClass
+      "'t'"
+    when FalseClass
+      "'f'"
+    when NilClass
+      'NULL'
+    else
+      value
+    end
+  end
+
+  DEFAULT_VALUE_QUOTE_PROC = Proc.new do |value, *_column|
+    case value
+    when String
+      "'" + value + "'"
+    when TrueClass
+      1
+    when FalseClass
+      0
+    when NilClass
+      'NULL'
+    else
+      value
+    end
+  end
+
+  ColumnMock = Struct.new(:name, :default)
+  COLUMNS_MOCK_PROC =  Proc.new do |*_table_name|
+    %w(id greeting age happy created_at updated_at color).zip(
+      [nil, nil, nil, nil, nil, nil, "chartreuse"]
+    ).map do |column_name, default|
+      ColumnMock.new(column_name, default)
+    end
+  end
+
+  MockTypeSerialize = Struct.new(:column) do
+    def serialize(value); value; end
+  end
+  CAST_COLUMN_MOCK_PROC = Proc.new do |column|
+    MockTypeSerialize.new(column)
+  end
+
+  def stub_connection_if_needed(connection, adapter_name)
+    raise "You need to provide a block" unless block_given?
+    if connection.adapter_name == adapter_name
+      yield
+    else
+      common_mocks(connection, adapter_name) do
+        case adapter_name
+        when /^mysql/i
+          mock_mysql_connection(connection, adapter_name) do
+            yield
+          end
+        when /\APost(?:greSQL|GIS)/i
+          mock_postgresql_connection(connection, adapter_name) do
+            yield
+          end
+        else
+          connection.stub :quote_table_name, DOUBLE_QUOTE_PROC do
+            connection.stub :quote_column_name, DOUBLE_QUOTE_PROC do
+              connection.stub :quote, DEFAULT_VALUE_QUOTE_PROC do
+                yield
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+
+  def common_mocks(connection, adapter_name)
+    connection.stub :adapter_name, adapter_name do
+      connection.stub :columns, COLUMNS_MOCK_PROC do
+        if ActiveRecord::VERSION::STRING >= "5.0.0"
+          connection.stub :lookup_cast_type_from_column, CAST_COLUMN_MOCK_PROC do
+            yield
+          end
+        else
+          yield
+        end
+      end
+    end
+  end
+
+  def mock_mysql_connection(connection, adapter_name)
+    connection.stub :quote_table_name, BACKTICK_QUOTE_PROC do
+      connection.stub :quote_column_name, BACKTICK_QUOTE_PROC do
+        connection.stub :quote, BOOLEAN_VALUE_QUOTE_PROC do
+          yield
+        end
+      end
+    end
+  end
+
+  def mock_postgresql_connection(connection, adapter_name)
+    connection.stub :quote_table_name, DOUBLE_QUOTE_PROC do
+      connection.stub :quote_column_name, DOUBLE_QUOTE_PROC do
+        if ActiveRecord::VERSION::STRING >= "5.0.0"
+          connection.stub :quote, BOOLEAN_VALUE_QUOTE_PROC do
+            yield
+          end
+        else
+          connection.stub :quote, LITERAL_BOOLEAN_VALUE_QUOTE_PROC do
+            yield
+          end
+        end
+      end
+    end
+  end
+end