bulk_dependency_eraser 4.2.1 → 4.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1ee041fa51d9506fdabf317bd2b72fab8be589073d5fa8c8940c6e5654a6bf6
-  data.tar.gz: 8d68033f0554c47a1818ce8e5f96ed047598c6dd3e302151e53589e3475ebdf8
+  metadata.gz: 5409fc52fbc918546360e196bd06c0be4837f0aa848af8a99aeed4015219f0e7
+  data.tar.gz: d3818d4f8c8e2a3be0c81c5e3b37bc0295d2e7ca077c08a45e7ae143975f2f3e
 SHA512:
-  metadata.gz: feae06d17b683a2a19518eca228fa04374265946cf308f45bd95c0e507fcf2a14cb74a79b45a03d03d7d5ad029769f85a68585234cb31c9ca2e45a38be6a80c7
-  data.tar.gz: 928c7bcc857f6ea3bc97165a93d11d7aaf74b15a90c5219e4bfb38137a22d27edf1edcacdc638b3d0bd39d14c91dfd92957663b2e3bb3cb9e473f997817d4080
+  metadata.gz: 14d334bd9f2baf4008a653c8f19b0544bc32e02e36dea965f6fa08ad3f317ca4e3bff5eb2417aeb70549a54d109341884d87c9af7591c2a258b018d6444d993d
+  data.tar.gz: 1f84b22cd3cfadf48d5450225c4cc3cbd4e3302acf15cd6c357904538b7427631a5d735621b3ecf4e574a31184525d9601630c9fd8c939d9e7f10fea6060e573

data/lib/bulk_dependency_eraser/builder.rb

@@ -192,12 +192,16 @@ module BulkDependencyEraser
         # If the query has a limit, then we don't want to clobber with batching.
         if batching_disabled? || !query.where({}).limit_value.nil?
           # query without batching
-          query_results = query.pluck(*columns)
+          # query_results = query.pluck(*columns)
+          query_results = query.pluck(*columns.collect{ |c| "#{query.klass.table_name}.#{c}"})
         elsif opts_c.disable_batch_ordering || opts_c.disable_batch_ordering_for_klasses.include?(current_klass_name)
           # query with orderless batching
           offset = 0
           loop do
-            new_query_results = query.offset(offset).limit(batch_size).pluck(*columns)
+            # This use-case didn't work. Rails converts the query filter to a left_outer_join, and can't then pull the CTID column in some use-cases
+            # new_query_results = query.offset(offset).limit(batch_size).pluck(*columns)
+            # This implementation does work. Prevents rails ORM from converting to a join
+            new_query_results = query.offset(offset).limit(batch_size).pluck(*columns.collect{ |c| "#{query.klass.table_name}.#{c}"})
             query_results += new_query_results
 
             break if new_query_results.size < batch_size
@@ -208,7 +212,8 @@ module BulkDependencyEraser
         else
           # query with ordered batching
           query.in_batches(of: batch_size) do |subset_query|
-            query_results += subset_query.pluck(*columns)
+            # query_results += subset_query.pluck(*columns)
+            query_results += subset_query.pluck(*columns.collect{ |c| "#{query.klass.table_name}.#{c}"})
           end
         end
       end
@@ -232,7 +237,8 @@ module BulkDependencyEraser
       query_primary_keys.each_with_index do |primary_key, plucked_index|
         query_additional_identifiers[primary_key] ||= {}
         results_per_additional_column.each do |column, column_results|
-          query_additional_identifiers[primary_key][column] = column_results[plucked_index]
+          # stringify the column key. All keys in the additional_identifiers are strings; The unification is nice and also JSONable.
+          query_additional_identifiers[primary_key][column.to_s] = column_results[plucked_index]
         end
       end
 

data/lib/bulk_dependency_eraser/version.rb

@@ -1,3 +1,3 @@
 module BulkDependencyEraser
-  VERSION = "4.2.1".freeze
+  VERSION = "4.2.3".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bulk_dependency_eraser
 version: !ruby/object:Gem::Version
-  version: 4.2.1
+  version: 4.2.3
 platform: ruby
 authors:
 - benjamin.dana.software.dev@gmail.com