bulk_dependency_eraser 4.2.0 → 4.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10daaabe21acb05d187dcf4c76fae13bd3e3b3aee727be9c6ebd0a315d581b54
-  data.tar.gz: d07c7a1303090c9e9291c19c8b6ec9974f2e9feee050e5962f63522ffd23c623
+  metadata.gz: 8efe5bca3c57d245dc00fcb0d04a57bab5dc9eb19d81e55be43a56e6adb7752c
+  data.tar.gz: b6b2d2bf30e7dd964d5032bd61ed1e57f820bec667dd3435c79567e24d6a0265
 SHA512:
-  metadata.gz: 2152f55aab950c36636bce7e67507ef6a5a27ee7b553a60727796550dc7e2bb489e1bc364beb47e8bce4adf1e0a778b5d5d7011631a77c8734035f85d77f1ded
-  data.tar.gz: 5889cd52acbcde3642db18e60f5958c189e4ecfc8066b635b33f5dfe5eb55810141244828be8043b1c19b403e773fde73dac302de6eabcf9147008e8f6191d85
+  metadata.gz: b7981de1665f8c6c7f7c2054c446a09edaa6add210481e091d2034f086eb9703bd619b23de29d03777bb8445b9fc7902329af8ce262204510e0e7695ebe380be
+  data.tar.gz: 42cfbfdb8ad934d9b4d1a806e9da158e82a2ddb2b38cbee790423c5ff046aa3517370f12bd6e5cad00f6ec7db57fb6ee3082bbcb6faefadc866f6332919a6143

data/lib/bulk_dependency_eraser/builder.rb

@@ -232,7 +232,8 @@ module BulkDependencyEraser
       query_primary_keys.each_with_index do |primary_key, plucked_index|
         query_additional_identifiers[primary_key] ||= {}
         results_per_additional_column.each do |column, column_results|
-          query_additional_identifiers[primary_key][column] = column_results[plucked_index]
+          # stringify the column key. All keys in the additional_identifiers are strings; The unification is nice and also JSONable.
+          query_additional_identifiers[primary_key][column.to_s] = column_results[plucked_index]
         end
       end
 

data/lib/bulk_dependency_eraser/deleter.rb

@@ -58,7 +58,7 @@ module BulkDependencyEraser
 
     def initialize class_names_and_ids: {}, additional_identifiers_by_id: {}, opts: {}
       @class_names_and_ids = class_names_and_ids
-      @additional_identifiers_by_id = additional_identifiers_by_id
+      @additional_identifiers_by_id = additional_identifiers_by_id || {}
       super(opts:)
     end
 
@@ -73,7 +73,8 @@ module BulkDependencyEraser
           class_names_and_ids.keys.reverse.each do |class_name|
             current_class_name = class_name
             additional_identifiers = additional_identifiers_by_id[class_name]
-            raise "invalid state! #{class_name} not found in 'additional_identifiers_by_id' list" if additional_identifiers.nil?
+            # We have to give implementers the ability to make changes to these lists. Even a full clear.
+            # raise "invalid state! #{class_name} not found in 'additional_identifiers_by_id' list" if additional_identifiers.nil?
 
             # Last in, First out
             ids = class_names_and_ids[class_name].reverse
@@ -128,6 +129,7 @@ module BulkDependencyEraser
       opts_c.disable_delete_batching.nil? ? opts_c.disable_batching : opts_c.disable_delete_batching
     end
 
+    # @param additional_identifiers [Hash] can be nil, if chosen to be so by implementers
     def delete_by_klass_and_ids(klass, ids, additional_identifiers:)
       puts "Deleting #{klass.name}'s IDs: #{ids}" if opts_c.verbose
       query = klass.unscoped
@@ -136,7 +138,7 @@ module BulkDependencyEraser
       if batching_disabled?
         puts "Deleting without batching" if opts_c.verbose
         # Get column-names/keys of any additional identifer columns
-        detected_additional_identifier_columns = additional_identifiers.values.flat_map(&:keys).uniq
+        detected_additional_identifier_columns = additional_identifiers&.values&.flat_map(&:keys)&.uniq || []
         delete_in_db do
           deletion_query = query.where(id: ids)
           # Apply any additional query identifiers (i.e. :ctid column)
@@ -154,9 +156,9 @@ module BulkDependencyEraser
       else
         puts "Deleting with batching" if opts_c.verbose
         ids.each_slice(batch_size) do |ids_subset|
-          additional_identifiers_subset = additional_identifiers.slice(*ids_subset)
+          additional_identifiers_subset = additional_identifiers&.slice(*ids_subset)
           # Get column-names/keys of any additional identifer columns
-          detected_additional_identifier_columns = additional_identifiers_subset.values.flat_map(&:keys).uniq
+          detected_additional_identifier_columns = additional_identifiers_subset&.values&.flat_map(&:keys)&.uniq || []
           delete_in_db do
             deletion_query = query.where(id: ids_subset)
             # Apply any additional query identifiers (i.e. :ctid column)

data/lib/bulk_dependency_eraser/version.rb

@@ -1,3 +1,3 @@
 module BulkDependencyEraser
-  VERSION = "4.2.0".freeze
+  VERSION = "4.2.2".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bulk_dependency_eraser
 version: !ruby/object:Gem::Version
-  version: 4.2.0
+  version: 4.2.2
 platform: ruby
 authors:
 - benjamin.dana.software.dev@gmail.com