bulk_dependency_eraser 1.0.4 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc034a38ab80a2e277860a5a69f6a654e1e461f691f54d6a510814b55279cebd
-  data.tar.gz: 88055bcbcb73bc260ef4718006f3149d95ea216badb4bd4ac142506e756c1882
+  metadata.gz: dc49b9b507510ed728ba6434832c29c44d76fe144ee4b738a7f5ade224caf0d2
+  data.tar.gz: 3437d5c44ca6ae2aaaf6d5e283da42d7267e5df2f378ef7abf7a72b63662cc5e
 SHA512:
-  metadata.gz: 0c9d1bc7851eaa2f51a853a99b24ff3842940f792938b2eac86ebfcc6471653c0d14de735d837f108ca59118a6661c086566b48475b87f1c98870cd80544dd79
-  data.tar.gz: 7e09f55e2baf0db2eefd7f2dfc028fda58b7f9ec2469a6bdbcfa56855bd4cf1ddc0b1502468554f56726fcbd08135daecc5e20940d18b2d9a2f49dc2558c5971
+  metadata.gz: 8f15ccf36462a1fa821843dd5b05144e078be9a624620b297c02b0bb9e4252b997c0db56ae7546962163559a4f141eeaa2c3be571e1edafb5faa41cb1c83c563
+  data.tar.gz: 6a72116ef8842358a7de07f461cae3a3fbb2b6bfce2a0b725dd373534480a84fd69e81c18838178bea8d65788039671244c76df2d1669bc470687354929c130d

data/lib/bulk_dependency_eraser/builder.rb

@@ -48,7 +48,8 @@ module BulkDependencyEraser
       'ActiveRecord::Reflection::HasAndBelongsToManyReflection'
     ].freeze
 
-    attr_reader :deletion_list, :nullification_list
+    # write access so that these can be edited in-place by end-users who might need to manually adjust deletion order.
+    attr_accessor :deletion_list, :nullification_list
     attr_reader :ignore_table_deletion_list, :ignore_table_nullification_list
 
     def initialize query:, opts: {}
@@ -260,7 +261,7 @@ module BulkDependencyEraser
       when 'ActiveRecord::Reflection::HasManyReflection'
         association_parser_has_many(parent_class, query, query_ids, association_name, type)
       when 'ActiveRecord::Reflection::HasOneReflection'
-        association_parser_has_many(parent_class, query, query_ids, association_name, type, { limit: 1 })
+        association_parser_has_many(parent_class, query, query_ids, association_name, type)
       when 'ActiveRecord::Reflection::BelongsToReflection'
         if type == :nullify
           report_error("#{parent_class.name}'s association '#{association_name}' - dependent 'nullify' invalid for 'belongs_to'")
@@ -347,10 +348,11 @@ module BulkDependencyEraser
         assoc_query = assoc_query.where(specified_foreign_key.to_sym => query_ids)
       end
 
-      # Apply limit if has_one assocation (subset of has_many)
-      if opts[:limit]
-        assoc_query = assoc_query.limit(opts[:limit])
-      end
+      # Works in theory for ONE record's has_one, but we're dealing with potentially many
+      # # Apply limit if has_one assocation (subset of has_many)
+      # if opts[:limit]
+      #   assoc_query = assoc_query.limit(opts[:limit])
+      # end
 
       if type == :delete
         # Recursively call 'deletion_query_parser' on association query, to delete any if the assoc's dependencies

data/lib/bulk_dependency_eraser/version.rb

@@ -0,0 +1,3 @@
+module BulkDependencyEraser
+  VERSION = "1.1.0".freeze
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bulk_dependency_eraser
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.1.0
 platform: ruby
 authors:
 - benjamin.dana.software.dev@gmail.com
@@ -148,6 +148,7 @@ files:
 - lib/bulk_dependency_eraser/deleter.rb
 - lib/bulk_dependency_eraser/manager.rb
 - lib/bulk_dependency_eraser/nullifier.rb
+- lib/bulk_dependency_eraser/version.rb
 homepage: https://github.com/danabr75/bulk_dependency_eraser
 licenses:
 - LGPL-3.0-only