buildr 1.3.5 → 1.4.0

data/spec/core/test_spec.rb

@@ -110,12 +110,22 @@ describe Buildr::TestTask do
     test_task.compile.dependencies.should include(artifact('acme:example:jar:1.0'))
   end
 
+  it 'should respond to deprecated classpath' do
+    test_task.classpath = artifact('acme:example:jar:1.0')
+    test_task.classpath.should be(artifact('acme:example:jar:1.0'))
+  end
+
+  it 'should respond to dependencies' do
+    test_task.dependencies = artifact('acme:example:jar:1.0')
+    test_task.dependencies.should be(artifact('acme:example:jar:1.0'))
+  end
+
   it 'should respond to :with and add artifacfs to task dependencies' do
     test_task.with 'test.jar', 'acme:example:jar:1.0'
     test_task.dependencies.should include(File.expand_path('test.jar'))
     test_task.dependencies.should include(artifact('acme:example:jar:1.0'))
   end
-  
+
   it 'should response to :options and return test framework options' do
     test_task.using :foo=>'bar'
     test_task.options[:foo].should eql('bar')
@@ -216,9 +226,9 @@ describe Buildr::TestTask do
     define('foo').test.dependencies.should include(project('foo').resources.target)
   end
 
-  it 'should not use the test compile dependencies' do
+  it 'should use the test compile dependencies' do
     define('foo') { test.compile.using(:javac).with 'group:id:jar:1.0' }
-    project('foo').test.dependencies.should_not include(artifact('group:id:jar:1.0'))
+    project('foo').test.dependencies.should include(artifact('group:id:jar:1.0'))
   end
 
   it 'should include the test compile target in its dependencies' do
@@ -252,7 +262,7 @@ describe Buildr::TestTask do
     depends = project('foo').test.dependencies
     depends.index(project('foo').test.resources.target).should < depends.index(project('foo').resources.target)
   end
-  
+
   it 'should not have a last successful run timestamp before the tests are run' do
     test_task.timestamp.should == Rake::EARLY
   end
@@ -268,6 +278,14 @@ describe Buildr::TestTask do
     mkpath project('foo').test.report_to.to_s
     lambda { task('clean').invoke }.should change { File.exist?(project('foo').test.report_to.to_s) }.to(false)
   end
+
+  it 'should only run tests explicitly specified if options.test is :only' do
+    Buildr.options.test = :only
+    write 'bar/src/main/java/Bar.java', 'public class Bar {}'
+    define('bar', :version=>'1.0', :base_dir=>'bar') { package :jar }
+    define('foo') { compile.with project('bar') }
+    lambda { task('foo:test').invoke rescue nil }.should_not run_tasks('bar:test')
+  end
 end
 
 
@@ -279,7 +297,7 @@ describe Buildr::TestTask, 'with no tests' do
   it 'should report no failed tests' do
     lambda { verbose(true) { define('foo').test.invoke } }.should_not show_error(/fail/i)
   end
-  
+
   it 'should return no failed tests' do
     define('foo') { test.using(:junit) }
     project('foo').test.invoke
@@ -319,7 +337,7 @@ describe Buildr::TestTask, 'with passing tests' do
   it 'should report no failed tests' do
     lambda { verbose(true) { test_task.invoke } }.should_not show_error(/fail/i)
   end
-  
+
   it 'should return passed tests' do
     test_task.invoke
     test_task.passed_tests.should == ['PassingTest1', 'PassingTest2']
@@ -343,7 +361,7 @@ end
 
 describe Buildr::TestTask, 'with failed test' do
   include TestHelper
-  
+
   def test_task
     @test_task ||= begin
       define 'foo' do
@@ -365,6 +383,11 @@ describe Buildr::TestTask, 'with failed test' do
     lambda { verbose(true) { test_task.invoke rescue nil } }.should show_error(/FailingTest/)
   end
 
+  it 'should record failed tests' do
+    test_task.invoke rescue nil
+    File.read(project('foo').path_to('target', "#{test_task.framework}-failed")).should == 'FailingTest'
+  end
+
   it 'should return failed tests' do
     test_task.invoke rescue nil
     test_task.failed_tests.should == ['FailingTest']
@@ -375,6 +398,11 @@ describe Buildr::TestTask, 'with failed test' do
     test_task.passed_tests.should == ['PassingTest']
   end
 
+  it 'should know what tests failed last time' do
+    test_task.invoke rescue nil
+    project('foo').test.last_failures.should == ['FailingTest']
+  end
+
   it 'should not fail if fail_on_failure is false' do
     test_task.using(:fail_on_failure=>false).invoke
     lambda { test_task.invoke }.should_not raise_error
@@ -393,7 +421,7 @@ describe Buildr::TestTask, 'with failed test' do
   it 'should execute teardown task' do
     lambda { test_task.invoke rescue nil }.should run_task('foo:test:teardown')
   end
-  
+
   it 'should not update the last successful run timestamp' do
     a_second_ago = Time.now - 1
     touch_last_successful_test_run test_task, a_second_ago
@@ -460,7 +488,7 @@ describe Buildr::Project, '#test' do
       test.options[:environment].should == {}
     end
   end
-  
+
   it 'should clone options from parent project when using #options' do
     define 'foo' do
       define 'bar' do
@@ -476,14 +504,14 @@ describe Buildr::Project, '#test' do
       test.options[:environment].should == {}
     end
   end
-  
+
   it 'should accept to set a test property in the top project' do
     define 'foo' do
         test.options[:properties][:foo] = 'bar'
     end
     project('foo').test.options[:properties][:foo].should == 'bar'
   end
-  
+
   it 'should accept to set a test property in a subproject' do
     define 'foo' do
       define 'bar' do
@@ -492,7 +520,7 @@ describe Buildr::Project, '#test' do
     end
     project('foo:bar').test.options[:properties][:bar].should == 'baz'
   end
-  
+
   it 'should not change options of unrelated projects when using #options' do
     define 'foo' do
       test.options[:properties][:foo] = 'bar'
@@ -501,7 +529,7 @@ describe Buildr::Project, '#test' do
       test.options[:properties].should == {}
     end
   end
-  
+
   it "should run from project's build task" do
     write 'src/main/java/Foo.java'
     write 'src/test/java/FooTest.java'
@@ -584,7 +612,9 @@ describe Buildr::Project, '#test.resources' do
   end
 
   it 'should create target directory even if no files to copy' do
-    define('foo').test.resources.filter.into('resources')
+    define('foo') do
+      test.resources.filter.into('resources')
+    end
     lambda { file(File.expand_path('resources')).invoke }.should change { File.exist?('resources') }.to(true)
   end
 
@@ -598,7 +628,7 @@ end
 
 describe Buildr::TestTask, '#invoke' do
   include TestHelper
-  
+
   def test_task
     @test_task ||= define('foo') {
       test.using(:junit)
@@ -608,7 +638,7 @@ describe Buildr::TestTask, '#invoke' do
       end
     }.test
   end
-  
+
   it 'should require dependencies to exist' do
     lambda { test_task.with('no-such.jar').invoke }.should \
       raise_error(RuntimeError, /Don't know how to build/)
@@ -622,12 +652,12 @@ describe Buildr::TestTask, '#invoke' do
   it 'should run tests if they have never run' do
     lambda { test_task.invoke }.should run_task('foo:test')
   end
-  
+
   it 'should not run tests if test option is off' do
     Buildr.options.test = false
     lambda { test_task.invoke }.should_not run_task('foo:test')
   end
-  
+
   describe 'when there was a successful test run already' do
     before do
       @a_second_ago = Time.now - 1
@@ -635,57 +665,69 @@ describe Buildr::TestTask, '#invoke' do
       target = ['classes/Foo.class', 'resources/config.xml', 'test/classes/FooTest.class', 'test/resources/config-test.xml'].map { |f| File.join('target', f) }
       files = ['buildfile'] + src + target
       files.each { |file| write file }
-      (files + files.map { |file| file.pathmap('%d') }).each { |file| File.utime(@a_second_ago, @a_second_ago, file) }
+      dirs = (src + target).map { |file| file.pathmap('%d') }
+      (files + dirs ).each { |path| File.utime(@a_second_ago, @a_second_ago, path) }
       touch_last_successful_test_run test_task, @a_second_ago
     end
-    
+
     it 'should not run tests if nothing changed' do
       lambda { test_task.invoke }.should_not run_task('foo:test')
     end
-    
+
     it 'should run tests if options.test is :all' do
       Buildr.options.test = :all
       lambda { test_task.invoke }.should run_task('foo:test')
     end
-    
+
     it 'should run tests if main compile target changed' do
       touch project('foo').compile.target.to_s
       lambda { test_task.invoke }.should run_task('foo:test')
     end
-    
+
     it 'should run tests if test compile target changed' do
       touch test_task.compile.target.to_s
       lambda { test_task.invoke }.should run_task('foo:test')
     end
-    
+
     it 'should run tests if main resources changed' do
       touch project('foo').resources.target.to_s
       lambda { test_task.invoke }.should run_task('foo:test')
     end
-    
+
     it 'should run tests if test resources changed' do
       touch test_task.resources.target.to_s
       lambda { test_task.invoke }.should run_task('foo:test')
     end
-    
+
     it 'should run tests if compile-dependent project changed' do
       write 'bar/src/main/java/Bar.java', 'public class Bar {}'
       define('bar', :version=>'1.0', :base_dir=>'bar') { package :jar }
       project('foo').compile.with project('bar')
       lambda { test_task.invoke }.should run_task('foo:test')
     end
-    
+
     it 'should run tests if test-dependent project changed' do
       write 'bar/src/main/java/Bar.java', 'public class Bar {}'
       define('bar', :version=>'1.0', :base_dir=>'bar') { package :jar }
       test_task.with project('bar')
       lambda { test_task.invoke }.should run_task('foo:test')
     end
-    
+
     it 'should run tests if buildfile changed' do
       touch 'buildfile'
+      test_task.should_receive(:run_tests)
       lambda { test_task.invoke }.should run_task('foo:test')
     end
+
+    it 'should not run tests if buildfile changed but IGNORE_BUILDFILE is true' do
+      begin
+        ENV["IGNORE_BUILDFILE"] = "true"
+        test_task.should_not_receive(:run_tests)
+        test_task.invoke
+      ensure
+        ENV["IGNORE_BUILDFILE"] = nil
+      end
+    end
   end
 end
 
@@ -713,9 +755,38 @@ describe Rake::Task, 'test' do
   it 'should ignore failure if options.test is :all' do
     define('foo') { test { fail } }
     define('bar') { test { fail } }
-    options.test = :all 
+    options.test = :all
     lambda { task('test').invoke rescue nil }.should run_tasks('foo:test', 'bar:test')
   end
+  
+  it 'should ignore failure in subprojects if options.test is :all' do
+    define('foo') {
+      define('p1') { test { fail } } 
+      define('p2') { test {  } } 
+      define('p3') { test { fail } } 
+    }
+    define('bar') { test { fail } } 
+    options.test = :all
+    lambda { task('test').invoke rescue nil }.should run_tasks('foo:p1:test', 'foo:p2:test', 'foo:p3:test', 'bar:test')
+  end
+  
+  it 'should ignore failure in subprojects if environment variable test is \'all\'' do
+    define('foo') {
+      define('p1') { test { fail } } 
+      define('p2') { test {  } } 
+      define('p3') { test { fail } } 
+    }
+    define('bar') { test { fail } } 
+    ENV['test'] = 'all'
+    lambda { task('test').invoke rescue nil }.should run_tasks('foo:p1:test', 'foo:p2:test', 'foo:p3:test', 'bar:test')
+  end
+
+  it 'should ignore failure if options.test is :all and target is build task ' do
+    define('foo') { test { fail } }
+    define('bar') { test { fail } }
+    options.test = :all
+    lambda { task('build').invoke rescue nil }.should run_tasks('foo:test', 'bar:test')
+  end
 
   it 'should ignore failure if environment variable test is \'all\'' do
     define('foo') { test { fail } }
@@ -751,12 +822,18 @@ describe Rake::Task, 'test' do
     ENV['TEST'] = 'no'
     lambda { task('test').invoke rescue nil }.should_not run_tasks('foo:test', 'bar:test')
   end
-end
 
+  it "should not compile tests if environment variable test is 'no'" do
+    write "src/test/java/HelloTest.java", "public class HelloTest { public void testTest() {}}"
+    define('foo') { test { fail } }
+    ENV['test'] = 'no'
+    lambda { task('test').invoke rescue nil }.should_not run_tasks('foo:test:compile')
+  end
+end
 
 describe 'test rule' do
   include TestHelper
-  
+
   it 'should execute test task on local project' do
     define('foo') { define 'bar' }
     lambda { task('test:something').invoke }.should run_task('foo:test')
@@ -816,7 +893,7 @@ describe 'test rule' do
     define 'foo'
     task('test:Something').invoke
   end
-  
+
   it 'should execute the named tests even if the test task is not needed' do
     define 'foo' do
       test.using(:junit)
@@ -826,7 +903,7 @@ describe 'test rule' do
     task('test:something').invoke
     project('foo').test.tests.should include('something')
   end
-  
+
   it 'should not update the last successful test run timestamp' do
     define 'foo' do
       test.using(:junit)
@@ -839,6 +916,38 @@ describe 'test rule' do
   end
 end
 
+describe 'test failed' do
+  include TestHelper
+
+  def test_task
+    @test_task ||= begin
+      define 'foo' do
+        test.using(:junit)
+        test.instance_eval do
+          @framework.stub!(:tests).and_return(['FailingTest', 'PassingTest'])
+          @framework.stub!(:run).and_return(['PassingTest'])
+        end
+      end
+      project('foo').test
+    end
+  end
+
+  it 'should run the tests that failed the last time' do
+    define 'foo' do
+      test.using(:junit)
+      test.instance_eval do
+        @framework.stub!(:tests).and_return(['FailingTest', 'PassingTest'])
+        @framework.stub!(:run).and_return(['PassingTest'])
+      end
+    end
+    write project('foo').path_to(:target, "junit-failed"), "FailingTest"
+    task('test:failed').invoke rescue nil
+    project('foo').test.tests.should include('FailingTest')
+    project('foo').test.tests.should_not include('PassingTest')
+  end
+
+end
+
 
 describe Buildr::Options, 'test' do
   it 'should be true by default' do
@@ -972,7 +1081,7 @@ describe Rake::Task, 'integration' do
   end
 
   it 'should run test cases marked for integration' do
-    write 'src/test/java/FailingTest.java', 
+    write 'src/test/java/FailingTest.java',
       'public class FailingTest extends junit.framework.TestCase { public void testNothing() { assertTrue(false); } }'
     define('foo') { test.using :integration }
     lambda { task('test').invoke }.should_not raise_error
@@ -996,7 +1105,7 @@ describe Rake::Task, 'integration' do
   end
 
   it 'should not fail if test=all' do
-    write 'src/test/java/FailingTest.java', 
+    write 'src/test/java/FailingTest.java',
       'public class FailingTest extends junit.framework.TestCase { public void testNothing() { assertTrue(false); } }'
     define('foo') { test.using :integration }
     options.test = :all

data/spec/core/transport_spec.rb

@@ -20,7 +20,7 @@ require File.join(File.dirname(__FILE__), '../spec_helpers')
 describe URI, '#download' do
   before do
     write @source = 'source', @content = 'Just a file'
-    @uri = URI("file://#{File.expand_path(@source)}")
+    @uri = URI(URI.escape("file://#{File.expand_path(@source)}"))
     @target = 'target'
   end
 
@@ -60,7 +60,7 @@ describe URI, '#upload' do
   before do
     write @source = 'source', @content = 'Just a file'
     @target = 'target'
-    @uri = URI("file://#{File.expand_path(@target)}")
+    @uri = URI(URI.escape("file://#{File.expand_path(@target)}"))
   end
 
   it 'should upload file if found' do
@@ -149,7 +149,7 @@ end
 describe URI::FILE, '#read' do
   before do
     @filename = 'readme'
-    @uri = URI("file:///#{File.expand_path(@filename)}")
+    @uri = URI(URI.escape("file:///#{File.expand_path(@filename)}"))
     @content = 'Readme. Please!'
     write 'readme', @content
   end
@@ -180,7 +180,7 @@ end
 describe URI::FILE, '#write' do
   before do
     @filename = 'readme'
-    @uri = URI("file:///#{File.expand_path(@filename)}")
+    @uri = URI(URI.escape("file:///#{File.expand_path(@filename)}"))
     @content = 'Readme. Please!'
   end
 
@@ -240,7 +240,7 @@ describe URI::HTTP, '#read' do
     @http.should_receive(:use_ssl=).with(true)
     URI(@uri.to_s.sub(/http/, 'https')).read
   end
-  
+
   it 'should use proxy from environment variable HTTP_PROXY when using http' do
     ENV['HTTP_PROXY'] = @proxy
     Net::HTTP.should_receive(:new).with(*@proxy_args).and_return(@http)
@@ -312,7 +312,7 @@ describe URI::HTTP, '#read' do
     request.should_receive(:basic_auth).with('john', 'secret')
     URI("http://john:secret@#{@host_domain}").read
   end
- 
+
   it 'should preseve authentication information during a redirect' do
     Net::HTTP.should_receive(:new).twice.and_return(@http)
 
@@ -324,7 +324,7 @@ describe URI::HTTP, '#read' do
     Net::HTTP::Get.should_receive(:new).once.with('/', nil).and_return(request1)
     request1.should_receive(:basic_auth).with('john', 'secret')
     @http.should_receive(:request).with(request1).and_yield(redirect)
- 
+
     # The second request will be ok
     ok = Net::HTTPOK.new(nil, nil, nil)
     ok.stub!(:read_body)
@@ -503,7 +503,7 @@ describe URI::SFTP, '#write' do
   end
 
   it 'should close all opened directories' do
-    @sftp_session.should_receive(:opendir!).with(anything()).twice do |path| 
+    @sftp_session.should_receive(:opendir!).with(anything()).twice do |path|
       @sftp_session.should_receive(:close).with(handle = Object.new)
       handle
     end

data/spec/core/util_spec.rb

@@ -21,7 +21,7 @@ describe Hash do
     it "should find value for one key" do
       {:a => 1, :b => 2, :c => 3}.only(:a).should == {:a => 1}
     end
-    
+
     it "should find values for multiple keys" do
       {:a => 1, :b => 2, :c => 3}.only(:b, :c).should == {:b => 2, :c => 3}
     end
@@ -36,19 +36,19 @@ describe OpenObject do
   it "should be kind of Hash" do
     Hash.should === @obj
   end
-  
+
   it "should accept block that supplies default value" do
     obj = OpenObject.new { |hash, key| hash[key] = "New #{key}" }
     obj[:foo].should == "New foo"
     obj.keys.should == [:foo]
   end
-  
+
   it "should combine initial values from hash argument and from block" do
     obj = OpenObject.new(:a => 6, :b => 2) { |h, k| h[k] = k.to_s * 2 }
     obj[:a].should == 6
     obj[:c].should == 'cc'
   end
-  
+
   it "should allow reading a value by calling its name method" do
     @obj.b.should == 2
   end
@@ -60,8 +60,66 @@ describe OpenObject do
   it "should allow changing a value by calling its name= method" do
     lambda { @obj.c = 17 }.should change { @obj.c }.to(17)
   end
-    
+
   it "should implement only method like a hash" do
     @obj.only(:a).should == { :a => 1 }
   end
 end
+
+describe File do
+  # Quite a few of the other specs depend on File#utime working correctly.
+  # These specs validate that utime is working as expected. 
+  describe "#utime" do
+    it "should update mtime of directories" do
+      mkpath 'tmp'
+      begin
+        creation_time = File.mtime('tmp')
+
+        sleep 1
+        File.utime(nil, nil, 'tmp')
+
+        File.mtime('tmp').should > creation_time
+      ensure
+        Dir.rmdir 'tmp'
+      end
+    end
+
+    it "should update mtime of files" do
+      FileUtils.touch('tmp')
+      begin
+        creation_time = File.mtime('tmp')
+
+        sleep 1
+        File.utime(nil, nil, 'tmp')
+
+        File.mtime('tmp').should > creation_time
+      ensure
+        File.delete 'tmp'
+      end
+    end
+
+    it "should be able to set mtime in the past" do
+      FileUtils.touch('tmp')
+      begin
+        time = Time.at((Time.now - 10).to_i)
+        File.utime(time, time, 'tmp')
+
+        File.mtime('tmp').should == time
+      ensure
+        File.delete 'tmp'
+      end
+    end
+
+    it "should be able to set mtime in the future" do
+      FileUtils.touch('tmp')
+      begin
+        time = Time.at((Time.now + 10).to_i)
+        File.utime(time, time, 'tmp')
+
+        File.mtime('tmp').should == time
+      ensure
+        File.delete 'tmp'
+      end
+    end
+  end
+end

data/spec/groovy/bdd_spec.rb

@@ -17,7 +17,7 @@ require File.join(File.dirname(__FILE__), '../spec_helpers')
 
 
 describe Buildr::Groovy::EasyB do
-  
+
   def foo(*args, &prc)
     define('foo', *args) do
       test.using :easyb
@@ -58,9 +58,9 @@ describe Buildr::Groovy::EasyB do
       test.compile.language.should eql(:java)
     end
   end
-  
+
   it 'should include src/spec/groovy/*Specification.groovy' do
-    foo do 
+    foo do
       spec = _('src/spec/groovy/SomeSpecification.groovy')
       write spec, 'true'
       test.invoke
@@ -69,12 +69,12 @@ describe Buildr::Groovy::EasyB do
   end
 
   it 'should include src/spec/groovy/*Story.groovy' do
-    foo do 
+    foo do
       spec = _('src/spec/groovy/SomeStory.groovy')
       write spec, 'true'
       test.invoke
       test.tests.should include(spec)
     end
   end
-  
+
 end # EasyB