buildr 1.3.5-java → 1.4.0-java

data/spec/core/transport_spec.rb

@@ -20,7 +20,7 @@ require File.join(File.dirname(__FILE__), '../spec_helpers')
 describe URI, '#download' do
   before do
     write @source = 'source', @content = 'Just a file'
-    @uri = URI("file://#{File.expand_path(@source)}")
+    @uri = URI(URI.escape("file://#{File.expand_path(@source)}"))
     @target = 'target'
   end
 
@@ -60,7 +60,7 @@ describe URI, '#upload' do
   before do
     write @source = 'source', @content = 'Just a file'
     @target = 'target'
-    @uri = URI("file://#{File.expand_path(@target)}")
+    @uri = URI(URI.escape("file://#{File.expand_path(@target)}"))
   end
 
   it 'should upload file if found' do
@@ -149,7 +149,7 @@ end
 describe URI::FILE, '#read' do
   before do
     @filename = 'readme'
-    @uri = URI("file:///#{File.expand_path(@filename)}")
+    @uri = URI(URI.escape("file:///#{File.expand_path(@filename)}"))
     @content = 'Readme. Please!'
     write 'readme', @content
   end
@@ -180,7 +180,7 @@ end
 describe URI::FILE, '#write' do
   before do
     @filename = 'readme'
-    @uri = URI("file:///#{File.expand_path(@filename)}")
+    @uri = URI(URI.escape("file:///#{File.expand_path(@filename)}"))
     @content = 'Readme. Please!'
   end
 
@@ -240,7 +240,7 @@ describe URI::HTTP, '#read' do
     @http.should_receive(:use_ssl=).with(true)
     URI(@uri.to_s.sub(/http/, 'https')).read
   end
-  
+
   it 'should use proxy from environment variable HTTP_PROXY when using http' do
     ENV['HTTP_PROXY'] = @proxy
     Net::HTTP.should_receive(:new).with(*@proxy_args).and_return(@http)
@@ -312,7 +312,7 @@ describe URI::HTTP, '#read' do
     request.should_receive(:basic_auth).with('john', 'secret')
     URI("http://john:secret@#{@host_domain}").read
   end
- 
+
   it 'should preseve authentication information during a redirect' do
     Net::HTTP.should_receive(:new).twice.and_return(@http)
 
@@ -324,7 +324,7 @@ describe URI::HTTP, '#read' do
     Net::HTTP::Get.should_receive(:new).once.with('/', nil).and_return(request1)
     request1.should_receive(:basic_auth).with('john', 'secret')
     @http.should_receive(:request).with(request1).and_yield(redirect)
- 
+
     # The second request will be ok
     ok = Net::HTTPOK.new(nil, nil, nil)
     ok.stub!(:read_body)
@@ -503,7 +503,7 @@ describe URI::SFTP, '#write' do
   end
 
   it 'should close all opened directories' do
-    @sftp_session.should_receive(:opendir!).with(anything()).twice do |path| 
+    @sftp_session.should_receive(:opendir!).with(anything()).twice do |path|
       @sftp_session.should_receive(:close).with(handle = Object.new)
       handle
     end

data/spec/core/util_spec.rb

@@ -21,7 +21,7 @@ describe Hash do
     it "should find value for one key" do
       {:a => 1, :b => 2, :c => 3}.only(:a).should == {:a => 1}
     end
-    
+
     it "should find values for multiple keys" do
       {:a => 1, :b => 2, :c => 3}.only(:b, :c).should == {:b => 2, :c => 3}
     end
@@ -36,19 +36,19 @@ describe OpenObject do
   it "should be kind of Hash" do
     Hash.should === @obj
   end
-  
+
   it "should accept block that supplies default value" do
     obj = OpenObject.new { |hash, key| hash[key] = "New #{key}" }
     obj[:foo].should == "New foo"
     obj.keys.should == [:foo]
   end
-  
+
   it "should combine initial values from hash argument and from block" do
     obj = OpenObject.new(:a => 6, :b => 2) { |h, k| h[k] = k.to_s * 2 }
     obj[:a].should == 6
     obj[:c].should == 'cc'
   end
-  
+
   it "should allow reading a value by calling its name method" do
     @obj.b.should == 2
   end
@@ -60,8 +60,66 @@ describe OpenObject do
   it "should allow changing a value by calling its name= method" do
     lambda { @obj.c = 17 }.should change { @obj.c }.to(17)
   end
-    
+
   it "should implement only method like a hash" do
     @obj.only(:a).should == { :a => 1 }
   end
 end
+
+describe File do
+  # Quite a few of the other specs depend on File#utime working correctly.
+  # These specs validate that utime is working as expected. 
+  describe "#utime" do
+    it "should update mtime of directories" do
+      mkpath 'tmp'
+      begin
+        creation_time = File.mtime('tmp')
+
+        sleep 1
+        File.utime(nil, nil, 'tmp')
+
+        File.mtime('tmp').should > creation_time
+      ensure
+        Dir.rmdir 'tmp'
+      end
+    end
+
+    it "should update mtime of files" do
+      FileUtils.touch('tmp')
+      begin
+        creation_time = File.mtime('tmp')
+
+        sleep 1
+        File.utime(nil, nil, 'tmp')
+
+        File.mtime('tmp').should > creation_time
+      ensure
+        File.delete 'tmp'
+      end
+    end
+
+    it "should be able to set mtime in the past" do
+      FileUtils.touch('tmp')
+      begin
+        time = Time.at((Time.now - 10).to_i)
+        File.utime(time, time, 'tmp')
+
+        File.mtime('tmp').should == time
+      ensure
+        File.delete 'tmp'
+      end
+    end
+
+    it "should be able to set mtime in the future" do
+      FileUtils.touch('tmp')
+      begin
+        time = Time.at((Time.now + 10).to_i)
+        File.utime(time, time, 'tmp')
+
+        File.mtime('tmp').should == time
+      ensure
+        File.delete 'tmp'
+      end
+    end
+  end
+end

data/spec/groovy/bdd_spec.rb

@@ -17,7 +17,7 @@ require File.join(File.dirname(__FILE__), '../spec_helpers')
 
 
 describe Buildr::Groovy::EasyB do
-  
+
   def foo(*args, &prc)
     define('foo', *args) do
       test.using :easyb
@@ -58,9 +58,9 @@ describe Buildr::Groovy::EasyB do
       test.compile.language.should eql(:java)
     end
   end
-  
+
   it 'should include src/spec/groovy/*Specification.groovy' do
-    foo do 
+    foo do
       spec = _('src/spec/groovy/SomeSpecification.groovy')
       write spec, 'true'
       test.invoke
@@ -69,12 +69,12 @@ describe Buildr::Groovy::EasyB do
   end
 
   it 'should include src/spec/groovy/*Story.groovy' do
-    foo do 
+    foo do
       spec = _('src/spec/groovy/SomeStory.groovy')
       write spec, 'true'
       test.invoke
       test.tests.should include(spec)
     end
   end
-  
+
 end # EasyB

data/spec/groovy/compiler_spec.rb

@@ -16,12 +16,12 @@
 
 require File.join(File.dirname(__FILE__), '../spec_helpers')
 
-describe 'groovyc compiler' do 
-  
+describe 'groovyc compiler' do
+
   it 'should identify itself from groovy source directories' do
     write 'src/main/groovy/some/Hello.groovy', 'println "Hello Groovy"'
     write 'src/test/groovy/some/Hello.groovy', 'println "Hello Groovy"'
-    define('foo') do 
+    define('foo') do
       compile.compiler.should eql(:groovyc)
       test.compile.compiler.should eql(:groovyc)
     end
@@ -30,7 +30,7 @@ describe 'groovyc compiler' do
   it 'should identify if groovy sources are found on java directories' do
     write 'src/main/java/some/Hello.groovy', 'println "Hello Groovy"'
     write 'src/test/java/some/Hello.groovy', 'println "Hello Groovy"'
-    define('foo') do 
+    define('foo') do
       compile.compiler.should eql(:groovyc)
       test.compile.compiler.should eql(:groovyc)
     end
@@ -41,13 +41,13 @@ describe 'groovyc compiler' do
     write 'src/main/groovy/some/Hello.groovy', 'println "Hello Groovy"'
     write 'src/test/java/some/Empty.java', 'package some; public interface Empty {}'
     write 'src/test/groovy/some/Hello.groovy', 'println "Hello Groovy"'
-    define('foo') do 
+    define('foo') do
       compile.compiler.should eql(:groovyc)
       test.compile.compiler.should eql(:groovyc)
     end
   end
 
-  it 'should identify from custom layout' do 
+  it 'should identify from custom layout' do
     write 'groovy/Hello.groovy', 'println "Hello world"'
     write 'testing/Hello.groovy', 'println "Hello world"'
     custom = Layout.new
@@ -58,10 +58,10 @@ describe 'groovyc compiler' do
       test.compile.compiler.should eql(:groovyc)
     end
   end
-  
+
   it 'should identify from compile source directories' do
-    write 'src/com/example/Code.groovy', 'println "monkey code"' 
-    write 'testing/com/example/Test.groovy', 'println "some test"' 
+    write 'src/com/example/Code.groovy', 'println "monkey code"'
+    write 'testing/com/example/Test.groovy', 'println "some test"'
     define 'foo' do
       lambda { compile.from 'src' }.should change { compile.compiler }.to(:groovyc)
       lambda { test.compile.from 'testing' }.should change { test.compile.compiler }.to(:groovyc)
@@ -91,25 +91,36 @@ describe 'groovyc compiler' do
       lambda { compile.using(:groovyc) }.should_not change { compile.sources }
     end
   end
-  
+
   it 'should compile groovy sources' do
     write 'src/main/groovy/some/Example.groovy', 'package some; class Example { static main(args) { println "Hello" } }'
     define('foo').compile.invoke
     file('target/classes/some/Example.class').should exist
   end
 
+  it 'should compile test groovy sources that rely on junit' do
+    write 'src/main/groovy/some/Example.groovy', 'package some; class Example { static main(args) { println "Hello" } }'
+    write 'src/test/groovy/some/ExampleTest.groovy', "package some\n import junit.framework.TestCase\n class ExampleTest extends TestCase { public testHello() { println \"Hello\" } }"
+    foo = define('foo') do
+      test.using :junit
+    end
+    foo.test.compile.invoke
+    file('target/classes/some/Example.class').should exist
+    file('target/test/classes/some/ExampleTest.class').should exist
+  end
+
   it 'should include as classpath dependency' do
     write 'src/bar/groovy/some/Foo.groovy', 'package some; interface Foo {}'
     write 'src/main/groovy/some/Example.groovy', 'package some; class Example implements Foo { }'
-    define('bar', :version => '1.0') do 
+    define('bar', :version => '1.0') do
       compile.from('src/bar/groovy').into('target/bar')
       package(:jar)
     end
     lambda { define('foo').compile.with(project('bar').package(:jar)).invoke }.should run_task('foo:compile')
     file('target/classes/some/Example.class').should exist
   end
-     
-  it 'should cross compile java sources' do 
+
+  it 'should cross compile java sources' do
     write 'src/main/java/some/Foo.java', 'package some; public interface Foo { public void hello(); }'
     write 'src/main/java/some/Baz.java', 'package some; public class Baz extends Bar { }'
     write 'src/main/groovy/some/Bar.groovy', 'package some; class Bar implements Foo { def void hello() { } }'
@@ -117,7 +128,7 @@ describe 'groovyc compiler' do
     %w{Foo Bar Baz}.each { |f| file("target/classes/some/#{f}.class").should exist }
   end
 
-  it 'should cross compile test java sources' do 
+  it 'should cross compile test java sources' do
     write 'src/test/java/some/Foo.java', 'package some; public interface Foo { public void hello(); }'
     write 'src/test/java/some/Baz.java', 'package some; public class Baz extends Bar { }'
     write 'src/test/groovy/some/Bar.groovy', 'package some; class Bar implements Foo { def void hello() { } }'
@@ -137,7 +148,7 @@ describe 'groovyc compiler' do
 end
 
 describe 'groovyc compiler options' do
-  
+
   def groovyc(&prc)
     define('foo') do
       compile.using(:groovyc)
@@ -153,8 +164,8 @@ describe 'groovyc compiler options' do
     end
     project('foo').compile
   end
-  
-  it 'should set warning option to false by default' do 
+
+  it 'should set warning option to false by default' do
     groovyc do
       compile.options.warnings.should be_false
       @compiler.javac_options[:nowarn].should be_true
@@ -177,7 +188,7 @@ describe 'groovyc compiler options' do
     trace true
     groovyc.options.verbose.should be_true
   end
-  
+
   it 'should set debug option to false based on Buildr.options' do
     Buildr.options.debug = false
     groovyc.options.debug.should be_false

data/spec/ide/eclipse_spec.rb

@@ -33,7 +33,7 @@ PLUGIN_BUILDERS = Buildr::Eclipse::Plugin::BUILDERS
 module EclipseHelper
   def classpath_xml_elements
     task('eclipse').invoke
-    REXML::Document.new(File.open('.classpath')).root.elements
+    File.open('.classpath') { |f| REXML::Document.new(f).root.elements }
   end
 
   def classpath_sources(attribute='path')
@@ -63,7 +63,7 @@ module EclipseHelper
 
   def project_xml_elements
     task('eclipse').invoke
-    REXML::Document.new(File.open('.project')).root.elements
+    File.open('.project') { |f| REXML::Document.new(f).root.elements }
   end
 
   def project_natures
@@ -85,6 +85,54 @@ describe Buildr::Eclipse do
 
   describe "eclipse's .project file" do
 
+    describe 'default project' do
+      before do
+        write 'buildfile'
+        write 'src/main/nono/Main.nono'
+      end
+
+      it 'should not have natures' do
+        define('foo')
+        project_natures.should be_empty
+      end
+
+      it 'should not have build commands' do
+        define('foo')
+        build_commands.should be_empty
+      end
+
+      it 'should generate a .project file' do
+        define('foo')
+        task('eclipse').invoke
+        File.open('.project') do |f|
+          REXML::Document.new(f).root.
+            elements.collect("name") { |e| e.text }.should == ['foo']
+        end
+      end
+
+      it 'should not generate a .classpath file' do
+        define('foo')
+        task('eclipse').invoke
+        File.exists?('.classpath').should be_false
+      end
+    end
+
+    describe 'parent project' do
+      before do
+        write 'buildfile'
+        mkpath 'bar'
+      end
+
+      it 'should not generate a .project for the parent project' do
+        define('foo') do
+          define('bar')
+        end
+        task('eclipse').invoke
+        File.exists?('.project').should be_false
+        File.exists?(File.join('bar','.project')).should be_true
+      end
+    end
+
     describe 'java project' do
       before do
         write 'buildfile'
@@ -111,8 +159,10 @@ describe Buildr::Eclipse do
           define('foo') { compile.using(:javac); package :jar }
         }
         task('eclipse').invoke
-        REXML::Document.new(File.open(File.join('foo', '.project'))).root.
-          elements.collect("name") { |e| e.text }.should == ['myproject-foo']
+        File.open(File.join('foo', '.project')) do |f|
+          REXML::Document.new(f).root.
+            elements.collect("name") { |e| e.text }.should == ['myproject-foo']
+        end
       end
 
     end
@@ -201,6 +251,68 @@ describe Buildr::Eclipse do
         build_commands.should include(JAVA_BUILDER)
       end
     end
+
+    describe 'Plugin project' do
+
+      before do
+        write 'buildfile'
+        write 'src/main/java/Activator.java'
+        write 'plugin.xml'
+      end
+
+      it 'should have plugin nature before Java nature' do
+        define('foo')
+        project_natures.should include(PLUGIN_NATURE)
+        project_natures.should include(JAVA_NATURE)
+        project_natures.index(PLUGIN_NATURE).should < project_natures.index(JAVA_NATURE)
+      end
+
+      it 'should have plugin build commands and the Java build command' do
+        define('foo')
+        build_commands.should include(PLUGIN_BUILDERS[0])
+        build_commands.should include(PLUGIN_BUILDERS[1])
+        build_commands.should include(JAVA_BUILDER)
+      end
+    end
+
+    describe 'Plugin project with META-INF/MANIFEST.MF' do
+
+      before do
+        write 'buildfile'
+        write 'src/main/java/Activator.java'
+      end
+
+      it 'should have plugin nature by default if MANIFEST.MF contains "Bundle-SymbolicName:"' do
+        write 'META-INF/MANIFEST.MF', <<-MANIFEST
+Manifest-Version: 1.0
+Name: example/
+Specification-Title: "Examples"
+Specification-Version: "1.0"
+Specification-Vendor: "Acme Corp.".
+Implementation-Title: "example"
+Implementation-Version: "build57"
+Implementation-Vendor: "Acme Corp."
+Bundle-SymbolicName: acme.plugin.example
+MANIFEST
+        define('foo')
+        project_natures.should include(PLUGIN_NATURE)
+      end
+
+      it 'should not have plugin nature if MANIFEST.MF exists but doesn\'t contain "Bundle-SymbolicName:"' do
+        write 'META-INF/MANIFEST.MF', <<-MANIFEST
+Manifest-Version: 1.0
+Name: example/
+Specification-Title: "Examples"
+Specification-Version: "1.0"
+Specification-Vendor: "Acme Corp.".
+Implementation-Title: "example"
+Implementation-Version: "build57"
+Implementation-Vendor: "Acme Corp."
+MANIFEST
+        define('foo')
+        project_natures.should_not include(PLUGIN_NATURE)
+      end
+    end
   end
 
   describe "eclipse's .classpath file" do
@@ -348,8 +460,10 @@ describe Buildr::Eclipse do
           define('bar') { compile.using(:javac).with project('foo'); }
         }
         task('eclipse').invoke
-        REXML::Document.new(File.open(File.join('bar', '.classpath'))).root.
-          elements.collect("classpathentry[@kind='src']") { |n| n.attributes['path'] }.should include('/myproject-foo')
+        File.open(File.join('bar', '.classpath')) do |f|
+          REXML::Document.new(f).root.
+            elements.collect("classpathentry[@kind='src']") { |n| n.attributes['path'] }.should include('/myproject-foo')
+        end
       end
     end
   end
@@ -359,10 +473,26 @@ describe Buildr::Eclipse do
       write 'lib/some-local.jar'
       define('foo') { compile.using(:javac).with(_('lib/some-local.jar')) }
     end
-    
+
     it 'should have a lib artifact reference in the .classpath file' do
       classpath_xml_elements.collect("classpathentry[@kind='lib']") { |n| n.attributes['path'] }.
-        should include(File.expand_path 'lib/some-local.jar')
+        should include('lib/some-local.jar')
+    end
+  end
+
+  describe 'project .classpath' do
+    before do
+      mkdir_p '../libs'
+      write '../libs/some-local.jar'
+      define('foo') do
+        eclipse.classpath_variables :LIBS => '../libs', :LIBS2 => '../libs2'
+        compile.using(:javac).with(_('../libs/some-local.jar'))
+      end
+    end
+
+    it 'supports generating library paths with classpath variables' do
+      classpath_xml_elements.collect("classpathentry[@kind='var']") { |n| n.attributes['path'] }.
+        should include('LIBS/some-local.jar')
     end
   end
 
@@ -371,7 +501,7 @@ describe Buildr::Eclipse do
       write 'lib/some.class'
       define('foo') { compile.using(:javac).with(_('lib')) }
     end
-    
+
     it 'should have src reference in the .classpath file' do
       classpath_xml_elements.collect("classpathentry[@kind='src']") { |n| n.attributes['path'] }.
         should include('lib')
@@ -449,6 +579,13 @@ describe Buildr::Eclipse do
       project('foo:bar').eclipse.natures.should include('foo_nature')
       project('foo:bar2').eclipse.natures.should include('bar2_nature')
     end
+
+    it 'should handle arrays correctly' do
+      define('foo') do
+        eclipse.natures ['foo_nature', 'bar_nature']
+      end
+      project('foo').eclipse.natures.should == ['foo_nature', 'bar_nature']
+    end
   end
 
   describe 'builders variable' do
@@ -473,6 +610,13 @@ describe Buildr::Eclipse do
       project('foo:bar').eclipse.builders.should include('foo_builder')
       project('foo:bar2').eclipse.builders.should include('bar2_builder')
     end
+
+    it 'should handle arrays correctly' do
+      define('foo') do
+        eclipse.builders ['foo_builder', 'bar_builder']
+      end
+      project('foo').eclipse.builders.should == ['foo_builder', 'bar_builder']
+    end
   end
 
   describe 'classpath_containers variable' do
@@ -497,5 +641,37 @@ describe Buildr::Eclipse do
       project('foo:bar').eclipse.classpath_containers.should include('foo_classpath_containers')
       project('foo:bar2').eclipse.classpath_containers.should include('bar2_classpath_containers')
     end
+
+    it 'should handle arrays correctly' do
+      define('foo') do
+        eclipse.classpath_containers ['foo_cc', 'bar_cc']
+      end
+      project('foo').eclipse.classpath_containers.should == ['foo_cc', 'bar_cc']
+    end
+  end
+
+  describe 'exclude_libs' do
+    it 'should support artifacts' do
+      define('foo') do
+        compile.using(:javac).with('com.example:library:jar:2.0')
+        eclipse.exclude_libs += [ artifact('com.example:library:jar:2.0') ]
+      end
+      artifact('com.example:library:jar:2.0') { |task| write task.name }
+
+      task('eclipse').invoke
+      classpath_xml_elements.collect("classpathentry[@kind='var']") { |n| n.attributes['path'] }.
+        should_not include('M2_REPO/com/example/library/2.0/library-2.0.jar')
+    end
+    it 'should support string paths' do
+      define('foo') do
+        compile.using(:javac).with _('path/to/library.jar')
+        eclipse.exclude_libs += [ _('path/to/library.jar') ]
+      end
+      write project('foo').path_to('path/to/library.jar')
+
+      task('eclipse').invoke
+      classpath_xml_elements.collect("classpathentry[@kind='lib']") { |n| n.attributes['path'] }.
+        should_not include('path/to/library.jar')
+    end
   end
 end