buildr 1.3.4-java → 1.3.5-java

data/spec/core/extension_spec.rb

@@ -0,0 +1,93 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with this
+# work for additional information regarding copyright ownership.  The ASF
+# licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+
+require File.join(File.dirname(__FILE__), '../spec_helpers')
+
+
+describe Extension do
+  
+  it 'should call Extension.first_time during include' do
+    TestExtension.should_receive(:first_time_called).once
+    class Buildr::Project
+      include TestExtension
+    end
+  end
+  
+  it 'should call before_define and after_define in order when project is defined' do
+    begin
+      TestExtension.initialized do |extension|
+        extension.should_receive(:before_define_called).once.ordered
+        extension.should_receive(:after_define_called).once.ordered
+      end
+      class Buildr::Project
+        include TestExtension
+      end
+      define('foo')
+    ensure
+      TestExtension.initialized { |ignore| }
+    end
+  end
+
+  it 'should call before_define and after_define for each project defined' do
+    begin
+      extensions = 0
+      TestExtension.initialized do |extension|
+        extensions += 1
+        extension.should_receive(:before_define_called).once.ordered
+        extension.should_receive(:after_define_called).once.ordered
+      end
+      class Buildr::Project
+        include TestExtension
+      end
+      define('foo')
+      define('bar')
+      extensions.should equal(2)
+    ensure  
+      TestExtension.initialized { |ignore| }
+    end
+  end
+end
+
+module TestExtension
+  include Extension
+  
+  def initialize(*args)
+    # callback is used to obtain extension instance created by buildr
+    @@initialized.call(self) if @@initialized
+    super
+  end
+  
+  def TestExtension.initialized(&block)
+    @@initialized = block
+  end
+  
+  first_time do
+    TestExtension.first_time_called()
+  end
+  
+  before_define do |project|
+    project.before_define_called()
+  end
+  
+  after_define do |project|
+    project.after_define_called()
+  end
+
+  def TestExtension.first_time_called()
+  end
+  
+end
+

data/spec/core/test_spec.rb

@@ -333,10 +333,10 @@ describe Buildr::TestTask, 'with passing tests' do
   it 'should execute teardown task' do
     lambda { test_task.invoke }.should run_task('foo:test:teardown')
   end
-  
+
   it 'should update the last successful run timestamp' do
     before = Time.now ; test_task.invoke ; after = Time.now
-    (before-1..after+1).should include(test_task.timestamp)
+    (before-1..after+1).should cover(test_task.timestamp)
   end
 end
 

data/spec/core/transport_spec.rb

@@ -511,7 +511,7 @@ describe URI::SFTP, '#write' do
   end
 
   it 'should create missing paths on server' do
-    @sftp_session.should_receive(:opendir!).twice { |path| fail unless path == '/root' }
+    @sftp_session.should_receive(:opendir!) { |path| fail unless path == '/root' }
     @sftp_session.should_receive(:mkdir!).once.with('/root/path', {})
     @uri.write @content
   end

data/spec/groovy/bdd_spec.rb

@@ -31,11 +31,11 @@ describe Buildr::Groovy::EasyB do
 
   it 'should apply to a project having EasyB sources' do
     define('one', :base_dir => 'one') do
-      write _('src/spec/groovy/SomeBehaviour.groovy'), 'true;'
+      write _('src/spec/groovy/SomeSpecification.groovy'), 'true;'
       Buildr::Groovy::EasyB.applies_to?(self).should be_true
     end
     define('two', :base_dir => 'two') do
-      write _('src/test/groovy/SomeBehaviour.groovy'), 'true;'
+      write _('src/test/groovy/SomeSpecification.groovy'), 'true;'
       Buildr::Groovy::EasyB.applies_to?(self).should be_false
     end
     define('three', :base_dir => 'three') do
@@ -54,14 +54,14 @@ describe Buildr::Groovy::EasyB do
 
   it 'should select a java compiler if java sources are found' do
     foo do
-      write _('src/spec/java/SomeBehavior.java'), 'public class SomeBehavior {}'
+      write _('src/spec/java/SomeSpecification.java'), 'public class SomeSpecification {}'
       test.compile.language.should eql(:java)
     end
   end
   
-  it 'should include src/spec/groovy/*Behavior.groovy' do
+  it 'should include src/spec/groovy/*Specification.groovy' do
     foo do 
-      spec = _('src/spec/groovy/SomeBehavior.groovy')
+      spec = _('src/spec/groovy/SomeSpecification.groovy')
       write spec, 'true'
       test.invoke
       test.tests.should include(spec)
@@ -77,4 +77,4 @@ describe Buildr::Groovy::EasyB do
     end
   end
   
-end # EasyB
+end # EasyB

data/spec/groovy/compiler_spec.rb

@@ -151,6 +151,7 @@ describe 'groovyc compiler options' do
         return compile
       end
     end
+    project('foo').compile
   end
   
   it 'should set warning option to false by default' do 

data/spec/ide/eclipse_spec.rb

@@ -17,85 +17,93 @@
 require File.join(File.dirname(__FILE__), '../spec_helpers')
 
 
+JAVA_CONTAINER   = Buildr::Eclipse::Java::CONTAINER
+SCALA_CONTAINER  = Buildr::Eclipse::Scala::CONTAINER
+PLUGIN_CONTAINER = Buildr::Eclipse::Plugin::CONTAINER
+
+JAVA_NATURE   = Buildr::Eclipse::Java::NATURE
+SCALA_NATURE  = Buildr::Eclipse::Scala::NATURE
+PLUGIN_NATURE = Buildr::Eclipse::Plugin::NATURE
+
+JAVA_BUILDER    = Buildr::Eclipse::Java::BUILDER
+SCALA_BUILDER   = Buildr::Eclipse::Scala::BUILDER
+PLUGIN_BUILDERS = Buildr::Eclipse::Plugin::BUILDERS
+
+
 module EclipseHelper
   def classpath_xml_elements
     task('eclipse').invoke
     REXML::Document.new(File.open('.classpath')).root.elements
   end
-  
-  def classpath_sources attribute='path'
+
+  def classpath_sources(attribute='path')
     classpath_xml_elements.collect("classpathentry[@kind='src']") { |n| n.attributes[attribute] }
   end
-  
+
   # <classpathentry path="PATH" output="RETURNED_VALUE"/>
-  def classpath_specific_output path
+  def classpath_specific_output(path)
     specific_output = classpath_xml_elements.collect("classpathentry[@path='#{path}']") { |n| n.attributes['output'] }
     raise "expected: one output attribute for path '#{path}, got: #{specific_output.inspect}" if specific_output.length > 1
     specific_output[0]
   end
-  
+
   # <classpathentry path="RETURNED_VALUE" kind="output"/>
   def classpath_default_output
     default_output = classpath_xml_elements.collect("classpathentry[@kind='output']") { |n| n.attributes['path'] }
     raise "expected: one path attribute for kind='output', got: #{default_output.inspect}" if default_output.length > 1
     default_output[0]
   end
-  
+
   # <classpathentry path="PATH" sourcepath="RETURNED_VALUE" kind="var"/>
-  def sourcepath_for_path path
+  def sourcepath_for_path(path)
     classpath_xml_elements.collect("classpathentry[@kind='var',@path='#{path}']") do |n|
       n.attributes['sourcepath'] || 'no source artifact'
     end
   end
-  
+
   def project_xml_elements
     task('eclipse').invoke
     REXML::Document.new(File.open('.project')).root.elements
   end
+
+  def project_natures
+    project_xml_elements.collect("natures/nature") { |n| n.text }
+  end
+
+  def build_commands
+    project_xml_elements.collect("buildSpec/buildCommand/name") { |n| n.text }
+  end
+
+  def classpath_containers(attribute='path')
+    classpath_xml_elements.collect("classpathentry[@kind='con']") { |n| n.attributes[attribute] }
+  end
 end
 
 
 describe Buildr::Eclipse do
   include EclipseHelper
-  
-  describe "eclipse's .project file" do
-
-    JAVA_CONTAINER  = 'org.eclipse.jdt.launching.JRE_CONTAINER'
-    SCALA_CONTAINER = 'ch.epfl.lamp.sdt.launching.SCALA_CONTAINER'
 
-    SCALA_NATURE = 'ch.epfl.lamp.sdt.core.scalanature'
-    JAVA_NATURE  = 'org.eclipse.jdt.core.javanature'
-    
-    SCALA_BUILDER = 'ch.epfl.lamp.sdt.core.scalabuilder'
-    JAVA_BUILDER  = 'org.eclipse.jdt.core.javabuilder'
+  describe "eclipse's .project file" do
 
-    def project_natures
-      project_xml_elements.collect("natures/nature") { |n| n.text }
-    end
-    
-    def build_commands
-      project_xml_elements.collect("buildSpec/buildCommand/name") { |n| n.text }
-    end
-    
     describe 'java project' do
       before do
         write 'buildfile'
         write 'src/main/java/Main.java'
       end
-      
+
       it 'should have Java nature' do
         define('foo')
         project_natures.should include(JAVA_NATURE)
       end
-      
+
       it 'should have Java build command' do
         define('foo')
         build_commands.should include(JAVA_BUILDER)
       end
     end
-    
+
     describe 'nested java project' do
-      
+
       it 'should have name corresponding to its project definition' do
         mkdir 'foo'
         define('myproject') {
@@ -108,42 +116,102 @@ describe Buildr::Eclipse do
       end
 
     end
-    
+
     describe 'scala project' do
-      
+
+      before do
+        define 'foo' do
+          eclipse.natures :scala
+        end
+      end
+
+      it 'should have Scala nature before Java nature' do
+        project_natures.should include(SCALA_NATURE)
+        project_natures.should include(JAVA_NATURE)
+        project_natures.index(SCALA_NATURE).should < project_natures.index(JAVA_NATURE)
+      end
+
+      it 'should have Scala build command and no Java build command' do
+        build_commands.should include(SCALA_BUILDER)
+        build_commands.should_not include(JAVA_BUILDER)
+      end
+    end
+
+    describe 'standard scala project' do
+
       before do
         write 'buildfile'
         write 'src/main/scala/Main.scala'
+        define 'foo'
       end
-      
+
       it 'should have Scala nature before Java nature' do
-        define('foo')
         project_natures.should include(SCALA_NATURE)
         project_natures.should include(JAVA_NATURE)
         project_natures.index(SCALA_NATURE).should < project_natures.index(JAVA_NATURE)
       end
-      
+
+      it 'should have Scala build command and no Java build command' do
+        build_commands.should include(SCALA_BUILDER)
+        build_commands.should_not include(JAVA_BUILDER)
+      end
+    end
+
+    describe 'non-standard scala project' do
+
+      before do
+        write 'buildfile'
+        write 'src/main/foo/Main.scala'
+        define 'foo' do
+          eclipse.natures = :scala
+        end
+      end
+
+      it 'should have Scala nature before Java nature' do
+        project_natures.should include(SCALA_NATURE)
+        project_natures.should include(JAVA_NATURE)
+        project_natures.index(SCALA_NATURE).should < project_natures.index(JAVA_NATURE)
+      end
+
       it 'should have Scala build command and no Java build command' do
-        define('foo')
         build_commands.should include(SCALA_BUILDER)
         build_commands.should_not include(JAVA_BUILDER)
       end
     end
+
+    describe 'Plugin project' do
+
+      before do
+        write 'buildfile'
+        write 'src/main/java/Activator.java'
+        write 'plugin.xml'
+      end
+
+      it 'should have plugin nature before Java nature' do
+        define('foo')
+        project_natures.should include(PLUGIN_NATURE)
+        project_natures.should include(JAVA_NATURE)
+        project_natures.index(PLUGIN_NATURE).should < project_natures.index(JAVA_NATURE)
+      end
+
+      it 'should have plugin build commands and the Java build command' do
+        define('foo')
+        build_commands.should include(PLUGIN_BUILDERS[0])
+        build_commands.should include(PLUGIN_BUILDERS[1])
+        build_commands.should include(JAVA_BUILDER)
+      end
+    end
   end
-  
+
   describe "eclipse's .classpath file" do
-    
+
     describe 'scala project' do
 
-      def classpath_containers attribute='path'
-        classpath_xml_elements.collect("classpathentry[@kind='con']") { |n| n.attributes[attribute] }
-      end
-      
       before do
         write 'buildfile'
         write 'src/main/scala/Main.scala'
       end
-      
+
       it 'should have SCALA_CONTAINER before JAVA_CONTAINER' do
         define('foo')
         classpath_containers.should include(SCALA_CONTAINER)
@@ -151,15 +219,15 @@ describe Buildr::Eclipse do
         classpath_containers.index(SCALA_CONTAINER).should < classpath_containers.index(JAVA_CONTAINER)
       end
     end
-    
+
     describe 'source folders' do
-      
+
       before do
         write 'buildfile'
         write 'src/main/java/Main.java'
         write 'src/test/java/Test.java'
       end
-      
+
       describe 'source', :shared=>true do
         it 'should ignore CVS and SVN files' do
           define('foo')
@@ -170,106 +238,106 @@ describe Buildr::Eclipse do
           end
         end
       end
-      
+
       describe 'main code' do
         it_should_behave_like 'source'
-        
+
         it 'should accept to come from the default directory' do
           define('foo')
           classpath_sources.should include('src/main/java')
         end
-        
+
         it 'should accept to come from a user-defined directory' do
           define('foo') { compile path_to('src/java') }
           classpath_sources.should include('src/java')
         end
-        
+
         it 'should accept a file task as a main source folder' do
           define('foo') { compile apt }
           classpath_sources.should include('target/generated/apt')
         end
-        
+
         it 'should go to the default target directory' do
           define('foo')
           classpath_specific_output('src/main/java').should be(nil)
           classpath_default_output.should == 'target/classes'
         end
       end
-      
+
       describe 'test code' do
         it_should_behave_like 'source'
-        
+
         it 'should accept to come from the default directory' do
           define('foo')
           classpath_sources.should include('src/test/java')
         end
-        
+
         it 'should accept to come from a user-defined directory' do
           define('foo') { test.compile path_to('src/test') }
           classpath_sources.should include('src/test')
         end
-        
+
         it 'should go to the default target directory' do
           define('foo')
           classpath_specific_output('src/test/java').should == 'target/test/classes'
         end
-        
+
         it 'should accept to be the only code in the project' do
           rm 'src/main/java/Main.java'
           define('foo')
           classpath_sources.should include('src/test/java')
         end
       end
-      
+
       describe 'main resources' do
         it_should_behave_like 'source'
-        
+
         before do
           write 'src/main/resources/config.xml'
         end
-        
+
         it 'should accept to come from the default directory' do
           define('foo')
           classpath_sources.should include('src/main/resources')
         end
-        
+
         it 'should share a classpath entry if it comes from a directory with code' do
           write 'src/main/java/config.properties'
           define('foo') { resources.from('src/main/java').exclude('**/*.java') }
           classpath_sources.select { |path| path == 'src/main/java'}.length.should == 1
         end
-        
+
         it 'should go to the default target directory' do
           define('foo')
           classpath_specific_output('src/main/resources').should == 'target/resources'
         end
       end
-      
+
       describe 'test resources' do
         it_should_behave_like 'source'
-        
+
         before do
           write 'src/test/resources/config-test.xml'
         end
-        
+
         it 'should accept to come from the default directory' do
           define('foo')
           classpath_sources.should include('src/test/resources')
         end
-        
+
         it 'should share a classpath entry if it comes from a directory with code' do
           write 'src/test/java/config-test.properties'
           define('foo') { test.resources.from('src/test/java').exclude('**/*.java') }
           classpath_sources.select { |path| path == 'src/test/java'}.length.should == 1
         end
-        
+
         it 'should go to the default target directory' do
           define('foo')
           classpath_specific_output('src/test/resources').should == 'target/test/resources'
         end
       end
     end
-      
+
     describe 'project depending on another project' do
       it 'should have the underlying project in its classpath' do
         mkdir 'foo'
@@ -285,27 +353,149 @@ describe Buildr::Eclipse do
       end
     end
   end
-  
+
+  describe 'local dependency' do
+    before do
+      write 'lib/some-local.jar'
+      define('foo') { compile.using(:javac).with(_('lib/some-local.jar')) }
+    end
+    
+    it 'should have a lib artifact reference in the .classpath file' do
+      classpath_xml_elements.collect("classpathentry[@kind='lib']") { |n| n.attributes['path'] }.
+        should include(File.expand_path 'lib/some-local.jar')
+    end
+  end
+
+  describe 'generated .classes' do
+    before do
+      write 'lib/some.class'
+      define('foo') { compile.using(:javac).with(_('lib')) }
+    end
+    
+    it 'should have src reference in the .classpath file' do
+      classpath_xml_elements.collect("classpathentry[@kind='src']") { |n| n.attributes['path'] }.
+        should include('lib')
+    end
+  end
+
   describe 'maven2 artifact dependency' do
     before do
       define('foo') { compile.using(:javac).with('com.example:library:jar:2.0') }
       artifact('com.example:library:jar:2.0') { |task| write task.name }
       task('eclipse').invoke
     end
-    
+
     it 'should have a reference in the .classpath file relative to the local M2 repo' do
       classpath_xml_elements.collect("classpathentry[@kind='var']") { |n| n.attributes['path'] }.
         should include('M2_REPO/com/example/library/2.0/library-2.0.jar')
     end
-    
+
     it 'should be downloaded' do
       file(artifact('com.example:library:jar:2.0').name).should exist
     end
-    
+
     it 'should have a source artifact reference in the .classpath file' do
       sourcepath_for_path('M2_REPO/com/example/library/2.0/library-2.0.jar').
         should == ['M2_REPO/com/example/library/2.0/library-2.0-sources.jar']
     end
   end
-  
+
+  describe 'maven2 repository variable' do
+    it 'should be configurable' do
+      define('foo') do
+        eclipse.options.m2_repo_var = 'PROJ_REPO'
+        compile.using(:javac).with('com.example:library:jar:2.0')
+      end
+      artifact('com.example:library:jar:2.0') { |task| write task.name }
+
+      task('eclipse').invoke
+      classpath_xml_elements.collect("classpathentry[@kind='var']") { |n| n.attributes['path'] }.
+        should include('PROJ_REPO/com/example/library/2.0/library-2.0.jar')
+    end
+
+    it 'should pick the parent value by default' do
+      define('foo') do
+        eclipse.options.m2_repo_var = 'FOO_REPO'
+        define('bar')
+
+        define('bar2') do
+          eclipse.options.m2_repo_var = 'BAR2_REPO'
+        end
+      end
+      project('foo:bar').eclipse.options.m2_repo_var.should eql('FOO_REPO')
+      project('foo:bar2').eclipse.options.m2_repo_var.should eql('BAR2_REPO')
+    end
+  end
+
+  describe 'natures variable' do
+    it 'should be configurable' do
+      define('foo') do
+        eclipse.natures = 'dummyNature'
+        compile.using(:javac).with('com.example:library:jar:2.0')
+      end
+      artifact('com.example:library:jar:2.0') { |task| write task.name }
+      project_natures.should include('dummyNature')
+    end
+
+    it 'should pick the parent value by default' do
+      define('foo') do
+        eclipse.natures = 'foo_nature'
+        define('bar')
+
+        define('bar2') do
+          eclipse.natures = 'bar2_nature'
+        end
+      end
+      project('foo:bar').eclipse.natures.should include('foo_nature')
+      project('foo:bar2').eclipse.natures.should include('bar2_nature')
+    end
+  end
+
+  describe 'builders variable' do
+    it 'should be configurable' do
+      define('foo') do
+        eclipse.builders 'dummyBuilder'
+        compile.using(:javac).with('com.example:library:jar:2.0')
+      end
+      artifact('com.example:library:jar:2.0') { |task| write task.name }
+      build_commands.should include('dummyBuilder')
+    end
+
+    it 'should pick the parent value by default' do
+      define('foo') do
+        eclipse.builders = 'foo_builder'
+        define('bar')
+
+        define('bar2') do
+          eclipse.builders = 'bar2_builder'
+        end
+      end
+      project('foo:bar').eclipse.builders.should include('foo_builder')
+      project('foo:bar2').eclipse.builders.should include('bar2_builder')
+    end
+  end
+
+  describe 'classpath_containers variable' do
+    it 'should be configurable' do
+      define('foo') do
+        eclipse.classpath_containers = 'myOlGoodContainer'
+        compile.using(:javac).with('com.example:library:jar:2.0')
+      end
+      artifact('com.example:library:jar:2.0') { |task| write task.name }
+      classpath_containers.should include('myOlGoodContainer')
+    end
+
+    it 'should pick the parent value by default' do
+      define('foo') do
+        eclipse.classpath_containers = 'foo_classpath_containers'
+        define('bar')
+
+        define('bar2') do
+          eclipse.classpath_containers = 'bar2_classpath_containers'
+        end
+      end
+      project('foo:bar').eclipse.classpath_containers.should include('foo_classpath_containers')
+      project('foo:bar2').eclipse.classpath_containers.should include('bar2_classpath_containers')
+    end
+  end
 end