buildr-dependency-extensions 0.2

data/lib/buildr-dependency-extensions/version.rb

@@ -0,0 +1,3 @@
+module BuildrDependencyExtensions
+  VERSION = '0.2'.freeze
+end

data/spec/compile_dependencies_spec.rb

@@ -0,0 +1,60 @@
+require 'rubygems'
+require 'buildr'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib/buildr-dependency-extensions'))
+require File.expand_path(File.join('spec', 'spec_helpers'), Gem::GemPathSearcher.new.find('buildr').full_gem_path)
+
+describe 'Compile dependencies' do
+  before(:each) do
+    write artifact('foo:bar:jar:1.0').pom.to_s, <<-XML
+<project>
+  <artifactId>bar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+
+    write artifact('foo:foobar:jar:1.0').pom.to_s, <<-XML
+<project>
+  <artifactId>foobar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+
+    write artifact('transitive:dependencies:jar:1.0').pom.to_s, <<-XML
+<project>
+  <artifactId>transitive</artifactId>
+  <groupId>dependencies</groupId>
+
+  <dependencies>
+    <dependency>
+      <groupId>foo</groupId>
+      <artifactId>foobar</artifactId>
+      <version>1.0</version>
+      <scope>compile</scope>
+    </dependency>
+    <dependency>
+      <groupId>foo</groupId>
+      <artifactId>bar</artifactId>
+      <version>1.0</version>
+      <scope>runtime</scope>
+    </dependency>
+  </dependencies>
+</project>
+XML
+  end
+
+  describe 'maven dependency mechanism' do
+    it 'transitively adds compile dependencies and runtime dependencies of this project runtime dependencies to the runtime dependencies' do
+      define "TestProject" do
+        extend TransitiveDependencies
+        project.version = '1.0'
+
+        project.transitive_scopes = [:compile]
+
+        compile.with 'transitive:dependencies:jar:1.0'
+      end
+
+      expected_dependencies = [artifact('foo:foobar:jar:1.0'), artifact('transitive:dependencies:jar:1.0')]
+      project('TestProject').compile.dependencies.should ==(expected_dependencies)
+    end
+  end
+end

data/spec/dependency_caching_spec.rb

@@ -0,0 +1,135 @@
+require 'rubygems'
+require 'buildr'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib/buildr-dependency-extensions'))
+require File.expand_path(File.join('spec', 'spec_helpers'), Gem::GemPathSearcher.new.find('buildr').full_gem_path)
+
+describe BuildrDependencyExtensions::DependencyCaching do
+  before(:each) do
+    write artifact('foo:bar:jar:1.0').pom.to_s, <<-XML
+<project>
+  <artifactId>bar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+  end
+
+  after(:each) do
+    FileUtils.rm_f(project('TestProject').path_to('dependency.cache'))
+  end
+
+  it 'reads and write the runtime dependencies to and from a dependency cache file' do
+    define "TestProject" do
+    end
+
+    project = project('TestProject')
+    project.run.with(artifact('foo:bar:jar:1.1'))
+
+    dependency_caching = DependencyCaching.new(project)
+
+    dependency_caching.write_cache
+
+    project.run.classpath = []
+
+    dependency_cache = dependency_caching.read_cache
+
+    dependency_cache['runtime'].should ==([artifact('foo:bar:jar:1.1')])
+  end
+
+  it 'reads and write the compile dependencies to and from a dependency cache file' do
+    define "TestProject" do
+    end
+
+    project = project('TestProject')
+    project.compile.with(artifact('foo:bar:jar:1.1'))
+
+    dependency_caching = DependencyCaching.new(project)
+
+    dependency_caching.write_cache
+
+    project.compile.dependencies = []
+
+    dependency_cache = dependency_caching.read_cache
+
+    dependency_cache['compile'].should ==([artifact('foo:bar:jar:1.1')])
+  end
+
+  it 'reads and write the test dependencies to and from a dependency cache file' do
+    define "TestProject" do
+    end
+
+    project = project('TestProject')
+    project.test.with(artifact('foo:bar:jar:1.1'))
+
+    dependency_caching = DependencyCaching.new(project)
+
+    dependency_caching.write_cache
+
+    project.test.dependencies = project.test.compile.dependencies = []
+
+    dependency_cache = dependency_caching.read_cache
+
+    dependency_cache['test'].should ==([artifact('foo:bar:jar:1.1')])
+  end
+
+  it 'return nil if no dependency cache file exist' do
+    define "TestProject" do
+    end
+
+    project = project('TestProject')
+
+    dependency_caching = DependencyCaching.new(project)
+
+    dependency_caching.read_cache.should ==(nil)
+  end
+
+  describe('cache_dependencies property') do
+    it 'causes the plugin to save the dependency cache file if it does not exist when set to true' do
+      dependency_caching_mock = stub('dependency_caching_mock')
+      dependency_caching_mock.should_receive(:read_cache).and_return(nil)
+      dependency_caching_mock.should_receive(:write_cache)
+      DependencyCaching.stub!(:new).and_return(dependency_caching_mock)
+      DependencyCaching.should_receive(:new).and_return(dependency_caching_mock)
+
+      define "TestProject" do
+        extend TransitiveDependencies
+
+        project.transitive_scopes = [:compile]
+        project.cache_dependencies = true
+
+        compile.with artifact('foo:bar:jar:1.0')
+      end
+    end
+
+    it 'causes the plugin to load the dependency cache file if it exists when set to true' do
+      dependency_caching_mock = stub('dependency_caching_mock')
+      dependency_caching_mock.should_receive(:read_cache).and_return({'compile' => [artifact('foo:bar:jar:1.0')]})
+      dependency_caching_mock.should_not_receive(:write_cache)
+      DependencyCaching.stub!(:new).and_return(dependency_caching_mock)
+      DependencyCaching.should_receive(:new).and_return(dependency_caching_mock)
+
+      define "TestProject" do
+        extend TransitiveDependencies
+
+        project.transitive_scopes = [:compile]
+        project.cache_dependencies = true
+      end
+
+      project('TestProject').compile.dependencies.should ==([artifact('foo:bar:jar:1.0')])
+    end
+
+    it 'does not load the dependency cache file when set to false' do
+      dependency_caching_mock = stub('dependency_caching_mock')
+      dependency_caching_mock.should_receive(:read_cache).and_return({'compile' => [artifact('foo:bar:jar:1.0')]})
+      dependency_caching_mock.should_receive(:write_cache)
+      DependencyCaching.should_receive(:new).and_return(dependency_caching_mock)
+
+      define "TestProject" do
+        extend TransitiveDependencies
+
+        project.transitive_scopes = [:compile]
+      end
+
+      project('TestProject').compile.dependencies.should ==([])
+    end
+  end
+end

data/spec/helper_spec.rb

@@ -0,0 +1,53 @@
+require 'rubygems'
+require 'buildr'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib/buildr-dependency-extensions'))
+
+module BuildrDependencyExtensions
+
+  describe HelperFunctions do
+    describe 'get_unique_group_artifact' do
+      it 'should return a set of artifacts with version set to 0 given a set of artifacts' do
+        original_set = ['foo:bar:jar:1.0', 'bar:foo:jar:2.0']
+        actual_set = HelperFunctions.get_unique_group_artifact original_set
+        expected_set = ['foo:bar:jar:0', 'bar:foo:jar:0']
+        actual_set.should == expected_set
+      end
+
+      it 'should return a array of unique artifacts given a set of artifacts' do
+        original_set = ['foo:bar:jar:1.0', 'foo:bar:jar:2.0']
+        actual_set = HelperFunctions.get_unique_group_artifact original_set
+        expected_set = ['foo:bar:jar:0']
+        actual_set.should == expected_set
+      end
+
+    end
+
+    describe 'get_all_versions' do
+      it 'should return all versions in descending order given an artifact and a set of artifacts' do
+        artifact = 'foo:bar:jar:0'
+        original_set = ['foo:bar:jar:1.0', 'foo:bar:jar:2.0']
+        actual_versions = HelperFunctions.get_all_versions artifact, original_set
+        expected_versions = [Version.new('2.0'), Version.new('1.0')]
+        actual_versions.should == expected_versions
+      end
+
+      it 'should return one version only if given an artifact and a set of artifacts with one occurence of the given artifact' do
+        artifact = 'foo:foobar:jar:0'
+        original_set = ['foo:bar:jar:1.0', 'foo:bar:jar:2.0', 'foo:foobar:jar:1.0']
+        actual_versions = HelperFunctions.get_all_versions artifact, original_set
+        expected_versions = [Version.new('1.0')]
+        actual_versions.should == expected_versions
+      end
+
+      it 'should not return repeated versions' do
+        artifact = 'foo:bar:jar:0'
+        original_set = ['foo:bar:jar:1.0', 'foo:bar:jar:1.0']
+        actual_versions = HelperFunctions.get_all_versions artifact, original_set
+        expected_versions = [Version.new('1.0')]
+        actual_versions.should == expected_versions
+      end
+
+    end
+  end
+
+end

data/spec/issues/issue_0_spec.rb

@@ -0,0 +1,54 @@
+require 'rubygems'
+require 'buildr'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib', 'buildr-dependency-extensions'))
+require File.expand_path(File.join('spec', 'spec_helpers'), Gem::GemPathSearcher.new.find('buildr').full_gem_path)
+
+describe 'Issue 1, mockito 1.8.1-rc1 is chosen instead of 1.8.5' do
+  before(:each) do
+    write artifact('foo:bar:jar:1.2').pom.to_s, <<-XML
+<project>
+  <artifactId>bar</artifactId>
+  <groupId>fuu</groupId>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito</artifactId>
+      <version>1.8.1-rc1</version>
+      <scope>test</scope>
+    </dependency>
+  </dependencies>
+</project>
+XML
+
+    write artifact('org.mockito:mockito:jar:1.8.5').pom.to_s, <<-XML
+<project>
+  <artifactId>mockito</artifactId>
+  <groupId>org.mockito</groupId>
+</project>
+XML
+
+    write artifact('org.mockito:mockito:jar:1.8.1-rc1').pom.to_s, <<-XML
+<project>
+  <artifactId>mockito</artifactId>
+  <groupId>org.mockito</groupId>
+</project>
+XML
+
+  end
+
+  it 'should not use mockito 1.8.5 instead of 1.8.1-rc1' do
+    define "Issue1Project" do
+      extend TransitiveDependencies
+      project.version = '1.0'
+      project.transitive_scopes = [:compile, :test]
+
+      compile.with 'foo:bar:jar:1.2'
+      test.with 'org.mockito:mockito:jar:1.8.5'
+    end
+
+    expected_test_dependencies = [artifact('org.mockito:mockito:jar:1.8.5'), artifact('foo:bar:jar:1.2')]
+    actual_test_dependencies = project('Issue1Project').test.dependencies
+    actual_test_dependencies.should == expected_test_dependencies
+  end
+end

data/spec/issues/issue_2_spec.rb

@@ -0,0 +1,29 @@
+require 'rubygems'
+require 'buildr'
+require File.expand_path(File.join(File.dirname(__FILE__), '../../lib/buildr-dependency-extensions'))
+require File.expand_path(File.join('spec', 'spec_helpers'), Gem::GemPathSearcher.new.find('buildr').full_gem_path)
+
+describe 'dependency resolution with jar dependencies' do
+  it 'throws exception: undefined method depth= for JarTask' do
+    define "TestProject" do
+      project.version = '1.0'
+      extend TransitiveDependencies
+      project.transitive_scopes = [:compile]
+
+      define 'bar' do
+        extend TransitiveDependencies
+        project.transitive_scopes = [:compile]
+        package :jar
+      end
+
+      define 'baz' do
+        extend TransitiveDependencies
+        project.transitive_scopes = [:compile]
+        compile.with project("bar")
+        package :jar
+      end
+    end
+
+    project('TestProject:baz').compile.dependencies[0].depth
+  end
+end

data/spec/maven_dependency_mechanism_spec.rb

@@ -0,0 +1,55 @@
+require 'rubygems'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib/buildr-dependency-extensions'))
+require File.expand_path(File.join('spec', 'spec_helpers'), Gem::GemPathSearcher.new.find('buildr').full_gem_path)
+
+describe 'Maven' do
+  before(:each) do
+    write artifact('foo:bar:jar:2.0').pom.to_s, <<-XML
+<project>
+  <artifactId>bar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+
+    write artifact('foo:bar:jar:2.1').pom.to_s, <<-XML
+<project>
+  <artifactId>bar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+
+    write artifact('transitive:dependencies:jar:2.0').pom.to_s, <<-XML
+<project>
+  <artifactId>transitive</artifactId>
+  <groupId>dependencies</groupId>
+
+  <dependencies>
+    <dependency>
+      <groupId>foo</groupId>
+      <artifactId>bar</artifactId>
+      <version>2.1</version>
+      <scope>runtime</scope>
+    </dependency>
+  </dependencies>
+</project>
+XML
+  end
+
+  describe 'version conflict resolver' do
+    it 'uses the depth of the dependency to resolve version conflicts' do
+      define "TestProject" do
+        extend TransitiveDependencies
+        project.version = '1.0'
+
+        project.transitive_scopes = [:run]
+
+        run.with 'foo:bar:jar:2.0'
+        run.with 'transitive:dependencies:jar:2.0'
+
+      end
+
+      expected_dependencies = [artifact('foo:bar:jar:2.0'), artifact('transitive:dependencies:jar:2.0')]
+      project('TestProject').run.classpath.should ==(expected_dependencies)
+    end
+  end
+end

data/spec/pom_generator_spec.rb

@@ -0,0 +1,187 @@
+require 'rubygems'
+require 'buildr'
+require 'xmlsimple'
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib/buildr-dependency-extensions'))
+
+
+describe BuildrDependencyExtensions::PomGenerator do
+  before(:each) do
+    write artifact('foo:bar:jar:1.0').pom.to_s, <<-XML
+<project>
+  <artifactId>bar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+
+    write artifact('foo:bar:jar:1.1').pom.to_s, <<-XML
+<project>
+  <artifactId>bar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+
+    write artifact('foo:foobar:jar:1.0').pom.to_s, <<-XML
+<project>
+  <artifactId>foobar</artifactId>
+  <groupId>foo</groupId>
+</project>
+XML
+  end
+
+  it "should not add any dependencies if PomGenerator isn't included" do
+    define "TestProject" do
+      extend TransitiveDependencies
+
+      project.version = '1.0-SNAPSHOT'
+      project.group = 'foo.bar'
+      compile.with 'foo:bar:jar:1.0'
+    end
+
+    pom = project('TestProject').package(:jar).pom
+    pom.invoke
+    generated_pom_hash = XmlSimple.xml_in(File.open(pom.to_s).read, {'ForceArray' => false})
+    expected_pom_hash = {
+      'modelVersion' => '4.0.0',
+      'groupId'      => 'foo.bar',
+      'artifactId'   => 'TestProject',
+      'version'      => '1.0-SNAPSHOT'
+    }
+    generated_pom_hash.should eql expected_pom_hash
+  end
+
+  it 'should add all compile dependencies with compile scope' do
+    define "TestProject" do
+      extend PomGenerator
+
+      project.version = '1.0-SNAPSHOT'
+      project.group = 'foo.bar'
+      compile.with 'foo:bar:jar:1.0'
+    end
+
+    pom = project('TestProject').package(:jar).pom
+    pom.invoke
+    generated_pom_hash = XmlSimple.xml_in(File.open(pom.to_s).read, {'ForceArray' => ['dependencies']})
+    expected_pom_hash = {
+      'modelVersion' => '4.0.0',
+      'groupId'      => 'foo.bar',
+      'artifactId'   => 'TestProject',
+      'version'      => '1.0-SNAPSHOT',
+      'dependencies' =>
+      [{ 'dependency' => {
+           'groupId'    => 'foo',
+           'artifactId' => 'bar',
+           'version'    => '1.0',
+           'scope'      => 'compile',
+           'type'       => 'jar'
+         }
+       }]
+    }
+    generated_pom_hash.should eql expected_pom_hash
+  end
+
+  it 'should add all runtime dependencies with runtime scope' do
+    define "TestProject" do
+      extend PomGenerator
+
+      project.version = '1.0-SNAPSHOT'
+      project.group = 'foo.bar'
+      run.with ['foo:bar:jar:1.0', 'foo:foobar:jar:1.0']
+    end
+
+    pom = project('TestProject').package(:jar).pom
+    pom.invoke
+    generated_pom_hash = XmlSimple.xml_in(File.open(pom.to_s).read, {'ForceArray' => ['dependency', 'plugin']})
+    expected_pom_hash = {
+      'modelVersion' => '4.0.0',
+      'groupId'      => 'foo.bar',
+      'artifactId'   => 'TestProject',
+      'version'      => '1.0-SNAPSHOT',
+      'dependencies' => { 'dependency' =>
+        [{
+           'groupId'    => 'foo',
+           'artifactId' => 'bar',
+           'version'    => '1.0',
+           'scope'      => 'runtime',
+           'type'       => 'jar'
+         },
+         {
+           'groupId'    => 'foo',
+           'artifactId' => 'foobar',
+           'version'    => '1.0',
+           'scope'      => 'runtime',
+           'type'       => 'jar'
+         }]
+      }
+    }
+    generated_pom_hash.should eql expected_pom_hash
+  end
+
+  it 'should add all test dependencies with test scope' do
+    define "TestProject" do
+      extend PomGenerator
+
+      project.version = '1.0-SNAPSHOT'
+      project.group = 'foo.bar'
+      test.with 'foo:bar:jar:1.0'
+    end
+
+    pom = project('TestProject').package(:jar).pom
+    pom.invoke
+    generated_pom_hash = XmlSimple.xml_in(File.open(pom.to_s).read, {'ForceArray' => ['dependency', 'plugin']})
+    expected_pom_hash = {
+      'modelVersion' => '4.0.0',
+      'groupId'      => 'foo.bar',
+      'artifactId'   => 'TestProject',
+      'version'      => '1.0-SNAPSHOT',
+      'dependencies' => { 'dependency' =>
+        [{
+           'groupId'    => 'foo',
+           'artifactId' => 'bar',
+           'version'    => '1.0',
+           'scope'      => 'test',
+           'type'       => 'jar'
+         }]
+       }
+    }
+    generated_pom_hash.should eql expected_pom_hash
+  end
+
+
+  it 'adds all extra pom sections to the generated pom' do
+    define "TestProject" do
+      extend PomGenerator
+
+      project.version = '1.0-SNAPSHOT'
+      project.group = 'foo.bar'
+      test.with 'foo:bar:jar:1.0'
+
+      project.extra_pom_sections['plugins'] =  [{'plugin' => {'groupId' => 'foo', 'artifactId' => 'bar'}}]
+    end
+
+    pom = project('TestProject').package(:jar).pom
+    pom.invoke
+    generated_pom_hash = XmlSimple.xml_in(File.open(pom.to_s).read, {'ForceArray' => ['dependency', 'plugin']})
+    expected_pom_hash = {
+      'modelVersion' => '4.0.0',
+      'groupId'      => 'foo.bar',
+      'artifactId'   => 'TestProject',
+      'version'      => '1.0-SNAPSHOT',
+      'dependencies' => { 'dependency' =>
+        [{
+           'groupId'    => 'foo',
+           'artifactId' => 'bar',
+           'version'    => '1.0',
+           'scope'      => 'test',
+           'type'       => 'jar'
+         }]
+      },
+      'plugins' => { 'plugin' =>
+        [{
+           'groupId'    => 'foo',
+           'artifactId' => 'bar'
+         }]
+       }
+    }
+    generated_pom_hash.should eql expected_pom_hash
+  end
+end