buildkite-builder 3.8.3 → 3.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2591489e3b57711b38926cf558ee362c2c579086b46ff800fccffb8db4598a92
-  data.tar.gz: cc12ee969c8e846008f13eea3ad61de0efa32d8706bda83ce76a3bf7e8b7772f
+  metadata.gz: 38dd50aa0554deb37552ff778d49fd94bd4e22e242ae72ccf179fdcf3460cf25
+  data.tar.gz: a134a4f33462478c35b965c4dbbdb4451cfd4b383817150fc192301fada635af
 SHA512:
-  metadata.gz: 6901d0afda1b70080615f5937ef7fa17c90023f1141606e4adf8f77b5ac3252da2f656070b22528b8eea2703686fb2e7af30575f6075e2d19e730a4b4c0df9e5
-  data.tar.gz: 39d6c40ec9a8f194997af75eb4776753d3b6904bbd19783e1592f92b260f918ccbda81c764efca332305e1f67073bcf7f060d52931a8738c1a2a7a56ffa5a924
+  metadata.gz: '02599590709a1ca3f7e19da232889b3bf26ff316ff48dc10b8ec3751efc1e08c39a3bf05c6eee21bc2d6463b296d8d777d1d89f5b55abd6ad1667ec89925fa8f'
+  data.tar.gz: a8b4e2b45030b631e1bbb9da80954a7debc9d056945e1e57f36b1df51e88fa68812bb3c99e3826536df356a0520d3e0fe830aa98fd7bea7f88a02dece853253e

data/VERSION

@@ -1 +1 @@
-3.8.3
+3.9.0

data/lib/buildkite/builder/extensions/plugins.rb

@@ -0,0 +1,47 @@
+module Buildkite
+  module Builder
+    module Extensions
+      class Plugins < Extension
+        attr_reader :manager
+
+        dsl do
+          def plugin(name, uri, default_attributes = {})
+            context.extensions.find(Buildkite::Builder::Extensions::Plugins).manager.add(name, uri, default_attributes)
+          end
+        end
+
+        def prepare
+          @manager = PluginManager.new
+        end
+
+        def build
+          context.data.steps.each(:command) do |step|
+            next unless step.has?(:plugins)
+
+            step.get(:plugins).map! do |plugin|
+              resource, attributes = extract_resource_and_attributes(plugin)
+              resource.is_a?(Symbol) ? manager.build(resource, attributes) : plugin
+            end
+          end
+
+          context.data.pipelines.each do |pipeline|
+            pipeline.data.steps.each(:command) do |step|
+              next unless step.has?(:plugins)
+
+              step.get(:plugins).map! do |plugin|
+                resource, attributes = extract_resource_and_attributes(plugin)
+                resource.is_a?(Symbol) ? manager.build(resource, attributes) : plugin
+              end
+            end
+          end
+        end
+
+        private
+
+        def extract_resource_and_attributes(plugin)
+          [plugin.keys.first, plugin.values.first]
+        end
+      end
+    end
+  end
+end

data/lib/buildkite/builder/extensions/steps.rb

@@ -3,10 +3,7 @@ module Buildkite
     module Extensions
       class Steps < Extension
         def prepare
-          context.data.steps = StepCollection.new(
-            TemplateManager.new(context.root),
-            PluginManager.new
-          )
+          context.data.steps = StepCollection.new(TemplateManager.new(context.root))
         end
 
         dsl do
@@ -21,10 +18,6 @@ module Buildkite
             context.data.steps.push(Buildkite::Builder::Group.new(label, context, &block))
           end
 
-          def plugin(name, uri, default_attributes = {})
-            context.data.steps.plugins.add(name, uri, default_attributes)
-          end
-
           def block(template = nil, **args, &block)
             context.data.steps.add(Pipelines::Steps::Block, template, **args, &block)
           end

data/lib/buildkite/builder/extensions/sub_pipelines.rb

@@ -28,10 +28,7 @@ module Buildkite
             @context = context
             @name = name
             @data = Data.new
-            @data.steps = StepCollection.new(
-              context.data.steps.templates,
-              context.data.steps.plugins
-            )
+            @data.steps = StepCollection.new(context.data.steps.templates)
             @data.notify = []
             @data.env = {}
 

data/lib/buildkite/builder/extensions.rb

@@ -8,6 +8,7 @@ module Buildkite
       autoload :Notify, File.expand_path('extensions/notify', __dir__)
       autoload :SubPipelines, File.expand_path('extensions/sub_pipelines', __dir__)
       autoload :Steps, File.expand_path('extensions/steps', __dir__)
+      autoload :Plugins, File.expand_path('extensions/plugins', __dir__)
       autoload :Use, File.expand_path('extensions/use', __dir__)
     end
   end

data/lib/buildkite/builder/group.rb

@@ -16,10 +16,7 @@ module Buildkite
       def initialize(label, context, &block)
         @label = label
         @data = Data.new
-        @data.steps = StepCollection.new(
-          context.data.steps.templates,
-          context.data.steps.plugins
-        )
+        @data.steps = StepCollection.new(context.data.steps.templates)
         @data.notify = []
 
         # Use `clone` to copy over dsl's extended extensions

data/lib/buildkite/builder/pipeline.rb

@@ -38,6 +38,7 @@ module Buildkite
         use(Extensions::Env)
         use(Extensions::Notify)
         use(Extensions::Steps)
+        use(Extensions::Plugins)
         use(Extensions::SubPipelines)
       end
 

data/lib/buildkite/builder/plugin.rb

@@ -3,16 +3,16 @@
 module Buildkite
   module Builder
     class Plugin
-      attr_reader :uri, :source, :version, :attributes
+      attr_reader \
+        :uri,
+        :source,
+        :version,
+        :default_attributes
 
-      def initialize(uri, attributes = {})
+      def initialize(uri, default_attributes = {})
         @uri = uri
         @source, @version = uri.split('#')
-        @attributes = attributes
-      end
-
-      def to_h
-        Buildkite::Pipelines::Helpers.sanitize(uri => (attributes&.empty? ? nil : attributes))
+        @default_attributes = default_attributes
       end
     end
   end

data/lib/buildkite/builder/plugin_manager.rb

@@ -7,23 +7,16 @@ module Buildkite
 
       def add(name, uri, default_attributes = {})
         name = name.to_s
+        raise(ArgumentError, "Plugin already defined: #{name}") if @plugins.key?(name)
 
-        if @plugins.key?(name)
-          raise ArgumentError, "Plugin already defined: #{name}"
-        end
-
-        @plugins[name] = {
-          uri: uri,
-          default_attributes: default_attributes
-        }
+        @plugins[name] = Plugin.new(uri, default_attributes)
       end
 
-      def fetch(name)
-        @plugins[name]
-      end
+      def build(name, attributes = {})
+        plugin = @plugins[name.to_s]
+        raise(ArgumentError, "Plugin is not registered: #{resource}") unless plugin
 
-      def to_definition
-        # No-op
+        { plugin.uri => plugin.default_attributes.merge(attributes) }
       end
     end
   end

data/lib/buildkite/builder/step_collection.rb

@@ -2,12 +2,10 @@ module Buildkite
   module Builder
     class StepCollection
       attr_reader :templates
-      attr_reader :plugins
       attr_reader :steps
 
-      def initialize(templates, plugins)
+      def initialize(templates)
         @templates = templates
-        @plugins = plugins
         @steps = []
       end
 

data/lib/buildkite/builder.rb

@@ -18,7 +18,6 @@ module Buildkite
     autoload :Processors, File.expand_path('builder/processors', __dir__)
     autoload :Rainbow, File.expand_path('builder/rainbow', __dir__)
     autoload :Plugin, File.expand_path('builder/plugin', __dir__)
-    autoload :PluginCollection, File.expand_path('builder/plugin_collection', __dir__)
     autoload :StepCollection, File.expand_path('builder/step_collection', __dir__)
     autoload :PipelineCollection, File.expand_path('builder/pipeline_collection', __dir__)
     autoload :TemplateManager, File.expand_path('builder/template_manager', __dir__)

data/lib/buildkite/pipelines/helpers/plugins.rb

@@ -5,12 +5,7 @@ module Buildkite
     module Helpers
       module Plugins
         def plugin(name_or_source, plugin_attributes = {})
-          attributes['plugins'] ||= Buildkite::Builder::PluginCollection.new(step_collection.plugins)
-          attributes['plugins'].add(name_or_source, plugin_attributes)
-        end
-
-        def plugins
-          attributes['plugins']
+          append(:plugins, { name_or_source => plugin_attributes })
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: buildkite-builder
 version: !ruby/object:Gem::Version
-  version: 3.8.3
+  version: 3.9.0
 platform: ruby
 authors:
 - Ngan Pham
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-12-09 00:00:00.000000000 Z
+date: 2022-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -113,6 +113,7 @@ files:
 - lib/buildkite/builder/extensions/env.rb
 - lib/buildkite/builder/extensions/lib.rb
 - lib/buildkite/builder/extensions/notify.rb
+- lib/buildkite/builder/extensions/plugins.rb
 - lib/buildkite/builder/extensions/steps.rb
 - lib/buildkite/builder/extensions/sub_pipelines.rb
 - lib/buildkite/builder/extensions/use.rb
@@ -125,7 +126,6 @@ files:
 - lib/buildkite/builder/pipeline.rb
 - lib/buildkite/builder/pipeline_collection.rb
 - lib/buildkite/builder/plugin.rb
-- lib/buildkite/builder/plugin_collection.rb
 - lib/buildkite/builder/plugin_manager.rb
 - lib/buildkite/builder/rainbow.rb
 - lib/buildkite/builder/step_collection.rb
@@ -177,7 +177,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: A gem for programmatically creating Buildkite pipelines.

data/lib/buildkite/builder/plugin_collection.rb

@@ -1,49 +0,0 @@
-module Buildkite
-  module Builder
-    class PluginCollection
-      attr_reader :plugin_manager
-
-      def initialize(plugin_manager)
-        @plugin_manager = plugin_manager
-        @collection = []
-      end
-
-      def add(resource, attributes = {})
-        plugin =
-          case resource
-          when Symbol
-            registered_plugin = plugin_manager.fetch(resource.to_s)
-
-            raise ArgumentError, "Plugin `#{resource}` does not exist" unless registered_plugin
-
-            Plugin.new(registered_plugin[:uri], registered_plugin[:default_attributes].merge(attributes))
-          when String
-            Plugin.new(resource, attributes)
-          when Plugin
-            resource
-          else
-            raise ArgumentError, "Unknown plugin `#{resource.inspect}`"
-          end
-
-        @collection.push(plugin).last
-      end
-
-      def find(source)
-        source_string =
-          case source
-          when String then source
-          when Plugin then source.source
-          else raise ArgumentError, "Unknown source #{source.inspect}"
-          end
-
-        @collection.select do |plugin|
-          plugin.source == source_string
-        end
-      end
-
-      def to_definition
-        @collection.map(&:to_h)
-      end
-    end
-  end
-end