buildkit 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 6bfeb459ca2ab1b4f33f68b3af71c8e5000a3c1d
-  data.tar.gz: 627be0e606c9781b8a1378630abceb8954ec49ae
+SHA256:
+  metadata.gz: b660f3bc437b261aac25d8a7e8dbeb533570924857e17309f31c283d847725f4
+  data.tar.gz: 1c3e6d58d5a38377d30b62ba3a98fededa51cfdb121f8371c3801d93e185d234
 SHA512:
-  metadata.gz: 7ef6f8e563bccf36437c2def7676473a124a5f7a4a3cb9ef6f8cfaea8bf424d4a72c933c52714756928bbd14aed289cd17afc45aaed6fea1f7ff75502b2d445a
-  data.tar.gz: 733f57b132f8788603b8e618448769967c5f78daa5524ed8abc5b5e425d2b1199609b5fd62bdd222a313a3874d007da022802edd3026c7548d7402bc8a0399fe
+  metadata.gz: 4fbc1cd2171b549376fd0baf0b342b53312d9d2c67deaa349bbeb5dc6e91a8eca3e61dd6a34dedbcc4e6bc47f9c90b8a63aefbbaabfc80de96907f648a8aa95e
+  data.tar.gz: 9b88b7ca24fba99297585e26e425dc31d33d9ed89c5e65e6db7d13c11c43b9bce98b65dfe2241c9570ca3cb297c2ebb4b21e46d632c17007c495e46208232961

data/.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.3
 
 Metrics/LineLength:
   Max: 120
@@ -39,7 +39,7 @@ Lint/AssignmentInCondition:
 Style/PerlBackrefs:
   Enabled: false
 
-Style/SpaceInsideHashLiteralBraces:
+Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
 Style/TrailingCommaInArrayLiteral:

data/.travis.yml

@@ -1,6 +1,4 @@
 sudo: false
 before_install: gem install bundler
 rvm:
-  - '2.2'
-  - '2.3'
-
+  - '2.5'

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'byebug'

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 
 require 'rspec/core/rake_task'

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'buildkit'

data/buildkit.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'buildkit/version'
@@ -17,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.2'
+  spec.required_ruby_version = '>= 2.3'
 
   spec.add_dependency 'sawyer', '~> 0.6'
   spec.add_development_dependency 'bundler'

data/dev.yml

@@ -0,0 +1,13 @@
+name: buildkit
+
+type: ruby
+
+up:
+  - homebrew:
+    - openssl
+  - ruby: 2.5.5
+  - bundler
+
+commands:
+  test:
+    run: bundle exec rake

data/lib/buildkit.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'buildkit/version'
 require 'buildkit/client'
 

data/lib/buildkit/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sawyer'
 require 'buildkit/client/agents'
 require 'buildkit/client/builds'
@@ -18,7 +20,7 @@ module Buildkit
     include Artifacts
     include HeaderLinkParser
 
-    DEFAULT_ENDPOINT = 'https://api.buildkite.com/v2/'.freeze
+    DEFAULT_ENDPOINT = 'https://api.buildkite.com/v2/'
 
     # Header keys that can be passed in options hash to {#get},{#head}
     CONVENIENCE_HEADERS = Set.new(%i[accept content_type])
@@ -139,10 +141,15 @@ module Buildkit
       response = []
       loop do
         request method, path, data, options
+
+        # Paginated API calls always return Arrays.
+        return last_response.data unless @last_response.data.is_a?(Array)
+
         response.concat @last_response.data
 
         link_header = parse_link_header(@last_response.headers[:link])
         break if link_header[:next].nil?
+
         path = next_page(link_header[:next])
       end
       response
@@ -181,7 +188,7 @@ module Buildkit
       end
       query = options.delete(:query)
       opts = {query: options}
-      opts[:query].merge!(query) if query && query.is_a?(Hash)
+      opts[:query].merge!(query) if query&.is_a?(Hash)
       opts[:headers] = headers unless headers.empty?
 
       opts

data/lib/buildkit/client/agents.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Agents API

data/lib/buildkit/client/artifacts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Artifacts API

data/lib/buildkit/client/builds.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Builds API

data/lib/buildkit/client/jobs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Jobs API

data/lib/buildkit/client/organizations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Organizations API

data/lib/buildkit/client/pipelines.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the pipelines API
@@ -31,7 +33,7 @@ module Buildkit
       # @param org [String] Organization slug.
       # @see https://buildkite.com/docs/api/pipelines#create-a-pipeline
       # @example
-      #   Buildkit.create_build('my-great-org', {
+      #   Buildkit.create_pipeline('my-great-org', {
       #     name: 'My pipeline',
       #     repository: 'git@github.com:acme/pipeline.git',
       #     steps: [

data/lib/buildkit/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   # Custom error class for rescuing from all Buildkite errors
   class Error < StandardError
@@ -44,7 +46,7 @@ module Buildkit
     # Array of validation errors
     # @return [Array<Hash>] Error info
     def errors
-      if data && data.is_a?(Hash)
+      if data&.is_a?(Hash)
         data[:errors] || []
       else
         []
@@ -98,7 +100,7 @@ module Buildkit
     def build_error_message
       return nil if @response.nil?
 
-      message = "#{@response[:method].to_s.upcase} #{redact_url(@response[:url].to_s)}: #{@response[:status]} - "
+      message = +"#{@response[:method].to_s.upcase} #{redact_url(@response[:url].to_s)}: #{@response[:status]} - "
       message << "#{response_message}#{response_error}#{response_error_summary}"
       message << " // See: #{documentation_url}" unless documentation_url.nil?
       message

data/lib/buildkit/header_link_parser.rb

@@ -1,26 +1,30 @@
-module HeaderLinkParser
-  module_function
+# frozen_string_literal: true
 
-  def parse_link_header(link_header)
-    {}.tap do |hash_link|
-      link_header.split(',').each do |link|
-        link_obj = LinkParser.new(link)
-        hash_link[link_obj.name] = link_obj.link
+module Buildkit
+  module HeaderLinkParser
+    module_function
+
+    def parse_link_header(link_header)
+      {}.tap do |hash_link|
+        link_header.split(',').each do |link|
+          link_obj = LinkParser.new(link)
+          hash_link[link_obj.name] = link_obj.link
+        end
       end
     end
-  end
 
-  class LinkParser
-    def initialize(value)
-      @value = value
-    end
+    class LinkParser
+      def initialize(value)
+        @value = value
+      end
 
-    def name
-      @name ||= @value[/rel="(.*)"/, 1].to_sym
-    end
+      def name
+        @name ||= @value[/rel="(.*)"/, 1].to_sym
+      end
 
-    def link
-      @link ||= @value[/<(.+)>/, 1]
+      def link
+        @link ||= @value[/<(.+)>/, 1]
+      end
     end
   end
 end

data/lib/buildkit/response/raise_error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'faraday'
 require 'buildkit/error'
 

data/lib/buildkit/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
-  VERSION = '1.4.0'.freeze
+  VERSION = '1.4.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: buildkit
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-12 00:00:00.000000000 Z
+date: 2019-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sawyer
@@ -57,6 +57,7 @@ files:
 - bin/console
 - bin/setup
 - buildkit.gemspec
+- dev.yml
 - lib/buildkit.rb
 - lib/buildkit/client.rb
 - lib/buildkit/client/agents.rb
@@ -81,15 +82,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Ruby toolkit for working with the Buildkite API