buildkit 1.3.0 → 1.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1c6dff3c82bb149b2cdc144fd406166383677156
-  data.tar.gz: 546b10638c5c057c039938453c91f950c39762a6
+SHA256:
+  metadata.gz: 3234026dc18c6c851be2a80e70c95a07e0a865911e8d3c04f89587cadbd6d8ba
+  data.tar.gz: 8c556f3866f605247c76162dd662bb3e4dda1799629f934acbe00b8a3c6c0342
 SHA512:
-  metadata.gz: fc285edc5ef194f29f87ffbe771fcd624d1f629d651c90f119a077d22a3fbf4b6393a1c2bb8d3e16a5ab0876be5ac3f35490fcb856d8d24e78ad6ccbf18ca8d8
-  data.tar.gz: 91d612ddcc59751858f38788fd8e882847ff03863149aaa00534cdeebb85b07635ce0f040a87526cf817d7bc9f6db1812cefff92d6ffb5c83eb1c99798a3694a
+  metadata.gz: 0db8c6342b4d25b3f7fa9b05a02d17fe6c2c49331e158ff1719f54585dbd134f92f0340233da8702bf23e4fbba9737c72d6862d8c93b07dd2200d1dfab4f6707
+  data.tar.gz: 7665d18d238bcd393d864f4e905639fad9753fd708f6fffa158478faf205800103c090ed7b4c2a8a58e15eda24a1ab8359c95f7771d9b93ffed39387f95fb3a5

data/.github/workflows/ci.yml

@@ -0,0 +1,21 @@
+on: push
+name: Test Buildkit Gem
+
+jobs:
+  build:
+    runs-on: ubuntu-20.04
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.6', '2.7', '3.0' ]
+    name: Ruby ${{ matrix.ruby }}
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - name: bundle install
+        run: |
+          gem install bundler
+          bundle install --jobs 4 --retry 3
+      - name: Run rspec
+        run: 'bundle exec rspec spec'

data/.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.1
+  TargetRubyVersion: 2.3
 
 Metrics/LineLength:
   Max: 120
@@ -9,6 +9,9 @@ Metrics/LineLength:
 Metrics/MethodLength:
   Max: 25
 
+Metrics/ClassLength:
+  Enabled: false
+
 Metrics/BlockLength:
   Enabled: false # RSpec ... :facepalm:
 
@@ -36,10 +39,13 @@ Lint/AssignmentInCondition:
 Style/PerlBackrefs:
   Enabled: false
 
-Style/SpaceInsideHashLiteralBraces:
+Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: comma
 
 Style/TrailingCommaInArguments:

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gem 'byebug'
@@ -7,7 +9,7 @@ gem 'yard'
 
 group :test do
   gem 'rspec', '~> 3.2'
-  gem 'vcr', '~> 2.9', github: 'vcr/vcr', branch: 'master', ref: '480304be6d73803e6c4a0eb21a4ab4091da558d8'
+  gem 'vcr', '~> 3.0'
 end
 
 gemspec

data/README.md

@@ -2,7 +2,6 @@
 
 Ruby toolkit for the Buildkite API.
 
-[![Build Status](https://secure.travis-ci.org/Shopify/buildkit.png)](http://travis-ci.org/Shopify/buildkit)
 [![Gem Version](https://badge.fury.io/rb/buildkit.png)](http://badge.fury.io/rb/buildkit)
 
 ## Installation

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 
 require 'rspec/core/rake_task'

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'buildkit'

data/buildkit.gemspec

@@ -1,6 +1,6 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'buildkit/version'
 
@@ -19,8 +19,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.0'
+  spec.metadata['allowed_push_host'] = 'https://rubygems.org'
 
-  spec.add_dependency 'sawyer', '~> 0.6'
+  spec.required_ruby_version = '>= 2.3'
+
+  spec.add_dependency 'sawyer', '>= 0.6'
   spec.add_development_dependency 'bundler'
 end

data/dev.yml

@@ -0,0 +1,11 @@
+name: buildkit
+
+type: ruby
+
+up:
+  - ruby: 2.5.5
+  - bundler
+
+commands:
+  test:
+    run: bundle exec rake

data/lib/buildkit.rb

@@ -1,8 +1,13 @@
+# frozen_string_literal: true
+
 require 'buildkit/version'
 require 'buildkit/client'
 
 module Buildkit
-  def self.new(*args)
-    Client.new(*args)
+  class << self
+    def new(*args)
+      Client.new(*args)
+    end
+    ruby2_keywords :new if respond_to?(:ruby2_keywords, true)
   end
 end

data/lib/buildkit/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sawyer'
 require 'buildkit/client/agents'
 require 'buildkit/client/builds'
@@ -6,6 +8,7 @@ require 'buildkit/client/pipelines'
 require 'buildkit/client/jobs'
 require 'buildkit/client/artifacts'
 require 'buildkit/response/raise_error'
+require 'buildkit/header_link_parser'
 
 module Buildkit
   class Client
@@ -15,8 +18,9 @@ module Buildkit
     include Pipelines
     include Jobs
     include Artifacts
+    include HeaderLinkParser
 
-    DEFAULT_ENDPOINT = 'https://api.buildkite.com/v2/'.freeze
+    DEFAULT_ENDPOINT = 'https://api.buildkite.com/v2/'
 
     # Header keys that can be passed in options hash to {#get},{#head}
     CONVENIENCE_HEADERS = Set.new(%i[accept content_type])
@@ -24,6 +28,8 @@ module Buildkit
     # In Faraday 0.9, Faraday::Builder was renamed to Faraday::RackBuilder
     RACK_BUILDER_CLASS = defined?(Faraday::RackBuilder) ? Faraday::RackBuilder : Faraday::Builder
 
+    attr_accessor :auto_paginate
+
     class << self
       def build_middleware
         RACK_BUILDER_CLASS.new do |builder|
@@ -36,10 +42,11 @@ module Buildkit
 
     def initialize(endpoint: ENV.fetch('BUILDKITE_API_ENDPOINT', DEFAULT_ENDPOINT),
                    token: ENV.fetch('BUILDKITE_API_TOKEN'),
-                   middleware: self.class.build_middleware)
+                   middleware: self.class.build_middleware, auto_paginate: false)
       @middleware = middleware
       @endpoint = endpoint
       @token = token
+      @auto_paginate = auto_paginate
     end
 
     # Make a HTTP GET request
@@ -48,7 +55,11 @@ module Buildkit
     # @param options [Hash] Query and header params for request
     # @return [Sawyer::Resource]
     def get(url, options = {})
-      request :get, url, parse_query_and_convenience_headers(options)
+      if @auto_paginate
+        paginate :get, url, parse_query_and_convenience_headers(options)
+      else
+        request :get, url, parse_query_and_convenience_headers(options)
+      end
     end
 
     # Make a HTTP POST request
@@ -109,19 +120,51 @@ module Buildkit
 
     def request(method, path, data, options = {})
       if data.is_a?(Hash)
-        options[:query]   = data.delete(:query) || {}
-        options[:headers] = data.delete(:headers) || {}
+        options = extract_query_and_headers_from data
         if accept = data.delete(:accept)
           options[:headers][:accept] = accept
         end
       end
 
-      @last_response = response = sawyer_agent.call(method, URI::Parser.new.escape(path.to_s), data, options)
+      @last_response = response = sawyer_agent.call(method, URI::DEFAULT_PARSER.escape(path.to_s), data, options)
       response.data
     end
 
+    def extract_query_and_headers_from(data)
+      {
+        query: data.delete(:query) || {},
+        headers: data.delete(:headers) || {},
+      }
+    end
+
+    def paginate(method, path, data, options = {})
+      response = []
+      loop do
+        request method, path, data, options
+
+        # Paginated API calls always return Arrays.
+        return last_response.data unless @last_response.data.is_a?(Array)
+
+        response.concat @last_response.data
+
+        link_header = parse_link_header(@last_response.headers[:link])
+        break if link_header[:next].nil?
+
+        path = next_page(link_header[:next])
+      end
+      response
+    end
+
+    def next_page(next_page)
+      build_path URI(next_page)
+    end
+
+    def build_path(uri)
+      "#{uri.path}?#{uri.query}"
+    end
+
     def sawyer_agent
-      @agent ||= Sawyer::Agent.new(@endpoint, sawyer_options) do |http|
+      @sawyer_agent ||= Sawyer::Agent.new(@endpoint, sawyer_options) do |http|
         http.headers[:accept] = 'application/json'
         http.headers[:content_type] = 'application/json'
         http.headers[:user_agent] = "Buildkit v#{Buildkit::VERSION}"
@@ -145,7 +188,7 @@ module Buildkit
       end
       query = options.delete(:query)
       opts = {query: options}
-      opts[:query].merge!(query) if query && query.is_a?(Hash)
+      opts[:query].merge!(query) if query&.is_a?(Hash)
       opts[:headers] = headers unless headers.empty?
 
       opts

data/lib/buildkit/client/agents.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Agents API

data/lib/buildkit/client/artifacts.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Artifacts API
@@ -13,6 +15,16 @@ module Buildkit
       def artifacts(org, pipeline, build, options = {})
         get("/v2/organizations/#{org}/pipelines/#{pipeline}/builds/#{build}/artifacts", options)
       end
+
+      # List all artifacts for a job
+      #
+      # @return [Array<Sawyer::Resource>] Array of hashes representing Buildkite artifacts.
+      # @see https://buildkite.com/docs/rest-api/artifacts#list-artifacts-for-a-job
+      # @example
+      #   Buildkit.job_artifacts('my-great-org', 'great-pipeline', 42, '76365070-34d5-4104-8b91-952780f8029f')
+      def job_artifacts(org, pipeline, build, job, options = {})
+        get("/v2/organizations/#{org}/pipelines/#{pipeline}/builds/#{build}/jobs/#{job}/artifacts", options)
+      end
     end
   end
 end

data/lib/buildkit/client/builds.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Builds API

data/lib/buildkit/client/jobs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Jobs API

data/lib/buildkit/client/organizations.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the Organizations API

data/lib/buildkit/client/pipelines.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   class Client
     # Methods for the pipelines API
@@ -31,7 +33,7 @@ module Buildkit
       # @param org [String] Organization slug.
       # @see https://buildkite.com/docs/api/pipelines#create-a-pipeline
       # @example
-      #   Buildkit.create_build('my-great-org', {
+      #   Buildkit.create_pipeline('my-great-org', {
       #     name: 'My pipeline',
       #     repository: 'git@github.com:acme/pipeline.git',
       #     steps: [

data/lib/buildkit/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
   # Custom error class for rescuing from all Buildkite errors
   class Error < StandardError
@@ -44,7 +46,7 @@ module Buildkit
     # Array of validation errors
     # @return [Array<Hash>] Error info
     def errors
-      if data && data.is_a?(Hash)
+      if data&.is_a?(Hash)
         data[:errors] || []
       else
         []
@@ -87,26 +89,31 @@ module Buildkit
     def response_error_summary
       return nil unless data.is_a?(Hash) && !Array(data[:errors]).empty?
 
-      summary = "\nError summary:\n"
-      summary << data[:errors].map do |hash|
+      errors = data[:errors].map do |hash|
         hash.map { |k, v| "  #{k}: #{v}" }
-      end.join("\n")
+      end
 
-      summary
+      <<~MSG.chomp
+        Error summary:
+        #{errors.join("\n")}
+      MSG
     end
 
     def build_error_message
       return nil if @response.nil?
 
-      message = "#{@response[:method].to_s.upcase} #{redact_url(@response[:url].to_s)}: #{@response[:status]} - "
-      message << "#{response_message}#{response_error}#{response_error_summary}"
-      message << " // See: #{documentation_url}" unless documentation_url.nil?
-      message
+      documentation_text = ''
+      documentation_text = "// See: #{documentation_url}" if documentation_url
+
+      <<~MSG.strip
+        #{@response[:method].to_s.upcase} #{redact_url(@response[:url].to_s)}: #{@response[:status]} - #{response_message}#{response_error}#{response_error_summary}
+        #{documentation_text}
+      MSG
     end
 
     def redact_url(url_string)
       %w[client_secret access_token].each do |token|
-        url_string.gsub!(/#{token}=\S+/, "#{token}=(redacted)") if url_string.include? token
+        url_string = url_string.gsub(/#{token}=\S+/, "#{token}=(redacted)") if url_string.include? token
       end
       url_string
     end

data/lib/buildkit/header_link_parser.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Buildkit
+  module HeaderLinkParser
+    module_function
+
+    def parse_link_header(link_header)
+      {}.tap do |hash_link|
+        link_header.split(',').each do |link|
+          link_obj = LinkParser.new(link)
+          hash_link[link_obj.name] = link_obj.link
+        end
+      end
+    end
+
+    class LinkParser
+      def initialize(value)
+        @value = value
+      end
+
+      def name
+        @name ||= @value[/rel="(.*)"/, 1].to_sym
+      end
+
+      def link
+        @link ||= @value[/<(.+)>/, 1]
+      end
+    end
+  end
+end

data/lib/buildkit/response/raise_error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'faraday'
 require 'buildkit/error'
 
@@ -7,8 +9,6 @@ module Buildkit
     # This class raises an Buildkit-flavored exception based
     # HTTP status codes returned by the API
     class RaiseError < Faraday::Response::Middleware
-      private
-
       def on_complete(response)
         if error = Buildkit::Error.from_response(response)
           raise error

data/lib/buildkit/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Buildkit
-  VERSION = '1.3.0'.freeze
+  VERSION = '1.4.4'
 end

metadata

@@ -1,27 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: buildkit
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.4
 platform: ruby
 authors:
 - Jean Boussier
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-25 00:00:00.000000000 Z
+date: 2021-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sawyer
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
 - !ruby/object:Gem::Dependency
@@ -45,11 +45,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -57,6 +57,7 @@ files:
 - bin/console
 - bin/setup
 - buildkit.gemspec
+- dev.yml
 - lib/buildkit.rb
 - lib/buildkit/client.rb
 - lib/buildkit/client/agents.rb
@@ -66,12 +67,14 @@ files:
 - lib/buildkit/client/organizations.rb
 - lib/buildkit/client/pipelines.rb
 - lib/buildkit/error.rb
+- lib/buildkit/header_link_parser.rb
 - lib/buildkit/response/raise_error.rb
 - lib/buildkit/version.rb
 homepage: https://github.com/shopify/buildkit
 licenses:
 - MIT
-metadata: {}
+metadata:
+  allowed_push_host: https://rubygems.org
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -80,15 +83,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Ruby toolkit for working with the Buildkite API

data/.travis.yml

@@ -1,6 +0,0 @@
-sudo: false
-before_install: gem install bundler
-rvm:
-  - '2.1'
-  - '2.2'
-