build_eval 0.0.6 → 0.0.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ODM2MmZjNDRlYmE4NDU0MTA2Mjc0ODUyZWNiYzFiNWI3M2Q2YWFiZA==
+    Yjk2OGI1MTg0ZWFiYjBhYTgyZDE4MmY5NzI2ODRkNDMyNWVjM2Y1NA==
   data.tar.gz: !binary |-
-    Nzg4Yjg5NTBkMGYxNWRjZmJiMjk1ODU1YjQ0OGRiNjljYTM0NWE0NQ==
+    ZjFmYmY4MjEzNzViNTYxZWExZmZiNTg1OTBiYTRjZWFiMjU3MDZmMw==
 SHA512:
   metadata.gz: !binary |-
-    NWMwNjViYWYyNjNjN2YwNThmNTEwNjc3ODU2YjE2YTlhNTg2ODkzMDJmZDkx
-    MmUzMjM4Y2Y0YjIzZGFlNTBiZDNlMDUyZjg2NGVjZTBiYTI5MWZmMDJkNzQ3
-    YzU2YTI1MTU5ZmQxNjRkOGIxNjQ3ZDdhZjVhNmFjYTdjMjVkZmI=
+    YThkNjhmN2Q4YmFmM2Q4NjU5MTk0ZjZjOGE3ZjAwODFkMWRjYjgyNWNkOTJl
+    MGYwMTUxNDVhMzRlZjE2Nzk0NjU0MjNiMDBlNTcwMzFhMThhNWNkNTNmOWFh
+    YmUxY2MxMTc1NTJlYTU4ZWIxMmU0Mjc5MmE5MzA1ZDQyYTE2NjM=
   data.tar.gz: !binary |-
-    ZGVjZDU1Y2VlNmMwMmQ5NmQ0YTdkMDViYjUyNzUzNDU1NzhlNWViNTg2NjU4
-    NzdhYTAxMThkZjk5MjY3NjhlMjRhNTEyZjI1MTAyMGU1ODU0MGIxMmM2MDRh
-    ZmFhNjAzZDNhMTgwNDJiNzMzNWQ4YzU4Mzg1YTdkMmM3ODdjZDQ=
+    YjY0ZTUyZGRiMWEyYTIxNzc2MGVhYmQ1ZjRjODEwZTc4NWRlNzI2NWFiNmRl
+    Y2JmZWIzNDU5YmVjMWI3ODlkOGJiNjhmOTFlZmI4YzgzZWIyODk5Yjg3YTRh
+    ODY3NTZhYWVjZjZhMzhjNTk2MzM3ZGI5NDg5ZDAyMTk1YWYyNTk=

data/lib/build_eval/server/travis.rb

@@ -9,7 +9,7 @@ module BuildEval
 
       def build_result(name)
         repo_string = "#{@username}/#{name}"
-        has_failed = ::Travis::Repository.find(repo_string).last_build.failed?
+        has_failed = ::Travis::Repository.find(repo_string).recent_builds.first.failed?
         BuildEval::Result::BuildResult.create(
           build_name:  repo_string,
           status_name: has_failed ? "Failure" : "Success"
@@ -19,6 +19,7 @@ module BuildEval
       def to_s
         "Travis CI #{@username}"
       end
+
     end
 
   end

data/lib/build_eval/server/travis_pro.rb

@@ -10,7 +10,7 @@ module BuildEval
 
       def build_result(name)
         repo_string = "#{@username}/#{name}"
-        has_failed = ::Travis::Pro::Repository.find(repo_string).last_build.failed?
+        has_failed = ::Travis::Pro::Repository.find(repo_string).recent_builds.first.failed?
         BuildEval::Result::BuildResult.create(
           build_name:  repo_string,
           status_name: has_failed ? "Failure" : "Success"

data/lib/build_eval/version.rb

@@ -1,3 +1,3 @@
 module BuildEval
-  VERSION = "0.0.6".freeze
+  VERSION = "0.0.7".freeze
 end

data/spec/lib/build_eval/server/travis_pro_spec.rb

@@ -19,7 +19,7 @@ describe BuildEval::Server::TravisPro do
     subject { described_class.new(constructor_args) }
 
     it "establishes the GitHub auth token" do
-      expect(Travis::Pro).to receive(:github_auth).with(github_token)
+      expect(::Travis::Pro).to receive(:github_auth).with(github_token)
 
       subject
     end
@@ -28,47 +28,72 @@ describe BuildEval::Server::TravisPro do
 
   describe "#build_result" do
 
-    let(:build_name)        { "some_build_name" }
-    let(:travis_repository) { instance_double(Travis::Client::Repository) }
-    let(:travis_build)      { instance_double(Travis::Client::Build) }
-    let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
+    let(:build_name)             { "some_build_name" }
+    let(:travis_repository)      { instance_double(::Travis::Client::Repository) }
+    let(:recent_builds)          { (1..3).map { instance_double(::Travis::Client::Build) } }
+    let(:last_build)             { recent_builds.first }
+    let(:last_build_failed_flag) { false }
+    let(:build_result)           { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_pro_server.build_result(build_name) }
 
     before(:example) do
-      allow(Travis::Pro::Repository).to receive(:find).and_return(travis_repository)
-      allow(travis_repository).to receive(:last_build).and_return(travis_build)
-      allow(travis_build).to receive(:failed?).and_return(false)
+      allow(::Travis::Pro::Repository).to receive(:find).and_return(travis_repository)
+      allow(travis_repository).to receive(:recent_builds).and_return(recent_builds)
+      allow(last_build).to receive(:failed?).and_return(last_build_failed_flag)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
     it "retrieves the relevant Travis repository" do
-      expect(Travis::Pro::Repository).to receive(:find).with("#{username}/#{build_name}").and_return(travis_repository)
+      expect(::Travis::Pro::Repository).to receive(:find).with("#{username}/#{build_name}")
 
       subject
     end
 
-    it "retrieves the last build on the Travis repository" do
-      expect(travis_repository).to receive(:last_build).and_return(travis_build)
+    it "retrieves the recent builds from Travis" do
+      expect(travis_repository).to receive(:recent_builds)
 
       subject
     end
 
-    it "retrieves the build status from the build" do
-      expect(travis_build).to receive(:failed?).and_return(false)
+    it "retrieves the build status from the last build" do
+      expect(last_build).to receive(:failed?)
 
       subject
     end
 
-    it "creates a build result" do
-      expect(BuildEval::Result::BuildResult).to receive(:create).with(
-        build_name:  "#{username}/#{build_name}",
-        status_name: "Success"
-      ).and_return(build_result)
+    it "creates a build result whose build name is the path to the repository" do
+      expect(BuildEval::Result::BuildResult).to(
+        receive(:create).with(hash_including(build_name: "#{username}/#{build_name}"))
+      )
 
       subject
     end
 
+    context "when the last build has passed" do
+
+      let(:last_build_failed_flag) { false }
+
+      it "creates a successful build result" do
+        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Success"))
+
+        subject
+      end
+
+    end
+
+    context "when the last build has failed" do
+
+      let(:last_build_failed_flag) { true }
+
+      it "creates a failed build result" do
+        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Failure"))
+
+        subject
+      end
+
+    end
+
     it "returns the parsed build result" do
       expect(subject).to eql(build_result)
     end

data/spec/lib/build_eval/server/travis_spec.rb

@@ -8,47 +8,72 @@ describe BuildEval::Server::Travis do
 
   describe "#build_result" do
 
-    let(:build_name)        { "some_build_name" }
-    let(:travis_repository) { instance_double(Travis::Client::Repository) }
-    let(:travis_build)      { instance_double(Travis::Client::Build) }
-    let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
+    let(:build_name)             { "some_build_name" }
+    let(:travis_repository)      { instance_double(::Travis::Client::Repository) }
+    let(:recent_builds)          { (1..3).map { instance_double(::Travis::Client::Build) } }
+    let(:last_build)             { recent_builds.first }
+    let(:last_build_failed_flag) { false }
+    let(:build_result)           { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_server.build_result(build_name) }
 
     before(:example) do
-      allow(Travis::Repository).to receive(:find).and_return(travis_repository)
-      allow(travis_repository).to receive(:last_build).and_return(travis_build)
-      allow(travis_build).to receive(:failed?).and_return(false)
+      allow(::Travis::Repository).to receive(:find).and_return(travis_repository)
+      allow(travis_repository).to receive(:recent_builds).and_return(recent_builds)
+      allow(last_build).to receive(:failed?).and_return(last_build_failed_flag)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
     it "retrieves the relevant Travis repository" do
-      expect(Travis::Repository).to receive(:find).with("#{username}/#{build_name}").and_return(travis_repository)
+      expect(::Travis::Repository).to receive(:find).with("#{username}/#{build_name}")
 
       subject
     end
 
-    it "retrieves the last build on the Travis repository" do
-      expect(travis_repository).to receive(:last_build).and_return(travis_build)
+    it "retrieves the recent builds from Travis" do
+      expect(travis_repository).to receive(:recent_builds)
 
       subject
     end
 
-    it "retrieves the build status from the build" do
-      expect(travis_build).to receive(:failed?).and_return(false)
+    it "retrieves the status of the last build" do
+      expect(last_build).to receive(:failed?)
 
       subject
     end
 
-    it "creates a build result" do
-      expect(BuildEval::Result::BuildResult).to receive(:create).with(
-        build_name:  "#{username}/#{build_name}",
-        status_name: "Success"
-      ).and_return(build_result)
+    it "creates a build result whose build name is the path to the repository" do
+      expect(BuildEval::Result::BuildResult).to(
+        receive(:create).with(hash_including(build_name: "#{username}/#{build_name}"))
+      )
 
       subject
     end
 
+    context "when the last build has passed" do
+
+      let(:last_build_failed_flag) { false }
+
+      it "creates a successful build result" do
+        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Success"))
+
+        subject
+      end
+
+    end
+
+    context "when the last build has failed" do
+
+      let(:last_build_failed_flag) { true }
+
+      it "creates a failed build result" do
+        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Failure"))
+
+        subject
+      end
+
+    end
+
     it "returns the parsed build result" do
       expect(subject).to eql(build_result)
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Matthew Ueckerman