build_eval 0.0.5 → 0.0.6

data/spec/lib/build_eval/server/travis_pro_spec.rb

@@ -0,0 +1,92 @@
+describe BuildEval::Server::TravisPro do
+  include_context "stubbed http interactions"
+
+  let(:username)     { "some_username" }
+  let(:github_token) { "ABCD1234" }
+  let(:constructor_args) do
+    {
+      username:     username,
+      github_token: github_token
+    }
+  end
+
+  let(:travis_pro_server) { described_class.new(constructor_args) }
+
+  before(:example) { allow(::Travis::Pro).to receive(:github_auth) }
+
+  describe "#initialize" do
+
+    subject { described_class.new(constructor_args) }
+
+    it "establishes the GitHub auth token" do
+      expect(Travis::Pro).to receive(:github_auth).with(github_token)
+
+      subject
+    end
+
+  end
+
+  describe "#build_result" do
+
+    let(:build_name)        { "some_build_name" }
+    let(:travis_repository) { instance_double(Travis::Client::Repository) }
+    let(:travis_build)      { instance_double(Travis::Client::Build) }
+    let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
+
+    subject { travis_pro_server.build_result(build_name) }
+
+    before(:example) do
+      allow(Travis::Pro::Repository).to receive(:find).and_return(travis_repository)
+      allow(travis_repository).to receive(:last_build).and_return(travis_build)
+      allow(travis_build).to receive(:failed?).and_return(false)
+      allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
+    end
+
+    it "retrieves the relevant Travis repository" do
+      expect(Travis::Pro::Repository).to receive(:find).with("#{username}/#{build_name}").and_return(travis_repository)
+
+      subject
+    end
+
+    it "retrieves the last build on the Travis repository" do
+      expect(travis_repository).to receive(:last_build).and_return(travis_build)
+
+      subject
+    end
+
+    it "retrieves the build status from the build" do
+      expect(travis_build).to receive(:failed?).and_return(false)
+
+      subject
+    end
+
+    it "creates a build result" do
+      expect(BuildEval::Result::BuildResult).to receive(:create).with(
+        build_name:  "#{username}/#{build_name}",
+        status_name: "Success"
+      ).and_return(build_result)
+
+      subject
+    end
+
+    it "returns the parsed build result" do
+      expect(subject).to eql(build_result)
+    end
+
+  end
+
+  describe "#to_s" do
+
+    subject { travis_pro_server.to_s }
+
+    it "returns a string indicating it uses the Travis Pro service" do
+      expect(subject).to include("Travis CI Pro")
+    end
+
+    it "returns a string containing the username" do
+      expect(subject).to include(username)
+    end
+
+  end
+
+end

data/spec/lib/build_eval/server/{travis_org_spec.rb → travis_spec.rb}

@@ -1,16 +1,17 @@
-describe BuildEval::Server::TravisOrg do
-  include_context 'stubbed http interactions'
+describe BuildEval::Server::Travis do
+  include_context "stubbed http interactions"
 
-  let(:username)         { 'some_username' }
+  let(:username)         { "some_username" }
   let(:constructor_args) { { username: username } }
 
   let(:travis_server) { described_class.new(constructor_args) }
 
-  describe '#build_result' do
-    let(:build_name)              { 'some_build_name' }
-    let(:travis_repository)       { instance_double(Travis::Client::Repository) }
-    let(:travis_build)            { instance_double(Travis::Client::Build) }
-    let(:build_result)            { instance_double(BuildEval::Result::BuildResult) }
+  describe "#build_result" do
+
+    let(:build_name)        { "some_build_name" }
+    let(:travis_repository) { instance_double(Travis::Client::Repository) }
+    let(:travis_build)      { instance_double(Travis::Client::Build) }
+    let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_server.build_result(build_name) }
 
@@ -21,51 +22,51 @@ describe BuildEval::Server::TravisOrg do
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
-    it 'retrieves the relevant Travis repository' do
+    it "retrieves the relevant Travis repository" do
       expect(Travis::Repository).to receive(:find).with("#{username}/#{build_name}").and_return(travis_repository)
 
-      begin
-        subject
-      rescue
-        Exception
-      end
+      subject
     end
 
-    it 'retrieves the last build on the Travis repository' do
+    it "retrieves the last build on the Travis repository" do
       expect(travis_repository).to receive(:last_build).and_return(travis_build)
 
       subject
     end
 
-    it 'retrieves the build status from the build' do
+    it "retrieves the build status from the build" do
       expect(travis_build).to receive(:failed?).and_return(false)
 
       subject
     end
 
-    it 'creates a build result' do
+    it "creates a build result" do
       expect(BuildEval::Result::BuildResult).to receive(:create).with(
         build_name:  "#{username}/#{build_name}",
-        status_name: 'Success'
+        status_name: "Success"
       ).and_return(build_result)
 
       subject
     end
 
-    it 'returns the parsed build result' do
+    it "returns the parsed build result" do
       expect(subject).to eql(build_result)
     end
+
   end
 
-  describe '#to_s' do
+  describe "#to_s" do
+
     subject { travis_server.to_s }
 
-    it 'returns a string indicating it uses the Travis CI Org service' do
-      expect(subject).to include('Travis CI Org')
+    it "returns a string indicating it uses the Travis CI service" do
+      expect(subject).to include("Travis CI")
     end
 
-    it 'returns a string containing the username' do
+    it "returns a string containing the username" do
       expect(subject).to include(username)
     end
+
   end
+
 end

data/spec/lib/build_eval_smoke_spec.rb

@@ -1,9 +1,10 @@
-describe BuildEval, 'integrating with a real CI server', smoke: true do
-  let(:server) { BuildEval.server(type: :TravisOrg, username: 'MYOB-Technology') }
+describe BuildEval, "integrating with a real CI server", smoke: true do
+  let(:server) { BuildEval.server(type: :Travis, username: "MYOB-Technology") }
 
-  let(:monitor) { server.monitor('build_eval') }
+  let(:monitor) { server.monitor("build_eval") }
+
+  describe "the evaluated results from a build monitor for the server" do
 
-  describe 'the evaluated results from a build monitor for the server' do
     let(:tolerated_statuses) do
       [
         BuildEval::Result::Status::SUCCESS,
@@ -15,12 +16,14 @@ describe BuildEval, 'integrating with a real CI server', smoke: true do
 
     subject { monitor.evaluate }
 
-    it 'indicate the builds status' do
+    it "indicate the builds status" do
       expect(tolerated_statuses).to include(subject.status)
     end
 
-    it "describe the build and it's status" do
+    it "describe the build and its status" do
       expect(subject.to_s).to match(/build_eval: (#{tolerated_statuses.map(&:to_s).join("|")})/)
     end
+
   end
+
 end

data/spec/lib/build_eval_spec.rb

@@ -1,30 +1,34 @@
 describe BuildEval do
-  describe '::server' do
+
+  describe "::server" do
+
     class BuildEval::Server::TestableServer
+
       def initialize(_args)
         # Intentionally blank
       end
+
     end
 
     let(:server_type)      { :TestableServer }
-    let(:server_arguments) { { key1: 'value1', key2: 'value2', key3: 'value3' } }
+    let(:server_arguments) { { key1: "value1", key2: "value2", key3: "value3" } }
     let(:args)             { { type: server_type }.merge(server_arguments) }
 
     subject { described_class.server(args) }
 
-    it 'constructs an instance of the server with the provided type' do
+    it "constructs an instance of the server with the provided type" do
       expect(BuildEval::Server::TestableServer).to receive(:new)
 
       subject
     end
 
-    it 'constructs the instance with additional arguments' do
+    it "constructs the instance with additional arguments" do
       expect(BuildEval::Server::TestableServer).to receive(:new).with(server_arguments)
 
       subject
     end
 
-    it 'decorates the server with standard server behaviour' do
+    it "decorates the server with standard server behaviour" do
       server = instance_double(BuildEval::Server::TestableServer)
       allow(BuildEval::Server::TestableServer).to receive(:new).and_return(server)
       expect(BuildEval::Server::Decorator).to receive(:new).with(server)
@@ -32,19 +36,23 @@ describe BuildEval do
       subject
     end
 
-    it 'returns the decorated server' do
+    it "returns the decorated server" do
       server_decorator = instance_double(BuildEval::Server::Decorator)
       allow(BuildEval::Server::Decorator).to receive(:new).and_return(server_decorator)
 
       expect(subject).to eql(server_decorator)
     end
 
-    context 'when a server of the provided type is not found' do
+    context "when a server of the provided type is not found" do
+
       let(:server_type) { :invalid_type }
 
-      it 'raises an error indicating the server type is invalid' do
+      it "raises an error indicating the server type is invalid" do
         expect { subject }.to raise_error("Server type '#{server_type}' is invalid")
       end
+
     end
+
   end
+
 end

metadata

@@ -1,140 +1,141 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Matthew Ueckerman
 - Ryan Davis
+- Andy King
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-01 00:00:00.000000000 Z
+date: 2016-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: travis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '11.1'
+        version: '11.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: '11.1'
+        version: '11.2'
 - !ruby/object:Gem::Dependency
   name: travis-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: '0.40'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
-        version: 0.40.0
+        version: '0.40'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '3.4'
 - !ruby/object:Gem::Dependency
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.11'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
 description: Evaluates the effective status of continuous integration builds. Useful
@@ -144,47 +145,47 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- "./lib/build_eval.rb"
-- "./lib/build_eval/error.rb"
-- "./lib/build_eval/http.rb"
-- "./lib/build_eval/monitor/base.rb"
-- "./lib/build_eval/monitor/composite.rb"
-- "./lib/build_eval/monitor/server.rb"
-- "./lib/build_eval/result/build_result.rb"
-- "./lib/build_eval/result/composite_result.rb"
-- "./lib/build_eval/result/server_result.rb"
-- "./lib/build_eval/result/status.rb"
-- "./lib/build_eval/server/cruise_control_response.rb"
-- "./lib/build_eval/server/decorator.rb"
-- "./lib/build_eval/server/invalid_selector_error.rb"
-- "./lib/build_eval/server/jenkins.rb"
-- "./lib/build_eval/server/team_city.rb"
-- "./lib/build_eval/server/travis_com.rb"
-- "./lib/build_eval/server/travis_org.rb"
-- "./lib/build_eval/version.rb"
-- "./spec/lib/build_eval/error_spec.rb"
-- "./spec/lib/build_eval/http_shared_context.rb"
-- "./spec/lib/build_eval/http_spec.rb"
-- "./spec/lib/build_eval/monitor/base_spec.rb"
-- "./spec/lib/build_eval/monitor/composite_spec.rb"
-- "./spec/lib/build_eval/monitor/server_spec.rb"
-- "./spec/lib/build_eval/result/build_result_spec.rb"
-- "./spec/lib/build_eval/result/composite_result_spec.rb"
-- "./spec/lib/build_eval/result/server_result_spec.rb"
-- "./spec/lib/build_eval/result/status_spec.rb"
-- "./spec/lib/build_eval/server/cruise_control_response_spec.rb"
-- "./spec/lib/build_eval/server/decorator_spec.rb"
-- "./spec/lib/build_eval/server/invalid_selector_error_spec.rb"
-- "./spec/lib/build_eval/server/jenkins_integration_spec.rb"
-- "./spec/lib/build_eval/server/jenkins_spec.rb"
-- "./spec/lib/build_eval/server/server_shared_examples.rb"
-- "./spec/lib/build_eval/server/team_city_integration_spec.rb"
-- "./spec/lib/build_eval/server/team_city_spec.rb"
-- "./spec/lib/build_eval/server/travis_com_spec.rb"
-- "./spec/lib/build_eval/server/travis_org_spec.rb"
-- "./spec/lib/build_eval_smoke_spec.rb"
-- "./spec/lib/build_eval_spec.rb"
-- "./spec/spec_helper.rb"
+- ./lib/build_eval.rb
+- ./lib/build_eval/error.rb
+- ./lib/build_eval/http.rb
+- ./lib/build_eval/monitor/base.rb
+- ./lib/build_eval/monitor/composite.rb
+- ./lib/build_eval/monitor/server.rb
+- ./lib/build_eval/result/build_result.rb
+- ./lib/build_eval/result/composite_result.rb
+- ./lib/build_eval/result/server_result.rb
+- ./lib/build_eval/result/status.rb
+- ./lib/build_eval/server/cruise_control_response.rb
+- ./lib/build_eval/server/decorator.rb
+- ./lib/build_eval/server/invalid_selector_error.rb
+- ./lib/build_eval/server/jenkins.rb
+- ./lib/build_eval/server/team_city.rb
+- ./lib/build_eval/server/travis.rb
+- ./lib/build_eval/server/travis_pro.rb
+- ./lib/build_eval/version.rb
+- ./spec/lib/build_eval/error_spec.rb
+- ./spec/lib/build_eval/http_shared_context.rb
+- ./spec/lib/build_eval/http_spec.rb
+- ./spec/lib/build_eval/monitor/base_spec.rb
+- ./spec/lib/build_eval/monitor/composite_spec.rb
+- ./spec/lib/build_eval/monitor/server_spec.rb
+- ./spec/lib/build_eval/result/build_result_spec.rb
+- ./spec/lib/build_eval/result/composite_result_spec.rb
+- ./spec/lib/build_eval/result/server_result_spec.rb
+- ./spec/lib/build_eval/result/status_spec.rb
+- ./spec/lib/build_eval/server/cruise_control_response_spec.rb
+- ./spec/lib/build_eval/server/decorator_spec.rb
+- ./spec/lib/build_eval/server/invalid_selector_error_spec.rb
+- ./spec/lib/build_eval/server/jenkins_integration_spec.rb
+- ./spec/lib/build_eval/server/jenkins_spec.rb
+- ./spec/lib/build_eval/server/server_shared_examples.rb
+- ./spec/lib/build_eval/server/team_city_integration_spec.rb
+- ./spec/lib/build_eval/server/team_city_spec.rb
+- ./spec/lib/build_eval/server/travis_pro_spec.rb
+- ./spec/lib/build_eval/server/travis_spec.rb
+- ./spec/lib/build_eval_smoke_spec.rb
+- ./spec/lib/build_eval_spec.rb
+- ./spec/spec_helper.rb
 homepage: http://github.com/MYOB-Technology/build_eval
 licenses:
 - MIT
@@ -195,41 +196,41 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: build_eval
-rubygems_version: 2.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Evaluates the effective status of continuous integration builds
 test_files:
-- "./spec/lib/build_eval/error_spec.rb"
-- "./spec/lib/build_eval/http_shared_context.rb"
-- "./spec/lib/build_eval/http_spec.rb"
-- "./spec/lib/build_eval/monitor/base_spec.rb"
-- "./spec/lib/build_eval/monitor/composite_spec.rb"
-- "./spec/lib/build_eval/monitor/server_spec.rb"
-- "./spec/lib/build_eval/result/build_result_spec.rb"
-- "./spec/lib/build_eval/result/composite_result_spec.rb"
-- "./spec/lib/build_eval/result/server_result_spec.rb"
-- "./spec/lib/build_eval/result/status_spec.rb"
-- "./spec/lib/build_eval/server/cruise_control_response_spec.rb"
-- "./spec/lib/build_eval/server/decorator_spec.rb"
-- "./spec/lib/build_eval/server/invalid_selector_error_spec.rb"
-- "./spec/lib/build_eval/server/jenkins_integration_spec.rb"
-- "./spec/lib/build_eval/server/jenkins_spec.rb"
-- "./spec/lib/build_eval/server/server_shared_examples.rb"
-- "./spec/lib/build_eval/server/team_city_integration_spec.rb"
-- "./spec/lib/build_eval/server/team_city_spec.rb"
-- "./spec/lib/build_eval/server/travis_com_spec.rb"
-- "./spec/lib/build_eval/server/travis_org_spec.rb"
-- "./spec/lib/build_eval_smoke_spec.rb"
-- "./spec/lib/build_eval_spec.rb"
-- "./spec/spec_helper.rb"
+- ./spec/lib/build_eval/error_spec.rb
+- ./spec/lib/build_eval/http_shared_context.rb
+- ./spec/lib/build_eval/http_spec.rb
+- ./spec/lib/build_eval/monitor/base_spec.rb
+- ./spec/lib/build_eval/monitor/composite_spec.rb
+- ./spec/lib/build_eval/monitor/server_spec.rb
+- ./spec/lib/build_eval/result/build_result_spec.rb
+- ./spec/lib/build_eval/result/composite_result_spec.rb
+- ./spec/lib/build_eval/result/server_result_spec.rb
+- ./spec/lib/build_eval/result/status_spec.rb
+- ./spec/lib/build_eval/server/cruise_control_response_spec.rb
+- ./spec/lib/build_eval/server/decorator_spec.rb
+- ./spec/lib/build_eval/server/invalid_selector_error_spec.rb
+- ./spec/lib/build_eval/server/jenkins_integration_spec.rb
+- ./spec/lib/build_eval/server/jenkins_spec.rb
+- ./spec/lib/build_eval/server/server_shared_examples.rb
+- ./spec/lib/build_eval/server/team_city_integration_spec.rb
+- ./spec/lib/build_eval/server/team_city_spec.rb
+- ./spec/lib/build_eval/server/travis_pro_spec.rb
+- ./spec/lib/build_eval/server/travis_spec.rb
+- ./spec/lib/build_eval_smoke_spec.rb
+- ./spec/lib/build_eval_spec.rb
+- ./spec/spec_helper.rb