build_eval 0.0.4 → 0.0.5

data/spec/lib/build_eval/server/travis_com_spec.rb

@@ -0,0 +1,91 @@
+describe BuildEval::Server::TravisCom do
+  include_context 'stubbed http interactions'
+
+  let(:username) { 'some_username' }
+  let(:github_token) { 'ABCD1234' }
+  let(:constructor_args) do
+    {
+      username: username,
+      github_token: github_token
+    }
+  end
+
+  let(:travis_server) { described_class.new(constructor_args) }
+
+  before(:example) do
+    allow(Travis::Pro).to receive(:github_auth)
+  end
+
+  describe '#initialize' do
+    subject { described_class.new(constructor_args) }
+
+    it 'should set the github auth token' do
+      expect(Travis::Pro).to receive(:github_auth).with(github_token)
+
+      subject
+    end
+  end
+
+  describe '#build_result' do
+    let(:build_name)              { 'some_build_name' }
+    let(:travis_repository)       { instance_double(Travis::Client::Repository) }
+    let(:travis_build)            { instance_double(Travis::Client::Build) }
+    let(:build_result)            { instance_double(BuildEval::Result::BuildResult) }
+
+    subject { travis_server.build_result(build_name) }
+
+    before(:example) do
+      allow(Travis::Pro::Repository).to receive(:find).and_return(travis_repository)
+      allow(travis_repository).to receive(:last_build).and_return(travis_build)
+      allow(travis_build).to receive(:failed?).and_return(false)
+      allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
+    end
+
+    it 'retrieves the relevant Travis repository' do
+      expect(Travis::Pro::Repository).to receive(:find).with("#{username}/#{build_name}").and_return(travis_repository)
+
+      begin
+        subject
+      rescue
+        Exception
+      end
+    end
+
+    it 'retrieves the last build on the Travis repository' do
+      expect(travis_repository).to receive(:last_build).and_return(travis_build)
+
+      subject
+    end
+
+    it 'retrieves the build status from the build' do
+      expect(travis_build).to receive(:failed?).and_return(false)
+
+      subject
+    end
+
+    it 'creates a build result' do
+      expect(BuildEval::Result::BuildResult).to receive(:create).with(
+        build_name:  "#{username}/#{build_name}",
+        status_name: 'Success'
+      ).and_return(build_result)
+
+      subject
+    end
+
+    it 'returns the parsed build result' do
+      expect(subject).to eql(build_result)
+    end
+  end
+
+  describe '#to_s' do
+    subject { travis_server.to_s }
+
+    it 'returns a string indicating it uses the Travis CI Org service' do
+      expect(subject).to include('Travis CI Com')
+    end
+
+    it 'returns a string containing the username' do
+      expect(subject).to include(username)
+    end
+  end
+end

data/spec/lib/build_eval/server/travis_org_spec.rb

@@ -0,0 +1,71 @@
+describe BuildEval::Server::TravisOrg do
+  include_context 'stubbed http interactions'
+
+  let(:username)         { 'some_username' }
+  let(:constructor_args) { { username: username } }
+
+  let(:travis_server) { described_class.new(constructor_args) }
+
+  describe '#build_result' do
+    let(:build_name)              { 'some_build_name' }
+    let(:travis_repository)       { instance_double(Travis::Client::Repository) }
+    let(:travis_build)            { instance_double(Travis::Client::Build) }
+    let(:build_result)            { instance_double(BuildEval::Result::BuildResult) }
+
+    subject { travis_server.build_result(build_name) }
+
+    before(:example) do
+      allow(Travis::Repository).to receive(:find).and_return(travis_repository)
+      allow(travis_repository).to receive(:last_build).and_return(travis_build)
+      allow(travis_build).to receive(:failed?).and_return(false)
+      allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
+    end
+
+    it 'retrieves the relevant Travis repository' do
+      expect(Travis::Repository).to receive(:find).with("#{username}/#{build_name}").and_return(travis_repository)
+
+      begin
+        subject
+      rescue
+        Exception
+      end
+    end
+
+    it 'retrieves the last build on the Travis repository' do
+      expect(travis_repository).to receive(:last_build).and_return(travis_build)
+
+      subject
+    end
+
+    it 'retrieves the build status from the build' do
+      expect(travis_build).to receive(:failed?).and_return(false)
+
+      subject
+    end
+
+    it 'creates a build result' do
+      expect(BuildEval::Result::BuildResult).to receive(:create).with(
+        build_name:  "#{username}/#{build_name}",
+        status_name: 'Success'
+      ).and_return(build_result)
+
+      subject
+    end
+
+    it 'returns the parsed build result' do
+      expect(subject).to eql(build_result)
+    end
+  end
+
+  describe '#to_s' do
+    subject { travis_server.to_s }
+
+    it 'returns a string indicating it uses the Travis CI Org service' do
+      expect(subject).to include('Travis CI Org')
+    end
+
+    it 'returns a string containing the username' do
+      expect(subject).to include(username)
+    end
+  end
+end

data/spec/lib/build_eval_smoke_spec.rb

@@ -1,25 +1,26 @@
-describe BuildEval, "integrating with a real CI server", smoke: true do
+describe BuildEval, 'integrating with a real CI server', smoke: true do
+  let(:server) { BuildEval.server(type: :TravisOrg, username: 'MYOB-Technology') }
 
-  let(:server) { BuildEval.server(type: :Travis, username: "MYOB-Technology") }
-
-  let(:monitor) { server.monitor("build_eval") }
-
-  describe "the evaluated results from a build monitor for the server" do
+  let(:monitor) { server.monitor('build_eval') }
 
+  describe 'the evaluated results from a build monitor for the server' do
     let(:tolerated_statuses) do
-      [ BuildEval::Result::Status::SUCCESS, BuildEval::Result::Status::UNKNOWN, BuildEval::Result::Status::FAILURE ]
+      [
+        BuildEval::Result::Status::SUCCESS,
+        BuildEval::Result::Status::UNKNOWN,
+        BuildEval::Result::Status::FAILURE,
+        BuildEval::Result::Status::ERROR
+      ]
     end
 
     subject { monitor.evaluate }
 
-    it "indicate the builds status" do
+    it 'indicate the builds status' do
       expect(tolerated_statuses).to include(subject.status)
     end
 
     it "describe the build and it's status" do
       expect(subject.to_s).to match(/build_eval: (#{tolerated_statuses.map(&:to_s).join("|")})/)
     end
-
   end
-
 end

data/spec/lib/build_eval_spec.rb

@@ -1,34 +1,30 @@
 describe BuildEval do
-
-  describe "::server" do
-
+  describe '::server' do
     class BuildEval::Server::TestableServer
-
       def initialize(_args)
         # Intentionally blank
       end
-
     end
 
     let(:server_type)      { :TestableServer }
-    let(:server_arguments) { { key1: "value1", key2: "value2", key3: "value3" } }
+    let(:server_arguments) { { key1: 'value1', key2: 'value2', key3: 'value3' } }
     let(:args)             { { type: server_type }.merge(server_arguments) }
 
     subject { described_class.server(args) }
 
-    it "constructs an instance of the server with the provided type" do
+    it 'constructs an instance of the server with the provided type' do
       expect(BuildEval::Server::TestableServer).to receive(:new)
 
       subject
     end
 
-    it "constructs the instance with additional arguments" do
+    it 'constructs the instance with additional arguments' do
       expect(BuildEval::Server::TestableServer).to receive(:new).with(server_arguments)
 
       subject
     end
 
-    it "decorates the server with standard server behaviour" do
+    it 'decorates the server with standard server behaviour' do
       server = instance_double(BuildEval::Server::TestableServer)
       allow(BuildEval::Server::TestableServer).to receive(:new).and_return(server)
       expect(BuildEval::Server::Decorator).to receive(:new).with(server)
@@ -36,23 +32,19 @@ describe BuildEval do
       subject
     end
 
-    it "returns the decorated server" do
+    it 'returns the decorated server' do
       server_decorator = instance_double(BuildEval::Server::Decorator)
       allow(BuildEval::Server::Decorator).to receive(:new).and_return(server_decorator)
 
       expect(subject).to eql(server_decorator)
     end
 
-    context "when a server of the provided type is not found" do
-
+    context 'when a server of the provided type is not found' do
       let(:server_type) { :invalid_type }
 
-      it "raises an error indicating the server type is invalid" do
+      it 'raises an error indicating the server type is invalid' do
         expect { subject }.to raise_error("Server type '#{server_type}' is invalid")
       end
-
     end
-
   end
-
 end

data/spec/spec_helper.rb

@@ -1,13 +1,13 @@
 require 'bundler'
 Bundler.require(:development)
 
-if ENV["coverage"]
+if ENV['coverage']
   CodeClimate::TestReporter.start
 
   SimpleCov.start do
-    coverage_dir "tmp/coverage"
+    coverage_dir 'tmp/coverage'
 
-    add_filter "/spec/"
+    add_filter '/spec/'
 
     minimum_coverage 100
     refuse_coverage_drop
@@ -16,6 +16,6 @@ end
 
 require_relative '../lib/build_eval'
 
-%w{ shared_examples shared_context }.each do |file_type|
+%w( shared_examples shared_context ).each do |file_type|
   Dir[::File.expand_path("../**/*_#{file_type}.rb", __FILE__)].each { |file| require file }
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Matthew Ueckerman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-09 00:00:00.000000000 Z
+date: 2016-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -25,20 +25,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: travis
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.8'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '11.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '11.1'
 - !ruby/object:Gem::Dependency
   name: travis-lint
   requirement: !ruby/object:Gem::Requirement
@@ -54,19 +68,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: metric_fu
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.12'
+        version: 0.40.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.12'
+        version: 0.40.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,29 +115,29 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.10'
+        version: '0.11'
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
-description: Evaluates the effective status of continuous integration builds.  Useful
+        version: '0.5'
+description: Evaluates the effective status of continuous integration builds. Useful
   for subsequent display on information radiators.
 email: matthew.ueckerman@myob.com
 executables: []
@@ -145,7 +159,8 @@ files:
 - "./lib/build_eval/server/invalid_selector_error.rb"
 - "./lib/build_eval/server/jenkins.rb"
 - "./lib/build_eval/server/team_city.rb"
-- "./lib/build_eval/server/travis.rb"
+- "./lib/build_eval/server/travis_com.rb"
+- "./lib/build_eval/server/travis_org.rb"
 - "./lib/build_eval/version.rb"
 - "./spec/lib/build_eval/error_spec.rb"
 - "./spec/lib/build_eval/http_shared_context.rb"
@@ -165,8 +180,8 @@ files:
 - "./spec/lib/build_eval/server/server_shared_examples.rb"
 - "./spec/lib/build_eval/server/team_city_integration_spec.rb"
 - "./spec/lib/build_eval/server/team_city_spec.rb"
-- "./spec/lib/build_eval/server/travis_integration_spec.rb"
-- "./spec/lib/build_eval/server/travis_spec.rb"
+- "./spec/lib/build_eval/server/travis_com_spec.rb"
+- "./spec/lib/build_eval/server/travis_org_spec.rb"
 - "./spec/lib/build_eval_smoke_spec.rb"
 - "./spec/lib/build_eval_spec.rb"
 - "./spec/spec_helper.rb"
@@ -190,7 +205,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: build_eval
-rubygems_version: 2.4.6
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Evaluates the effective status of continuous integration builds
@@ -213,8 +228,8 @@ test_files:
 - "./spec/lib/build_eval/server/server_shared_examples.rb"
 - "./spec/lib/build_eval/server/team_city_integration_spec.rb"
 - "./spec/lib/build_eval/server/team_city_spec.rb"
-- "./spec/lib/build_eval/server/travis_integration_spec.rb"
-- "./spec/lib/build_eval/server/travis_spec.rb"
+- "./spec/lib/build_eval/server/travis_com_spec.rb"
+- "./spec/lib/build_eval/server/travis_org_spec.rb"
 - "./spec/lib/build_eval_smoke_spec.rb"
 - "./spec/lib/build_eval_spec.rb"
 - "./spec/spec_helper.rb"

data/lib/build_eval/server/travis.rb

@@ -1,23 +0,0 @@
-module BuildEval
-  module Server
-
-    class Travis
-
-      def initialize(args)
-        @http     = BuildEval::Http.new(args)
-        @username = args[:username]
-      end
-
-      def build_result(name)
-        raw_response = @http.get("https://api.travis-ci.org/repositories/#{@username}/#{name}/cc.xml")
-        BuildEval::Server::CruiseControlResponse.new(raw_response).parse_result("//Project")
-      end
-
-      def to_s
-        "Travis CI #{@username}"
-      end
-
-    end
-
-  end
-end

data/spec/lib/build_eval/server/travis_integration_spec.rb

@@ -1,53 +0,0 @@
-describe BuildEval::Server::Travis, "integrating with a response parser", integration: true do
-  include_context "stubbed http interactions"
-
-  let(:username) { "some_username" }
-
-  let(:travis) { described_class.new(username: username) }
-
-  describe "#build_result" do
-
-    let(:build_name) { "some_build_name" }
-    let(:response)   { instance_double(Net::HTTPResponse, body: response_body) }
-
-    subject { travis.build_result(build_name) }
-
-    before(:example) { allow(http).to receive(:get).and_return(response) }
-
-    context "when the server responds successfully with build results" do
-
-      let(:latest_build_status) { "Success" }
-      let(:response_body)       do
-        <<-RESPONSE
-          <Projects>
-            <Project name="#{username}/#{build_name}" activity="Sleeping" lastBuildStatus="#{latest_build_status}" lastBuildLabel="2" lastBuildTime="2015-08-13T08:31:27.000+0000" webUrl="https://travis-ci.org/#{username}/#{build_name}" />
-          </Projects>
-        RESPONSE
-      end
-
-      it "creates a build result containing the build name" do
-        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(build_name: build_name))
-
-        subject
-      end
-
-      it "creates a build result containing the latest build status" do
-        expect(BuildEval::Result::BuildResult).to(
-          receive(:create).with(hash_including(status_name: latest_build_status))
-        )
-
-        subject
-      end
-
-      it "returns the created result" do
-        build_result = instance_double(BuildEval::Result::BuildResult)
-        allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
-
-        expect(subject).to eql(build_result)
-      end
-
-    end
-
-  end
-
-end

data/spec/lib/build_eval/server/travis_spec.rb

@@ -1,70 +0,0 @@
-describe BuildEval::Server::Travis do
-  include_context "stubbed http interactions"
-
-  let(:username)         { "some_username" }
-  let(:constructor_args) { { username: username } }
-
-  let(:travis_server) { described_class.new(constructor_args) }
-
-  it_behaves_like "a continuous integration server" do
-
-    let(:server) { travis_server }
-
-  end
-
-  describe "#build_result" do
-
-    let(:build_name)              { "some_build_name" }
-    let(:response)                { instance_double(Net::HTTPResponse) }
-    let(:build_result)            { instance_double(BuildEval::Result::BuildResult) }
-    let(:cruise_control_response) do
-      instance_double(BuildEval::Server::CruiseControlResponse, parse_result: build_result)
-    end
-
-    subject { travis_server.build_result(build_name) }
-
-    before(:example) do
-      allow(http).to receive(:get).and_return(response)
-      allow(BuildEval::Server::CruiseControlResponse).to receive(:new).and_return(cruise_control_response)
-      allow(cruise_control_response).to receive(:parse_result).and_return(build_result)
-    end
-
-    it "issues a GET request for the build" do
-      expect(http).to receive(:get).with("https://api.travis-ci.org/repositories/#{username}/#{build_name}/cc.xml")
-
-      subject rescue Exception
-    end
-
-    it "creates a Cruise Control response containing the GET request response" do
-      expect(BuildEval::Server::CruiseControlResponse).to receive(:new).with(response)
-
-      subject
-    end
-
-    it "parses the Cruise Control response to return the project" do
-      expect(cruise_control_response).to receive(:parse_result).with("//Project")
-
-      subject
-    end
-
-    it "returns the parsed build result" do
-      expect(subject).to eql(build_result)
-    end
-
-  end
-
-  describe "#to_s" do
-
-    subject { travis_server.to_s }
-
-    it "returns a string indicating it uses the Travis CI service" do
-      expect(subject).to include("Travis CI")
-    end
-
-    it "returns a string containing the username" do
-      expect(subject).to include(username)
-    end
-
-  end
-
-end