build_eval 0.0.14 → 0.0.15

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.14
+  version: 0.0.15
 platform: ruby
 authors:
 - Matthew Ueckerman
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-24 00:00:00.000000000 Z
+date: 2016-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -74,14 +74,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.40'
+        version: '0.41'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.40'
+        version: '0.41'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -130,14 +130,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '0.6'
 description: Evaluates the effective status of continuous integration builds. Useful
   for subsequent display on information radiators.
 email: matthew.ueckerman@myob.com
@@ -163,7 +163,10 @@ files:
 - ./lib/build_eval/server/travis.rb
 - ./lib/build_eval/server/travis_pro.rb
 - ./lib/build_eval/travis.rb
-- ./lib/build_eval/travis/session_factory.rb
+- ./lib/build_eval/travis/session.rb
+- ./lib/build_eval/travis/session/factory.rb
+- ./lib/build_eval/travis/session/pool.rb
+- ./lib/build_eval/travis/session/session.rb
 - ./lib/build_eval/version.rb
 - ./spec/lib/build_eval/error_spec.rb
 - ./spec/lib/build_eval/http_shared_context.rb
@@ -185,7 +188,10 @@ files:
 - ./spec/lib/build_eval/server/team_city_spec.rb
 - ./spec/lib/build_eval/server/travis_pro_spec.rb
 - ./spec/lib/build_eval/server/travis_spec.rb
-- ./spec/lib/build_eval/travis/session_factory_spec.rb
+- ./spec/lib/build_eval/travis/session/factory_spec.rb
+- ./spec/lib/build_eval/travis/session/pool_spec.rb
+- ./spec/lib/build_eval/travis/session/session_spec.rb
+- ./spec/lib/build_eval/travis/session_spec.rb
 - ./spec/lib/build_eval/travis_spec.rb
 - ./spec/lib/build_eval_smoke_spec.rb
 - ./spec/lib/build_eval_spec.rb
@@ -235,7 +241,10 @@ test_files:
 - ./spec/lib/build_eval/server/team_city_spec.rb
 - ./spec/lib/build_eval/server/travis_pro_spec.rb
 - ./spec/lib/build_eval/server/travis_spec.rb
-- ./spec/lib/build_eval/travis/session_factory_spec.rb
+- ./spec/lib/build_eval/travis/session/factory_spec.rb
+- ./spec/lib/build_eval/travis/session/pool_spec.rb
+- ./spec/lib/build_eval/travis/session/session_spec.rb
+- ./spec/lib/build_eval/travis/session_spec.rb
 - ./spec/lib/build_eval/travis_spec.rb
 - ./spec/lib/build_eval_smoke_spec.rb
 - ./spec/lib/build_eval_spec.rb

data/lib/build_eval/travis/session_factory.rb

@@ -1,38 +0,0 @@
-module BuildEval
-  module Travis
-
-    class SessionFactory
-
-      class << self
-
-        def create(github_token)
-          find_session(github_token) || create_session(github_token)
-        end
-
-        def clear_cache
-          @sessions = {}
-        end
-
-        private
-
-        def find_session(github_token)
-          sessions[github_token].tap { |session| session.clear_cache if session }
-        end
-
-        def create_session(github_token)
-          travis_uri = github_token ? ::Travis::Client::PRO_URI : ::Travis::Client::ORG_URI
-          sessions[github_token] = ::Travis::Client::Session.new(uri: travis_uri, ssl: {}).tap do |session|
-            session.github_auth(github_token) if github_token
-          end
-        end
-
-        def sessions
-          @sessions ||= {}
-        end
-
-      end
-
-    end
-
-  end
-end

data/spec/lib/build_eval/travis/session_factory_spec.rb

@@ -1,105 +0,0 @@
-describe BuildEval::Travis::SessionFactory do
-
-  describe "::create" do
-
-    let(:github_token)   { nil }
-    let(:travis_session) { instance_double(::Travis::Client::Session) }
-
-    subject { create_session }
-
-    before(:example) { allow(::Travis::Client::Session).to receive(:new).and_return(travis_session) }
-    after(:example)  { described_class.clear_cache }
-
-    shared_examples_for "a call creating a new session" do
-
-      it "creates a Travis session with empty SSL settings to avoid using local security certificates" do
-        expect(::Travis::Client::Session).to receive(:new).with(hash_including(ssl: {}))
-
-        subject
-      end
-
-      it "returns the created session" do
-        expect(subject).to eql(travis_session)
-      end
-
-    end
-
-    context "when a session for the GitHub token has not been retrieved previously" do
-
-      context "and a non-nil GitHub token is provided" do
-
-        let(:github_token)  { "SOMEGITHUBAUTHTOKEN" }
-
-        before(:example) { allow(travis_session).to receive(:github_auth) }
-
-        it_behaves_like "a call creating a new session"
-
-        it "creates a Travis session connecting to the Travis Pro site" do
-          expect(::Travis::Client::Session).to receive(:new).with(hash_including(uri: ::Travis::Client::PRO_URI))
-
-          subject
-        end
-
-        it "logs-in using the provided GitHub token via the session" do
-          expect(travis_session).to receive(:github_auth).with(github_token)
-
-          subject
-        end
-
-      end
-
-      context "and a nil GitHub token is provided" do
-
-        let(:github_token)  { nil }
-
-        it_behaves_like "a call creating a new session"
-
-        it "creates a Travis session connecting to the Travis Org site" do
-          expect(::Travis::Client::Session).to receive(:new).with(hash_including(uri: ::Travis::Client::ORG_URI))
-
-          subject
-        end
-
-        it "does not log-in" do
-          expect(travis_session).to_not receive(:github_auth)
-
-          subject
-        end
-
-      end
-
-    end
-
-    context "when a session for the GitHub token has been retrieved previously" do
-
-      before(:example) do
-        create_session
-
-        allow(travis_session).to receive(:clear_cache)
-      end
-
-      it "does not create a new session" do
-        expect(::Travis::Client::Session).to_not receive(:new)
-
-        subject
-      end
-
-      it "clears the cache of the previously retrieved session to ensure no stale data is returned" do
-        expect(travis_session).to receive(:clear_cache)
-
-        subject
-      end
-
-      it "returns the previously retrieved session" do
-        expect(subject).to eql(travis_session)
-      end
-
-    end
-
-    def create_session
-      described_class.create(github_token)
-    end
-
-  end
-
-end