build_eval 0.0.10 → 0.0.11

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Y2RmM2FlM2IyNDIwNGI2YmRmZjM0ODkyOTU1Y2MxNzBiZmEyNjY4MQ==
+    MTdkM2EyNDlhMjZkNzZmNTNhOTg0YmMxNzVkZmEzMjY1YzQzZmU4NA==
   data.tar.gz: !binary |-
-    OTRkNzVhNjY0Njg5Y2NhZWMwN2Q2Y2NjMzYxYmEyZDZlODQxNTNiNg==
+    M2M2NmIwYjQ1NjNkYmE4YTZjZDYyYTBkN2I2NzIzNjNhNTU5ZDE4Ng==
 SHA512:
   metadata.gz: !binary |-
-    Y2FiMDJhZjdlYTA0Yzg0NGU2NDMyMTJhMjk4MTYzYzBhNTY5ZDA2OTAyODlm
-    YmFlMWRmOWJiZDE2Y2VkOWEyODA4MWFkOTM4NmI0ZjcwZDNhMzE5MzhmNmI2
-    ZTFlNjYwMzlhOWE1ODBjMGM4ZTJiMGIwNTk2YWQ2Y2U1NjU4NDY=
+    NWVhYWUzOTNhMmEyY2Y2ZjNkNWVkYmE3ZGQ4Nzk0ZTVlZTM5MjUwN2UyNmMw
+    ZmY4YjY1MjJkNjA5ZjYxODUyZjE3NzJmYzk0Y2VmZTExYTg4MDFhOWNjNjRh
+    ZmY3NmVjY2UyNWIwMmVkMjk1M2Y0YzU2NTc0YjA2ZjQ1NDVhOWQ=
   data.tar.gz: !binary |-
-    NDZiYjI2Yzg4OWRhNWE2YmM0OGMzMjE3YmE2NDQ1MTZhYzQwNDY0ZjQwZGNi
-    ODBmNmFiOGI3YTc2NjY5ZDg3NzY0YTM0ZjRmZmI2ZGU2Y2Q0MWY4NDlhOWIw
-    NzI1MWQ3ZjhiMzg3YzQ5OWYwMDc5NWI4NTkxODg3ODYxMWEzMWM=
+    ZTkzNzE4M2UxN2U0ODJmZmQ1MTFlNmI4YWJjYjgzYmRlMGQ1Y2Q3ZTBhNWVk
+    ODY3ZjJhODI2Y2U5OGI0OTIyZjI3OWNhM2Y5NmM3OGZhNzdkMTQzZTk4YTcy
+    ZmIwNWM4YzExYWIxZTVlMDQzZDY1MTA4MzU5NWYyNmQ4YzcxOTg=

data/lib/build_eval/server/travis.rb

@@ -5,14 +5,13 @@ module BuildEval
 
       def initialize(args)
         @username = args[:username]
-        @travis   = BuildEval::Travis.new(::Travis)
       end
 
       def build_result(name)
         build_path = "#{@username}/#{name}"
         BuildEval::Result::BuildResult.create(
           build_name:  build_path,
-          status_name: @travis.last_build_status_for(build_path)
+          status_name: BuildEval::Travis.last_build_status(build_path: build_path)
         )
       end
 

data/lib/build_eval/server/travis_pro.rb

@@ -6,25 +6,20 @@ module BuildEval
       def initialize(args)
         @username     = args[:username]
         @github_token = args[:github_token]
-        @travis       = BuildEval::Travis.new(::Travis::Pro)
       end
 
       def build_result(name)
         build_path = "#{@username}/#{name}"
-        BuildEval::Result::BuildResult.create(build_name: build_path, status_name: last_status_name(build_path))
+        BuildEval::Result::BuildResult.create(
+          build_name:  build_path,
+          status_name: BuildEval::Travis.last_build_status(github_token: @github_token, build_path: build_path)
+        )
       end
 
       def to_s
         "Travis CI Pro #{@username}"
       end
 
-      private
-
-      def last_status_name(build_path)
-        @travis.login(@github_token)
-        @travis.last_build_status_for(build_path)
-      end
-
     end
 
   end

data/lib/build_eval/travis.rb

@@ -2,18 +2,26 @@ module BuildEval
 
   class Travis
 
-    def initialize(travis_module)
-      @travis_module = travis_module
-    end
+    class << self
 
-    def login(auth_token)
-      @travis_module.github_auth(auth_token)
-    end
+      def last_build_status(args)
+        repository = travis_module_for(args)::Repository.find(args[:build_path])
+        repository.recent_builds.find(&:finished?).passed? ? "Success" : "Failure"
+      rescue ::Travis::Client::Error
+        "Unknown"
+      end
+
+      private
+
+      def travis_module_for(args)
+        travis_module = ::Travis
+        if args[:github_token]
+          travis_module = ::Travis::Pro
+          travis_module.github_auth(args[:github_token])
+        end
+        travis_module
+      end
 
-    def last_build_status_for(build_path)
-      @travis_module::Repository.find(build_path).recent_builds.find(&:finished?).passed? ? "Success" : "Failure"
-    rescue ::Travis::Client::Error
-      "Unknown"
     end
 
   end

data/lib/build_eval/version.rb

@@ -1,3 +1,3 @@
 module BuildEval
-  VERSION = "0.0.10".freeze
+  VERSION = "0.0.11".freeze
 end

data/spec/lib/build_eval/server/travis_pro_spec.rb

@@ -16,35 +16,32 @@ describe BuildEval::Server::TravisPro do
 
     let(:build_name)        { "some_build_name" }
     let(:last_build_status) { "Unknown" }
-    let(:travis)            { instance_double(BuildEval::Travis, login: nil, last_build_status_for: last_build_status) }
     let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_pro_server.build_result(build_name) }
 
     before(:example) do
-      allow(BuildEval::Travis).to receive(:new).and_return(travis)
+      allow(BuildEval::Travis).to receive(:last_build_status).and_return(last_build_status)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
-    it "creates a Travis API wrapping the Pro module" do
-      expect(BuildEval::Travis).to receive(:new).with(::Travis::Pro)
-
-      subject
-    end
-
-    it "logs-in to the Travis API using the provided GitHub token" do
-      expect(travis).to receive(:login).with(github_token)
+    it "retrieves the last build status from Travis using the provided GitHub token" do
+      expect(BuildEval::Travis).to(
+        receive(:last_build_status).with(hash_including(github_token: github_token))
+      )
 
       subject
     end
 
-    it "retrieves the last build status for the GitHub repository" do
-      expect(travis).to receive(:last_build_status_for).with("#{username}/#{build_name}")
+    it "retrieves the last build status from Travis for the users build" do
+      expect(BuildEval::Travis).to(
+        receive(:last_build_status).with(hash_including(build_path: "#{username}/#{build_name}"))
+      )
 
       subject
     end
 
-    it "creates a build result whose build name is the path to the GitHub repository" do
+    it "creates a build result whose build name is the path to users build" do
       expect(BuildEval::Result::BuildResult).to(
         receive(:create).with(hash_including(build_name: "#{username}/#{build_name}"))
       )

data/spec/lib/build_eval/server/travis_spec.rb

@@ -10,29 +10,24 @@ describe BuildEval::Server::Travis do
 
     let(:build_name)        { "some_build_name" }
     let(:last_build_status) { "Failure" }
-    let(:travis)            { instance_double(BuildEval::Travis, last_build_status_for: last_build_status) }
     let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_server.build_result(build_name) }
 
     before(:example) do
-      allow(BuildEval::Travis).to receive(:new).and_return(travis)
+      allow(BuildEval::Travis).to receive(:last_build_status).and_return(last_build_status)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
-    it "creates a Travis API wrapping the Standard module" do
-      expect(BuildEval::Travis).to receive(:new).with(::Travis)
-
-      subject
-    end
-
-    it "retrieves the last build status for the GitHub repository" do
-      expect(travis).to receive(:last_build_status_for).with("#{username}/#{build_name}")
+    it "retrieves the last build status from Travis for the users build" do
+      expect(BuildEval::Travis).to(
+        receive(:last_build_status).with(hash_including(build_path: "#{username}/#{build_name}"))
+      )
 
       subject
     end
 
-    it "creates a build result whose build name is the path to the GitHub repository" do
+    it "creates a build result whose build name is the path to users build" do
       expect(BuildEval::Result::BuildResult).to(
         receive(:create).with(hash_including(build_name: "#{username}/#{build_name}"))
       )

data/spec/lib/build_eval/travis_shared_context.rb

@@ -1,7 +1,50 @@
 shared_context "stubbed Travis API interactions" do
 
-  let(:travis_namespace) { instance_double(::Travis::Client::Namespace) }
+  module StubTravisBuild
 
-  before(:each) { allow(::Travis::Client::Namespace).to receive(:new).and_return(travis_namespace) }
+    def finished?
+      # Intentionally blank
+    end
+
+    def passed?
+      # Intentionally blank
+    end
+
+  end
+
+    module StubTravisRepository
+
+    def recent_builds
+      # Intentionally blank
+    end
+
+  end
+
+  module StubTravisPro
+
+    Repository = StubTravisRepository
+
+    def self.github_auth(auth_token)
+      # Intentionally blank
+    end
+
+  end
+
+  module StubTravis
+
+    Repository = StubTravisRepository
+    Pro = StubTravisPro
+
+    module Client
+      Repository = StubTravisRepository
+      Build = StubTravisBuild
+      Error = ::StandardError
+    end
+
+  end
+
+  before(:context) do
+    ::Travis = StubTravis
+  end
 
 end

data/spec/lib/build_eval/travis_spec.rb

@@ -1,27 +1,10 @@
 describe BuildEval::Travis do
   include_context "stubbed Travis API interactions"
 
-  let(:travis_module) { ::Travis }
+  describe "::last_build_status" do
 
-  let(:travis) { described_class.new(travis_module) }
-
-  describe "#login" do
-
-    let(:github_token) { "SOMEGITHUBTOKEN" }
-
-    subject { travis.login(github_token) }
-
-    it "logs-in to Travis using the GitHub Auth token provided" do
-      expect(travis_module).to receive(:github_auth).with(github_token)
-
-      subject
-    end
-
-  end
-
-  describe "#last_build_status_for" do
-
-    let(:build_path) { "some/build_path" }
+    let(:build_path)    { "some/build_path" }
+    let(:optional_args) { {} }
 
     let(:recent_builds)                   do
       (1..3).map { |i| instance_double(::Travis::Client::Build, finished?: i > 1) }
@@ -32,20 +15,63 @@ describe BuildEval::Travis do
       instance_double(::Travis::Client::Repository, recent_builds: recent_builds)
     end
 
-    subject { travis.last_build_status_for(build_path) }
+    subject { described_class.last_build_status({ build_path: build_path }.merge(optional_args)) }
 
     before(:example) do
-      allow(travis_module::Repository).to receive(:find).and_return(travis_repository)
+      allow(::Travis::Repository).to receive(:find).and_return(travis_repository)
       allow(last_finished_build).to receive(:passed?).and_return(last_finished_build_passed_flag)
     end
 
-    it "retrieves the Travis Repository for the provided build path" do
-      expect(travis_module::Repository).to receive(:find).with(build_path)
+    context "when a GitHub token is provided" do
+
+      let(:github_token)  { "SOMEGITHUBAUTHTOKEN" }
+      let(:optional_args) { { github_token: github_token } }
+
+      it "logs-in to the Travis Pro API with the provided GitHub token" do
+        expect(::Travis::Pro).to receive(:github_auth).with(github_token)
+
+        subject
+      end
+
+      it "uses the Travis Pro modules Repository" do
+        expect(::Travis::Pro::Repository).to receive(:find)
+
+        subject
+      end
+
+      context "when a Travis Client error occurs on log-in" do
+
+        before(:example) do
+          allow(::Travis::Pro).to receive(:github_auth).and_raise(::Travis::Client::Error.new("Forced error"))
+        end
+
+        it "returns 'Unknown'" do
+          expect(subject).to eql("Unknown")
+        end
+
+      end
+
+    end
+
+    context "when no GitHub token is provided" do
+
+      let(:optional_args) { {} }
+
+      it "uses the Travis modules Repository" do
+        expect(::Travis::Repository).to receive(:find)
+
+        subject
+      end
+
+    end
+
+    it "retrieves the repository for the provided build path" do
+      expect(::Travis::Repository).to receive(:find).with(build_path)
 
       subject
     end
 
-    it "retrieves the recent builds from the Travis Repository" do
+    it "retrieves the recent builds from the repository" do
       expect(travis_repository).to receive(:recent_builds)
 
       subject

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.11
 platform: ruby
 authors:
 - Matthew Ueckerman