build 2.4.4 → 2.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b7921d3b8f07853ccccdd021aeba784001c856078cbd272bad7948dda19199a
-  data.tar.gz: e3ae69fe9aa59716ce07eb2e0755f75d8a9fe2e2b82b66b73f73fbbcfdfcad0e
+  metadata.gz: 0a7dc5ba6382c7406b79f7a5963fab483b90f7420cd337e3d3e5c912b6a8dc1e
+  data.tar.gz: 2667f5375ed38172f5abe47f595951c82b545d58b27cbcb449b5f1fd8b367ef8
 SHA512:
-  metadata.gz: 96f81bd9b9b8d61e0d4409c66d4731083cae8836fe04b693fe68b3a2e106fc3040f4ea80f92c792dcdd894f6cdbffb252d95ecdc9e6c565ba87876b84ed2954c
-  data.tar.gz: dd759132956ca254cbd977699ee32bdc22fcb537478de63d1a4b264462d24fb22ac6cecdcd3e043b71a9db55347cb8bca393115775eb5813dd327ce83c1faa25
+  metadata.gz: 0be1a4642c4b95e46abfc8d49f2a80c77acb819aa906e4912e1161f0422af22bd50056910b80f60e8475c27e28402f64aa15feed23bfc838704916341c0e7a5e
+  data.tar.gz: ab49021a6454da45bf8f299cf62b81aa44201e652bc2720d329b97189a5154485f20f064b42cc2bd9dd241adcda32fc36107d718d573a8e1e2513b4d188699fd

data/lib/build/rule.rb

@@ -88,13 +88,15 @@ module Build
 			def compute(arguments, scope)
 				if implicit?
 					# Can be replaced if supplied:
-					arguments[@name] || scope.instance_exec(arguments, &@dynamic)
+					arguments[@name] || scope.instance_exec(arguments, &@dynamic) || @options[:default]
 				elsif dynamic?
 					# Argument is optional:
-					scope.instance_exec(arguments[@name], arguments, &@dynamic)
-				else
+					scope.instance_exec(arguments[@name], arguments, &@dynamic) || @options[:default]
+				elsif arguments.key?(@name)
 					arguments[@name]
-				end || @options[:default]
+				else
+					@options[:default]
+				end
 			end
 			
 			def hash

data/lib/build/version.rb

@@ -19,5 +19,5 @@
 # THE SOFTWARE.
 
 module Build
-	VERSION = "2.4.4"
+	VERSION = "2.4.5"
 end

data/spec/build/rule_spec.rb

@@ -32,4 +32,22 @@ RSpec.describe Build::Rule do
 		expect(rule.applicable?(source: 'foo', destination: 'bar')).to be_truthy
 		expect(rule.applicable?(source: 'foo')).to be_falsey
 	end
+	
+	it "respects false argument" do
+		rule = Build::Rule.new("compile", "cpp")
+		
+		rule.parameter :install, default: true
+		
+		expect(
+			rule.normalize({}, binding)
+		).to be == {install: true}
+		
+		expect(
+			rule.normalize({install: true}, binding)
+		).to be == {install: true}
+		
+		expect(
+			rule.normalize({install: false}, binding)
+		).to be == {install: false}
+	end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: build
 version: !ruby/object:Gem::Version
-  version: 2.4.4
+  version: 2.4.5
 platform: ruby
 authors:
 - Samuel Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-14 00:00:00.000000000 Z
+date: 2019-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: build-graph