bugsnag 6.6.3 → 6.6.4

data/.travis.yml

@@ -4,11 +4,11 @@ language: ruby
 before_install:
 - gem update --system 2.6.14
 - gem --version
-- gem install bundler -v 1.12
-- bundle _1.12.0_ --version
+- gem install bundler -v $BUNDLE_VERSION
+- bundle _${BUNDLE_VERSION}_ --version
 
 install:
-- bundle _1.12.0_ install --with "$GEMSETS" --binstubs
+- bundle _${BUNDLE_VERSION}_ install --with "$GEMSETS" --binstubs
 
 script:
 - bundle exec ./bin/rake spec
@@ -16,23 +16,58 @@ script:
 jobs:
   include:
   - stage: test
-    env: GEMSETS=test
+    env:
+    - BUNDLE_VERSION=1.16.1
+    - GEMSETS=test
     rvm: jruby-19mode
   - stage: test
-    env: GEMSETS=test
     rvm: 1.9.3
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS=test
   - stage: test
-    env: GEMSETS=test
     rvm: 2.0.0
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS=test
   - stage: test
-    env: GEMSETS=test
-    rvm: 2.1.10
+    rvm: 2.1.
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS=test
   - stage: test
-    env: GEMSETS="test sidekiq"
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS="test sidekiq"
     rvm: 2.2.4
   - stage: test
-    env: GEMSETS="test sidekiq coverage"
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS="test sidekiq coverage"
     rvm: 2.3.0
   - stage: test
-    env: GEMSETS="test sidekiq"
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS="test sidekiq"
     rvm: 2.4.1
+  - stage: test
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS="test rubocop"
+    rvm: 2.4.1
+    script: bundle exec ./bin/rubocop lib/
+  - stage: deploy
+    env:
+    - BUNDLE_VERSION=1.12.0
+    - GEMSETS="test doc"
+    rvm: 2.4.1
+    script: bundle exec rake rdoc
+    if: tag =~ ^v[1-9]
+
+deploy:
+  provider: pages
+  local_dir: rdoc # only include the contents of the generated docs dir
+  skip_cleanup: true
+  github_token: $GITHUB_TOKEN # set in travis-ci dashboard
+  on:
+    tags: true # only deploy when tag is applied to commit

data/CHANGELOG.md

@@ -1,6 +1,18 @@
 Changelog
 =========
 
+## 6.6.4 (14 Feb 2018)
+
+### Fixes
+
+* Mark files in `.bundle/` directory as not "in project"
+  | [#420](https://github.com/bugsnag/bugsnag-ruby/pull/420)
+  | [Alex Moinet](https://github.com/Cawllec)
+* Restore support for attaching `bugsnag_*` metadata to exceptions without
+  extending `Bugsnag::Middleware::ExceptionMetaData`
+  | [#426](https://github.com/bugsnag/bugsnag-ruby/pull/426)
+  | [Jordan Raine](https://github.com/jnraine)
+
 ## 6.6.3 (23 Jan 2018)
 
 ### Fixes

data/Gemfile

@@ -16,8 +16,16 @@ group :coverage, optional: true do
     gem 'coveralls'
 end
 
+group :rubocop, optional: true do
+    gem 'rubocop', '~> 0.52.1'
+end
+
 group :sidekiq, optional: true do
     gem 'sidekiq', '~> 5.0.4'
 end
 
+group :doc, optional: true do
+  gem 'hanna-nouveau'
+end
+
 gemspec

data/Rakefile

@@ -2,12 +2,13 @@
 
 require 'rdoc/task'
 RDoc::Task.new do |rdoc|
-  version = File.exist?('VERSION') ? File.read('VERSION') : ""
-
   rdoc.rdoc_dir = 'rdoc'
-  rdoc.title = "bugsnag #{version}"
-  rdoc.rdoc_files.include('README*')
+  rdoc.rdoc_files.include('README.md')
+  rdoc.rdoc_files.include('CONTRIBUTING.md')
+  rdoc.rdoc_files.include('CHANGELOG.md')
   rdoc.rdoc_files.include('lib/**/*.rb')
+  rdoc.options.push '-f', 'hanna'
+  rdoc.markup = 'markdown'
 end
 
 # RSpec tasks

data/VERSION

@@ -1 +1 @@
-6.6.3
+6.6.4

data/lib/bugsnag.rb

@@ -30,7 +30,10 @@ module Bugsnag
   LOCK = Mutex.new
 
   class << self
+    ##
     # Configure the Bugsnag notifier application-wide settings.
+    #
+    # Yields a configuration object to use to set application settings.
     def configure
       yield(configuration) if block_given?
 
@@ -41,7 +44,10 @@ module Bugsnag
       end
     end
 
-    # Explicitly notify of an exception
+    ##
+    # Explicitly notify of an exception.
+    #
+    # Optionally accepts a block to append metadata to the yielded report.
     def notify(exception, auto_notify=false, &block)
       unless auto_notify.is_a? TrueClass or auto_notify.is_a? FalseClass
         configuration.warn("Adding metadata/severity using a hash is no longer supported, please use block syntax instead")
@@ -120,23 +126,32 @@ module Bugsnag
       end
     end
 
-    # Configuration getters
+    ##
+    # Returns the client's Configuration object, or creates one if not yet created.
     def configuration
       @configuration = nil unless defined?(@configuration)
       @configuration || LOCK.synchronize { @configuration ||= Bugsnag::Configuration.new }
     end
 
-    # Session tracking
+    ##
+    # Returns the client's SessionTracker object, or creates one if not yet created.
     def session_tracker
       @session_tracker = nil unless defined?(@session_tracker)
       @session_tracker || LOCK.synchronize { @session_tracker ||= Bugsnag::SessionTracker.new}
     end
 
+    ##
+    # Starts a session.
+    #
+    # Allows Bugsnag to track error rates across releases.
     def start_session
       session_tracker.start_session
     end
 
-    # Allow access to "before notify" callbacks
+    ##
+    # Allow access to "before notify" callbacks as an array.
+    #
+    # These callbacks will be called whenever an error notification is being made.
     def before_notify_callbacks
       Bugsnag.configuration.request_data[:before_callbacks] ||= []
     end

data/lib/bugsnag/configuration.rb

@@ -121,40 +121,58 @@ module Bugsnag
       @default_delivery_method = delivery_method
     end
 
+    ##
+    # Indicates whether the notifier should send a notification based on the
+    # configured release stage.
     def should_notify_release_stage?
       @release_stage.nil? || @notify_release_stages.nil? || @notify_release_stages.include?(@release_stage)
     end
 
+    ##
+    # Tests whether the configured API key is valid.
     def valid_api_key?
       !api_key.nil? && api_key =~ API_KEY_REGEX
     end
 
+    ##
+    # Returns the array of data that will be automatically attached to every
+    # error notification.
     def request_data
       Thread.current[THREAD_LOCAL_NAME] ||= {}
     end
 
+    ##
+    # Sets an entry in the array of data attached to every error notification.
     def set_request_data(key, value)
       self.request_data[key] = value
     end
 
+    ##
+    # Unsets an entry in the array of data attached to every error notification.
     def unset_request_data(key, value)
       self.request_data.delete(key)
     end
 
+    ##
+    # Clears the array of data attached to every error notification.
     def clear_request_data
       Thread.current[THREAD_LOCAL_NAME] = nil
     end
 
+    ##
+    # Logs an info level message
     def info(message)
       logger.info(message)
     end
 
-    # Warning logger
+    ##
+    # Logs a warning level message
     def warn(message)
       logger.warn(message)
     end
 
-    # Debug logger
+    ##
+    # Logs a debug level message
     def debug(message)
       logger.debug(message)
     end

data/lib/bugsnag/delivery.rb

@@ -1,18 +1,22 @@
 module Bugsnag
   module Delivery
     class << self
+      ##
       # Add a delivery method to the list of supported methods. Any registered
       # method can then be used by name in Configuration.
       #
+      # ```
       # require 'bugsnag'
       # Bugsnag::Delivery.register(:my_delivery_queue, MyDeliveryQueue)
       # Bugsnag.configure do |config|
       #   config.delivery_method = :my_delivery_queue
       # end
+      # ```
       def register(name, delivery_method)
         delivery_methods[name.to_sym] = delivery_method
       end
 
+      ##
       # Reference a delivery method by name
       def [](name)
         delivery_methods[name.to_sym]

data/lib/bugsnag/delivery/synchronous.rb

@@ -5,6 +5,8 @@ module Bugsnag
   module Delivery
     class Synchronous
       class << self
+        ##
+        # Attempts to deliver a payload to the given endpoint synchronously.
         def deliver(url, body, configuration, options={})
           begin
             response = request(url, body, configuration, options)

data/lib/bugsnag/delivery/thread_queue.rb

@@ -8,6 +8,8 @@ module Bugsnag
       MUTEX = Mutex.new
 
       class << self
+        ##
+        # Queues a given payload to be delivered asynchronously.
         def deliver(url, body, configuration, options={})
           @configuration = configuration
 

data/lib/bugsnag/helpers.rb

@@ -10,6 +10,7 @@ module Bugsnag
     MAX_ARRAY_LENGTH = 40
     RAW_DATA_TYPES = [Numeric, TrueClass, FalseClass]
 
+    ##
     # Trim the size of value if the serialized JSON value is longer than is
     # accepted by Bugsnag
     def self.trim_if_needed(value)
@@ -23,6 +24,10 @@ module Bugsnag
       remove_metadata_from_events(reduced_value)
     end
 
+    ##
+    # Merges r_hash into l_hash recursively, favouring the values in r_hash.
+    #
+    # Returns a new array consisting of the merged values
     def self.deep_merge(l_hash, r_hash)
       l_hash.merge(r_hash) do |key, l_val, r_val|
         if l_val.is_a?(Hash) && r_val.is_a?(Hash)
@@ -35,6 +40,10 @@ module Bugsnag
       end
     end
 
+    ##
+    # Merges r_hash into l_hash recursively, favouring the values in r_hash.
+    #
+    # Overwrites the values in the existing l_hash
     def self.deep_merge!(l_hash, r_hash)
       l_hash.merge!(r_hash) do |key, l_val, r_val|
         if l_val.is_a?(Hash) && r_val.is_a?(Hash)
@@ -51,6 +60,7 @@ module Bugsnag
 
     TRUNCATION_INFO = '[TRUNCATED]'
 
+    ##
     # Check if a value is a raw type which should not be trimmed, truncated
     # or converted to a string
     def self.is_json_raw_type?(value)

data/lib/bugsnag/integrations/mailman.rb

@@ -1,6 +1,8 @@
 require 'mailman'
 
 module Bugsnag
+  ##
+  # Extracts and appends mailman message information to error reports
   class Mailman
 
     FRAMEWORK_ATTRIBUTES = {
@@ -12,6 +14,8 @@ module Bugsnag
       Bugsnag.configuration.app_type = "mailman"
     end
 
+    ##
+    # Calls the mailman middleware.
     def call(mail)
       begin
         Bugsnag.configuration.set_request_data :mailman_msg, mail.to_s

data/lib/bugsnag/integrations/rack.rb

@@ -1,4 +1,6 @@
 module Bugsnag
+  ##
+  # Automatically captures and adds Rack request information to error reports
   class Rack
 
     FRAMEWORK_ATTRIBUTES = {
@@ -31,6 +33,8 @@ module Bugsnag
       end
     end
 
+    ##
+    # Wraps a call to the application with error capturing
     def call(env)
       # Set the request data for bugsnag middleware to use
       Bugsnag.configuration.set_request_data(:rack_env, env)

data/lib/bugsnag/integrations/rake.rb

@@ -8,6 +8,8 @@ class Rake::Task
     :framework => "Rake"
   }
 
+  ##
+  # Executes the rake task with Bugsnag setup with contextual data.
   def execute_with_bugsnag(args=nil)
     Bugsnag.configuration.app_type ||= "rake"
     old_task = Bugsnag.configuration.request_data[:bugsnag_running_task]

data/lib/bugsnag/integrations/resque.rb

@@ -8,11 +8,15 @@ module Bugsnag
       :framework => "Resque"
     }
 
+    ##
+    # Callthrough to Bugsnag configuration.
     def self.configure(&block)
       add_failure_backend
       Bugsnag.configure(&block)
     end
 
+    ##
+    # Sets up the Resque failure backend.
     def self.add_failure_backend
       return if ::Resque::Failure.backend == self
 
@@ -30,6 +34,8 @@ module Bugsnag
       end
     end
 
+    ##
+    # Notifies Bugsnag of a raised exception.
     def save
       Bugsnag.notify(exception, true) do |report|
         report.severity = "error"

data/lib/bugsnag/integrations/shoryuken.rb

@@ -1,6 +1,8 @@
 require 'shoryuken'
 
 module Bugsnag
+  ##
+  # Extracts and attaches Shoryuken queue information to an error report
   class Shoryuken
 
     FRAMEWORK_ATTRIBUTES = {

data/lib/bugsnag/integrations/sidekiq.rb

@@ -1,6 +1,8 @@
 require 'sidekiq'
 
 module Bugsnag
+  ##
+  # Extracts and attaches Sidekiq job and queue information to an error report
   class Sidekiq
 
     FRAMEWORK_ATTRIBUTES = {

data/lib/bugsnag/middleware/callbacks.rb

@@ -1,4 +1,6 @@
 module Bugsnag::Middleware
+  ##
+  # Calls all configured callbacks passing an error report
   class Callbacks
     def initialize(bugsnag)
       @bugsnag = bugsnag

data/lib/bugsnag/middleware/classify_error.rb

@@ -1,4 +1,6 @@
 module Bugsnag::Middleware
+  ##
+  # Sets the severity to info for low-importance errors
   class ClassifyError
     INFO_CLASSES = [
         "AbstractController::ActionNotFound",