bugsnag 6.4.0 → 6.5.0

data/spec/session_tracker_spec.rb

@@ -0,0 +1,153 @@
+# encoding: utf-8
+require 'webrick'
+require 'spec_helper'
+require 'json'
+
+describe Bugsnag::SessionTracker do
+  server = nil
+  queue = Queue.new
+
+  before do
+    @config = Bugsnag::Configuration.new
+    @config.track_sessions = true
+    server = WEBrick::HTTPServer.new :Port => 0, :Logger => WEBrick::Log.new("/dev/null"), :AccessLog => []
+    server.mount_proc '/' do |req, res|
+      headers = []
+      req.each { |header| headers << header }
+      queue << [JSON.parse(req.body), headers]
+      res.status = 202
+      res.body = "OK\n"
+    end
+    Thread.new{ server.start }
+  end
+
+  after do    
+    Bugsnag.configure do |conf|
+      conf.track_sessions = false
+      conf.delivery_method = :synchronous
+    end
+    server.stop
+    queue.clear
+  end
+
+  it 'does not create session object if disabled' do
+    config = Bugsnag::Configuration.new
+    config.track_sessions = false
+    tracker = Bugsnag::SessionTracker.new(config)
+    tracker.create_session
+    expect(tracker.session_counts.size).to eq(0)
+  end
+
+  it 'adds session object to queue' do
+    tracker = Bugsnag::SessionTracker.new(@config)
+    tracker.create_session
+    expect(tracker.session_counts.size).to eq(1)
+    time = tracker.session_counts.keys.last
+    count = tracker.session_counts[time]
+
+    expect(count).to eq(1)
+  end
+
+  it 'stores session in thread' do
+    tracker = Bugsnag::SessionTracker.new(@config)
+    tracker.create_session
+    session = Thread.current[Bugsnag::SessionTracker::THREAD_SESSION]
+    expect(session.include? :id).to be true
+    expect(session.include? :startedAt).to be true
+    expect(session.include? :events).to be true
+    expect(session[:events].include? :handled).to be true
+    expect(session[:events].include? :unhandled).to be true
+    expect(session[:events][:handled]).to eq(0)
+    expect(session[:events][:unhandled]).to eq(0)
+  end
+
+  it 'gives unique ids to each session' do
+    tracker = Bugsnag::SessionTracker.new(@config)
+    tracker.create_session
+    session_one = Thread.current[Bugsnag::SessionTracker::THREAD_SESSION]
+    tracker.create_session
+    session_two = Thread.current[Bugsnag::SessionTracker::THREAD_SESSION]
+    expect(session_one[:id]).to_not eq(session_two[:id])
+  end
+
+  it 'sends sessions when send_sessions is called' do
+    Bugsnag.configure do |conf|
+      conf.track_sessions = true
+      conf.delivery_method = :thread_queue
+      conf.session_endpoint = "http://localhost:#{server.config[:Port]}"
+    end
+    WebMock.allow_net_connect!
+    Bugsnag.session_tracker.create_session
+    expect(Bugsnag.session_tracker.session_counts.size).to eq(1)
+    Bugsnag.session_tracker.send_sessions
+    expect(Bugsnag.session_tracker.session_counts.size).to eq(0)
+    while queue.empty?
+      sleep(0.05)
+    end
+    payload, headers = queue.pop
+    expect(payload.include?("app")).to be true
+    expect(payload.include?("notifier")).to be true
+    expect(payload.include?("device")).to be true
+    expect(payload.include?("sessionCounts")).to be true
+    expect(payload["sessionCounts"].size).to eq(1)
+  end
+
+  it 'sets details from config' do
+    Bugsnag.configure do |conf|
+      conf.track_sessions = true
+      conf.release_stage = "test_stage"
+      conf.delivery_method = :thread_queue
+      conf.session_endpoint = "http://localhost:#{server.config[:Port]}"
+    end
+    WebMock.allow_net_connect!
+    Bugsnag.session_tracker.create_session
+    expect(Bugsnag.session_tracker.session_counts.size).to eq(1)
+    Bugsnag.session_tracker.send_sessions
+    expect(Bugsnag.session_tracker.session_counts.size).to eq(0)
+    while queue.empty?
+      sleep(0.05)
+    end
+    payload, headers = queue.pop
+    notifier = payload["notifier"]
+    expect(notifier.include?("name")).to be true
+    expect(notifier["name"]).to eq(Bugsnag::Report::NOTIFIER_NAME)
+    expect(notifier.include?("url")).to be true
+    expect(notifier["url"]).to eq(Bugsnag::Report::NOTIFIER_URL)
+    expect(notifier.include?("version")).to be true
+    expect(notifier["version"]).to eq(Bugsnag::Report::NOTIFIER_VERSION)
+
+    app = payload["app"]
+    expect(app.include?("releaseStage")).to be true
+    expect(app["releaseStage"]).to eq(Bugsnag.configuration.release_stage)
+    expect(app.include?("version")).to be true
+    expect(app["version"]).to eq(Bugsnag.configuration.app_version)
+    expect(app.include?("type")).to be true
+    expect(app["type"]).to eq(Bugsnag.configuration.app_type)
+
+    device = payload["device"]
+    expect(device.include?("hostname")).to be true
+    expect(device["hostname"]).to eq(Bugsnag.configuration.hostname)
+  end
+
+  it 'uses middleware to attach session to notification' do
+    Bugsnag.configure do |conf|
+      conf.track_sessions = true
+      conf.release_stage = "test_stage"
+    end
+    Bugsnag.session_tracker.create_session
+    Bugsnag.notify(BugsnagTestException.new("It crashed"))
+    expect(Bugsnag).to have_sent_notification{ |payload, headers|
+      event = payload["events"][0]
+      expect(event.include?("session")).to be true
+      session = event["session"]
+      expect(session.include?("id")).to be true
+      expect(session.include?("startedAt")).to be true
+      expect(session.include?("events")).to be true
+      sesevents = session['events']
+      expect(sesevents.include?("unhandled")).to be true
+      expect(sesevents["unhandled"]).to eq(0)
+      expect(sesevents.include?("handled")).to be true
+      expect(sesevents["handled"]).to eq(1)
+    }
+  end
+end

data/spec/spec_helper.rb

@@ -23,6 +23,10 @@ def get_event_from_payload(payload)
   payload["events"].first
 end
 
+def get_headers_from_payload(payload)
+
+end
+
 def get_exception_from_payload(payload)
   event = get_event_from_payload(payload)
   expect(event["exceptions"].size).to eq(1)
@@ -46,6 +50,7 @@ RSpec.configure do |config|
 
   config.before(:each) do
     WebMock.stub_request(:post, "https://notify.bugsnag.com/")
+    WebMock.stub_request(:post, "https://sessions.bugsnag.com/")
 
     Bugsnag.instance_variable_set(:@configuration, Bugsnag::Configuration.new)
     Bugsnag.configure do |bugsnag|
@@ -62,10 +67,21 @@ RSpec.configure do |config|
   end
 end
 
+def have_sent_sessions(&matcher)
+  have_requested(:post, "https://sessions.bugsnag.com/").with do |request|
+    if matcher
+      matcher.call([JSON.parse(request.body), request.headers])
+      true
+    else
+      raise "no matcher provided to have_sent_sessions (did you use { })"
+    end
+  end
+end
+
 def have_sent_notification(&matcher)
   have_requested(:post, "https://notify.bugsnag.com/").with do |request|
     if matcher
-      matcher.call JSON.parse(request.body)
+      matcher.call([JSON.parse(request.body), request.headers])
       true
     else
       raise "no matcher provided to have_sent_notification (did you use { })"

data/spec/stacktrace_spec.rb

@@ -10,7 +10,7 @@ describe Bugsnag::Stacktrace do
     _e = 5
     _f = 6
 
-    expect(Bugsnag).to have_sent_notification{ |payload|
+    expect(Bugsnag).to have_sent_notification{ |payload, headers|
       exception = get_exception_from_payload(payload)
       starting_line = __LINE__ - 10
       expect(exception["stacktrace"][1]["code"]).to eq({
@@ -30,7 +30,7 @@ describe Bugsnag::Stacktrace do
 
     notify_test_exception
 
-    expect(Bugsnag).to have_sent_notification{ |payload|
+    expect(Bugsnag).to have_sent_notification{ |payload, headers|
       exception = get_exception_from_payload(payload)
       expect(exception["stacktrace"][1]["code"]).to eq(nil)
     }
@@ -39,7 +39,7 @@ describe Bugsnag::Stacktrace do
   it 'should send the first 7 lines of the file for exceptions near the top' do
     load 'spec/fixtures/crashes/start_of_file.rb' rescue Bugsnag.notify $!
 
-    expect(Bugsnag).to have_sent_notification{ |payload|
+    expect(Bugsnag).to have_sent_notification{ |payload, headers|
       exception = get_exception_from_payload(payload)
 
       expect(exception["stacktrace"][0]["code"]).to eq({
@@ -57,7 +57,7 @@ describe Bugsnag::Stacktrace do
   it 'should send the last 7 lines of the file for exceptions near the bottom' do
     load 'spec/fixtures/crashes/end_of_file.rb' rescue Bugsnag.notify $!
 
-    expect(Bugsnag).to have_sent_notification{ |payload|
+    expect(Bugsnag).to have_sent_notification{ |payload, headers|
       exception = get_exception_from_payload(payload)
 
       expect(exception["stacktrace"][0]["code"]).to eq({
@@ -75,7 +75,7 @@ describe Bugsnag::Stacktrace do
   it 'should send the last 7 lines of the file for exceptions near the bottom' do
     load 'spec/fixtures/crashes/short_file.rb' rescue Bugsnag.notify $!
 
-    expect(Bugsnag).to have_sent_notification{ |payload|
+    expect(Bugsnag).to have_sent_notification{ |payload, headers|
       exception = get_exception_from_payload(payload)
 
       expect(exception["stacktrace"][0]["code"]).to eq({

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 6.4.0
+  version: 6.5.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-21 00:00:00.000000000 Z
+date: 2018-01-04 00:00:00.000000000 Z
 dependencies: []
 description: Ruby notifier for bugsnag.com
 email: james@bugsnag.com
@@ -60,11 +60,13 @@ files:
 - lib/bugsnag/middleware/rack_request.rb
 - lib/bugsnag/middleware/rails3_request.rb
 - lib/bugsnag/middleware/rake.rb
+- lib/bugsnag/middleware/session_data.rb
 - lib/bugsnag/middleware/sidekiq.rb
 - lib/bugsnag/middleware/suggestion_data.rb
 - lib/bugsnag/middleware/warden_user.rb
 - lib/bugsnag/middleware_stack.rb
 - lib/bugsnag/report.rb
+- lib/bugsnag/session_tracker.rb
 - lib/bugsnag/stacktrace.rb
 - lib/bugsnag/tasks.rb
 - lib/bugsnag/tasks/bugsnag.rake
@@ -87,6 +89,7 @@ files:
 - spec/rack_spec.rb
 - spec/rails3_request_spec.rb
 - spec/report_spec.rb
+- spec/session_tracker_spec.rb
 - spec/spec_helper.rb
 - spec/stacktrace_spec.rb
 homepage: http://github.com/bugsnag/bugsnag-ruby
@@ -109,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Ruby notifier for bugsnag.com