bugsnag 6.15.0 → 6.16.0

data/spec/cleaner_spec.rb

@@ -1,350 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-describe Bugsnag::Cleaner do
-  subject { Bugsnag::Cleaner.new(Bugsnag::Configuration.new) }
-
-  describe "#clean_object" do
-    is_jruby = defined?(RUBY_ENGINE) && RUBY_ENGINE == 'jruby'
-
-    it "cleans up recursive hashes" do
-      a = {:a => {}}
-      a[:a][:b] = a
-      expect(subject.clean_object(a)).to eq({:a => {:b => "[RECURSION]"}})
-    end
-
-    it "cleans up hashes when keys infinitely recurse in to_s" do
-      skip "JRuby doesn't allow recovery from SystemStackErrors" if is_jruby
-
-      class RecursiveHashKey
-        def to_s
-          to_s
-        end
-      end
-
-      key = RecursiveHashKey.new
-
-      a = {}
-      a[key] = 1
-
-      expect(subject.clean_object(a)).to eq({ "[RECURSION]" => "[FILTERED]" })
-    end
-
-    it "cleans up hashes when a nested key infinitely recurse in to_s" do
-      skip "JRuby doesn't allow recovery from SystemStackErrors" if is_jruby
-
-      class RecursiveHashKey
-        def to_s
-          to_s
-        end
-      end
-
-      key = RecursiveHashKey.new
-
-      a = {}
-      a[:b] = {}
-      a[:b][key] = 1
-
-      expected = { :b => { "[RECURSION]" => "[FILTERED]" } }
-
-      expect(subject.clean_object(a)).to eq(expected)
-    end
-
-    it "cleans up hashes when keys raise in to_s" do
-      class RaisingHashKey
-        def to_s
-          raise "hey!"
-        end
-      end
-
-      key = RaisingHashKey.new
-
-      a = {}
-      a[key] = 1
-
-      expect(subject.clean_object(a)).to eq({ "[RAISED]" => "[FILTERED]" })
-    end
-
-    it "cleans up hashes when nested keys raise in to_s" do
-      class RaisingHashKey
-        def to_s
-          raise "hey!"
-        end
-      end
-
-      key = RaisingHashKey.new
-
-      a = {}
-      a[:b] = {}
-      a[:b][key] = 1
-
-      expected = { :b => { "[RAISED]" => "[FILTERED]" } }
-
-      expect(subject.clean_object(a)).to eq(expected)
-    end
-
-    it "cleans up recursive arrays" do
-      a = []
-      a << a
-      a << "hello"
-      expect(subject.clean_object(a)).to eq(["[RECURSION]", "hello"])
-    end
-
-    it "doesn't remove nil from arrays" do
-      a = ["b", nil, "c"]
-      expect(subject.clean_object(a)).to eq(["b", nil, "c"])
-    end
-
-    it "allows multiple copies of the same string" do
-      a = {:name => "bugsnag"}
-      a[:second] = a[:name]
-      expect(subject.clean_object(a)).to eq({:name => "bugsnag", :second => "bugsnag"})
-    end
-
-    it "allows multiple copies of the same object" do
-      a = []
-      b = ["hello"]
-      a << b; a << b
-      expect(subject.clean_object(a)).to eq([["hello"], ["hello"]])
-    end
-
-    it "cleans up UTF8 strings properly" do
-      obj = "André"
-      expect(subject.clean_object(obj)).to eq("André")
-    end
-
-    it "cleans custom objects" do
-      class Macaron; end
-      a = Macaron.new
-      expect(subject.clean_object(a)).to eq('[OBJECT]')
-    end
-
-    it "cleans custom objects when they infinitely recurse" do
-      skip "JRuby doesn't allow recovery from SystemStackErrors" if is_jruby
-
-      class RecursiveObject
-        def to_s
-          to_s
-        end
-      end
-
-      object = RecursiveObject.new
-
-      expect(subject.clean_object(object)).to eq("[RECURSION]")
-    end
-
-    it "cleans custom objects to show the id of the object if object responds to id method" do
-      class MacaronWithId
-        def id
-          10
-        end
-      end
-
-      a = MacaronWithId.new
-      expect(subject.clean_object(a)).to eq("[OBJECT]: [Class]: #{a.class.name} [ID]: #{a.id}")
-    end
-
-    it "cleans up binary strings properly" do
-      if RUBY_VERSION > "1.9"
-        obj = "Andr\xc7\xff"
-        if obj.respond_to? :force_encoding
-          obj = obj.force_encoding('BINARY')
-        end
-        expect(subject.clean_object(obj)).to eq("Andr��")
-      end
-    end
-
-    it "cleans up strings returned from #to_s properly" do
-      if RUBY_VERSION > "1.9"
-        str = "Andr\xc7\xff"
-        if str.respond_to? :force_encoding
-          str = str.force_encoding('BINARY')
-        end
-        obj = RuntimeError.new(str)
-        expect(subject.clean_object(obj)).to eq("Andr��")
-      end
-    end
-
-    it "filters by string inclusion" do
-      object = { events: { metaData: { foo: 'bar' } } }
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = ['f']
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-      expect(cleaner.clean_object(object)).to eq({ events: { metaData: { foo: '[FILTERED]' } } })
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = ['b']
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-      expect(cleaner.clean_object(object)).to eq({ events: { metaData: { foo: 'bar' } } })
-    end
-
-    it "filters by regular expression" do
-      object = { events: { metaData: { foo: 'bar' } } }
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/fb?/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-      expect(cleaner.clean_object(object)).to eq({ events: { metaData: { foo: '[FILTERED]' } } })
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/fb+/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-      expect(cleaner.clean_object(object)).to eq({ events: { metaData: { foo: 'bar' } } })
-    end
-
-    it "filters deeply nested keys" do
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/^foo\.bar/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      params = { events: { metaData: { foo: { bar: 'baz' } } } }
-      expect(cleaner.clean_object(params)).to eq({ events: { metaData: { foo: { bar: '[FILTERED]' } } } })
-    end
-
-    it "filters deeply nested request parameters" do
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/^foo\.bar/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      params = { events: { metaData: { request: { params: { foo: { bar: 'baz' } } } } } }
-      expect(cleaner.clean_object(params)).to eq({ events: { metaData: { request: { params: { foo: { bar: '[FILTERED]' } } } } } })
-    end
-
-    it "doesn't filter by string inclusion when the scope is not in 'scopes_to_filter'" do
-      object = { foo: 'bar' }
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = ['f']
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      expect(cleaner.clean_object(object)).to eq({ foo: 'bar' })
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = ['b']
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      expect(cleaner.clean_object(object)).to eq({ foo: 'bar' })
-    end
-
-    it "doesn't filter by regular expression when the scope is not in 'scopes_to_filter'" do
-      object = { foo: 'bar' }
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/fb?/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      expect(cleaner.clean_object(object)).to eq({ foo: 'bar' })
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/fb+/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      expect(cleaner.clean_object(object)).to eq({ foo: 'bar' })
-    end
-
-    it "doesn't filter deeply nested keys when the scope is not in 'scopes_to_filter'" do
-      params = { foo: { bar: 'baz' } }
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/^foo\.bar/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      expect(cleaner.clean_object(params)).to eq({ foo: { bar: 'baz' } })
-    end
-
-    it "doesn't filter deeply nested request parameters when the scope is not in 'scopes_to_filter'" do
-      params = { request: { params: { foo: { bar: 'baz' } } } }
-
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = [/^foo\.bar/]
-
-      cleaner = Bugsnag::Cleaner.new(configuration)
-
-      expect(cleaner.clean_object(params)).to eq({ request: { params: { foo: { bar: 'baz' } } } })
-    end
-
-    it "filters objects which can't be stringified" do
-      class StringRaiser
-        def to_s
-          raise 'Oh no you do not!'
-        end
-      end
-      expect(subject.clean_object({ :foo => StringRaiser.new })).to eq({ :foo => '[RAISED]' })
-    end
-  end
-
-  describe "#clean_url" do
-    let(:filters) { [] }
-
-    subject do
-      configuration = Bugsnag::Configuration.new
-      configuration.meta_data_filters = filters
-      described_class.new(configuration).clean_url(url)
-    end
-
-    context "with no filters configured" do
-      let(:url) { "/dir/page?param1=value1&param2=value2" }
-      it { should eq "/dir/page?param1=value1&param2=value2" }
-    end
-
-    context "with no get params" do
-      let(:url) { "/dir/page" }
-      it { should eq "/dir/page" }
-    end
-
-    context "with no matching parameters" do
-      let(:filters) { ["param3"] }
-      let(:url) { "/dir/page?param1=value1&param2=value2" }
-      it { should eq "/dir/page?param1=value1&param2=value2" }
-    end
-
-    context "with a single matching parameter" do
-      let(:filters) { ["param1"] }
-      let(:url) { "/dir/page?param1=value1&param2=value2" }
-      it { should eq "/dir/page?param1=[FILTERED]&param2=value2" }
-    end
-
-    context "with partially matching parameters" do
-      let(:filters) { ["param"] }
-      let(:url) { "/dir/page?param1=value1&param2=value2&bla=yes" }
-      it { should eq "/dir/page?param1=[FILTERED]&param2=[FILTERED]&bla=yes" }
-    end
-
-    context "with multiple matching filters" do
-      let(:filters) { ["param1", "param2"] }
-      let(:url) { "/dir/page?param1=value1&param2=value2&param3=value3" }
-      it { should eq "/dir/page?param1=[FILTERED]&param2=[FILTERED]&param3=value3" }
-    end
-
-    context "with both string and regexp filters" do
-      let(:filters) { ["param1", /param2/] }
-      let(:url) { "/dir/page?param1=value1&param2=value2&param3=value3" }
-      it { should eq "/dir/page?param1=[FILTERED]&param2=[FILTERED]&param3=value3" }
-    end
-
-    context "with matching regexp filters" do
-      let(:filters) { [/\Aaccess_token\z/] }
-      let(:url) { "https://host.example/sessions?access_token=abc123" }
-      it { should eq "https://host.example/sessions?access_token=[FILTERED]" }
-    end
-
-    context "with partially-matching regexp filters" do
-      let(:filters) { [/token/] }
-      let(:url) { "https://host.example/sessions?access_token=abc123" }
-      it { should eq "https://host.example/sessions?access_token=[FILTERED]" }
-    end
-  end
-end

data/spec/code_extractor_spec.rb

@@ -1,129 +0,0 @@
-require 'spec_helper'
-
-describe Bugsnag::CodeExtractor do
-  it "extracts code from a file and adds it to the given hash" do
-    file1_hash = { lineNumber: 5 }
-    file2_hash = { lineNumber: 7 }
-
-    code_extractor = Bugsnag::CodeExtractor.new(Bugsnag::Configuration.new)
-    code_extractor.add_file("spec/fixtures/crashes/file1.rb", file1_hash)
-    code_extractor.add_file("spec/fixtures/crashes/file2.rb", file2_hash)
-
-    code_extractor.extract!
-
-    expect(file1_hash).to eq({
-      lineNumber: 5,
-      code: {
-        2 => "",
-        3 => "module File1",
-        4 => "  def self.foo1",
-        5 => "    File2.foo2",
-        6 => "  end",
-        7 => "",
-        8 => "  def self.bar1"
-      }
-    })
-
-    expect(file2_hash).to eq({
-      lineNumber: 7,
-      code: {
-        4 => "  end",
-        5 => "",
-        6 => "  def self.bar2",
-        7 => "    File1.baz1",
-        8 => "  end",
-        9 => "",
-        10 => "  def self.baz2"
-      }
-    })
-  end
-
-  it "handles extracting code from the first & last line in a file" do
-    file1_hash = { lineNumber: 1 }
-    file2_hash = { lineNumber: 25 }
-
-    code_extractor = Bugsnag::CodeExtractor.new(Bugsnag::Configuration.new)
-    code_extractor.add_file("spec/fixtures/crashes/file1.rb", file1_hash)
-    code_extractor.add_file("spec/fixtures/crashes/file2.rb", file2_hash)
-
-    code_extractor.extract!
-
-    expect(file1_hash).to eq({
-      lineNumber: 1,
-      code: {
-        1 => "require_relative 'file2'",
-        2 => "",
-        3 => "module File1",
-        4 => "  def self.foo1",
-        5 => "    File2.foo2",
-        6 => "  end",
-        7 => ""
-      }
-    })
-
-    expect(file2_hash).to eq({
-      lineNumber: 25,
-      code: {
-        19 => "    puts 'abcdef2'",
-        20 => "  end",
-        21 => "",
-        22 => "  def self.abcdefghi2",
-        23 => "    puts 'abcdefghi2'",
-        24 => "  end",
-        25 => "end"
-      }
-    })
-  end
-
-  it "truncates lines to a maximum of 200 characters" do
-    hash = { lineNumber: 4 }
-
-    code_extractor = Bugsnag::CodeExtractor.new(Bugsnag::Configuration.new)
-    code_extractor.add_file("spec/fixtures/crashes/file_with_long_lines.rb", hash)
-
-    code_extractor.extract!
-
-    # rubocop:disable Layout/LineLength
-    expect(hash).to eq({
-      lineNumber: 4,
-      code: {
-        1 => "# rubocop:disable Layout/LineLength",
-        2 => "def a_super_long_function_name_that_would_be_really_impractical_to_use_but_luckily_this_is_just_for_a_test_to_prove_we_can_handle_really_long_lines_of_code_that_go_over_200_characters_and_some_more_pa",
-        3 => "  puts 'This is a shorter string'",
-        4 => "  puts 'A more realistic example of when a line would be really long is long strings such as this one, which extends over the 200 character limit by containing a lot of excess words for padding its le",
-        5 => "  puts 'and another shorter string for comparison'",
-        6 => "end",
-        7 => "# rubocop:enable Layout/LineLength",
-      }
-    })
-    # rubocop:enable Layout/LineLength
-  end
-
-  it "rescues exceptions raised in extract!" do
-    file1_hash = { lineNumber: 1 }
-    file2_hash = { lineNumber: 25 }
-
-    code_extractor = Bugsnag::CodeExtractor.new(Bugsnag::Configuration.new)
-    code_extractor.add_file("spec/fixtures/crashes/file1.rb", file1_hash)
-    code_extractor.add_file("spec/fixtures/crashes/file2.rb", file2_hash)
-
-    file1_hash[:first_line_number] = nil
-
-    code_extractor.extract!
-
-    expect(file1_hash).to eq({ lineNumber: 1, code: nil })
-
-    expect(file2_hash).to eq({
-      lineNumber: 25,
-      code: {
-        19 => "    puts 'abcdef2'",
-        20 => "  end",
-        21 => "",
-        22 => "  def self.abcdefghi2",
-        23 => "    puts 'abcdefghi2'",
-        24 => "  end",
-        25 => "end"
-      }
-    })
-  end
-end