bugsnag 6.13.1 → 6.14.0

data/spec/spec_helper.rb

@@ -10,6 +10,7 @@ end
 
 require 'bugsnag'
 
+require 'tmpdir'
 require 'webmock/rspec'
 require 'rspec/expectations'
 require 'rspec/mocks'
@@ -43,12 +44,16 @@ end
 
 RSpec.configure do |config|
   config.order = "random"
+  config.example_status_persistence_file_path = "#{Dir.tmpdir}/rspec_status"
 
   config.before(:each) do
     WebMock.stub_request(:post, "https://notify.bugsnag.com/")
     WebMock.stub_request(:post, "https://sessions.bugsnag.com/")
 
     Bugsnag.instance_variable_set(:@configuration, Bugsnag::Configuration.new)
+    Bugsnag.instance_variable_set(:@session_tracker, Bugsnag::SessionTracker.new)
+    Bugsnag.instance_variable_set(:@cleaner, Bugsnag::Cleaner.new(Bugsnag.configuration))
+
     Bugsnag.configure do |bugsnag|
       bugsnag.api_key = "c9d60ae4c7e70c4b6c4ebd3e8056d2b8"
       bugsnag.release_stage = "production"
@@ -83,4 +88,4 @@ def have_sent_notification(&matcher)
       raise "no matcher provided to have_sent_notification (did you use { })"
     end
   end
-end
+end

data/spec/stacktrace_spec.rb

@@ -1,91 +1,159 @@
 require 'spec_helper'
 
 describe Bugsnag::Stacktrace do
-  it "includes code in the stack trace" do
-    begin
-      _a = 1
-      _b = 2
-      _c = 3
-      "Test".prepnd "T"
-      _d = 4
-      _e = 5
-      _f = 6
-    rescue Exception => e
-      Bugsnag.notify(e)
+  context "sending code" do
+    it "includes code in the stack trace" do
+      begin
+        _a = 1
+        _b = 2
+        _c = 3
+        "Test".prepnd "T"
+        _d = 4
+        _e = 5
+        _f = 6
+      rescue Exception => e
+        Bugsnag.notify(e)
+      end
+
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
+        starting_line = __LINE__ - 13
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          (starting_line + 0).to_s => '        _a = 1',
+          (starting_line + 1).to_s => '        _b = 2',
+          (starting_line + 2).to_s => '        _c = 3',
+          (starting_line + 3).to_s => '        "Test".prepnd "T"',
+          (starting_line + 4).to_s => '        _d = 4',
+          (starting_line + 5).to_s => '        _e = 5',
+          (starting_line + 6).to_s => '        _f = 6'
+          })
+      }
     end
 
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-      starting_line = __LINE__ - 13
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        (starting_line + 0).to_s => '      _a = 1',
-        (starting_line + 1).to_s => '      _b = 2',
-        (starting_line + 2).to_s => '      _c = 3',
-        (starting_line + 3).to_s => '      "Test".prepnd "T"',
-        (starting_line + 4).to_s => '      _d = 4',
-        (starting_line + 5).to_s => '      _e = 5',
-        (starting_line + 6).to_s => '      _f = 6'
+    it "allows you to disable sending code" do
+      Bugsnag.configuration.send_code = false
+
+      notify_test_exception
+
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
+        expect(exception["stacktrace"][1]["code"]).to eq(nil)
+      }
+    end
+
+    it 'should send the first 7 lines of the file for exceptions near the top' do
+      load 'spec/fixtures/crashes/start_of_file.rb' rescue Bugsnag.notify $!
+
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
+
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          "1" => "#",
+          "2" => "raise 'hell'",
+          "3" => "#",
+          "4" => "#",
+          "5" => "#",
+          "6" => "#",
+          "7" => "#"
         })
-    }
-  end
+      }
+    end
 
-  it "allows you to disable sending code" do
-    Bugsnag.configuration.send_code = false
+    it 'should send the last 7 lines of the file for exceptions near the bottom' do
+      load 'spec/fixtures/crashes/end_of_file.rb' rescue Bugsnag.notify $!
 
-    notify_test_exception
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
 
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-      expect(exception["stacktrace"][1]["code"]).to eq(nil)
-    }
-  end
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          "3" => "#",
+          "4" => "#",
+          "5" => "#",
+          "6" => "#",
+          "7" => "#",
+          "8" => "raise 'hell'",
+          "9" => "#"
+        })
+      }
+    end
 
-  it 'should send the first 7 lines of the file for exceptions near the top' do
-    load 'spec/fixtures/crashes/start_of_file.rb' rescue Bugsnag.notify $!
-
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        "1" => "#",
-        "2" => "raise 'hell'",
-        "3" => "#",
-        "4" => "#",
-        "5" => "#",
-        "6" => "#",
-        "7" => "#"
-      })
-    }
-  end
+    it 'should send the last 7 lines of the file for exceptions near the bottom' do
+      load 'spec/fixtures/crashes/short_file.rb' rescue Bugsnag.notify $!
+
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
 
-  it 'should send the last 7 lines of the file for exceptions near the bottom' do
-    load 'spec/fixtures/crashes/end_of_file.rb' rescue Bugsnag.notify $!
-
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        "3" => "#",
-        "4" => "#",
-        "5" => "#",
-        "6" => "#",
-        "7" => "#",
-        "8" => "raise 'hell'",
-        "9" => "#"
-      })
-    }
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          "1" => "raise 'hell'"
+        })
+      }
+    end
   end
 
-  it 'should send the last 7 lines of the file for exceptions near the bottom' do
-    load 'spec/fixtures/crashes/short_file.rb' rescue Bugsnag.notify $!
+  context "file paths" do
+    it "leaves absolute paths alone" do
+      configuration = Bugsnag::Configuration.new
+      configuration.send_code = false
+
+      backtrace = [
+        "/foo/bar/app/models/user.rb:1:in `something'",
+        "/foo/bar/other_vendor/lib/dont.rb:2:in `to_s'",
+        "/foo/bar/vendor/lib/ignore_me.rb:3:in `to_s'",
+        "/foo/bar/.bundle/lib/ignore_me.rb:4:in `to_s'",
+      ]
+
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration).to_a
+
+      expect(stacktrace).to eq([
+        { file: "/foo/bar/app/models/user.rb", lineNumber: 1, method: "something" },
+        { file: "/foo/bar/other_vendor/lib/dont.rb", lineNumber: 2, method: "to_s" },
+        { file: "/foo/bar/vendor/lib/ignore_me.rb", lineNumber: 3, method: "to_s" },
+        { file: "/foo/bar/.bundle/lib/ignore_me.rb", lineNumber: 4, method: "to_s" },
+      ])
+    end
+
+    it "does not modify relative paths if they can't be resolved" do
+      configuration = Bugsnag::Configuration.new
+
+      backtrace = [
+        "./foo/bar/baz.rb:1:in `something'",
+        "../foo.rb:1:in `to_s'",
+        "../xyz.rb:1:in `to_s'",
+        "abc.rb:1:in `defg'",
+      ]
 
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration).to_a
 
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        "1" => "raise 'hell'"
-      })
-    }
+      expect(stacktrace).to eq([
+        { code: nil, file: "./foo/bar/baz.rb", lineNumber: 1, method: "something" },
+        { code: nil, file: "../foo.rb", lineNumber: 1, method: "to_s" },
+        { code: nil, file: "../xyz.rb", lineNumber: 1, method: "to_s" },
+        { code: nil, file: "abc.rb", lineNumber: 1, method: "defg" },
+      ])
+    end
+
+    it "resolves relative paths when the files exist" do
+      configuration = Bugsnag::Configuration.new
+      configuration.send_code = false
+
+      dir = File.dirname(__FILE__)
+
+      backtrace = [
+        "./spec/spec_helper.rb:1:in `something'",
+        "./lib/bugsnag/breadcrumbs/../configuration.rb:100:in `to_s'",
+        "lib/bugsnag.rb:20:in `notify'",
+        "#{dir}/../spec/stacktrace_spec.rb:5:in `something_else'",
+      ]
+
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration).to_a
+
+      expect(stacktrace).to eq([
+        { file: "#{dir}/spec_helper.rb", lineNumber: 1, method: "something" },
+        { file: "#{File.dirname(dir)}/lib/bugsnag/configuration.rb", lineNumber: 100, method: "to_s" },
+        { file: "#{File.dirname(dir)}/lib/bugsnag.rb", lineNumber: 20, method: "notify" },
+        { file: "#{dir}/stacktrace_spec.rb", lineNumber: 5, method: "something_else" },
+      ])
+    end
   end
 
   context "with configurable vendor_path" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 6.13.1
+  version: 6.14.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-12 00:00:00.000000000 Z
+date: 2020-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -639,6 +639,7 @@ files:
 - lib/bugsnag/middleware/classify_error.rb
 - lib/bugsnag/middleware/clearance_user.rb
 - lib/bugsnag/middleware/delayed_job.rb
+- lib/bugsnag/middleware/discard_error_class.rb
 - lib/bugsnag/middleware/exception_meta_data.rb
 - lib/bugsnag/middleware/ignore_error_class.rb
 - lib/bugsnag/middleware/mailman.rb