bugsnag 6.1.0 → 6.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 87a875a7b8d7eb04937db718665e498303157cea
-  data.tar.gz: 39d1e2ad03f42d882286a4ed6845312e99a63738
+  metadata.gz: 87f0ef9e95838181ef04c215cf4e535d6833effa
+  data.tar.gz: bcfe35f561ac496c436dd99733f0df630659683d
 SHA512:
-  metadata.gz: 9fb191d7ec53908887b1b3cbb200a9d714fb0dbd7d17b2157808b110b1f0b5994f2b6d04a0549e39311fa4e822f21bf51152ceb55a151f90fcf28300cdc30244
-  data.tar.gz: 6def29d78105b3e3c2b39aa4d874d86d080285a0afe5e27b2fae9e11c348c1e37ef71dae1447a1656224e989611f96bc4ed597f2d6069daf635cbbdfe86cd0b6
+  metadata.gz: 62d4455c390e8e3c9fce2b0f6e5da83974ffcb1ef805e549e5e79324524e5bd07ff000a75d34c2f88bbb9cdc36acbde69b6ed6aac586635ed8957763fc70cb0c
+  data.tar.gz: 4c8e70a864252fe2e1bbb6a8642da9f290edfe8f21a41f4ea026d6295f810aa07bf221c623990ce293e859cbd72677edb357dfbcbbd8833f2089083d2d623fc0

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+## 6.1.1 (23 Nov 2017)
+
+### Fixes
+
+* Ensured Bugsnag class intialises before railties initialised
+  | [#396](https://github.com/bugsnag/bugsnag-ruby/pull/396)
+
 ## 6.1.0 (17 Nov 2017)
 
 ### Enhancements

data/UPGRADING.md

@@ -56,3 +56,14 @@ guide](https://docs.bugsnag.com/api/deploy-tracking/capistrano/) for more inform
   +   config.logger.level = Logger::DEBUG
     end
   ```
+
+* Log accessor functions on the `Bugsnag` object no longer exist. Logging must now be accessed through the configuration object:
+
+  ```diff
+  - Bugsnag.log "Log message"
+  - Bugsnag.warn "Warn message"
+  - Bugsnag.debug "Debug message"
+  + Bugsnag.configuration.logger.info "Info message"
+  + Bugsnag.configuration.logger.warn "Warn message"
+  + Bugsnag.configuration.logger.debug "Debug message"
+  ```

data/VERSION

@@ -1 +1 @@
-6.1.0
+6.1.1

data/lib/bugsnag.rb

@@ -13,7 +13,6 @@ require "bugsnag/delivery/synchronous"
 require "bugsnag/delivery/thread_queue"
 
 require "bugsnag/integrations/rack"
-require "bugsnag/integrations/railtie" if defined?(Rails::Railtie)
 
 require "bugsnag/middleware/rack_request"
 require "bugsnag/middleware/warden_user"
@@ -127,6 +126,7 @@ module Bugsnag
   end
 end
 
+require "bugsnag/integrations/railtie" if defined?(Rails::Railtie)
 [:resque, :sidekiq, :mailman, :delayed_job, :shoryuken, :que].each do |integration|
   begin
     require "bugsnag/integrations/#{integration}"

data/lib/bugsnag/middleware/clearance_user.rb

@@ -8,13 +8,13 @@ module Bugsnag::Middleware
 
     def call(report)
       if report.request_data[:rack_env] &&
-        report.request_data[:rack_env]["clearance"] &&
-        report.request_data[:rack_env]["clearance"].signed_in? &&
-        report.request_data[:rack_env]["clearance"].current_user
+        report.request_data[:rack_env][:clearance] &&
+        report.request_data[:rack_env][:clearance].signed_in? &&
+        report.request_data[:rack_env][:clearance].current_user
 
         # Extract useful user information
         user = {}
-        user_object = report.request_data[:rack_env]["clearance"].current_user
+        user_object = report.request_data[:rack_env][:clearance].current_user
         if user_object
           # Build the bugsnag user info from the current user record
           COMMON_USER_FIELDS.each do |field|

data/lib/bugsnag/stacktrace.rb

@@ -7,6 +7,9 @@ module Bugsnag
     # e.g. "org.jruby.Ruby.runScript(Ruby.java:807)"
     JAVA_BACKTRACE_REGEX = /^(.*)\((.*)(?::([0-9]+))?\)$/
 
+    # Path to vendored code. Used to mark file paths as out of project.
+    VENDOR_PATH = 'vendor/'
+
     def initialize(backtrace, configuration)
       @configuration = configuration
 
@@ -31,7 +34,6 @@ module Bugsnag
 
         # Generate the stacktrace line hash
         trace_hash = {}
-        trace_hash[:inProject] = true if in_project?(file)
         trace_hash[:lineNumber] = line_str.to_i
 
         if configuration.send_code
@@ -40,9 +42,12 @@ module Bugsnag
 
         # Clean up the file path in the stacktrace
         if defined?(@configuration.project_root) && @configuration.project_root.to_s != ''
+          trace_hash[:inProject] = true if file.start_with?(@configuration.project_root)
           file.sub!(/#{@configuration.project_root}\//, "")
+          trace_hash.delete(:inProject) if file.start_with?(VENDOR_PATH)
         end
 
+
         # Strip common gem path prefixes
         if defined?(Gem)
           file = Gem.path.inject(file) {|line, path| line.sub(/#{path}\//, "") }
@@ -67,10 +72,6 @@ module Bugsnag
 
     private
 
-    def in_project?(line)
-      @configuration.project_root && line.start_with?(@configuration.project_root.to_s)
-    end
-
     def code(file, line_number, num_lines = 7)
       code_hash = {}
 

data/spec/report_spec.rb

@@ -524,6 +524,34 @@ describe Bugsnag::Report do
     }
   end
 
+  it 'marks vendored stack frames as out-of-project' do
+    project_root = File.expand_path File.dirname(__FILE__)
+    Bugsnag.configuration.project_root = project_root
+
+    ex = Exception.new('Division by zero')
+    allow(ex).to receive (:backtrace) {[
+      File.join(project_root, "vendor/strutils/lib/string.rb:508:in `splice'"),
+      File.join(project_root, "vendors/strutils/lib/string.rb:508:in `splice'"),
+      File.join(project_root, "lib/helpers/string.rb:32:in `splice'"),
+      File.join(project_root, "lib/vendor/lib/article.rb:158:in `initialize'"),
+      File.join(project_root, "lib/prog.rb:158:in `read_articles'"),
+      "app.rb:10:in `main'",
+      "(pry):3:in `__pry__'"
+    ]}
+    Bugsnag.notify(ex)
+    expect(Bugsnag).to have_sent_notification{ |payload|
+      exception = get_exception_from_payload(payload)
+
+      expect(exception["stacktrace"][0]["inProject"]).to be_nil
+      expect(exception["stacktrace"][1]["inProject"]).to be true
+      expect(exception["stacktrace"][2]["inProject"]).to be true
+      expect(exception["stacktrace"][3]["inProject"]).to be true
+      expect(exception["stacktrace"][4]["inProject"]).to be true
+      expect(exception["stacktrace"][5]["inProject"]).to be_nil
+      expect(exception["stacktrace"][6]["inProject"]).to be_nil
+    }
+  end
+
   it "adds app_version to the payload if it is set" do
     Bugsnag.configuration.app_version = "1.1.1"
     Bugsnag.notify(BugsnagTestException.new("It crashed"))

data/spec/spec_helper.rb

@@ -1,4 +1,4 @@
-if ARGV.include? "--coverage"
+if ENV['GEMSETS'] and ENV['GEMSETS'].include? "coverage"
   require 'simplecov'
   require 'coveralls'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 6.1.0
+  version: 6.1.1
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-17 00:00:00.000000000 Z
+date: 2017-11-23 00:00:00.000000000 Z
 dependencies: []
 description: Ruby notifier for bugsnag.com
 email: james@bugsnag.com