bugsnag 5.2.0 → 5.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d4b00bead73bfc579980368d65edb60286f0531b
-  data.tar.gz: fbb45b08f2dc84545752c020110bb5c0bc746706
+  metadata.gz: bd7eb03ea37369e9f1168f4bacca512afe60b57e
+  data.tar.gz: c547dd53611a661b2965c5e6e75485e7ba8ccf42
 SHA512:
-  metadata.gz: 08581bdce123264cbd592ddb6c4074f03b4d7d044bfa8ef8e72ee4af29dce3c34d183bb5db93b2fe770eee9b170ce39220969c6d93f784ab87dc50fb270a355b
-  data.tar.gz: baa4a8957c00e2ac6608471ff19b3976dbe076b4c63fb3277c3c24ecfb18586fb40a80a896c3d8a1685cc3062d859311730f26e0e03fa0e1eb3586caf5c97b43
+  metadata.gz: 72ccb3099959f0e0fbf41f0c8bbbfeedeb5df9f2762b70a2a8d6cd01a399868e014fa2b0ae8a8d014ed49a87c7a9ab6ff893155deb70a6b5871164fe81d0a82c
+  data.tar.gz: e80bda1683ad5c7c9452467e2001ec17c9cb0631a87ae4c0ba5bc5ec1d5f2c6745a09bab8663955612d768090aa193fcd04edbfcc65063521b87ce5e38b0b5b9

data/CHANGELOG.md

@@ -1,6 +1,42 @@
 Changelog
 =========
 
+## 5.3.0 (07 April 2017)
+
+### Enhancements
+
+* [Resque] Fix leaking config into parent process
+  | [Martin Holman](https://github.com/martin308)
+  | [#347](https://github.com/bugsnag/bugsnag-ruby/pull/347)
+* Add new integration for Que
+  | [Sjoerd Andringa](https://github.com/s-andringa)
+  | [#305](https://github.com/bugsnag/bugsnag-ruby/pull/305)
+* [Sidekiq] Start Bugsnag after the logger in the middleware chain
+  | [Stephen Bussey](https://github.com/sb8244)
+  | [Akhil Naini](https://github.com/akhiln)
+  | [#326](https://github.com/bugsnag/bugsnag-ruby/pull/326)
+  | [#350](https://github.com/bugsnag/bugsnag-ruby/pull/350)
+* [Rake] Allow overriding `app_type` apps
+  | [#351](https://github.com/bugsnag/bugsnag-ruby/issues/351)
+* Send the dyno name as the hostname when running on Heroku
+  | [#333](https://github.com/bugsnag/bugsnag-ruby/issues/333)
+* [Delayed Job] Add additional job information such as arguments and number of
+  attempts when available
+  | [Tim Diggins](https://github.com/timdiggins)
+  | [Abraham Chan](https://github.com/abraham-chan)
+  | [Johnny Shields](https://github.com/johnnyshields)
+  | [#329](https://github.com/bugsnag/bugsnag-ruby/pull/329)
+  | [#332](https://github.com/bugsnag/bugsnag-ruby/pull/332)
+  | [#321](https://github.com/bugsnag/bugsnag-ruby/pull/321)
+
+### Bug fixes
+
+* Initialize Railtie after Bugsnag class
+  | [#343](https://github.com/bugsnag/bugsnag-ruby/issues/343)
+* Alias `notify_or_ignore` to `notify`
+  | [Simon Maynard](https://github.com/snmaynard)
+  | [#319](https://github.com/bugsnag/bugsnag-ruby/pull/319)
+
 ## 5.2.0 (10 February 2017)
 
 ### Enhancements

data/CONTRIBUTING.md

@@ -1,16 +1,34 @@
 
 ## How to contribute
 
--   [Fork](https://help.github.com/articles/fork-a-repo) the [notifier on github](https://github.com/bugsnag/bugsnag-ruby)
+We are glad you're here! First-time and returning contributors are welcome to
+add bug fixes and new integrations. If you are unsure about the direction of an
+enhancement or if it would be generally useful, feel free to open an issue or a
+work-in-progress pull request and ask for input.
+
+Thank you!
+
+### Getting started
+
+-   [Fork](https://help.github.com/articles/fork-a-repo) the [library on github](https://github.com/bugsnag/bugsnag-ruby)
 -   Commit and push until you are happy with your contribution
+
+### Polish
+
 -   Run the tests with and make sure they all pass
 
     ```
     rake spec
     ```
+-   For adding a new integration (like support for a web framework or worker
+    queue), include an example in the `example/` directory showing off what
+    you've built. Include a `README` with the example app so others know how to
+    run it.
+
+
+### Ship it!
 
 -   [Make a pull request](https://help.github.com/articles/using-pull-requests)
--   Thanks!
 
 
 ## How to release

data/README.md

@@ -15,6 +15,7 @@ The Bugsnag exception reporter for Ruby gives you instant notification of except
 
 1. [Create a Bugsnag account](https://bugsnag.com)
 2. Complete the instructions in the integration guide for your framework:
+    * [Que](http://docs.bugsnag.com/platforms/ruby/que)
     * [Rack](http://docs.bugsnag.com/platforms/ruby/rack)
     * [Rails](http://docs.bugsnag.com/platforms/ruby/rails)
     * [Rake](http://docs.bugsnag.com/platforms/ruby/rake)
@@ -26,6 +27,7 @@ The Bugsnag exception reporter for Ruby gives you instant notification of except
 ## Support
 
 * Read the configuration reference:
+    * [Que](http://docs.bugsnag.com/platforms/ruby/que/configuration-options)
     * [Rack](http://docs.bugsnag.com/platforms/ruby/rack/configuration-options)
     * [Rails](http://docs.bugsnag.com/platforms/ruby/rails/configuration-options)
     * [Rake](http://docs.bugsnag.com/platforms/ruby/rake/configuration-options)

data/VERSION

@@ -1 +1 @@
-5.2.0
+5.3.0

data/lib/bugsnag.rb

@@ -14,7 +14,6 @@ require "bugsnag/delivery/synchronous"
 require "bugsnag/delivery/thread_queue"
 
 require "bugsnag/rack"
-require "bugsnag/railtie" if defined?(Rails::Railtie)
 
 require "bugsnag/middleware/rack_request"
 require "bugsnag/middleware/warden_user"
@@ -59,16 +58,6 @@ module Bugsnag
 
       yield(notification) if block_given?
 
-      notification.deliver
-      notification
-    end
-
-    # Notify of an exception unless it should be ignored
-    def notify_or_ignore(exception, overrides=nil, request_data=nil, &block)
-      notification = Notification.new(exception, configuration, overrides, request_data)
-
-      yield(notification) if block_given?
-
       unless notification.ignore?
         notification.deliver
         notification
@@ -76,6 +65,7 @@ module Bugsnag
         false
       end
     end
+    alias_method :notify_or_ignore, :notify
 
     # Auto notify of an exception, called from rails and rack exception
     # rescuers, unless auto notification is disabled, or we should ignore this
@@ -131,7 +121,8 @@ module Bugsnag
   end
 end
 
-[:resque, :sidekiq, :mailman, :delayed_job, :shoryuken].each do |integration|
+require "bugsnag/railtie" if defined?(Rails::Railtie)
+[:resque, :sidekiq, :mailman, :delayed_job, :shoryuken, :que].each do |integration|
   begin
     require "bugsnag/#{integration}"
   rescue LoadError

data/lib/bugsnag/configuration.rb

@@ -146,8 +146,8 @@ module Bugsnag
     private
 
     def default_hostname
-      # Don't send the hostname on Heroku
-      Socket.gethostname unless ENV["DYNO"]
+      # Send the heroku dyno name instead of hostname if available
+      ENV["DYNO"] || Socket.gethostname;
     end
   end
 end

data/lib/bugsnag/delayed_job.rb

@@ -19,6 +19,13 @@ unless defined? Delayed::Plugins::Bugsnag
                 :id => job.id,
               }
             }
+            if job.respond_to?(:queue) && (queue = job.queue)
+              overrides[:job][:queue] = queue
+            end
+            if job.respond_to?(:attempts)
+              overrides[:job][:attempts] = "#{job.attempts + 1} / #{Delayed::Worker.max_attempts}"
+              # +1 as "attempts" is really previous attempts AFAICT, certainly it starts at 0.
+            end
             if payload = job.payload_object
               p = {
                 :class => payload.class.name,
@@ -33,6 +40,7 @@ unless defined? Delayed::Plugins::Bugsnag
                 }
                 p[:object][:id] = object.id if object.respond_to?(:id)
               end
+              add_active_job_details(p, payload)
               overrides[:job][:payload] = p
             end
 
@@ -40,6 +48,16 @@ unless defined? Delayed::Plugins::Bugsnag
 
             super if defined?(super)
           end
+
+          def add_active_job_details(p, payload)
+            if payload.respond_to?(:job_data) && payload.job_data.respond_to?(:[])
+              [:job_class, :arguments, :queue_name, :job_id].each do |key|
+                if (value = payload.job_data[key.to_s])
+                  p[key] = value
+                end
+              end
+            end
+          end
         end
 
         callbacks do |lifecycle|

data/lib/bugsnag/que.rb

@@ -0,0 +1,37 @@
+if defined?(::Que)
+  handler = proc do |error, job|
+    begin
+      job = job.dup # Make sure the original job object is not mutated.
+
+      Bugsnag.auto_notify(error) do |notification|
+        job[:error_count] += 1
+
+        # If the job was scheduled using ActiveJob then unwrap the job details for clarity:
+        if job[:job_class] == "ActiveJob::QueueAdapters::QueAdapter::JobWrapper"
+          wrapped_job = job[:args].last
+          wrapped_job = wrapped_job.each_with_object({}) { |(k, v), result| result[k.to_sym] = v } # Symbolize keys
+
+          # Align key names with keys in `job`
+          wrapped_job[:queue] = wrapped_job.delete(:queue_name)
+          wrapped_job[:args]  = wrapped_job.delete(:arguments)
+
+          job.merge!(wrapper_job_class: job[:job_class], wrapper_job_id: job[:job_id]).merge!(wrapped_job)
+        end
+
+        notification.add_tab(:job, job)
+      end
+    rescue => e
+      # Que supresses errors raised by its error handler to avoid killing the worker. Log them somewhere:
+      Bugsnag.warn("Failed to notify Bugsnag of error in Que job (#{e.class}): #{e.message} \n#{e.backtrace[0..9].join("\n")}")
+      raise
+    end
+  end
+
+  if Que.respond_to?(:error_notifier=)
+    Bugsnag.configuration.app_type ||= "que"
+    Que.error_notifier = handler
+  elsif Que.respond_to?(:error_handler=)
+    Bugsnag.configuration.app_type ||= "que"
+    Que.error_handler = handler
+  end
+end

data/lib/bugsnag/rake.rb

@@ -5,7 +5,7 @@ Rake::TaskManager.record_task_metadata = true
 class Rake::Task
 
   def execute_with_bugsnag(args=nil)
-    Bugsnag.configuration.app_type = "rake"
+    Bugsnag.configuration.app_type ||= "rake"
     old_task = Bugsnag.configuration.request_data[:bugsnag_running_task]
     Bugsnag.set_request_data :bugsnag_running_task, self
 

data/lib/bugsnag/resque.rb

@@ -37,7 +37,14 @@ Resque::Failure::Bugsnag = Bugsnag::Resque
 # Auto-load the failure backend
 Bugsnag::Resque.add_failure_backend
 
-Resque.before_first_fork do
-  Bugsnag.configuration.app_type = "resque"
-  Bugsnag.configuration.default_delivery_method = :synchronous
+if Resque::Worker.new.fork_per_job?
+  Resque.after_fork do
+    Bugsnag.configuration.app_type = "resque"
+    Bugsnag.configuration.default_delivery_method = :synchronous
+  end
+else
+  Resque.before_first_fork do
+    Bugsnag.configuration.app_type = "resque"
+    Bugsnag.configuration.default_delivery_method = :synchronous
+  end
 end

data/lib/bugsnag/sidekiq.rb

@@ -27,6 +27,6 @@ end
 
 ::Sidekiq.configure_server do |config|
   config.server_middleware do |chain|
-    chain.add ::Bugsnag::Sidekiq
+    chain.insert_after ::Sidekiq::Middleware::Server::Logging, ::Bugsnag::Sidekiq
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.3.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-10 00:00:00.000000000 Z
+date: 2017-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -140,6 +140,7 @@ files:
 - lib/bugsnag/middleware/warden_user.rb
 - lib/bugsnag/middleware_stack.rb
 - lib/bugsnag/notification.rb
+- lib/bugsnag/que.rb
 - lib/bugsnag/rack.rb
 - lib/bugsnag/rails.rb
 - lib/bugsnag/rails/action_controller_rescue.rb
@@ -191,7 +192,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Ruby notifier for bugsnag.com