bugsnag 4.2.1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c7a125074b0ce11af4b27fdec174ae254e9f93f6
-  data.tar.gz: d9ec806e212474fb4a91ad7d743ba0e52a1e3eba
+  metadata.gz: 5403d5abb730249b3c5b9a55199be90907d0b09b
+  data.tar.gz: f7279565d7c9ff5f7de4573c70116dc5411fda66
 SHA512:
-  metadata.gz: 00f9605f9d914345731261720b2b9d9c1a5ad9e51c137eacd87aa58c6d1fb87b54576d08f701f61dd0c0ffad2f796b484848b6860899d26d905b91642b3b6fb1
-  data.tar.gz: 04094907d4eb4267e03ac1ab068eabf5ed07be81f6192c09376476faa56cfdcccd669cbce6f7c9e3a7dd0626eaac2c432a2c5c10a532ce1dc4a65785ba4c51b9
+  metadata.gz: a73f4524eb83ab779faa0ed7374440b07585ef70b59a8331405b64a7c42e40b699044144ccd209ba323f3f740e56b875d4f78c9b19aa5609bc2436d679afeee1
+  data.tar.gz: 404a4ef28199ae30b4a10cb9591699d218bc698f19316c9f78b8045da52b7a07339aeb8baa25be0b4d7063713819dccf40a6a73897da1a15de8e85cb2bbc4c31

data/CHANGELOG.md

@@ -1,6 +1,28 @@
 Changelog
 =========
 
+## 5.0.0 (23 August 2016)
+
+### Enhancements
+
+* Remove RoutingError from default ignore classes
+  | [#308](https://github.com/bugsnag/bugsnag-ruby/issues/308)
+* Prefer BUGSNAG_RELEASE_STAGE over RAILS_ENV for release_stage
+  | [#298](https://github.com/bugsnag/bugsnag-ruby/issues/298)
+* Apply grouping hash if method `bugsnag_grouping_hash` is available on the object
+  | [#318](https://github.com/bugsnag/bugsnag-ruby/issues/318)
+  | [#311](https://github.com/bugsnag/bugsnag-ruby/issues/311)
+* Sidekiq improvements
+  | [#317](https://github.com/bugsnag/bugsnag-ruby/issues/317)
+  | [#282](https://github.com/bugsnag/bugsnag-ruby/issues/282)
+  | [#309](https://github.com/bugsnag/bugsnag-ruby/issues/309)
+  | [#306](https://github.com/bugsnag/bugsnag-ruby/issues/306)
+
+### Fixes
+
+* Exception backtrace could be empty
+  | [#307](https://github.com/bugsnag/bugsnag-ruby/issues/307)
+
 ## 4.2.1 (23 Jun 2016)
 
 ### Fixes

data/README.md

@@ -2,10 +2,7 @@
 [![build status](https://travis-ci.org/bugsnag/bugsnag-ruby.svg?branch=master)](https://travis-ci.org/bugsnag/bugsnag-ruby)
 
 
-The Bugsnag exception reporter for Ruby gives you instant notification of exceptions
-thrown from your **[Rails](https://bugsnag.com/platforms/rails)**, **Sinatra**, **Rack** or **plain Ruby** app.
-Any uncaught exceptions will trigger a notification to be sent to your
-Bugsnag project.
+The Bugsnag exception reporter for Ruby gives you instant notification of exceptions thrown from your **[Rails](https://bugsnag.com/platforms/rails)**, **Sinatra**, **Rack** or **plain Ruby** app. Any uncaught exceptions will trigger a notification to be sent to your Bugsnag project.
 
 ## Features
 
@@ -40,11 +37,8 @@ Bugsnag project.
 
 ## Contributing
 
-All contributors are welcome! For information on how to build, test
-and release `bugsnag-ruby`, see our
-[contributing guide](https://github.com/bugsnag/bugsnag-ruby/blob/master/CONTRIBUTING.md). Feel free to comment on [existing issues](https://github.com/bugsnag/bugsnag-ruby/issues) for clarification or starting points.
+All contributors are welcome! For information on how to build, test and release `bugsnag-ruby`, see our [contributing guide](https://github.com/bugsnag/bugsnag-ruby/blob/master/CONTRIBUTING.md). Feel free to comment on [existing issues](https://github.com/bugsnag/bugsnag-ruby/issues) for clarification or starting points.
 
 ## License
 
-The Bugsnag ruby notifier is free software released under the MIT License.
-See [LICENSE.txt](LICENSE.txt) for details.
+The Bugsnag ruby notifier is free software released under the MIT License. See [LICENSE.txt](LICENSE.txt) for details.

data/VERSION

@@ -1 +1 @@
-4.2.1
+5.0.0

data/lib/bugsnag/capistrano2.rb

@@ -11,7 +11,7 @@ module Bugsnag
             begin
               Bugsnag::Deploy.notify({
                 :api_key => fetch(:bugsnag_api_key, ENV["BUGSNAG_API_KEY"]),
-                :release_stage => fetch(:rails_env, ENV["BUGSNAG_RELEASE_STAGE"] || "production"),
+                :release_stage => ENV["BUGSNAG_RELEASE_STAGE"] || fetch(:rails_env, "production"),
                 :revision => fetch(:current_revision, ENV["BUGSNAG_REVISION"]),
                 :repository => fetch(:repository, ENV["BUGSNAG_REPOSITORY"]),
                 :branch => fetch(:branch, ENV["BUGSNAG_BRANCH"],

data/lib/bugsnag/configuration.rb

@@ -50,7 +50,6 @@ module Bugsnag
       "AbstractController::ActionNotFound",
       "ActionController::InvalidAuthenticityToken",
       "ActionController::ParameterMissing",
-      "ActionController::RoutingError",
       "ActionController::UnknownAction",
       "ActionController::UnknownFormat",
       "ActionController::UnknownHttpMethod",

data/lib/bugsnag/mailman.rb

@@ -2,6 +2,11 @@ require 'mailman'
 
 module Bugsnag
   class Mailman
+    def initialize
+      Bugsnag.configuration.internal_middleware.use(Bugsnag::Middleware::Mailman)
+      Bugsnag.configuration.app_type = "mailman"
+    end
+
     def call(mail)
       begin
 
@@ -23,6 +28,3 @@ end
 if Mailman.config.respond_to?(:middleware)
   Mailman.config.middleware.add ::Bugsnag::Mailman
 end
-
-Bugsnag.configuration.internal_middleware.use(Bugsnag::Middleware::Mailman)
-Bugsnag.configuration.app_type = "mailman"

data/lib/bugsnag/meta_data.rb

@@ -3,5 +3,6 @@ module Bugsnag
     attr_accessor :bugsnag_meta_data
     attr_accessor :bugsnag_user_id
     attr_accessor :bugsnag_context
+    attr_accessor :bugsnag_grouping_hash
   end
 end

data/lib/bugsnag/middleware/sidekiq.rb

@@ -6,7 +6,10 @@ module Bugsnag::Middleware
 
     def call(notification)
       sidekiq = notification.request_data[:sidekiq]
-      notification.add_tab(:sidekiq, sidekiq) if sidekiq
+      if sidekiq
+        notification.add_tab(:sidekiq, sidekiq)
+        notification.context ||= "#{sidekiq[:msg]['wrapper'] || sidekiq[:msg]['class']}@#{sidekiq[:msg]['queue']}"
+      end
       @bugsnag.call(notification)
     end
   end

data/lib/bugsnag/notification.rb

@@ -198,6 +198,9 @@ module Bugsnag
           if exception.bugsnag_context.is_a?(String)
             self.context = exception.bugsnag_context
           end
+          if exception.bugsnag_grouping_hash.is_a?(String)
+            self.grouping_hash = exception.bugsnag_grouping_hash
+          end
         end
       end
 
@@ -343,7 +346,7 @@ module Bugsnag
         {
           :errorClass => error_class(exception),
           :message => exception.message,
-          :stacktrace => stacktrace(exception)
+          :stacktrace => stacktrace(exception.backtrace)
         }
       end
     end
@@ -354,9 +357,9 @@ module Bugsnag
       (exception.is_a? Class) ? exception.name : exception.class.name
     end
 
-    def stacktrace(exception)
-      (exception.backtrace || caller).map do |trace|
-
+    def stacktrace(backtrace)
+      backtrace = caller if !backtrace || backtrace.empty?
+      backtrace.map do |trace|
         if trace.match(BACKTRACE_LINE_REGEX)
           file, line_str, method = [$1, $2, $3]
         elsif trace.match(JAVA_BACKTRACE_REGEX)

data/lib/bugsnag/rack.rb

@@ -6,7 +6,7 @@ module Bugsnag
       # Configure bugsnag rack defaults
       Bugsnag.configure do |config|
         # Try to set the release_stage automatically if it hasn't already been set
-        config.release_stage ||= ENV["RACK_ENV"] if ENV["RACK_ENV"]
+        config.release_stage ||= release_stage
 
         # Try to set the project_root if it hasn't already been set, or show a warning if we can't
         unless config.project_root && !config.project_root.to_s.empty?
@@ -49,5 +49,11 @@ module Bugsnag
       # Clear per-request data after processing the each request
       Bugsnag.clear_request_data
     end
+
+    private
+
+    def release_stage
+      ENV["BUGSNAG_RELEASE_STAGE"] || ENV["RACK_ENV"]
+    end
   end
 end

data/lib/bugsnag/rails.rb

@@ -23,7 +23,7 @@ module Bugsnag
 
       Bugsnag.configure do |config|
         config.logger ||= rails_logger
-        config.release_stage = rails_env if rails_env
+        config.release_stage = release_stage if release_stage
         config.project_root = rails_root if rails_root
 
         config.middleware.insert_before(Bugsnag::Middleware::Callbacks,Bugsnag::Middleware::Rails2Request)
@@ -45,6 +45,10 @@ module Bugsnag
       end
     end
 
+    def self.release_stage
+      ENV["BUGSNAG_RELEASE_STAGE"] || rails_env
+    end
+
     def self.rails_env
       if defined?(::Rails.env)
         ::Rails.env

data/lib/bugsnag/railtie.rb

@@ -7,8 +7,6 @@ require "bugsnag/middleware/rack_request"
 
 module Bugsnag
   class Railtie < Rails::Railtie
-    cattr_accessor :running_as_dependency
-
     rake_tasks do
       require "bugsnag/rake"
       load "bugsnag/tasks/bugsnag.rake"
@@ -29,7 +27,7 @@ module Bugsnag
       # Configure bugsnag rails defaults
       Bugsnag.configure do |config|
         config.logger = ::Rails.logger
-        config.release_stage = ::Rails.env.to_s
+        config.release_stage = ENV["BUGSNAG_RELEASE_STAGE"] || ::Rails.env.to_s
         config.project_root = ::Rails.root.to_s
         config.middleware.insert_before Bugsnag::Middleware::Callbacks, Bugsnag::Middleware::Rails3Request
       end
@@ -51,7 +49,7 @@ module Bugsnag
         ActiveRecord::Base.send(:include, Bugsnag::Rails::ActiveRecordRescue)
       end
 
-      Bugsnag.configuration.app_type = "rails" unless Bugsnag::Railtie.running_as_dependency
+      Bugsnag.configuration.app_type = "rails"
     end
 
     # Configure params_filters after initialization, so that rails initializers

data/lib/bugsnag/resque.rb

@@ -37,4 +37,7 @@ Resque::Failure::Bugsnag = Bugsnag::Resque
 # Auto-load the failure backend
 Bugsnag::Resque.add_failure_backend
 
-Bugsnag.configuration.app_type = "resque"
+Resque.before_first_fork do
+  Bugsnag.configuration.app_type = "resque"
+  Bugsnag.configuration.delivery_method = :synchronous
+end

data/lib/bugsnag/sidekiq.rb

@@ -2,9 +2,14 @@ require 'sidekiq'
 
 module Bugsnag
   class Sidekiq
+    def initialize
+      Bugsnag.configuration.internal_middleware.use(Bugsnag::Middleware::Sidekiq)
+      Bugsnag.configuration.app_type = "sidekiq"
+      Bugsnag.configuration.delivery_method = :synchronous
+    end
+
     def call(worker, msg, queue)
       begin
-
         # store msg/queue in thread local state to be read by Bugsnag::Middleware::Sidekiq
         Bugsnag.set_request_data :sidekiq, { :msg => msg, :queue => queue }
 
@@ -20,23 +25,8 @@ module Bugsnag
   end
 end
 
-if ::Sidekiq::VERSION < '3'
-  ::Sidekiq.configure_server do |config|
-    config.server_middleware do |chain|
-      chain.add ::Bugsnag::Sidekiq
-    end
+::Sidekiq.configure_server do |config|
+  config.server_middleware do |chain|
+    chain.add ::Bugsnag::Sidekiq
   end
-else
-  ::Sidekiq.configure_server do |config|
-    config.error_handlers << lambda do |ex, ctx|
-      Bugsnag.auto_notify(ex, :sidekiq => ctx, :context => "#{ctx['class']}@#{ctx['queue']}")
-    end
-  end
-end
-
-Bugsnag.configuration.internal_middleware.use(Bugsnag::Middleware::Sidekiq)
-Bugsnag.configuration.app_type = "sidekiq"
-
-if defined?(::Sidekiq::CLI) && defined?(Bugsnag::Railtie)
-  Bugsnag::Railtie.running_as_dependency = true
 end

data/lib/bugsnag/tasks/bugsnag.cap

@@ -28,7 +28,7 @@ namespace :bugsnag do
       begin
         Bugsnag::Deploy.notify({
           :api_key => fetch(:bugsnag_api_key, ENV["BUGSNAG_API_KEY"]),
-          :release_stage => fetch(:bugsnag_env) || fetch(:rails_env) || fetch(:stage) || ENV["BUGSNAG_RELEASE_STAGE"] || "production",
+          :release_stage => fetch(:bugsnag_env) || ENV["BUGSNAG_RELEASE_STAGE"] || fetch(:rails_env) || fetch(:stage) || "production",
           :revision => fetch(:current_revision, ENV["BUGSNAG_REVISION"]),
           :repository => fetch(:repo_url, ENV["BUGSNAG_REPOSITORY"]),
           :branch => fetch(:branch, ENV["BUGSNAG_BRANCH"]),

data/spec/notification_spec.rb

@@ -223,6 +223,18 @@ describe Bugsnag::Notification do
     }
   end
 
+  it "accepts grouping_hash from an exception that mixes in Bugsnag::MetaData" do
+    exception = BugsnagTestExceptionWithMetaData.new("It crashed")
+    exception.bugsnag_grouping_hash = "exception_hash"
+
+    Bugsnag.notify(exception)
+
+    expect(Bugsnag).to have_sent_notification{ |payload|
+      event = get_event_from_payload(payload)
+      expect(event["groupingHash"]).to eq("exception_hash")
+    }
+  end
+
   it "accept contexts from an exception that mixes in Bugsnag::MetaData, but override using the overrides" do
 
     exception = BugsnagTestExceptionWithMetaData.new("It crashed")
@@ -857,6 +869,21 @@ describe Bugsnag::Notification do
     }
   end
 
+  it 'should handle exceptions with empty backtrace' do
+    begin
+      err = RuntimeError.new
+      err.set_backtrace([])
+      raise err
+    rescue
+      Bugsnag.notify $!
+    end
+
+    expect(Bugsnag).to have_sent_notification { |payload|
+      exception = get_exception_from_payload(payload)
+      expect(exception['stacktrace'].size).to be > 0
+    }
+  end
+
   if defined?(JRUBY_VERSION)
 
     it "should work with java.lang.Throwables" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 4.2.1
+  version: 5.0.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-23 00:00:00.000000000 Z
+date: 2016-08-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -188,7 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby notifier for bugsnag.com