bugsnag 2.8.6 → 2.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9ebe125f07a4a2afd8e873ce95df608085afa4a2
-  data.tar.gz: 34b35b4affa3ec05ba974bd379e917043d16be9f
+  metadata.gz: 067814066dcb230ce23d76c6a2c6aaac1f558d6a
+  data.tar.gz: ca9cdab9e2a56282adae7ad665448cb7a56fbe3c
 SHA512:
-  metadata.gz: ff650953a205f95032b1cf7f4d06be225d0e1f0bcc24ce3d84f6c5ffbf0d2f1a82699bbcf44b9a5a29e5e478733ff18adcd418a8197b8fc95bb016693923e123
-  data.tar.gz: f5b7ea42d4cfb05b663fab08f5b09f3844480ba80ee06c550f2773e08f21effb51257170bcb3f7884825e3fb6e2e5afefde9c6bb97bae8c134b72732fef2189d
+  metadata.gz: 359bf4b141709e8eaa9c69a703c5572970349a536f4b91ca0a62e14ad7e250f9979a99f9f8904ab6f1c144909df40d741886f421b9a77bb1a7053a65d4c389a7
+  data.tar.gz: 1b4490466b23031df3577d009c4a0482d10d702d85394d501f90577378f99316e89d3ca9304336df411a680cb245d37b0157f3f3014c89aa6324366c70bdfccc

data/CHANGELOG.md

@@ -1,6 +1,16 @@
 Changelog
 =========
 
+2.8.7
+-----
+
+-   Fix for old rails 3.2 not having runner defined in the railtie
+-   Support for rails API
+-   Added support for ca_file for dealing with SSL issues
+-   Threadsafe ignore_classes
+-   Add app type
+-   Dont send cookies in their own tab
+
 2.8.6
 -----
 

data/README.md

@@ -115,6 +115,22 @@ class MyController < ApplicationController
 end
 ```
 
+### Rails API Apps
+
+If you are building an API using the [rails-api](https://github.com/rails-api/rails-api) gem, your controllers will inherit from `ActionController::API` instead of `ActionController::Base`.
+
+In this case, the `before_bugsnag_notify` filter will not be automatically available in your controllers.  In order to use it, you will need to include the module `Bugsnag::Rails::ControllerMethods`.
+
+```ruby
+class ApplicationController < ActionController::API
+
+  # Include module which defines the before_bugsnag_notify filter
+  include Bugsnag::Rails::ControllerMethods
+
+  # Other code here
+end
+```
+
 ### Other Ruby Apps
 
 In other ruby apps, you can provide lambda functions to execute before any `Bugsnag.notify` calls as follows. Don't forget to clear the callbacks at the end of each request or session. In Rack applications like Sinatra, this is automatically done for you.

data/VERSION

@@ -1 +1 @@
-2.8.6
+2.8.7

data/bugsnag.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/bugsnag/bugsnag-ruby"
   s.licenses = ["MIT"]
 
-  s.files = `git ls-files`.split("\n")
+  s.files = `git ls-files`.split("\n").reject {|file| file.start_with? "example/"}
   s.extra_rdoc_files = [
     "LICENSE.txt",
     "README.md"

data/lib/bugsnag/configuration.rb

@@ -10,6 +10,7 @@ module Bugsnag
     attr_accessor :notify_release_stages
     attr_accessor :auto_notify
     attr_accessor :use_ssl
+    attr_accessor :ca_file
     attr_accessor :send_environment
     attr_accessor :send_code
     attr_accessor :project_root
@@ -30,7 +31,6 @@ module Bugsnag
     attr_accessor :timeout
     attr_accessor :hostname
     attr_accessor :delivery_method
-
     attr_writer :ignore_classes
 
     THREAD_LOCAL_NAME = "bugsnag_req_data"
@@ -62,6 +62,8 @@ module Bugsnag
     DEFAULT_DELIVERY_METHOD = :thread_queue
 
     def initialize
+      @mutex = Mutex.new
+
       # Set up the defaults
       self.auto_notify = true
       self.use_ssl = true
@@ -90,7 +92,7 @@ module Bugsnag
 
     # Accept both String and Class instances as an ignored class
     def ignore_classes
-      @ignore_classes.map! { |klass| klass.is_a?(Class) ? klass.name : klass }
+      @mutex.synchronize { @ignore_classes.map! { |klass| klass.is_a?(Class) ? klass.name : klass } }
     end
 
     def should_notify?

data/lib/bugsnag/delivery/synchronous.rb

@@ -32,6 +32,7 @@ module Bugsnag
             http.use_ssl = true
             # the default in 1.9+, but required for 1.8
             http.verify_mode = OpenSSL::SSL::VERIFY_PEER
+            http.ca_file = configuration.ca_file if configuration.ca_file
           end
 
           request = Net::HTTP::Post.new(path(uri), HEADERS)
@@ -47,4 +48,4 @@ module Bugsnag
   end
 end
 
-Bugsnag::Delivery.register(:synchronous, Bugsnag::Delivery::Synchronous)
+Bugsnag::Delivery.register(:synchronous, Bugsnag::Delivery::Synchronous)

data/lib/bugsnag/mailman.rb

@@ -25,3 +25,4 @@ if Mailman.config.respond_to?(:middleware)
 end
 
 Bugsnag.configuration.internal_middleware.use(Bugsnag::Middleware::Mailman)
+Bugsnag.configuration.app_type = "mailman"

data/lib/bugsnag/middleware/rack_request.rb

@@ -64,10 +64,6 @@ module Bugsnag::Middleware
             notification.add_tab(:session, session.to_hash)
           end
         end
-
-        # Add a cookies tab
-        cookies = request.cookies
-        notification.add_tab(:cookies, cookies) if cookies
       end
 
       @bugsnag.call(notification)

data/lib/bugsnag/notification.rb

@@ -213,7 +213,7 @@ module Bugsnag
       end
 
       # make meta_data available to public middleware
-      @meta_data = Bugsnag::Helpers.cleanup_obj(generate_meta_data(@exceptions, @overrides), @configuration.params_filters)
+      @meta_data = generate_meta_data(@exceptions, @overrides)
 
       # Run the middleware here (including Bugsnag::Middleware::Callbacks)
       # at the end of the middleware stack, execute the actual notification delivery

data/lib/bugsnag/rack.rb

@@ -20,6 +20,8 @@ module Bugsnag
         # Hook up rack-based notification middlewares
         config.middleware.insert_before([Bugsnag::Middleware::Rails3Request,Bugsnag::Middleware::Callbacks], Bugsnag::Middleware::RackRequest) if defined?(::Rack)
         config.middleware.insert_before(Bugsnag::Middleware::Callbacks, Bugsnag::Middleware::WardenUser) if defined?(Warden)
+
+        Bugsnag.configuration.app_type ||= "rack"
       end
     end
 

data/lib/bugsnag/rails.rb

@@ -31,6 +31,8 @@ module Bugsnag
       config_file = File.join(rails_root, "config", "bugsnag.yml")
       config = YAML.load_file(config_file) if File.exists?(config_file)
       Bugsnag.configure(config[rails_env] ? config[rails_env] : config) if config
+
+      Bugsnag.configuration.app_type = "rails"
     end
 
     def self.rails_logger

data/lib/bugsnag/railtie.rb

@@ -13,10 +13,12 @@ module Bugsnag
     end
 
     # send notifications if a command fails in a 'rails runner' call
-    runner do
-      at_exit do
-        if $!
-          Bugsnag.auto_notify($!)
+    if self.respond_to? :runner
+      runner do
+        at_exit do
+          if $!
+            Bugsnag.auto_notify($!)
+          end
         end
       end
     end
@@ -39,10 +41,15 @@ module Bugsnag
         require "bugsnag/rails/controller_methods"
         ::ActionController::Base.send(:include, Bugsnag::Rails::ControllerMethods)
       end
+      if defined?(ActionController::API)
+        ActionController::API.send(:include, Bugsnag::Rails::ControllerMethods)
+      end
       if defined?(ActiveRecord::Base)
         require "bugsnag/rails/active_record_rescue"
         ActiveRecord::Base.send(:include, Bugsnag::Rails::ActiveRecordRescue)
       end
+
+      Bugsnag.configuration.app_type = "rails"
     end
 
     # Configure params_filters after initialization, so that rails initializers

data/lib/bugsnag/rake.rb

@@ -5,6 +5,7 @@ Rake::TaskManager.record_task_metadata = true
 class Rake::Task
 
   def execute_with_bugsnag(args=nil)
+    Bugsnag.configuration.app_type = "rake"
     old_task = Bugsnag.configuration.request_data[:bugsnag_running_task]
     Bugsnag.set_request_data :bugsnag_running_task, self
 

data/lib/bugsnag/resque.rb

@@ -36,3 +36,5 @@ Resque::Failure::Bugsnag = Bugsnag::Resque
 
 # Auto-load the failure backend
 Bugsnag::Resque.add_failure_backend
+
+Bugsnag.configuration.app_type = "resque"

data/lib/bugsnag/sidekiq.rb

@@ -35,3 +35,4 @@ else
 end
 
 Bugsnag.configuration.internal_middleware.use(Bugsnag::Middleware::Sidekiq)
+Bugsnag.configuration.app_type = "sidekiq"

data/spec/notification_spec.rb

@@ -469,6 +469,38 @@ describe Bugsnag::Notification do
     }
   end
 
+  it "filters params from all payload hashes if they are added to params_filters as regex" do
+
+    Bugsnag.configuration.params_filters << /other_data/
+    Bugsnag.notify(BugsnagTestException.new("It crashed"), {:request => {:params => {:password => "1234", :other_password => "123456", :other_data => "123456"}}})
+
+    expect(Bugsnag).to have_sent_notification{ |payload|
+      event = get_event_from_payload(payload)
+      expect(event["metaData"]).not_to be_nil
+      expect(event["metaData"]["request"]).not_to be_nil
+      expect(event["metaData"]["request"]["params"]).not_to be_nil
+      expect(event["metaData"]["request"]["params"]["password"]).to eq("[FILTERED]")
+      expect(event["metaData"]["request"]["params"]["other_password"]).to eq("[FILTERED]")
+      expect(event["metaData"]["request"]["params"]["other_data"]).to eq("[FILTERED]")
+    }
+  end
+
+  it "filters params from all payload hashes if they are added to params_filters as partial regex" do
+
+    Bugsnag.configuration.params_filters << /r_data/
+    Bugsnag.notify(BugsnagTestException.new("It crashed"), {:request => {:params => {:password => "1234", :other_password => "123456", :other_data => "123456"}}})
+
+    expect(Bugsnag).to have_sent_notification{ |payload|
+      event = get_event_from_payload(payload)
+      expect(event["metaData"]).not_to be_nil
+      expect(event["metaData"]["request"]).not_to be_nil
+      expect(event["metaData"]["request"]["params"]).not_to be_nil
+      expect(event["metaData"]["request"]["params"]["password"]).to eq("[FILTERED]")
+      expect(event["metaData"]["request"]["params"]["other_password"]).to eq("[FILTERED]")
+      expect(event["metaData"]["request"]["params"]["other_data"]).to eq("[FILTERED]")
+    }
+  end
+
   it "does not filter params from payload hashes if their values are nil" do
     Bugsnag.notify(BugsnagTestException.new("It crashed"), {:request => {:params => {:nil_param => nil}}})
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 2.8.6
+  version: 2.8.7
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-30 00:00:00.000000000 Z
+date: 2015-06-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -190,4 +190,3 @@ signing_key:
 specification_version: 4
 summary: Ruby notifier for bugsnag.com
 test_files: []
-has_rdoc: