bugsnag 2.4.0 → 2.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0521fc3cace95079dc4d038dc75c02481ba7847b
-  data.tar.gz: 1d34bcc368eb9e4fc6b04a15ccd31e6ec3db2380
+  metadata.gz: 0293abdf77561e74847883fc613ca6dc008cebab
+  data.tar.gz: 619d14f7854cfc80f580d3d02737f1df3e67b661
 SHA512:
-  metadata.gz: 5a2fbdbd810edc36b0ca20ac6e44dbd61c59cccd3ad96cb53e8b8da49ea38e6010e9969e4d34096f58e53892faf061a1b81af677fe937fa7fa3609af566c06f1
-  data.tar.gz: e48a77338ef9d1ec47e277aa40e8ac84dadbecdb688938531b9f508dba39b242ebce72a0999a387bd08e0a82201acc08148a99b63db1fdf83ce5a37ec7ef5f81
+  metadata.gz: cf05cd8421771e2af00139da267a9bdb3f29104d1cc9b20974db805677582676289e5f2ffaf8248ca4d9b660aa879b0099a85fbdc1e0709859d26b6da170f0b3
+  data.tar.gz: f3b7696c70a8eedf524ab3a8bfdac71a0e6dfd8f3c823270a51f7a3f1a20c46321cfdf4e03a3490193e8ad7e9c3b0071f81e2e78f1d04208eda214945a65c1d3

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 Changelog
 =========
 
+2.4.1
+------
+
+-   Ensure filtering behaviour matches rails' for symbol filters
+-   Fix Rails 4 sessions appearing in Custom tab instead of its own ([144](https://github.com/bugsnag/bugsnag-ruby/issues/144))
+
 2.4.0
 -----
 -   Allow filters to be regular expressions (thanks @tamird)

data/VERSION

@@ -1 +1 @@
-2.4.0
+2.4.1

data/lib/bugsnag/middleware/rack_request.rb

@@ -39,7 +39,15 @@ module Bugsnag::Middleware
         notification.add_tab(:environment, env)
 
         # Add a session tab
-        notification.add_tab(:session, session) if session
+        if session
+          if session.is_a?(Hash)
+            # Rails 3
+            notification.add_tab(:session, session)
+          elsif session.respond_to?(:to_hash)
+            # Rails 4
+            notification.add_tab(:session, session.to_hash)
+          end
+        end
 
         # Add a cookies tab
         cookies = request.cookies

data/lib/bugsnag/middleware_stack.rb

@@ -4,13 +4,13 @@ module Bugsnag
       @middlewares = []
       @disabled_middleware = []
     end
-  
+
     def use(new_middleware)
       return if @disabled_middleware.include?(new_middleware)
 
       @middlewares << new_middleware
     end
-  
+
     def insert_after(after, new_middleware)
       return if @disabled_middleware.include?(new_middleware)
 
@@ -26,7 +26,7 @@ module Bugsnag
         @middlewares.insert index + 1, new_middleware
       end
     end
-  
+
     def insert_before(before, new_middleware)
       return if @disabled_middleware.include?(new_middleware)
 
@@ -38,7 +38,7 @@ module Bugsnag
 
       @middlewares.insert index || @middlewares.length, new_middleware
     end
-    
+
     def disable(*middlewares)
       @disabled_middleware += middlewares
 
@@ -49,19 +49,19 @@ module Bugsnag
     def method_missing(method, *args, &block)
       @middlewares.send(method, *args, &block)
     end
-    
-    # Runs the middleware stack and calls 
+
+    # Runs the middleware stack and calls
     def run(notification)
       # The final lambda is the termination of the middleware stack. It calls deliver on the notification
       lambda_has_run = false
-      notify_lambda = lambda do |notification|
-        lambda_has_run = true        
+      notify_lambda = lambda do |notif|
+        lambda_has_run = true
         yield
       end
 
       begin
         # We reverse them, so we can call "call" on the first middleware
-        middleware_procs.reverse.inject(notify_lambda) { |n,e| e[n] }.call(notification)
+        middleware_procs.reverse.inject(notify_lambda) { |n,e| e.call(n) }.call(notification)
       rescue StandardError => e
         # KLUDGE: Since we don't re-raise middleware exceptions, this breaks rspec
         raise if e.class.to_s == "RSpec::Expectations::ExpectationNotMetError"
@@ -71,7 +71,7 @@ module Bugsnag
         Bugsnag.warn "Bugsnag middleware error: #{e}"
         Bugsnag.log "Middleware error stacktrace: #{e.backtrace.inspect}"
       end
-      
+
       # Ensure that the deliver has been performed, and no middleware has botched it
       notify_lambda.call(notification) unless lambda_has_run
     end
@@ -83,4 +83,4 @@ module Bugsnag
       @middlewares.map{|middleware| proc { |next_middleware| middleware.new(next_middleware) } }
     end
   end
-end
+end

data/lib/bugsnag/notification.rb

@@ -77,6 +77,7 @@ module Bugsnag
       @request_data = request_data
       @meta_data = {}
       @user = {}
+      @should_ignore = false
 
       self.severity = @overrides[:severity]
       @overrides.delete :severity
@@ -93,6 +94,7 @@ module Bugsnag
 
       # Unwrap exceptions
       @exceptions = []
+
       ex = exception
       while ex != nil && !@exceptions.include?(ex) && @exceptions.length < MAX_EXCEPTIONS_TO_UNWRAP
 
@@ -213,6 +215,10 @@ module Bugsnag
 
       # Run the middleware here, at the end of the middleware stack, execute the actual delivery
       @configuration.middleware.run(self) do
+        # At this point the callbacks have already been run.
+        # This supports self.ignore! for before_notify_callbacks.
+        return if @should_ignore
+
         # Now override the required fields
         exceptions.each do |exception|
           if exception.class.include?(Bugsnag::MetaData)
@@ -270,7 +276,7 @@ module Bugsnag
     end
 
     def ignore?
-      ignore_exception_class? || ignore_user_agent?
+      @should_ignore || ignore_exception_class? || ignore_user_agent?
     end
 
     def request_data
@@ -281,11 +287,14 @@ module Bugsnag
       @exceptions
     end
 
+    def ignore!
+      @should_ignore = true
+    end
+
     private
 
     def ignore_exception_class?
       @exceptions.any? do |ex|
-        ex_name = error_class(ex)
         ancestor_chain = ex.class.ancestors.select { |ancestor| ancestor.is_a?(Class) }.map { |ancestor| error_class(ancestor) }.to_set
 
         @configuration.ignore_classes.any? do |to_ignore|

data/lib/bugsnag/railtie.rb

@@ -20,7 +20,7 @@ module Bugsnag
         config.project_root = Rails.root.to_s
         config.params_filters += Rails.configuration.filter_parameters.map do |filter|
           case filter
-          when String
+          when String, Symbol
             /\A#{filter}\z/
           else
             filter

data/spec/middleware_spec.rb

@@ -8,7 +8,7 @@ describe Bugsnag::MiddlewareStack do
       expect(event[:metaData][:some_tab][:info]).to eq("here")
       expect(event[:metaData][:some_tab][:data]).to eq("also here")
     end
-    
+
     callback_run_count = 0
     Bugsnag.before_notify_callbacks << lambda {|notif|
       notif.add_tab(:some_tab, {
@@ -21,7 +21,7 @@ describe Bugsnag::MiddlewareStack do
     Bugsnag.notify(BugsnagTestException.new("It crashed"))
     expect(callback_run_count).to eq(1)
   end
-  
+
   it "runs before_bugsnag_notify callbacks, adding custom data" do
     expect(Bugsnag::Notification).to receive(:deliver_exception_payload) do |endpoint, payload|
       event = get_event_from_payload(payload)
@@ -29,12 +29,12 @@ describe Bugsnag::MiddlewareStack do
       expect(event[:metaData][:custom][:info]).to eq("here")
       expect(event[:metaData][:custom][:data]).to eq("also here")
     end
-    
+
     callback_run_count = 0
     Bugsnag.before_notify_callbacks << lambda {|notif|
       notif.add_custom_data(:info, "here")
       notif.add_custom_data(:data, "also here")
-      
+
       callback_run_count += 1
     }
 
@@ -51,7 +51,7 @@ describe Bugsnag::MiddlewareStack do
       expect(event[:user][:name]).to eq("also here too")
       expect(event[:user][:random_key]).to eq("also here too too")
     end
-    
+
     callback_run_count = 0
     Bugsnag.before_notify_callbacks << lambda {|notif|
       notif.user = {:id => "here", :email => "also here", :name => "also here too", :random_key => "also here too too"}
@@ -61,7 +61,7 @@ describe Bugsnag::MiddlewareStack do
     Bugsnag.notify(BugsnagTestException.new("It crashed"))
     expect(callback_run_count).to eq(1)
   end
-  
+
   it "overrides data set in before_notify" do
     expect(Bugsnag::Notification).to receive(:deliver_exception_payload) do |endpoint, payload|
       event = get_event_from_payload(payload)
@@ -69,40 +69,40 @@ describe Bugsnag::MiddlewareStack do
       expect(event[:metaData][:custom][:info]).to eq("here2")
       expect(event[:metaData][:custom][:data]).to eq("also here")
     end
-    
+
     callback_run_count = 0
     Bugsnag.before_notify_callbacks << lambda {|notif|
       notif.add_custom_data(:info, "here")
       notif.add_custom_data(:data, "also here")
-      
+
       callback_run_count += 1
     }
 
     Bugsnag.notify(BugsnagTestException.new("It crashed"), {:info => "here2"})
     expect(callback_run_count).to eq(1)
   end
-  
+
   it "does not have have before or after callbacks by default" do
     expect(Bugsnag::Notification).to receive(:deliver_exception_payload) do |endpoint, payload|
       event = get_event_from_payload(payload)
       expect(event[:metaData].size).to eq(0)
     end
-    
+
     expect(Bugsnag.before_notify_callbacks.size).to eq(0)
     expect(Bugsnag.after_notify_callbacks.size).to eq(0)
     Bugsnag.notify(BugsnagTestException.new("It crashed"))
   end
-  
+
   it "runs after_bugsnag_notify callbacks" do
     expect(Bugsnag::Notification).to receive(:deliver_exception_payload)
-    
+
     callback_run_count = 0
     Bugsnag.after_notify_callbacks << lambda {|notif|
       callback_run_count += 1
     }
 
     Bugsnag.notify(BugsnagTestException.new("It crashed"))
-    
+
     expect(callback_run_count).to eq(1)
   end
 
@@ -111,12 +111,20 @@ describe Bugsnag::MiddlewareStack do
     Bugsnag.configure do |config|
       config.middleware.disable(Bugsnag::Middleware::Callbacks)
     end
-    
+
     Bugsnag.before_notify_callbacks << lambda {|notif|
       callback_run_count += 1
     }
-    
+
     Bugsnag.notify(BugsnagTestException.new("It crashed"))
     expect(callback_run_count).to eq(0)
   end
+
+  it "does not notify if a callback told so" do
+    expect(Bugsnag::Notification).not_to receive(:deliver_exception_payload)
+    Bugsnag.before_notify_callbacks << lambda do |notif|
+      notif.ignore!
+    end
+    Bugsnag.notify(BugsnagTestException.new("It crashed"))
+  end
 end

metadata

@@ -1,103 +1,103 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 2.4.0
+  version: 2.4.1
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-23 00:00:00.000000000 Z
+date: 2014-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Ruby notifier for bugsnag.com
@@ -108,10 +108,10 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.md
 files:
-- .document
-- .gitignore
-- .rspec
-- .travis.yml
+- ".document"
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -168,17 +168,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby notifier for bugsnag.com