bugsnag 1.2.6 → 1.2.7

data/VERSION

@@ -1 +1 @@
-1.2.6
+1.2.7

data/bugsnag.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "bugsnag"
-  s.version = "1.2.6"
+  s.version = "1.2.7"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Smith"]
-  s.date = "2012-12-02"
+  s.date = "2012-12-10"
   s.description = "Ruby notifier for bugsnag.com"
   s.email = "james@bugsnag.com"
   s.extra_rdoc_files = [

data/lib/bugsnag/notification.rb

@@ -12,6 +12,8 @@ module Bugsnag
 
     API_KEY_REGEX = /[0-9a-f]{32}/i
 
+    MAX_EXCEPTIONS_TO_UNWRAP = 5
+
     # HTTParty settings
     headers  "Content-Type" => "application/json"
     default_timeout 5
@@ -50,7 +52,7 @@ module Bugsnag
       # Unwrap exceptions
       @exceptions = []
       ex = exception
-      while ex != nil
+      while ex != nil && !@exceptions.include?(ex) && @exceptions.length < MAX_EXCEPTIONS_TO_UNWRAP
         @exceptions << ex
 
         if ex.respond_to?(:continued_exception) && ex.continued_exception

data/spec/notification_spec.rb

@@ -3,6 +3,14 @@ require 'securerandom'
 
 module ActiveRecord; class RecordNotFound < RuntimeError; end; end
 
+class RecursiveException < StandardError
+  attr_accessor :original_exception
+  def initialize(*args)
+    self.original_exception = self
+    super(message)
+  end
+end
+
 describe Bugsnag::Notification do
   it "should contain an api_key if one is set" do
     Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
@@ -290,4 +298,26 @@ describe Bugsnag::Notification do
 
     Bugsnag.notify_or_ignore(BugsnagTestException.new("It crashed"))
   end
+
+  it "should not unwrap the same exception twice" do
+    Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
+      get_exception_from_payload(payload)
+    end
+
+    Bugsnag.notify_or_ignore(RecursiveException.new("Self-referential exception"))
+  end
+  
+  it "should not unwrap more than 5 exceptions" do
+    Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
+      event = get_event_from_payload(payload)
+      event[:exceptions].should have(5).items
+    end
+
+    first_ex = ex = RecursiveException.new("Deep exception")
+    10.times do |idx|
+      ex = ex.original_exception = RecursiveException.new("Deep exception #{idx}")
+    end
+
+    Bugsnag.notify_or_ignore(first_ex)
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: bugsnag
 version: !ruby/object:Gem::Version 
-  hash: 19
+  hash: 17
   prerelease: 
   segments: 
   - 1
   - 2
-  - 6
-  version: 1.2.6
+  - 7
+  version: 1.2.7
 platform: ruby
 authors: 
 - James Smith
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-02 00:00:00 Z
+date: 2012-12-10 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   requirement: &id001 !ruby/object:Gem::Requirement