bugsnag 1.0.7 → 1.0.8

data/Gemfile.lock

@@ -9,7 +9,7 @@ GEM
       bundler (~> 1.0)
       git (>= 1.2.5)
       rake
-    multi_json (1.0.3)
+    multi_json (1.1.0)
     rake (0.9.2)
     rcov (0.9.11)
     shoulda (2.11.3)

data/VERSION

@@ -1 +1 @@
-1.0.7
+1.0.8

data/bugsnag.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "bugsnag"
-  s.version = "1.0.7"
+  s.version = "1.0.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Smith"]
-  s.date = "2012-01-16"
+  s.date = "2012-02-27"
   s.description = "Ruby notifier for bugsnag.com"
   s.email = "james@bugsnag.com"
   s.extra_rdoc_files = [
@@ -27,6 +27,7 @@ Gem::Specification.new do |s|
     "bugsnag.gemspec",
     "lib/bugsnag.rb",
     "lib/bugsnag/configuration.rb",
+    "lib/bugsnag/delay/resque.rb",
     "lib/bugsnag/helpers.rb",
     "lib/bugsnag/notification.rb",
     "lib/bugsnag/rack.rb",
@@ -34,7 +35,6 @@ Gem::Specification.new do |s|
     "lib/bugsnag/rails/action_controller_rescue.rb",
     "lib/bugsnag/rails/controller_methods.rb",
     "lib/bugsnag/railtie.rb",
-    "lib/bugsnag/resque.rb",
     "lib/bugsnag/version.rb",
     "rails/init.rb",
     "test/helper.rb",
@@ -43,7 +43,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/bugsnag/bugsnag-ruby"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.10"
+  s.rubygems_version = "1.8.15"
   s.summary = "Ruby notifier for bugsnag.com"
 
   if s.respond_to? :specification_version then

data/lib/bugsnag.rb

@@ -17,7 +17,7 @@ module Bugsnag
       yield(configuration)
 
       # Use resque for asynchronous notification if required
-      require "bugsnag/resque" if configuration.use_resque && defined?(Resque)
+      require "bugsnag/delay/resque" if configuration.delay_with_resque && defined?(Resque)
 
       # Log that we are ready to rock
       if configuration.api_key && !@logged_ready

data/lib/bugsnag/configuration.rb

@@ -1,15 +1,13 @@
 module Bugsnag
   class Configuration
     OPTIONS = [
-      :api_key, :release_stage, :project_root, :app_version,
+      :api_key, :release_stage, :use_ssl, :project_root, :app_version,
       :framework, :endpoint, :logger, :disable_auto_notification,
       :params_filters, :stacktrace_filters, :ignore_classes,
-      :use_resque
+      :delay_with_resque
     ]
     OPTIONS.each {|o| attr_accessor o }
 
-
-    DEFAULT_ENDPOINT = "http://api.bugsnag.com/notify"
     DEFAULT_PARAMS_FILTERS = %w(password password_confirmation).freeze
 
     DEFAULT_STACKTRACE_FILTERS = [
@@ -42,7 +40,6 @@ module Bugsnag
 
 
     def initialize
-      @endpoint = DEFAULT_ENDPOINT
       @params_filters = DEFAULT_PARAMS_FILTERS.dup
       @stacktrace_filters = DEFAULT_STACKTRACE_FILTERS.dup
       @ignore_classes = DEFAULT_IGNORE_CLASSES.dup

data/lib/bugsnag/{resque.rb → delay/resque.rb}

@@ -1,8 +1,10 @@
 module Bugsnag
-  class Resque
-    @queue = "bugsnag"
-    def self.perform(*args)
-      Bugsnag::Notification.deliver_exception_payload_without_resque(*args)
+  module Delay
+    class Resque
+      @queue = "bugsnag"
+      def self.perform(*args)
+        Bugsnag::Notification.deliver_exception_payload_without_resque(*args)
+      end
     end
   end
 end
@@ -10,7 +12,7 @@ end
 Bugsnag::Notification.class_eval do
   class << self
     def deliver_exception_payload_with_resque(*args)
-      Resque.enqueue(Bugsnag::Resque, *args)
+      Resque.enqueue(Bugsnag::Delay::Resque, *args)
     end
   
     alias_method :deliver_exception_payload_without_resque, :deliver_exception_payload

data/lib/bugsnag/notification.rb

@@ -8,7 +8,9 @@ module Bugsnag
     NOTIFIER_NAME = "Ruby Bugsnag Notifier"
     NOTIFIER_VERSION = Bugsnag::VERSION
     NOTIFIER_URL = "http://www.bugsnag.com"
-    
+
+    DEFAULT_ENDPOINT = "api.bugsnag.com/notify"
+
     # HTTParty settings
     headers  "Content-Type" => "application/json"
     default_timeout 5
@@ -22,7 +24,7 @@ module Bugsnag
     # Attributes from configuration
     attr_accessor :api_key, :params_filters, :stacktrace_filters, 
                   :ignore_classes, :endpoint, :app_version, :release_stage, 
-                  :project_root
+                  :project_root, :use_ssl
 
 
     def self.deliver_exception_payload(endpoint, payload_string)
@@ -41,6 +43,11 @@ module Bugsnag
     end
 
     def deliver
+      # Unless we are using a custom endpoint, use api.bugsnag.com, and work out protocol
+      unless self.endpoint
+        self.endpoint = (self.use_ssl ? "https://" : "http://") + DEFAULT_ENDPOINT
+      end
+
       Bugsnag.log("Notifying #{self.endpoint} of exception")
 
       payload = {
@@ -60,7 +67,7 @@ module Bugsnag
     end
 
     def ignore?
-      self.ignore_classes.include?(self.exception.class.to_s)
+      self.ignore_classes.include?(error_class(self.exception))
     end
 
 
@@ -106,10 +113,16 @@ module Bugsnag
 
     def exception_hash
       {
-        :errorClass => self.exception.class.to_s,
+        :errorClass => error_class(self.exception),
         :message => self.exception.message,
         :stacktrace => stacktrace_hash
       }
     end
+    
+    def error_class(exception)
+      # The "Class" check is for some strange exceptions like Timeout::Error 
+      # which throw the error class instead of an instance
+      (exception.is_a? Class) ? exception.name : exception.class.name
+    end
   end
 end

data/test/test_bugsnag.rb

@@ -9,7 +9,6 @@ class TestBugsnag < Test::Unit::TestCase
       config.endpoint = "http://localhost:8000/notify"
       config.release_stage = "production"
       config.project_root = File.dirname(__FILE__)
-      config.user_id = "static_user_id"
     end
     
     begin

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: bugsnag
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 7
   prerelease: 
   segments: 
   - 1
   - 0
-  - 7
-  version: 1.0.7
+  - 8
+  version: 1.0.8
 platform: ruby
 authors: 
 - James Smith
@@ -15,11 +15,10 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-01-16 00:00:00 Z
+date: 2012-02-27 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -28,12 +27,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  version_requirements: *id001
-  name: multi_json
+  requirement: *id001
   type: :runtime
-- !ruby/object:Gem::Dependency 
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  name: multi_json
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -42,12 +41,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  version_requirements: *id002
-  name: httparty
+  requirement: *id002
   type: :runtime
-- !ruby/object:Gem::Dependency 
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  name: httparty
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -56,12 +55,12 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  version_requirements: *id003
-  name: shoulda
+  requirement: *id003
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  name: shoulda
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -72,12 +71,12 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  version_requirements: *id004
-  name: bundler
+  requirement: *id004
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  name: bundler
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -88,12 +87,12 @@ dependencies:
         - 6
         - 4
         version: 1.6.4
-  version_requirements: *id005
-  name: jeweler
+  requirement: *id005
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  name: jeweler
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -102,9 +101,10 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  version_requirements: *id006
-  name: rcov
+  requirement: *id006
   type: :development
+  prerelease: false
+  name: rcov
 description: Ruby notifier for bugsnag.com
 email: james@bugsnag.com
 executables: []
@@ -125,6 +125,7 @@ files:
 - bugsnag.gemspec
 - lib/bugsnag.rb
 - lib/bugsnag/configuration.rb
+- lib/bugsnag/delay/resque.rb
 - lib/bugsnag/helpers.rb
 - lib/bugsnag/notification.rb
 - lib/bugsnag/rack.rb
@@ -132,7 +133,6 @@ files:
 - lib/bugsnag/rails/action_controller_rescue.rb
 - lib/bugsnag/rails/controller_methods.rb
 - lib/bugsnag/railtie.rb
-- lib/bugsnag/resque.rb
 - lib/bugsnag/version.rb
 - rails/init.rb
 - test/helper.rb
@@ -166,7 +166,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Ruby notifier for bugsnag.com