bugloco 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0fef7785321fdce820ab8e7fbc512b25f7cfc170
-  data.tar.gz: 569b05df812831ee54b908174052193ee7b68074
+  metadata.gz: 620a8abfc5db039673d1e1d2f839613e6f89c7a7
+  data.tar.gz: 542dea7518cba073ff850e239b79f46e7816a95c
 SHA512:
-  metadata.gz: f2f44a7e327d5485e73d65941e22da138d0488b11131b1b7cd51e7376639687f8dd71c840c22578903219b716bf1f6dccf8d453c6f97567764cf742d5c3c0b2e
-  data.tar.gz: 35d6cf0754ec224d11a0820fca5a976db4cc2f46d12d07a0dcf95a0d31f4d462f3d2262abb9e171839521cbf64cf4b5dafda34af8c72914c3d706d72ae47f8d3
+  metadata.gz: 7209e52c1deb733a06f1d9ae64980cb7a13875211e2c87bab4f41391b8971e367519dc466d0fd9edd8b7785ff3d44abb7e4e2cdbe0da4d856ca60699d5e33fb6
+  data.tar.gz: 1c9270bb5e710aa891c05b2ccbd0382155523d31d71d4a17d033b9a4e3cb764de550f90aab6f8c06e1a40a06adccbbd5d9720d95c9996f3bc59dbb10328e241c

data/lib/bugloco.rb

@@ -20,16 +20,20 @@ module Bugloco
       Errno::ECONNREFUSED,
       OpenSSL::SSL::SSLError].freeze
 
-    def report_notice(exception, options = {})
-      # TODO: We need to inform the user if api_key/project_id were not given
-      encoded_notice = Bugloco::Notice.new(exception, options).to_pb
-      encoded_response = send_notice(encoded_notice, options)
+    def report_notice_or_ignore(exception, options = {})
+      notice = Bugloco::Notice.new(exception, options)
+      report_notice(notice) unless notice.ignore?
+    end
+
+    def report_notice(notice)
+      encoded_notice = notice.to_pb
+      encoded_response = send_notice(encoded_notice)
 
       if encoded_response
         response = Bugloco::Proto::Response.new.
           parse_from_string(encoded_response)
 
-        response.notice_id if response.status == Bugloco::Proto::Status::SUCCESS
+        response
       else
         nil
       end
@@ -43,12 +47,10 @@ module Bugloco
 
     private
 
-    def send_notice(encoded_notice, options = {})
+    def send_notice(encoded_notice)
       response = http_connection.post(api_url.path, encoded_notice, headers)
       response.body
     rescue *HTTP_ERRORS => e
-      # log e
-
       nil
     end
 

data/lib/bugloco/configuration.rb

@@ -6,7 +6,7 @@ module Bugloco
     def initialize(hash = {})
       super
 
-      self.api_url = "https://bugloco.com/api/v1/notices"
+      self.api_url = "https://bugloco.com/api/v1/notices.pb"
     end
 
     def configured?

data/lib/bugloco/notice.rb

@@ -7,6 +7,16 @@ module Bugloco
 
     EXCEPTION_REGEX = /^(?<path>[^:]*):(?<line_number>[0-9]*):in `(?<function_name>[^']*)'$/
 
+    IGNORE_DEFAULT = ['ActiveRecord::RecordNotFound',
+      'ActionController::RoutingError',
+      'ActionController::InvalidAuthenticityToken',
+      'CGI::Session::CookieStore::TamperedWithCookie',
+      'ActionController::UnknownHttpMethod',
+      'ActionController::UnknownAction',
+      'AbstractController::ActionNotFound',
+      'Mongoid::Errors::DocumentNotFound',
+      'ActionController::UnknownFormat']
+
     def initialize(exception, options = {})
       @exception = exception
       @options = options
@@ -18,6 +28,10 @@ module Bugloco
       @pb ||= proto_message.serialize_to_string
     end
 
+    def ignore?
+      IGNORE_DEFAULT.include?(@exception.class.to_s)
+    end
+
     def proto_message
       return @proto_message unless @proto_message.nil?
 

data/lib/bugloco/rails/middleware.rb

@@ -9,14 +9,29 @@ module Bugloco
         response = @app.call(env)
 
         if framework_exception = env["action_dispatch.exception"]
-          env["bugloco.error_id"] = Bugloco.report_notice(framework_exception, rack_env: env)
+          env["bugloco.error_id"] = report_exception_or_ignore(framework_exception, env)
         end
 
         response
       rescue Exception => exception
-        env["bugloco.error_id"] = Bugloco.report_notice(exception, rack_env: env)
+        env["bugloco.error_id"] = report_exception_or_ignore(exception, env)
+
         raise exception
       end
+
+      private
+
+      def report_exception_or_ignore(exception, env)
+        response = Bugloco.report_notice_or_ignore(exception, rack_env: env)
+
+        if response
+          if response.status == Bugloco::Proto::Status::SUCCESS
+            response.notice_id
+          else
+            # Report the issue
+          end
+        end
+      end
     end
   end
 end

data/lib/bugloco/version.rb

@@ -1,3 +1,3 @@
 module Bugloco
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/bugloco/notice_spec.rb

@@ -43,15 +43,20 @@ describe Bugloco::Notice do
     }
 
     @rack_env_extra = {}
-
-
-
   end
 
   after do
     @extra_env.each {|k, _| ENV[k] = nil}
   end
 
+  it "should ignore ActiveRecord::RecordNotFound" do
+    module ::ActiveRecord; class RecordNotFound < Exception; end; end
+    exception = ::ActiveRecord::RecordNotFound.new
+
+    notice = Bugloco::Notice.new(exception)
+    expect(notice.ignore?).to be_truthy
+  end
+
   it "should include the company" do
     @api_key = "secret_key"
     Bugloco.config do |config|

data/spec/bugloco_spec.rb

@@ -14,7 +14,7 @@ describe Bugloco do
     end
 
     it "should include the API url" do
-      expect(Bugloco.config.api_url).to eq("https://bugloco.com/api/v1/notices")
+      expect(Bugloco.config.api_url).to eq("https://bugloco.com/api/v1/notices.pb")
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugloco
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Wael M. Nasreddine
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-12 00:00:00.000000000 Z
+date: 2014-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler