bug_bunny 4.10.0 → 4.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af9746f85e544f059873513a7ace9b478acb6664b9053bb90d1963afb1d72848
-  data.tar.gz: 32854fb9e2a67f8e5cb537550d957704443d95183d22d5305b48c3207edaf05b
+  metadata.gz: '08e0d33ac09d046d3de52d3d7f75b7b87df8d6e96f495ab37c7433fe9f4add33'
+  data.tar.gz: '09373953a7dc292c97363e3514f9e3db1b9b041527a9e26e09e52089abfda0b9'
 SHA512:
-  metadata.gz: 90169fb942803e87f47cf1af2fb2b4cb4d66112aaf4ab6632bb6a8d5031383e1fc0105a4cf2449eed847822509a71c1e4695c8cacb9907889c286cc5cfefe70b
-  data.tar.gz: 39262e92b89fb583769bcfaa8a17972584b0aaeda9f197ff3cf7cf4c45941ca0ee0b3aa154e8073d4004f5213bb1852aa16cc6c6f809951b2bcf3c76b85fa66d
+  metadata.gz: 34799b71420bb76ca71439e80d5b27a5d2ed38f424b16ba914b85566c5277279d3f4e1743caa4f2e8d932d125ceb019479add38df49573ab42880ef103cf1c34
+  data.tar.gz: 7b8cceae4b29ff12e9e42fc51ee3b68ec5a1ae92122a91f35c6bb132f09edf1b5171785ef6494d3580e86da715218f1602f2ef8071a2e9b77b0e0123c28795ff

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [4.10.2] - 2026-04-08
+
+### Correcciones
+- **RemoteError#to_s recursión infinita:** Corregir `SystemStackError` al invocar `to_s` en `BugBunny::RemoteError` en IRB. Antes, `to_s` llamaba a `message`, que en Ruby delega a `to_s`, generando recursión infinita. Ahora usa `super` para invocar `Exception#to_s` directamente. — @Gabriel
+
+## [4.10.1] - 2026-04-08
+
+### Correcciones
+- Corregir route matching 404: el path del cliente ahora se normaliza antes de pasarlo a `RouteSet#recognize`. Antes, `URI.parse("http://dummy/#{path}")` prependead un `/` extra al path, causando que rutas existentes no hicieran match. Ahora se usa `path.gsub(%r{^/|/$}, '')` antes del recognize. — @Gabriel
+
 ## [4.9.1] - 2026-04-06
 
 ### Correcciones

data/lib/bug_bunny/consumer.rb

@@ -181,18 +181,20 @@ module BugBunny
       # ===================================================================
       # 3. Ruteo Declarativo
       # ===================================================================
-      uri = URI.parse("http://dummy/#{path}")
+      normalized_path = path.gsub(%r{^/|/$}, '')
+
+      uri = URI.parse("http://dummy/#{normalized_path}")
 
       # Extraemos query params (ej. /nodes?status=active)
       query_params = uri.query ? Rack::Utils.parse_nested_query(uri.query) : {}
       query_params = query_params.with_indifferent_access if defined?(ActiveSupport::HashWithIndifferentAccess)
 
       # Le preguntamos al motor de rutas global quién debe manejar esto
-      route_info = BugBunny.routes.recognize(http_method, uri.path)
+      route_info = BugBunny.routes.recognize(http_method, normalized_path)
 
       if route_info.nil?
-        safe_log(:warn, 'consumer.route_not_found', method: http_method, path: uri.path)
-        handle_fatal_error(properties, 404, 'Not Found', "No route matches [#{http_method}] \"/#{uri.path}\"")
+        safe_log(:warn, 'consumer.route_not_found', method: http_method, path: normalized_path)
+        handle_fatal_error(properties, 404, 'Not Found', "No route matches [#{http_method}] \"#{normalized_path}\"")
         session.channel.reject(delivery_info.delivery_tag, false)
         return
       end

data/lib/bug_bunny/remote_error.rb

@@ -49,7 +49,7 @@ module BugBunny
 
     # @return [String] Representación legible de la excepción.
     def to_s
-      "#{self.class.name}(#{original_class}): #{message}"
+      "#{self.class.name}(#{original_class}): #{super}"
     end
   end
 end

data/lib/bug_bunny/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BugBunny
-  VERSION = '4.10.0'
+  VERSION = '4.10.2'
 end

data/skill/SKILL.md

@@ -230,6 +230,10 @@ No registrar consumer middlewares durante la ejecución de `call()`. El stack to
 **Causa:** El mensaje intenta ejecutar un controlador que no hereda de `BugBunny::Controller`.
 **Resolución:** Verificar la jerarquía de controladores y que `config.controller_namespace` coincida.
 
+### BugBunny::RouteNotFoundError (404)
+**Causa:** El path del mensaje no coincide con ninguna ruta registrada. El path debe estar normalizado (sin slashes iniciales/trailing).
+**Resolución:** Verificar que el cliente envíe el path sin leading/trailing slashes (ej: `users/42`, no `/users/42/`).
+
 ### BugBunny::UnprocessableEntity (422)
 **Causa:** Fallo de validación en el servicio remoto.
 **Resolución:** `resource.save` devuelve `false`. Acceder a `resource.errors` o `rescue` con `e.error_messages`.

data/skill/references/consumer.md

@@ -21,13 +21,14 @@ consumer = BugBunny::Consumer.subscribe(
 2. Extrae campos **OTel messaging** del mensaje para logs estructurados (sin mutar headers).
 3. Valida que el mensaje tenga header `type` (path).
 4. Parsea el método HTTP de headers (`x-http-method` o `method`).
-5. Emite log `consumer.message_received` con campos OTel (`messaging_operation: 'process'`).
-6. Reconoce la ruta con `BugBunny.routes.recognize(method, path)`.
-7. Resuelve el controlador validando herencia de `BugBunny::Controller`.
-8. Ejecuta consumer middlewares → controller callbacks → acción.
-9. Responde via `reply_to` si está presente (RPC), inyectando campos OTel (`messaging_operation: 'publish'`).
-10. Emite log `consumer.message_processed` con campos OTel y duraciones.
-11. Hace `ack` del mensaje. En caso de error, `reject`.
+5. **Normaliza el path**: remueve slashes iniciales/trailing (`path.gsub(%r{^/|/$}, '')`).
+6. Emite log `consumer.message_received` con campos OTel (`messaging_operation: 'process'`).
+7. Reconoce la ruta con `BugBunny.routes.recognize(method, normalized_path)`.
+8. Resuelve el controlador validando herencia de `BugBunny::Controller`.
+9. Ejecuta consumer middlewares → controller callbacks → acción.
+10. Responde via `reply_to` si está presente (RPC), inyectando campos OTel (`messaging_operation: 'publish'`).
+11. Emite log `consumer.message_processed` con campos OTel y duraciones.
+12. Hace `ack` del mensaje. En caso de error, `reject`.
 
 ## Observability: OTel Fields
 

data/skill/references/errores.md

@@ -16,7 +16,8 @@ StandardError
     │   ├── BugBunny::Conflict (409)
     │   └── BugBunny::UnprocessableEntity (422)
     └── BugBunny::ServerError (5xx)
-        └── BugBunny::InternalServerError (500+)
+        ├── BugBunny::InternalServerError (500+)
+        └── BugBunny::RemoteError (500)
 ```
 
 ## Errores de Infraestructura
@@ -83,6 +84,21 @@ end
 **Causa:** Cualquier error de servidor no mapeado a InternalServerError.
 **Resolución:** Similar a InternalServerError.
 
+### BugBunny::RemoteError (500)
+**Causa:** Excepción no manejada en el controller remoto. El error se serializa y propaga al cliente RPC.
+**Acceso a detalles:**
+```ruby
+begin
+  client.request('users/42')
+rescue BugBunny::RemoteError => e
+  e.original_class     # String: clase original (ej: "TypeError")
+  e.original_message  # String: mensaje original
+  e.original_backtrace # Array<String>: backtrace original
+end
+```
+**Serialización:** El controller captura excepciones con `rescue_from` → `handle_exception` → serializa con clase, mensaje y primeras 25 líneas del backtrace.
+**Propagación:** El middleware `RaiseError` del cliente reconstituye `RemoteError` y la lanza localmente.
+
 ## Formato de Mensajes de Error
 
 El middleware `RaiseError` construye el mensaje así:

data/spec/unit/remote_error_spec.rb

@@ -0,0 +1,68 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BugBunny::RemoteError do
+  subject(:error) do
+    described_class.new('TypeError', 'nil can\'t be coerced into Integer', [
+                          "/app/controllers/services_controller.rb:5:in 'Integer#*'",
+                          "/app/controllers/services_controller.rb:5:in 'ServicesController#index'"
+                        ])
+  end
+
+  describe '#to_s' do
+    it 'does not cause infinite recursion (message -> to_s -> message)' do
+      expect(error.to_s).to eq("BugBunny::RemoteError(TypeError): nil can't be coerced into Integer")
+    end
+  end
+
+  describe '#message' do
+    it 'returns the formatted string without stack overflow' do
+      expect(error.message).to eq("BugBunny::RemoteError(TypeError): nil can't be coerced into Integer")
+    end
+  end
+
+  describe '#inspect' do
+    it 'is renderable by IRB without raising' do
+      expect { error.inspect }.not_to raise_error
+    end
+  end
+
+  describe '.serialize' do
+    it 'serializes an exception with class, message and backtrace' do
+      exception = TypeError.new('test error')
+      exception.set_backtrace(%w[line1 line2])
+
+      result = described_class.serialize(exception)
+
+      expect(result).to eq(class: 'TypeError', message: 'test error', backtrace: %w[line1 line2])
+    end
+
+    it 'truncates backtrace to max_lines' do
+      exception = TypeError.new('test')
+      exception.set_backtrace(Array.new(30) { |i| "line#{i}" })
+
+      result = described_class.serialize(exception, max_lines: 5)
+
+      expect(result[:backtrace].size).to eq(5)
+    end
+  end
+
+  describe 'attributes' do
+    it 'exposes the original exception class' do
+      expect(error.original_class).to eq('TypeError')
+    end
+
+    it 'exposes the original message' do
+      expect(error.original_message).to eq("nil can't be coerced into Integer")
+    end
+
+    it 'exposes the original backtrace' do
+      expect(error.original_backtrace.size).to eq(2)
+    end
+
+    it 'sets the Ruby backtrace to the remote backtrace' do
+      expect(error.backtrace).to eq(error.original_backtrace)
+    end
+  end
+end

data/spec/unit/route_spec.rb

@@ -0,0 +1,180 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BugBunny::Routing::Route do
+  describe '#match? and #extract_params — path normalization' do
+    let(:route) { described_class.new('GET', 'services/otaigccd59q0k7kxb1h193go2/restart', to: 'services#restart') }
+
+    it 'matches path without leading slash' do
+      expect(route.match?('GET', 'services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+    end
+
+    it 'matches path with leading slash' do
+      expect(route.match?('GET', '/services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+    end
+
+    it 'matches path with trailing slash' do
+      expect(route.match?('GET', 'services/otaigccd59q0k7kxb1h193go2/restart/')).to be true
+    end
+
+    it 'matches path with leading and trailing slash' do
+      expect(route.match?('GET', '/services/otaigccd59q0k7kxb1h193go2/restart/')).to be true
+    end
+
+    it 'extracts params from path without slash' do
+      params = route.extract_params('services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(params).to eq({})
+    end
+
+    it 'extracts params from path with slash' do
+      params = route.extract_params('/services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(params).to eq({})
+    end
+
+    context 'route with dynamic segment' do
+      let(:route_with_id) { described_class.new('GET', 'nodes/:id', to: 'nodes#show') }
+
+      it 'extracts params from path without slash' do
+        params = route_with_id.extract_params('nodes/123')
+        expect(params).to eq({ 'id' => '123' })
+      end
+
+      it 'extracts params from path with slash' do
+        params = route_with_id.extract_params('/nodes/123')
+        expect(params).to eq({ 'id' => '123' })
+      end
+    end
+
+    context 'route defined with leading slash' do
+      let(:route_with_leading_slash) do
+        described_class.new('GET', '/services/otaigccd59q0k7kxb1h193go2/restart', to: 'services#restart')
+      end
+
+      it 'matches path without slash' do
+        expect(route_with_leading_slash.match?('GET', 'services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+      end
+
+      it 'matches path with slash' do
+        expect(route_with_leading_slash.match?('GET', '/services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+      end
+    end
+  end
+
+  describe 'RouteSet#recognize path normalization' do
+    let(:route_set) { BugBunny::Routing::RouteSet.new }
+
+    before do
+      route_set.draw do
+        get 'services/otaigccd59q0k7kxb1h193go2/restart', to: 'services#restart'
+      end
+    end
+
+    it 'recognizes path without slash' do
+      result = route_set.recognize('GET', 'services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(result).not_to be_nil
+      expect(result[:controller]).to eq('services')
+      expect(result[:action]).to eq('restart')
+    end
+
+    it 'recognizes path with leading slash' do
+      result = route_set.recognize('GET', '/services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(result).not_to be_nil
+      expect(result[:controller]).to eq('services')
+      expect(result[:action]).to eq('restart')
+    end
+
+    it 'returns nil for non-matching path' do
+      result = route_set.recognize('GET', 'services/nonexistent')
+      expect(result).to be_nil
+    end
+  end
+
+  describe 'Consumer path handling — URI parsing edge case' do
+    let(:channel) { BunnyMocks::FakeChannel.new(true) }
+    let(:connection) { BunnyMocks::FakeConnection.new(true, channel) }
+
+    let(:mock_channel) do
+      ch = double('channel')
+      allow(ch).to receive(:reject)
+      allow(ch).to receive(:ack)
+      allow(ch).to receive(:open?).and_return(true)
+      default_ex = double('default_exchange')
+      allow(default_ex).to receive(:publish)
+      allow(ch).to receive(:default_exchange).and_return(default_ex)
+      ch
+    end
+
+    let(:mock_session) do
+      s = instance_double(BugBunny::Session)
+      allow(s).to receive(:exchange).and_return(double('exchange'))
+      allow(s).to receive(:queue).and_return(double('queue'))
+      allow(s).to receive(:close)
+      allow(s).to receive(:channel).and_return(mock_channel)
+      s
+    end
+
+    let(:test_consumer) do
+      c = BugBunny::Consumer.new(connection)
+      c.instance_variable_set(:@session, mock_session)
+      c
+    end
+
+    let(:delivery_info) do
+      double('delivery_info',
+             exchange: 'events_x',
+             routing_key: 'users.created',
+             delivery_tag: 'delivery-tag-1',
+             redelivered?: false)
+    end
+
+    let(:properties) do
+      double('properties',
+             type: 'services/otaigccd59q0k7kxb1h193go2/restart',
+             headers: { 'x-http-method' => 'GET' },
+             correlation_id: 'corr-abc-123',
+             reply_to: nil,
+             content_type: 'application/json')
+    end
+
+    let(:logged_events) { [] }
+
+    before do
+      allow(test_consumer).to receive(:safe_log) do |level, event, **kwargs|
+        logged_events << { level: level, event: event, kwargs: kwargs }
+      end
+      allow(test_consumer).to receive(:handle_fatal_error)
+    end
+
+    it 'logs route_not_found with normalized path (without extra slash)' do
+      allow(BugBunny.routes).to receive(:recognize).and_return(nil)
+
+      test_consumer.send(:process_message, delivery_info, properties, '{}')
+
+      route_not_found_event = logged_events.find { |e| e[:event] == 'consumer.route_not_found' }
+      expect(route_not_found_event).not_to be_nil
+      expect(route_not_found_event[:kwargs][:path]).to eq('services/otaigccd59q0k7kxb1h193go2/restart')
+    end
+
+    context 'when properties.type has leading slash' do
+      let(:properties) do
+        double('properties',
+               type: '/services/otaigccd59q0k7kxb1h193go2/restart',
+               headers: { 'x-http-method' => 'GET' },
+               correlation_id: 'corr-abc-123',
+               reply_to: nil,
+               content_type: 'application/json')
+      end
+
+      it 'logs route_not_found with normalized path (stripped leading slash)' do
+        allow(BugBunny.routes).to receive(:recognize).and_return(nil)
+
+        test_consumer.send(:process_message, delivery_info, properties, '{}')
+
+        route_not_found_event = logged_events.find { |e| e[:event] == 'consumer.route_not_found' }
+        expect(route_not_found_event).not_to be_nil
+        expect(route_not_found_event[:kwargs][:path]).to eq('services/otaigccd59q0k7kxb1h193go2/restart')
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bug_bunny
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: 4.10.2
 platform: ruby
 authors:
 - gabix
@@ -288,8 +288,10 @@ files:
 - spec/unit/observability_spec.rb
 - spec/unit/otel_spec.rb
 - spec/unit/producer_spec.rb
+- spec/unit/remote_error_spec.rb
 - spec/unit/request_spec.rb
 - spec/unit/resource_attributes_spec.rb
+- spec/unit/route_spec.rb
 - spec/unit/session_spec.rb
 - test/integration/infrastructure_test.rb
 - test/integration/manual_client_test.rb
@@ -301,7 +303,7 @@ metadata:
   homepage_uri: https://github.com/gedera/bug_bunny
   source_code_uri: https://github.com/gedera/bug_bunny
   changelog_uri: https://github.com/gedera/bug_bunny/blob/main/CHANGELOG.md
-  documentation_uri: https://github.com/gedera/bug_bunny/blob/v4.10.0/skill
+  documentation_uri: https://github.com/gedera/bug_bunny/blob/v4.10.2/skill
 post_install_message:
 rdoc_options: []
 require_paths: